Shamrock [McDonald's Shamrock Shake] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in ShamrockShake._transferFrom(address,address,uint256) (#559-600):
External calls:
- swapBack() (#569)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#634-640)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
External calls sending eth:
- swapBack() (#569)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#577)
- _balances[recipient] = _balances[recipient].add(finalAmount) (#585)
- finalAmount = takeFee(sender,recipient,amount) (#584)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#614)
Apply the check-effects-interactions pattern.

Additional information: link

ShamrockShake.swapBack() (#624-673) sends eth to arbitrary user
Dangerous calls:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

DividendDistributor.distributeDividend(address) (#245-257) ignores return value by RewardToken.transfer(shareholder,amount) (#251)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

ShamrockShake.swapBack().tmpSuccess (#655) is written in both
(tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
tmpSuccess = false (#659)
ShamrockShake.swapBack().tmpSuccess1 (#656) is written in both
(tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
tmpSuccess1 = false (#660)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract name (McDonald's Shamrock Shake) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

Reentrancy in DividendDistributor.distributeDividend(address) (#245-257):
External calls:
- RewardToken.transfer(shareholder,amount) (#251)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#253)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#254)
Reentrancy in DividendDistributor.process(uint256) (#216-238):
External calls:
- distributeDividend(shareholders[currentIndex]) (#230)
- RewardToken.transfer(shareholder,amount) (#251)
State variables written after the call(s):
- currentIndex ++ (#235)
Reentrancy in DividendDistributor.setShare(address,uint256) (#179-194):
External calls:
- distributeDividend(shareholder) (#182)
- RewardToken.transfer(shareholder,amount) (#251)
State variables written after the call(s):
- shares[shareholder].amount = amount (#192)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#193)
Apply the check-effects-interactions pattern.

Additional information: link

ShamrockShake.swapBack() (#624-673) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256) (#174-177) should emit an event for:
- minPeriod = newMinPeriod (#175)
- minDistribution = newMinDistribution (#176)
ShamrockShake.changeFees(uint256,uint256,uint256,uint256) (#516-524) should emit an event for:
- liquidityFee = newLiqFee (#517)
- rewardsFee = newRewardFee (#518)
- totalFee = liquidityFee.add(marketingFee).add(rewardsFee) (#522)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (#523)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#344) lacks a zero-check on :
- owner = adr (#345)
ShamrockShake.changeFeeReceivers(address,address,address).newLiquidityReceiver (#526) lacks a zero-check on :
- autoLiquidityReceiver = newLiquidityReceiver (#527)
ShamrockShake.changeFeeReceivers(address,address,address).newMarketingWallet (#526) lacks a zero-check on :
- marketingWallet = newMarketingWallet (#528)
ShamrockShake.changeFeeReceivers(address,address,address).newanothermarketingWallet (#526) lacks a zero-check on :
- anothermarketingWallet = newanothermarketingWallet (#529)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (#245-257) has external calls inside a loop: RewardToken.transfer(shareholder,amount) (#251)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in ShamrockShake._transferFrom(address,address,uint256) (#559-600):
External calls:
- swapBack() (#569)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#634-640)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
External calls sending eth:
- swapBack() (#569)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
State variables written after the call(s):
- launch() (#573)
- launchedAt = block.number (#482)
Reentrancy in ShamrockShake.constructor() (#412-444):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#415)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = uint256(- 1) (#416)
- _balances[msg.sender] = _totalSupply (#442)
- anothermarketingWallet = 0x5e5488c1d43c2CE62B993f3B2f0d90ad426a2B23 (#437)
- autoLiquidityReceiver = msg.sender (#435)
- dividendDistributor = new DividendDistributor(address(router)) (#418)
- isDividendExempt[pair] = true (#428)
- isDividendExempt[address(this)] = true (#430)
- isDividendExempt[DEAD] = true (#431)
- isDividendExempt[ZERO] = true (#432)
- isFeeExempt[msg.sender] = true (#420)
- isFeeExempt[address(this)] = true (#421)
- isFeeExempt[anothermarketingWallet] = true (#422)
- isTxLimitExempt[msg.sender] = true (#424)
- isTxLimitExempt[pair] = true (#425)
- isTxLimitExempt[DEAD] = true (#426)
- marketingWallet = msg.sender (#436)
- totalFee = liquidityFee.add(marketingFee).add(rewardsFee) (#439)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (#440)
Reentrancy in DividendDistributor.deposit() (#196-214):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#204-209)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#213)
- totalDividends = totalDividends.add(amount) (#212)
Reentrancy in DividendDistributor.distributeDividend(address) (#245-257):
External calls:
- RewardToken.transfer(shareholder,amount) (#251)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#252)
Reentrancy in DividendDistributor.setShare(address,uint256) (#179-194):
External calls:
- distributeDividend(shareholder) (#182)
- RewardToken.transfer(shareholder,amount) (#251)
State variables written after the call(s):
- addShareholder(shareholder) (#186)
- shareholderIndexes[shareholder] = shareholders.length (#275)
- removeShareholder(shareholder) (#188)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#281)
- addShareholder(shareholder) (#186)
- shareholders.push(shareholder) (#276)
- removeShareholder(shareholder) (#188)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#280)
- shareholders.pop() (#282)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#191)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in ShamrockShake._transferFrom(address,address,uint256) (#559-600):
External calls:
- swapBack() (#569)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#634-640)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
- dividendDistributor.setShare(sender,_balances[sender]) (#589)
- dividendDistributor.setShare(recipient,_balances[recipient]) (#593)
- dividendDistributor.process(distributorGas) (#596)
External calls sending eth:
- swapBack() (#569)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
Event emitted after the call(s):
- Transfer(sender,recipient,finalAmount) (#598)
Reentrancy in ShamrockShake._transferFrom(address,address,uint256) (#559-600):
External calls:
- swapBack() (#569)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#634-640)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
External calls sending eth:
- swapBack() (#569)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#615)
- finalAmount = takeFee(sender,recipient,amount) (#584)
Reentrancy in ShamrockShake.constructor() (#412-444):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#415)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#443)
Reentrancy in ShamrockShake.swapBack() (#624-673):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#634-640)
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
External calls sending eth:
- dividendDistributor.deposit{value: amountBNBReflection}() (#650)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#663-670)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#671)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#240-243) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#241-242)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#216-238) has costly operations inside a loop:
- currentIndex = 0 (#227)
DividendDistributor.distributeDividend(address) (#245-257) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#250)
DividendDistributor.process(uint256) (#216-238) has costly operations inside a loop:
- currentIndex ++ (#235)
Use a local variable to hold the loop computation result.

Additional information: link

ShamrockShake._maxTxAmount (#367) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 1 / 100
ShamrockShake._walletMax (#368) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 3 / 100
ShamrockShake.swapThreshold (#404) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 5 / 2000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.7.4 (#14) allows old versions
solc-0.7.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in ShamrockShake.swapBack() (#624-673):
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#655)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#656)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IDEXRouter.WETH() (#73) is not in mixedCase
Variable DividendDistributor._token (#130) is not in mixedCase
Variable DividendDistributor.RewardToken (#140) is not in mixedCase
Constant ShamrockShake._name (#357) is not in UPPER_CASE_WITH_UNDERSCORES
Constant ShamrockShake._symbol (#358) is not in UPPER_CASE_WITH_UNDERSCORES
Constant ShamrockShake._decimals (#359) is not in UPPER_CASE_WITH_UNDERSCORES
Variable ShamrockShake.DEAD (#361) is not in mixedCase
Variable ShamrockShake.ZERO (#362) is not in mixedCase
Variable ShamrockShake.RewardToken (#364) is not in mixedCase
Variable ShamrockShake._totalSupply (#366) is not in mixedCase
Variable ShamrockShake._maxTxAmount (#367) is not in mixedCase
Variable ShamrockShake._walletMax (#368) is not in mixedCase
Variable ShamrockShake._balances (#372) is not in mixedCase
Variable ShamrockShake._allowances (#373) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#78) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#79)
Prevent variables from having similar names.

Additional information: link

ShamrockShake.slitherConstructorVariables() (#353-678) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#361)
ShamrockShake.slitherConstructorVariables() (#353-678) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#362)
ShamrockShake.slitherConstructorVariables() (#353-678) uses literals with too many digits:
- _totalSupply = 1000000 * (10 ** _decimals) (#366)
ShamrockShake.slitherConstructorVariables() (#353-678) uses literals with too many digits:
- distributorGas = 300000 (#398)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

ShamrockShake.RewardToken (#364) is never used in ShamrockShake (#353-678)
Remove unused state variables.

Additional information: link

DividendDistributor.dividendsPerShareAccuracyFactor (#151) should be constant
DividendDistributor.routerAddress (#139) should be constant
ShamrockShake.DEAD (#361) should be constant
ShamrockShake.RewardToken (#364) should be constant
ShamrockShake.ZERO (#362) should be constant
ShamrockShake._totalSupply (#366) should be constant
ShamrockShake.routerAddress (#363) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#316-318)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#323-325)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#344-348)
getCirculatingSupply() should be declared external:
- ShamrockShake.getCirculatingSupply() (#454-456)
claim() should be declared external:
- ShamrockShake.claim() (#472-475)
tradingStatus(bool) should be declared external:
- ShamrockShake.tradingStatus(bool) (#620-622)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank