Mdex is an automatic market-making decentralized exchange based on the concept of fund pools. It is similar in function to some DEXs on the market, but on this basis, it proposes and implements a dual-chain DEX model based on the Huobi Eco Chain and Ethereum . It combines the advantages of the low transaction fees of the Huobi Eco Chain and the prosperity of the Ethereum ecosystem, and supports the dual mining mechanism of liquidity and transactions.
DelegateERC20._writeCheckpoint(address,uint32,uint256,uint256) (#1232-1250) uses a dangerous strict equality:
- nCheckpoints > 0 && checkpoints[delegatee][nCheckpoints - 1].fromBlock == blockNumber (#1242)
Don't use strict equality to determine if an account has enough Ether or tokens.
Additional information: link
DelegateERC20.delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) (#1096-1137) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now <= expiry,MdxToken::delegateBySig: signature expired) (#1135)
Avoid relying on block.timestamp.
Additional information: link
ERC20.constructor(string,string).name (#511) shadows:
- ERC20.name() (#520-522) (function)
ERC20.constructor(string,string).symbol (#511) shadows:
- ERC20.symbol() (#528-530) (function)
Rename the local variables that shadow another component.
Additional information: link
Address._functionCallWithValue(address,bytes,uint256,string) (#439-460) uses assembly
- INLINE ASM (#452-455)
DelegateERC20.getChainId() (#1257-1262) uses assembly
- INLINE ASM (#1259)
Address.isContract(address) (#346-355) uses assembly
- INLINE ASM (#353)
Do not use evm assembly.
Additional information: link
Pragma version^0.6.0 (#2) allows old versions
Pragma version^0.6.0 (#1035) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Redundant expression "this (#21)" inContext (#15-25)
Remove redundant statements if they congest code but offer no value.
Additional information: link
MdxToken.slitherConstructorConstantVariables() (#1272-1322) uses literals with too many digits:
- preMineSupply = 2000000 * 1e18 (#1273)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
SafeMath.mul(uint256,uint256) (#240-252) is never used and should be removed
EnumerableSet.length(EnumerableSet.Bytes32Set) (#907-909) is never used and should be removed
EnumerableSet.at(EnumerableSet.Bytes32Set,uint256) (#921-923) is never used and should be removed
Address.sendValue(address,uint256) (#373-379) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#424-426) is never used and should be removed
EnumerableSet.remove(EnumerableSet.UintSet,uint256) (#1002-1004) is never used and should be removed
EnumerableSet.contains(EnumerableSet.Bytes32Set,bytes32) (#900-902) is never used and should be removed
EnumerableSet.contains(EnumerableSet.UintSet,uint256) (#1009-1011) is never used and should be removed
ERC20._burn(address,uint256) (#704-712) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#318-321) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#434-437) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#282-288) is never used and should be removed
EnumerableSet.add(EnumerableSet.Bytes32Set,bytes32) (#883-885) is never used and should be removed
ERC20._setupDecimals(uint8) (#742-744) is never used and should be removed
Context._msgData() (#20-24) is never used and should be removed
SafeMath.mod(uint256,uint256) (#302-304) is never used and should be removed
SafeMath.div(uint256,uint256) (#266-268) is never used and should be removed
EnumerableSet.length(EnumerableSet.UintSet) (#1016-1018) is never used and should be removed
Address._functionCallWithValue(address,bytes,uint256,string) (#439-460) is never used and should be removed
EnumerableSet.at(EnumerableSet.UintSet,uint256) (#1030-1032) is never used and should be removed
Address.isContract(address) (#346-355) is never used and should be removed
Address.functionCall(address,bytes,string) (#409-411) is never used and should be removed
EnumerableSet.add(EnumerableSet.UintSet,uint256) (#992-994) is never used and should be removed
EnumerableSet.remove(EnumerableSet.Bytes32Set,bytes32) (#893-895) is never used and should be removed
Address.functionCall(address,bytes) (#399-401) is never used and should be removed
Remove unused functions.
Additional information: link
Low level call in Address.sendValue(address,uint256) (#373-379):
- (success) = recipient.call{value: amount}() (#377)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#439-460):
- (success,returndata) = target.call{value: weiValue}(data) (#443)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#607-611)
getMinter(uint256) should be declared external:
- MdxToken.getMinter(uint256) (#1310-1313)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#76-79)
mint(address,uint256) should be declared external:
- MdxToken.mint(address,uint256) (#1284-1290)
addMinter(address) should be declared external:
- MdxToken.addMinter(address) (#1292-1295)
decimals() should be declared external:
- ERC20.decimals() (#545-547)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#644-647)
symbol() should be declared external:
- ERC20.symbol() (#528-530)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#571-574)
owner() should be declared external:
- Ownable.owner() (#57-59)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#625-628)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#85-89)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#590-593)
delMinter(address) should be declared external:
- MdxToken.delMinter(address) (#1297-1300)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#579-581)
Use the external attribute for functions never called from the contract.
Additional information: link
Parameter MdxToken.getMinter(uint256)._index (#1310) is not in mixedCase
Parameter MdxToken.mint(address,uint256)._amount (#1284) is not in mixedCase
Variable DelegateERC20._delegates (#1040) is not in mixedCase
Parameter MdxToken.addMinter(address)._addMinter (#1292) is not in mixedCase
Constant MdxToken.preMineSupply (#1273) is not in UPPER_CASE_WITH_UNDERSCORES
Parameter MdxToken.mint(address,uint256)._to (#1284) is not in mixedCase
Parameter MdxToken.delMinter(address)._delMinter (#1297) is not in mixedCase
Constant MdxToken.maxSupply (#1274) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.
Additional information: link
Unable to find audit link on the website
Token is not listed at Mobula.Finance
Additional information: link
Unable to find whitepaper link on the website
Unable to find Telegram link on the website
Unable to find Twitter link on the website
Twitter account link seems to be invalid
Unable to find Youtube account