SCH [SolanaCash] Token

SolanaCash.swapBack() (#653-695) sends eth to arbitrary user
Dangerous calls:
- (success) = address(shillFeeReceiver).call{gas: 30000,value: amountBNBShill}() (#681)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in SolanaCash._transferFrom(address,address,uint256) (#588-614):
External calls:
- swapBack() (#597)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#664-670)
- distributor.deposit{value: amountBNBReflection}() (#680)
- (success) = address(shillFeeReceiver).call{gas: 30000,value: amountBNBShill}() (#681)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
- triggerAutoBuyback() (#598)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#729-734)
External calls sending eth:
- swapBack() (#597)
- distributor.deposit{value: amountBNBReflection}() (#680)
- (success) = address(shillFeeReceiver).call{gas: 30000,value: amountBNBShill}() (#681)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
- triggerAutoBuyback() (#598)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#729-734)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#602)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#605)
- amountReceived = takeFee(sender,recipient,amount) (#604)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#640)
- triggerAutoBuyback() (#598)
- inSwap = true (#533)
- inSwap = false (#533)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#428-439) ignores return value by SOL.transfer(shareholder,amount) (#434)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in DividendDistributor.setShare(address,uint256) (#360-374):
External calls:
- distributeDividend(shareholder) (#362)
- SOL.transfer(shareholder,amount) (#434)
State variables written after the call(s):
- shares[shareholder].amount = amount (#372)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#373)
Apply the check-effects-interactions pattern.

Additional information: link

SolanaCash.swapBack() (#653-695) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
Ensure that all the return values of the function calls are used.

Additional information: link

SolanaCash.setTargetLiquidity(uint256,uint256) (#814-817) should emit an event for:
- targetLiquidity = _target (#815)
- targetLiquidityDenominator = _denominator (#816)
Emit an event for critical parameter changes.

Additional information: link

SolanaCash.setFeeReceivers(address,address)._shillFeeReceiver (#804) lacks a zero-check on :
- shillFeeReceiver = _shillFeeReceiver (#806)
Check that the address is not zero.

Additional information: link

Reentrancy in SolanaCash.triggerManualBuyback(uint256,bool) (#705-711):
External calls:
- buyTokens(amount,DEAD) (#706)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#729-734)
State variables written after the call(s):
- buybackMultiplierTriggeredAt = block.timestamp (#708)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in SolanaCash.triggerManualBuyback(uint256,bool) (#705-711):
External calls:
- buyTokens(amount,DEAD) (#706)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,to,block.timestamp) (#729-734)
Event emitted after the call(s):
- BuybackMultiplierActive(buybackMultiplierLength) (#709)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#423-426) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#424-425)
Avoid relying on block.timestamp.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#49-70) uses assembly
- INLINE ASM (#62-65)
Do not use evm assembly.

Additional information: link

DividendDistributor.process(uint256) (#397-421) has costly operations inside a loop:
- currentIndex ++ (#418)
Use a local variable to hold the loop computation result.

Additional information: link

Context._msgData() (#78-81) is never used and should be removed
Remove unused functions.

Additional information: link

SolanaCash.swapThreshold (#531) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 2000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.7.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in SolanaCash.swapBack() (#653-695):
- (success) = address(shillFeeReceiver).call{gas: 30000,value: amountBNBShill}() (#681)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable SolanaCash._sellMultiplier (#502) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#79)" inContext (#73-82)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#256) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#257)
Prevent variables from having similar names.

Additional information: link

SolanaCash.slitherConstructorVariables() (#473-843) uses literals with too many digits:
- distributorGas = 500000 (#528)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SolanaCash.BEP20UpgradableProxy (#477) is never used in SolanaCash (#473-843)
Remove unused state variables.

Additional information: link

SolanaCash._totalSupply (#486) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#238-242)
Use the external attribute for functions never called from the contract.

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank