MYST [Mysterium] Token

SafeERC20.safeApprove(IERC20,address,uint256) (#115-120) is never used and should be removed
Remove unused functions.

Additional information: link

AnyswapV5ERC20.constructor(string,string,uint8,address,address) (#298-326) uses assembly
- INLINE ASM (#318)
Address.isContract(address) (#95-101) uses assembly
- INLINE ASM (#99)
Do not use evm assembly.

Additional information: link

Pragma version0.8.2 (#23) allows old versions
solc-0.8.2 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in SafeERC20.callOptionalReturn(IERC20,bytes) (#121-132):
- (success,returndata) = address(token).call(data) (#125)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

AnyswapV5ERC20.delayDelay (#175) should be constant
AnyswapV5ERC20.pendingDelay (#174) should be constant
AnyswapV5ERC20.delay (#158) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#339-342) ignores return value by IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#340)
Ensure that all the return values of the function calls are used.

Additional information: link

AnyswapV5ERC20.constructor(string,string,uint8,address,address)._underlying (#298) lacks a zero-check on :
- underlying = _underlying (#302)
AnyswapV5ERC20.setVault(address)._vault (#218) lacks a zero-check on :
- pendingVault = _vault (#219)
AnyswapV5ERC20.constructor(string,string,uint8,address,address)._vault (#298) lacks a zero-check on :
- vault = _vault (#313)
- pendingVault = _vault (#314)
AnyswapV5ERC20.initVault(address)._vault (#203) lacks a zero-check on :
- vault = _vault (#205)
- pendingVault = _vault (#206)
AnyswapV5ERC20.setMinter(address)._auth (#213) lacks a zero-check on :
- pendingMinter = _auth (#214)
Check that the address is not zero.

Additional information: link

Parameter AnyswapV5ERC20.setVault(address)._vault (#218) is not in mixedCase
Function AnyswapV5ERC20.Swapin(bytes32,address,uint256) (#271-275) is not in mixedCase
Function AnyswapV5ERC20.Swapout(uint256,address) (#277-283) is not in mixedCase
Variable AnyswapV5ERC20.DOMAIN_SEPARATOR (#145) is not in mixedCase
Parameter AnyswapV5ERC20.initVault(address)._vault (#203) is not in mixedCase
Parameter AnyswapV5ERC20.revokeMinter(address)._auth (#235) is not in mixedCase
Parameter AnyswapV5ERC20.setMinter(address)._auth (#213) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

changeMPCOwner(address) should be declared external:
- AnyswapV5ERC20.changeMPCOwner(address) (#252-258)
owner() should be declared external:
- AnyswapV5ERC20.owner() (#188-190)
Swapout(uint256,address) should be declared external:
- AnyswapV5ERC20.Swapout(uint256,address) (#277-283)
Swapin(bytes32,address,uint256) should be declared external:
- AnyswapV5ERC20.Swapin(bytes32,address,uint256) (#271-275)
Use the external attribute for functions never called from the contract.

Additional information: link

Reentrancy in AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#339-342):
External calls:
- IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#340)
State variables written after the call(s):
- _deposit(value,to) (#341)
- _totalSupply += amount (#404)
- _deposit(value,to) (#341)
- balanceOf[account] += amount (#405)
Reentrancy in AnyswapV5ERC20.deposit(uint256) (#350-353):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#351)
State variables written after the call(s):
- _deposit(amount,msg.sender) (#352)
- _totalSupply += amount (#404)
- _deposit(amount,msg.sender) (#352)
- balanceOf[account] += amount (#405)
Reentrancy in AnyswapV5ERC20.deposit() (#344-348):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),_amount) (#346)
State variables written after the call(s):
- _deposit(_amount,msg.sender) (#347)
- _totalSupply += amount (#404)
- _deposit(_amount,msg.sender) (#347)
- balanceOf[account] += amount (#405)
Reentrancy in AnyswapV5ERC20.depositWithPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#333-337):
External calls:
- IERC20(underlying).permit(target,address(this),value,deadline,v,r,s) (#334)
- IERC20(underlying).safeTransferFrom(target,address(this),value) (#335)
State variables written after the call(s):
- _deposit(value,to) (#336)
- _totalSupply += amount (#404)
- _deposit(value,to) (#336)
- balanceOf[account] += amount (#405)
Reentrancy in AnyswapV5ERC20.deposit(uint256,address) (#355-358):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#356)
State variables written after the call(s):
- _deposit(amount,to) (#357)
- _totalSupply += amount (#404)
- _deposit(amount,to) (#357)
- balanceOf[account] += amount (#405)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in AnyswapV5ERC20.deposit(uint256) (#350-353):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#351)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#406)
- _deposit(amount,msg.sender) (#352)
Reentrancy in AnyswapV5ERC20.deposit() (#344-348):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),_amount) (#346)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#406)
- _deposit(_amount,msg.sender) (#347)
Reentrancy in AnyswapV5ERC20.depositWithPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#333-337):
External calls:
- IERC20(underlying).permit(target,address(this),value,deadline,v,r,s) (#334)
- IERC20(underlying).safeTransferFrom(target,address(this),value) (#335)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#406)
- _deposit(value,to) (#336)
Reentrancy in AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#339-342):
External calls:
- IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#340)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#406)
- _deposit(value,to) (#341)
Reentrancy in AnyswapV5ERC20.deposit(uint256,address) (#355-358):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#356)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#406)
- _deposit(amount,to) (#357)
Apply the check-effects-interactions pattern.

Additional information: link

AnyswapV5ERC20.transferWithPermit(address,address,uint256,uint256,uint8,bytes32,bytes32) (#480-504) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp <= deadline,AnyswapV3ERC20: Expired permit) (#481)
AnyswapV5ERC20.permit(address,address,uint256,uint256,uint8,bytes32,bytes32) (#461-478) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp <= deadline,AnyswapV3ERC20: Expired permit) (#462)
AnyswapV5ERC20.applyVault() (#223-226) uses timestamp for comparisons
Dangerous comparisons:
- require(bool)(block.timestamp >= delayVault) (#224)
AnyswapV5ERC20.applyMinter() (#228-232) uses timestamp for comparisons
Dangerous comparisons:
- require(bool)(block.timestamp >= delayMinter) (#229)
AnyswapV5ERC20.mpc() (#192-197) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp >= delayVault (#193)
Avoid relying on block.timestamp.

Additional information: link

Token is not listed at Mobula.Finance

Additional information: link

Unable to find audit link on the website