RDC [Ragdoll Cat NFT] Token

Ragdoll.distributeAndLiquify(address,address) (#436-498) sends eth to arbitrary user
Dangerous calls:
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Ragdoll._transfer(address,address,uint256) (#369-396):
External calls:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#516-522)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#395)
- _balances[sender] = _balances[sender].sub(amount) (#408)
- _balances[recipient] = _balances[recipient].add(tTransferAmount) (#409)
- _balances[address(this)] = _balances[address(this)].add(_lpFee).add(_marketFee).add(_buyBackFee) (#431)
- _balances[sender] = _balances[sender].sub(amount) (#416)
- _balances[recipient] = _balances[recipient].add(amount) (#417)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- liquidityFeeCounter = liquidityFeeCounter.add(_lpFee) (#425)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- marketFeeCounter = marketFeeCounter.add(_marketFee) (#427)
Reentrancy in Ragdoll.distributeAndLiquify(address,address) (#436-498):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- liquidityFeeCounter = 0 (#494)
- marketFeeCounter = 0 (#495)
Apply the check-effects-interactions pattern.

Additional information: link

Ragdoll.removeStuckToken(IBEP20,address,uint256) (#338-344) ignores return value by _token.transfer(_account,_amount) (#343)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Ragdoll.distributeAndLiquify(address,address) (#436-498) performs a multiplication on the result of a division:
-halfLiquidity = liquidityFeeCounter.div(2) (#454)
-bnbToBeAddedToLiquidity = deltaBalance.mul(halfLiquidity).div(tokenAmountToBeSwapped) (#465)
Consider ordering multiplication before division.

Additional information: link

Utils.addLiquidity(address,address,uint256,uint256) (#525-542) ignores return value by dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
Ensure that all the return values of the function calls are used.

Additional information: link

Ragdoll.allowance(address,address).owner (#222) shadows:
- Ownable.owner() (#99-101) (function)
Ragdoll._approve(address,address,uint256).owner (#358) shadows:
- Ownable.owner() (#99-101) (function)
Rename the local variables that shadow another component.

Additional information: link

Ragdoll.setMinTokenToSwap(uint256) (#293-295) should emit an event for:
- minTokenToSwap = _amount (#294)
Ragdoll.setFeePercent(uint256,uint256,uint256) (#297-305) should emit an event for:
- buyBackFee = _buyBackFee (#302)
- marketFee = _marketFee (#303)
- liquidityFee = _lpFee (#304)
Emit an event for critical parameter changes.

Additional information: link

Ragdoll.constructor(address,address)._buyBackWallet (#161) lacks a zero-check on :
- buyBackWallet = _buyBackWallet (#166)
Ragdoll.constructor(address,address)._marketWallet (#162) lacks a zero-check on :
- marketWallet = _marketWallet (#167)
Ragdoll.updateAddresses(address,address)._buyBackWallet (#316) lacks a zero-check on :
- buyBackWallet = _buyBackWallet (#319)
Ragdoll.updateAddresses(address,address)._marketWallet (#317) lacks a zero-check on :
- marketWallet = _marketWallet (#320)
Ragdoll.setPancakeRouter(IDexRouter,address)._pair (#323) lacks a zero-check on :
- dexPair = _pair (#328)
Ragdoll.removeStuckBnb(address,uint256)._account (#331) lacks a zero-check on :
- _account.transfer(_amount) (#335)
Check that the address is not zero.

Additional information: link

Reentrancy in Ragdoll._transfer(address,address,uint256) (#369-396):
External calls:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#516-522)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#395)
- buyBackFeeCounter = buyBackFeeCounter.add(_buyBackFee) (#429)
Reentrancy in Ragdoll.constructor(address,address) (#160-188):
External calls:
- dexPair = IPancakeFactory(_pancakeRouter.factory()).createPair(address(this),_pancakeRouter.WETH()) (#174-177)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#183)
- _isExcludedFromFee[address(this)] = true (#184)
- dexRouter = _pancakeRouter (#180)
Reentrancy in Ragdoll.distributeAndLiquify(address,address) (#436-498):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- buyBackFeeCounter = 0 (#496)
Reentrancy in Ragdoll.transferFrom(address,address,uint256) (#240-255):
External calls:
- _transfer(sender,recipient,amount) (#245)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#516-522)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- _transfer(sender,recipient,amount) (#245)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,RDC: transfer amount exceeds allowance)) (#246-253)
- _allowances[owner][spender] = amount (#365)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Ragdoll._transfer(address,address,uint256) (#369-396):
External calls:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#516-522)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
Event emitted after the call(s):
- Transfer(sender,recipient,tTransferAmount) (#410)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- Transfer(sender,address(this),_lpFee.add(_marketFee).add(_buyBackFee)) (#433)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- Transfer(sender,recipient,amount) (#419)
- _tokenTransfer(from,to,amount,takeFee) (#395)
Reentrancy in Ragdoll.constructor(address,address) (#160-188):
External calls:
- dexPair = IPancakeFactory(_pancakeRouter.factory()).createPair(address(this),_pancakeRouter.WETH()) (#174-177)
Event emitted after the call(s):
- Transfer(address(0),owner(),_totalSupply) (#187)
Reentrancy in Ragdoll.distributeAndLiquify(address,address) (#436-498):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
Event emitted after the call(s):
- SwapAndLiquify(halfLiquidity,bnbToBeAddedToLiquidity,otherHalfLiquidity) (#486-490)
Reentrancy in Ragdoll.transferFrom(address,address,uint256) (#240-255):
External calls:
- _transfer(sender,recipient,amount) (#245)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#516-522)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#462)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#479-484)
External calls sending eth:
- _transfer(sender,recipient,amount) (#245)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#366)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,RDC: transfer amount exceeds allowance)) (#246-253)
Apply the check-effects-interactions pattern.

Additional information: link

Context._msgData() (#80-83) is never used and should be removed
SafeMath.mod(uint256,uint256) (#598-600) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#602-609) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version^0.8.10 (#1) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.10 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function IDexRouter.WETH() (#48) is not in mixedCase
Parameter Ragdoll.setMinTokenToSwap(uint256)._amount (#293) is not in mixedCase
Parameter Ragdoll.setFeePercent(uint256,uint256,uint256)._buyBackFee (#298) is not in mixedCase
Parameter Ragdoll.setFeePercent(uint256,uint256,uint256)._marketFee (#299) is not in mixedCase
Parameter Ragdoll.setFeePercent(uint256,uint256,uint256)._lpFee (#300) is not in mixedCase
Parameter Ragdoll.setDistributionStatus(bool)._value (#307) is not in mixedCase
Parameter Ragdoll.enableOrDisableFees(bool)._value (#311) is not in mixedCase
Parameter Ragdoll.updateAddresses(address,address)._buyBackWallet (#316) is not in mixedCase
Parameter Ragdoll.updateAddresses(address,address)._marketWallet (#317) is not in mixedCase
Parameter Ragdoll.setPancakeRouter(IDexRouter,address)._router (#323) is not in mixedCase
Parameter Ragdoll.setPancakeRouter(IDexRouter,address)._pair (#323) is not in mixedCase
Parameter Ragdoll.removeStuckBnb(address,uint256)._account (#331) is not in mixedCase
Parameter Ragdoll.removeStuckBnb(address,uint256)._amount (#331) is not in mixedCase
Parameter Ragdoll.removeStuckToken(IBEP20,address,uint256)._token (#339) is not in mixedCase
Parameter Ragdoll.removeStuckToken(IBEP20,address,uint256)._account (#340) is not in mixedCase
Parameter Ragdoll.removeStuckToken(IBEP20,address,uint256)._amount (#341) is not in mixedCase
Variable Ragdoll._isExcludedFromFee (#128) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#81)" inContext (#75-84)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in Ragdoll._transfer(address,address,uint256) (#369-396):
External calls:
- distributeAndLiquify(from,to) (#380)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
External calls sending eth:
- distributeAndLiquify(from,to) (#380)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#395)
- _balances[sender] = _balances[sender].sub(amount) (#408)
- _balances[recipient] = _balances[recipient].add(tTransferAmount) (#409)
- _balances[address(this)] = _balances[address(this)].add(_lpFee).add(_marketFee).add(_buyBackFee) (#431)
- _balances[sender] = _balances[sender].sub(amount) (#416)
- _balances[recipient] = _balances[recipient].add(amount) (#417)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- buyBackFeeCounter = buyBackFeeCounter.add(_buyBackFee) (#429)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- liquidityFeeCounter = liquidityFeeCounter.add(_lpFee) (#425)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- marketFeeCounter = marketFeeCounter.add(_marketFee) (#427)
Event emitted after the call(s):
- Transfer(sender,recipient,tTransferAmount) (#410)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- Transfer(sender,address(this),_lpFee.add(_marketFee).add(_buyBackFee)) (#433)
- _tokenTransfer(from,to,amount,takeFee) (#395)
- Transfer(sender,recipient,amount) (#419)
- _tokenTransfer(from,to,amount,takeFee) (#395)
Reentrancy in Ragdoll.distributeAndLiquify(address,address) (#436-498):
External calls:
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- buyBackFeeCounter = 0 (#496)
- liquidityFeeCounter = 0 (#494)
- marketFeeCounter = 0 (#495)
Event emitted after the call(s):
- SwapAndLiquify(halfLiquidity,bnbToBeAddedToLiquidity,otherHalfLiquidity) (#486-490)
Reentrancy in Ragdoll.transferFrom(address,address,uint256) (#240-255):
External calls:
- _transfer(sender,recipient,amount) (#245)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
External calls sending eth:
- _transfer(sender,recipient,amount) (#245)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#534-541)
- marketWallet.transfer(bnbFormarket) (#471)
- buyBackWallet.transfer(bnbForBuyBack) (#475)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,RDC: transfer amount exceeds allowance)) (#246-253)
- _allowances[owner][spender] = amount (#365)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#366)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,RDC: transfer amount exceeds allowance)) (#246-253)
Apply the check-effects-interactions pattern.

Additional information: link

Ragdoll.slitherConstructorVariables() (#123-499) uses literals with too many digits:
- minTokenToSwap = 100000 * 1e9 (#140)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Ragdoll._decimals (#132) should be constant
Ragdoll._name (#130) should be constant
Ragdoll._symbol (#131) should be constant
Ragdoll._totalSupply (#133) should be constant
Ragdoll.percentDivider (#141) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#108-111)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#113-120)
name() should be declared external:
- Ragdoll.name() (#193-195)
symbol() should be declared external:
- Ragdoll.symbol() (#197-199)
decimals() should be declared external:
- Ragdoll.decimals() (#201-203)
totalSupply() should be declared external:
- Ragdoll.totalSupply() (#205-207)
transfer(address,uint256) should be declared external:
- Ragdoll.transfer(address,uint256) (#213-220)
allowance(address,address) should be declared external:
- Ragdoll.allowance(address,address) (#222-229)
approve(address,uint256) should be declared external:
- Ragdoll.approve(address,uint256) (#231-238)
transferFrom(address,address,uint256) should be declared external:
- Ragdoll.transferFrom(address,address,uint256) (#240-255)
increaseAllowance(address,uint256) should be declared external:
- Ragdoll.increaseAllowance(address,uint256) (#257-268)
decreaseAllowance(address,uint256) should be declared external:
- Ragdoll.decreaseAllowance(address,uint256) (#270-284)
setDistributionStatus(bool) should be declared external:
- Ragdoll.setDistributionStatus(bool) (#307-309)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 9% buy tax and 11% sell tax.
Taxes are suspiciously high (over 10%) and contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find Telegram link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank