Binamon, A Complete Metaverse of Digital Monsters on Binance Smart Chain
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
Reentrancy in BMONSeedAndPreSale.buyTokens() (#283-312):
External calls:
- token.transfer(msg.sender,tokenAmount) (#296)
External calls sending eth:
- address(benificiary).transfer(msg.value) (#297)
State variables written after the call(s):
- totalPresaleTokensSold += tokenAmount (#302)
Apply the check-effects-interactions pattern.
Additional information: link
BMONSeedAndPreSale.buyTokens() (#283-312) ignores return value by token.transfer(msg.sender,tokenAmount) (#307)
BMONSeedAndPreSale.buyTokens() (#283-312) ignores return value by token.transfer(msg.sender,tokenAmount) (#296)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Contract ownership is not renounced (belongs to a wallet)
Pragma version>=0.7.0<0.9.0 (#1) is too complex
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Reentrancy in BMONSeedAndPreSale.buyTokens() (#283-312):
External calls:
- address(benificiary).transfer(msg.value) (#297)
State variables written after the call(s):
- salesAtPresale[msg.sender] += msg.value (#304)
- totalPresaleBnbCollected += msg.value (#303)
- totalPresaleTokensSold += tokenAmount (#302)
Apply the check-effects-interactions pattern.
Additional information: link
BMON.restrictionLiftTime (#63) is never used in BMON (#49-208)
Ownable._lockTime (#19) is never used in BMON (#49-208)
Ownable._previousOwner (#18) is never used in BMON (#49-208)
Ownable._previousOwner (#18) is never used in BMONSeedAndPreSale (#210-321)
Ownable._lockTime (#19) is never used in BMONSeedAndPreSale (#210-321)
Remove unused state variables.
Additional information: link
BMON.restrictionLiftTime (#63) should be constant
Ownable._previousOwner (#18) should be constant
Ownable._lockTime (#19) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
BMONSeedAndPreSale.closePreSale() (#314-320) ignores return value by token.burn(token.balanceOf(address(this))) (#318)
Ensure that all the return values of the function calls are used.
Additional information: link
BMON.boosterBuyingAllowance(address,address).owner (#143) shadows:
- Ownable.owner() (#28-30) (function)
BMON.allowance(address,address).owner (#119) shadows:
- Ownable.owner() (#28-30) (function)
BMON.transferFrom(address,address,uint256).owner (#123) shadows:
- Ownable.owner() (#28-30) (function)
BMON.boosterBuyingAllowance(address).owner (#139) shadows:
- Ownable.owner() (#28-30) (function)
Rename the local variables that shadow another component.
Additional information: link
BMON.setSeedAndPresale(address) (#153-155) should emit an event for:
- seedAndPresale = seedAndPresale_ (#154)
- seedAndPresale = seedAndPresale_ (#154)
Emit an event for critical parameter changes.
Additional information: link
BMONSeedAndPreSale.setStartTime(uint256) (#251-253) should emit an event for:
- startTime = time (#252)
Emit an event for critical parameter changes.
Additional information: link
BMON.setSeedAndPresale(address).seedAndPresale_ (#153) lacks a zero-check on :
- seedAndPresale = seedAndPresale_ (#154)
BMONSeedAndPreSale.constructor(address,address).beneficiary_ (#246) lacks a zero-check on :
- benificiary = beneficiary_ (#248)
Check that the address is not zero.
Additional information: link
Reentrancy in BMONSeedAndPreSale.buyTokens() (#283-312):
External calls:
- token.transfer(msg.sender,tokenAmount) (#296)
External calls sending eth:
- address(benificiary).transfer(msg.value) (#297)
State variables written after the call(s):
- salesAtPresale[msg.sender] += msg.value (#304)
- totalPresaleBnbCollected += msg.value (#303)
Apply the check-effects-interactions pattern.
Additional information: link
BMONSeedAndPreSale.getState() (#259-273) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp < startTime (#260)
- block.timestamp >= startTime && block.timestamp < startTime + SEED_DURATION (#261)
- block.timestamp >= startTime + SEED_DURATION && block.timestamp < startTime + SEED_DURATION + DELAY_BEFORE_PRESALE (#265)
- block.timestamp >= startTime + SEED_DURATION + DELAY_BEFORE_PRESALE && block.timestamp < startTime + SEED_DURATION + DELAY_BEFORE_PRESALE + PRESALE_DURATION (#266-267)
- block.timestamp >= startTime + SEED_DURATION + DELAY_BEFORE_PRESALE + PRESALE_DURATION (#271)
Avoid relying on block.timestamp.
Additional information: link
Constant BMON._symbol (#52) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BMON._decimals (#53) is not in UPPER_CASE_WITH_UNDERSCORES
Constant BMON._name (#51) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.
Additional information: link
decimals() should be declared external:
- BMON.decimals() (#92-94)
setRestrictionAmount(uint256) should be declared external:
- BMON.setRestrictionAmount(uint256) (#178-180)
name() should be declared external:
- BMON.name() (#84-86)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#37-40)
getSalesAtSeed(address) should be declared external:
- BMONSeedAndPreSale.getSalesAtSeed(address) (#275-277)
allowBuyingBoosters(address) should be declared external:
- BMON.allowBuyingBoosters(address) (#148-151)
transfer(address,uint256) should be declared external:
- BMON.transfer(address,uint256) (#104-111)
setBotProtection(bool) should be declared external:
- BMON.setBotProtection(bool) (#173-176)
getSalesAtPresale(address) should be declared external:
- BMONSeedAndPreSale.getSalesAtPresale(address) (#279-281)
closePreSale() should be declared external:
- BMONSeedAndPreSale.closePreSale() (#314-320)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#42-46)
approve(address,uint256) should be declared external:
- BMON.approve(address,uint256) (#113-117)
setStartTime(uint256) should be declared external:
- BMONSeedAndPreSale.setStartTime(uint256) (#251-253)
transferFrom(address,address,uint256) should be declared external:
- BMON.transferFrom(address,address,uint256) (#123-137)
allowance(address,address) should be declared external:
- BMON.allowance(address,address) (#119-121)
burn(uint256) should be declared external:
- BMON.burn(uint256) (#162-168)
balanceOf(address) should be declared external:
- BMON.balanceOf(address) (#100-102)
symbol() should be declared external:
- BMON.symbol() (#88-90)
boosterBuyingAllowance(address) should be declared external:
- BMON.boosterBuyingAllowance(address) (#139-141)
totalSupply() should be declared external:
- BMON.totalSupply() (#96-98)
setSeedAndPresale(address) should be declared external:
- BMON.setSeedAndPresale(address) (#153-155)
whitelistAccount(address) should be declared external:
- BMON.whitelistAccount(address) (#182-184)
Use the external attribute for functions never called from the contract.
Additional information: link
Unable to find token contract audit
Unable to find audit link on the website
Unable to find code repository for the project
Unable to find Blog account (Reddit or Medium)