MetaKnight [Meta Knight] Token

MetaKnight.swapBack() (#676-705) sends eth to arbitrary user
Dangerous calls:
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in MetaKnight._transferFrom(address,address,uint256) (#570-623):
External calls:
- swapBack() (#589)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#681-687)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
External calls sending eth:
- swapBack() (#589)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
State variables written after the call(s):
- _basicTransfer(address(this),DEAD,taxBurnAmount) (#593)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#630-633)
- _balances[recipient] = _balances[recipient].add(amount) (#634)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#598-601)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#606)
- amountReceived = takeFee(sender,amount,recipient) (#603-605)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#662)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#338-355) ignores return value by REWARDS.transfer(shareholder,amount) (#346)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

MetaKnight.swapBack().tmpSuccess (#699) is written in both
(tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
tmpSuccess = false (#704)
Fix or remove the writes.

Additional information: link

Contract ownership is not renounced (belongs to a wallet)

DividendDistributor.WBNB (#210) should be constant
DividendDistributor.dividendsPerShareAccuracyFactor (#225) should be constant
MetaKnight.DEAD (#411) should be constant
MetaKnight.WBNB (#410) should be constant
MetaKnight.ZERO (#412) should be constant
MetaKnight._totalSupply (#418) should be constant
MetaKnight.feeDenominator (#441) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#153-156)
getCirculatingSupply() should be declared external:
- MetaKnight.getCirculatingSupply() (#791-793)
Use the external attribute for functions never called from the contract.

Additional information: link

MetaKnight._maxWalletToken (#421) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 5) / 100
MetaKnight.swapThreshold (#454) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 2) / 1000
MetaKnight.taxBurnAmount (#455) is set pre-construction with a non-constant function or state variable:
- swapThreshold.div(4)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Reentrancy in DividendDistributor.distributeDividend(address) (#338-355):
External calls:
- REWARDS.transfer(shareholder,amount) (#346)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#348-350)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#351-353)
Reentrancy in DividendDistributor.process(uint256) (#300-326):
External calls:
- distributeDividend(shareholders[currentIndex]) (#318)
- REWARDS.transfer(shareholder,amount) (#346)
State variables written after the call(s):
- currentIndex ++ (#323)
Reentrancy in DividendDistributor.setShare(address,uint256) (#259-279):
External calls:
- distributeDividend(shareholder) (#265)
- REWARDS.transfer(shareholder,amount) (#346)
State variables written after the call(s):
- shares[shareholder].amount = amount (#275)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#276-278)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256) (#251-257) should emit an event for:
- minPeriod = _minPeriod (#255)
- minDistribution = _minDistribution (#256)
MetaKnight.setFees(uint256,uint256,uint256) (#746-757) should emit an event for:
- totalFee = _totalFee (#754)
- totalSellFee = _totalSellFee (#755)
- totalTransferFee = _totalTransferFee (#756)
MetaKnight.setDistributionAmounts(uint256,uint256) (#759-766) should emit an event for:
- totalAmountDivider = _reflectionAmount.add(_marketingAmount) (#763)
- reflectionAmount = _reflectionAmount (#764)
- marketingAmount = _marketingAmount (#765)
MetaKnight.setSwapBackSettings(bool,uint256,uint256) (#769-777) should emit an event for:
- swapThreshold = _amount * 10 ** 9 (#775)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#153) lacks a zero-check on :
- owner = adr (#154)
MetaKnight.setFeeReceivers(address)._marketingAmountReceiver (#739) lacks a zero-check on :
- marketingAmountReceiver = _marketingAmountReceiver (#743)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (#338-355) has external calls inside a loop: REWARDS.transfer(shareholder,amount) (#346)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in MetaKnight.constructor() (#464-498):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#472)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#473)
- _balances[msg.sender] = _totalSupply (#496)
- distributor = new DividendDistributor(address(router)) (#475)
- isDividendExempt[pair] = true (#489)
- isDividendExempt[address(this)] = true (#490)
- isDividendExempt[DEAD] = true (#491)
- isFeeExempt[msg.sender] = true (#477)
- isFeeExempt[marketingAmountReceiver] = true (#478)
- isFeeExempt[DEAD] = true (#479)
- isFeeExempt[address(this)] = true (#480)
- isMaxWalletExempt[msg.sender] = true (#483)
- isMaxWalletExempt[marketingAmountReceiver] = true (#484)
- isMaxWalletExempt[DEAD] = true (#485)
- isMaxWalletExempt[address(this)] = true (#486)
- isMaxWalletExempt[pair] = true (#487)
- pairs[pair] = true (#494)
Reentrancy in DividendDistributor.deposit() (#281-298):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#288-290)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#295-297)
- totalDividends = totalDividends.add(amount) (#294)
Reentrancy in DividendDistributor.distributeDividend(address) (#338-355):
External calls:
- REWARDS.transfer(shareholder,amount) (#346)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#347)
Reentrancy in DividendDistributor.setShare(address,uint256) (#259-279):
External calls:
- distributeDividend(shareholder) (#265)
- REWARDS.transfer(shareholder,amount) (#346)
State variables written after the call(s):
- addShareholder(shareholder) (#269)
- shareholderIndexes[shareholder] = shareholders.length (#392)
- removeShareholder(shareholder) (#271)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#400-402)
- addShareholder(shareholder) (#269)
- shareholders.push(shareholder) (#393)
- removeShareholder(shareholder) (#271)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#397-399)
- shareholders.pop() (#403)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#274)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MetaKnight._transferFrom(address,address,uint256) (#570-623):
External calls:
- swapBack() (#589)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#681-687)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
External calls sending eth:
- swapBack() (#589)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#635)
- _basicTransfer(address(this),DEAD,taxBurnAmount) (#593)
- Transfer(sender,address(this),feeAmount) (#663)
- amountReceived = takeFee(sender,amount,recipient) (#603-605)
Reentrancy in MetaKnight._transferFrom(address,address,uint256) (#570-623):
External calls:
- swapBack() (#589)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#681-687)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
- distributor.setShare(sender,_balances[sender]) (#610)
- distributor.setShare(recipient,_balances[recipient]) (#614-616)
- distributor.process(distributorGas) (#619)
External calls sending eth:
- swapBack() (#589)
- distributor.deposit{value: amountBNBReflection}() (#698)
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#621)
Reentrancy in MetaKnight.constructor() (#464-498):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#472)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#497)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#328-336) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#333-335)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#300-326) has costly operations inside a loop:
- currentIndex = 0 (#314)
DividendDistributor.distributeDividend(address) (#338-355) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#345)
DividendDistributor.process(uint256) (#300-326) has costly operations inside a loop:
- currentIndex ++ (#323)
Use a local variable to hold the loop computation result.

Additional information: link

Pragma version^0.8.10 (#30) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.10 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in MetaKnight.swapBack() (#676-705):
- (tmpSuccess) = address(marketingAmountReceiver).call{value: amountBNBMarketing}() (#699-701)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Parameter DividendDistributor.setDistributionCriteria(uint256,uint256)._minPeriod (#252) is not in mixedCase
Parameter DividendDistributor.setDistributionCriteria(uint256,uint256)._minDistribution (#253) is not in mixedCase
Variable DividendDistributor._token (#202) is not in mixedCase
Variable DividendDistributor.WBNB (#210) is not in mixedCase
Variable DividendDistributor.REWARDS (#212) is not in mixedCase
Parameter MetaKnight.setFeeReceivers(address)._marketingAmountReceiver (#739) is not in mixedCase
Parameter MetaKnight.setFees(uint256,uint256,uint256)._totalFee (#747) is not in mixedCase
Parameter MetaKnight.setFees(uint256,uint256,uint256)._totalSellFee (#748) is not in mixedCase
Parameter MetaKnight.setFees(uint256,uint256,uint256)._totalTransferFee (#749) is not in mixedCase
Parameter MetaKnight.setDistributionAmounts(uint256,uint256)._reflectionAmount (#760) is not in mixedCase
Parameter MetaKnight.setDistributionAmounts(uint256,uint256)._marketingAmount (#761) is not in mixedCase
Parameter MetaKnight.setSwapBackSettings(bool,uint256,uint256)._enabled (#770) is not in mixedCase
Parameter MetaKnight.setSwapBackSettings(bool,uint256,uint256)._amount (#771) is not in mixedCase
Parameter MetaKnight.setSwapBackSettings(bool,uint256,uint256)._taxBurnAmount (#772) is not in mixedCase
Parameter MetaKnight.setDistributionCriteria(uint256,uint256)._minPeriod (#780) is not in mixedCase
Parameter MetaKnight.setDistributionCriteria(uint256,uint256)._minDistribution (#781) is not in mixedCase
Variable MetaKnight.WBNB (#410) is not in mixedCase
Variable MetaKnight.DEAD (#411) is not in mixedCase
Variable MetaKnight.ZERO (#412) is not in mixedCase
Constant MetaKnight._name (#414) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MetaKnight._symbol (#415) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MetaKnight._decimals (#416) is not in UPPER_CASE_WITH_UNDERSCORES
Variable MetaKnight._totalSupply (#418) is not in mixedCase
Variable MetaKnight._maxWalletToken (#421) is not in mixedCase
Variable MetaKnight._balances (#423) is not in mixedCase
Variable MetaKnight._allowances (#424) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

MetaKnight.slitherConstructorVariables() (#407-801) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#411)
MetaKnight.slitherConstructorVariables() (#407-801) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#412)
MetaKnight.slitherConstructorVariables() (#407-801) uses literals with too many digits:
- distributorGas = 300000 (#451)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Contract has 6% buy tax and 89% sell tax.
Taxes are extremely high (over 30%)

Additional information: link

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Average 30d PancakeSwap liquidity is low.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to verify token contract address on the website

Unable to find Twitter link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank