McCardanos Token

Reentrancy in McCardanos.claimBTC(address) (#1098-1132):
External calls:
- _pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,addr,block.timestamp) (#1124-1128)
State variables written after the call(s):
- _isWithdrawing = false (#1131)
Apply the check-effects-interactions pattern.

Additional information: link

McCardanos.TeamReleaseLiquidity() (#1412-1422) ignores return value by liquidityToken.transfer(TeamWallet,amount) (#1420)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

McCardanos.claimBTC(address) (#1098-1132) uses a dangerous strict equality:
- amount == 0 (#1115)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

McCardanos.slitherConstructorConstantVariables() (#749-1540) uses literals with too many digits:
- InitialSupply = 1000000000 * 10 ** _decimals (#767)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

TeamRemoveRemainingBNB() should be declared external:
- McCardanos.TeamRemoveRemainingBNB() (#1455-1460)
Use the external attribute for functions never called from the contract.

Additional information: link

McCardanos.TeamRemoveLiquidity(bool) (#1424-1453) ignores return value by _pancakeRouter.removeLiquidityETHSupportingFeeOnTransferTokens(address(this),amount,0,0,address(this),block.timestamp) (#1437-1444)
Ensure that all the return values of the function calls are used.

Additional information: link

McCardanos._approve(address,address,uint256).owner (#1506) shadows:
- Ownable.owner() (#233-235) (function)
Rename the local variables that shadow another component.

Additional information: link

McCardanos.TeamUpdateLimits(uint256,uint256) (#1365-1382) should emit an event for:
- balanceLimit = newBalanceLimit (#1380)
- sellLimit = newSellLimit (#1381)
Emit an event for critical parameter changes.

Additional information: link

McCardanos.SetupLiquidityTokenAddress(address).liquidityTokenAddress (#1394) lacks a zero-check on :
- _liquidityTokenAddress = liquidityTokenAddress (#1395)
Check that the address is not zero.

Additional information: link

Reentrancy in McCardanos.transferFrom(address,address,uint256) (#1514-1522):
External calls:
- _transfer(sender,recipient,amount) (#1515)
- _pancakeRouter.addLiquidityETH{value: bnbamount}(address(this),tokenamount,0,0,address(this),block.timestamp) (#1198-1205)
- _pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,address(this),block.timestamp) (#1186-1192)
- _pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,addr,block.timestamp) (#1124-1128)
External calls sending eth:
- _transfer(sender,recipient,amount) (#1515)
- _pancakeRouter.addLiquidityETH{value: bnbamount}(address(this),tokenamount,0,0,address(this),block.timestamp) (#1198-1205)
- _pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,addr,block.timestamp) (#1124-1128)
State variables written after the call(s):
- _approve(sender,msg.sender,currentAllowance - amount) (#1520)
- _allowances[owner][spender] = amount (#1510)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in McCardanos.transferFrom(address,address,uint256) (#1514-1522):
External calls:
- _transfer(sender,recipient,amount) (#1515)
- _pancakeRouter.addLiquidityETH{value: bnbamount}(address(this),tokenamount,0,0,address(this),block.timestamp) (#1198-1205)
- _pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,address(this),block.timestamp) (#1186-1192)
- _pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,addr,block.timestamp) (#1124-1128)
External calls sending eth:
- _transfer(sender,recipient,amount) (#1515)
- _pancakeRouter.addLiquidityETH{value: bnbamount}(address(this),tokenamount,0,0,address(this),block.timestamp) (#1198-1205)
- _pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,addr,block.timestamp) (#1124-1128)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1511)
- _approve(sender,msg.sender,currentAllowance - amount) (#1520)
Apply the check-effects-interactions pattern.

Additional information: link

McCardanos.TeamRemoveRemainingBNB() (#1455-1460) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp >= _liquidityUnlockTime,Not yet unlocked) (#1456)
Avoid relying on block.timestamp.

Additional information: link

Address._verifyCallResult(bool,bytes,string) (#434-451) uses assembly
- INLINE ASM (#443-446)
Do not use evm assembly.

Additional information: link

McCardanos._isTeam(address) (#809-811) is never used and should be removed
Remove unused functions.

Additional information: link

McCardanos.sellLimit (#791) is set pre-construction with a non-constant function or state variable:
- _circulatingSupply
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.8.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in McCardanos.TeamRemoveRemainingBNB() (#1455-1460):
- (sent) = TeamWallet.call{value: (address(this).balance)}() (#1458)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Constant McCardanos.DistributionMultiplier (#987) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Variable IPancakeRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#73) is too similar to IPancakeRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#74)
Prevent variables from having similar names.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death