LAVA [LavaCake] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

LavaToken.addLiquidity(uint256,uint256) (#1316-1329) sends eth to arbitrary user
Dangerous calls:
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in LavaToken._transfer(address,address,uint256) (#1230-1261):
External calls:
- swapAndLiquify() (#1240)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
- lavaRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1306-1312)
External calls sending eth:
- swapAndLiquify() (#1240)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
State variables written after the call(s):
- super._transfer(sender,recipient,amount) (#1244)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#1051)
- _balances[recipient] = _balances[recipient].add(amount) (#1052)
- super._transfer(sender,BURN_ADDRESS,burnAmount) (#1256)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#1051)
- _balances[recipient] = _balances[recipient].add(amount) (#1052)
- super._transfer(sender,address(this),liquidityAmount) (#1257)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#1051)
- _balances[recipient] = _balances[recipient].add(amount) (#1052)
- super._transfer(sender,recipient,sendAmount) (#1258)
- _balances[sender] = _balances[sender].sub(amount,BEP20: transfer amount exceeds balance) (#1051)
- _balances[recipient] = _balances[recipient].add(amount) (#1052)
Apply the check-effects-interactions pattern.

Additional information: link

LavaToken._writeCheckpoint(address,uint32,uint256,uint256) (#1639-1657) uses a dangerous strict equality:
- nCheckpoints > 0 && checkpoints[delegatee][nCheckpoints - 1].fromBlock == blockNumber (#1649)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

LavaToken._transfer(address,address,uint256) (#1230-1261) performs a multiplication on the result of a division:
-taxAmount = amount.mul(transferTaxRate).div(10000) (#1247)
-burnAmount = taxAmount.mul(burnRate).div(100) (#1248)
Consider ordering multiplication before division.

Additional information: link

LavaToken.addLiquidity(uint256,uint256) (#1316-1329) ignores return value by lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
Ensure that all the return values of the function calls are used.

Additional information: link

LavaToken.swapAndLiquify().maxTransferAmount (#1266) shadows:
- LavaToken.maxTransferAmount() (#1334-1336) (function)
Rename the local variables that shadow another component.

Additional information: link

Reentrancy in LavaToken.swapAndLiquify() (#1264-1294):
External calls:
- swapTokensForEth(half) (#1284)
- lavaRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1306-1312)
- addLiquidity(otherHalf,newBalance) (#1290)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1290)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1290)
- _allowances[owner][spender] = amount (#1113)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in LavaToken.swapAndLiquify() (#1264-1294):
External calls:
- swapTokensForEth(half) (#1284)
- lavaRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1306-1312)
- addLiquidity(otherHalf,newBalance) (#1290)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1290)
- lavaRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,operator(),block.timestamp) (#1321-1328)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1114)
- addLiquidity(otherHalf,newBalance) (#1290)
- SwapAndLiquify(half,newBalance,otherHalf) (#1292)
Apply the check-effects-interactions pattern.

Additional information: link

LavaToken.delegateBySig(address,uint256,uint256,uint8,bytes32,bytes32) (#1505-1546) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now <= expiry,LAVA::delegateBySig: signature expired) (#1544)
Avoid relying on block.timestamp.

Additional information: link

LavaToken.getChainId() (#1664-1668) uses assembly
- INLINE ASM (#1666)
Do not use evm assembly.

Additional information: link

LavaToken.antiWhale(address,address,uint256) (#1184-1195) compares to a boolean constant:
-_excludedFromAntiWhale[sender] == false && _excludedFromAntiWhale[recipient] == false (#1187-1188)
Remove the equality to the boolean constant.

Additional information: link

Different versions of Solidity is used:
- Version used: ['0.6.12', '>=0.4.0', '>=0.5.0', '>=0.6.0<0.8.0', '>=0.6.2', '>=0.6.2<0.8.0']
- >=0.5.0 (#5)
- >=0.5.0 (#25)
- >=0.6.2 (#80)
- >=0.6.2 (#178)
- >=0.6.2<0.8.0 (#224)
- >=0.6.0<0.8.0 (#414)
- >=0.4.0 (#629)
- >=0.6.0<0.8.0 (#728)
- >=0.6.0<0.8.0 (#753)
- >=0.4.0 (#821)
- 0.6.12 (#1135)
Use one Solidity version.

Additional information: link

SafeMath.trySub(uint256,uint256) (#446-449) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version>=0.4.0 (#821) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.functionDelegateCall(address,bytes,string) (#384-390):
- (success,returndata) = target.delegatecall(data) (#388)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable LavaToken._delegates (#1447) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#746)" inContext (#740-749)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#89) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#90)
Prevent variables from having similar names.

Additional information: link

LavaToken.slitherConstructorConstantVariables() (#1138-1670) uses literals with too many digits:
- BURN_ADDRESS = 0x000000000000000000000000000000000000dEaD (#1146)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

transferOperator(address) should be declared external:
- LavaToken.transferOperator(address) (#1434-1438)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token contract audit

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Token has a considerable age, but social accounts / website are missing or have few users

Token has a considerable age, but average PancakeSwap 30d trading volume is low

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank