$HOLD$ [HolidayDoge] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

HolidayDoge.swapBack() (#646-695) sends eth to arbitrary user
Dangerous calls:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in HolidayDoge._transferFrom(address,address,uint256) (#568-607):
External calls:
- swapBack() (#576)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#656-662)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
External calls sending eth:
- swapBack() (#576)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#584)
- _balances[recipient] = _balances[recipient].add(finalAmount) (#592)
- finalAmount = takeFee(sender,recipient,amount) (#591)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#621)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#242-254) ignores return value by RewardToken.transfer(shareholder,amount) (#248)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

HolidayDoge.swapBack().tmpSuccess (#677) is written in both
(tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
tmpSuccess = false (#681)
HolidayDoge.swapBack().tmpSuccess1 (#678) is written in both
(tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
tmpSuccess1 = false (#682)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ticker ($HOLD$) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

Reentrancy in DividendDistributor.distributeDividend(address) (#242-254):
External calls:
- RewardToken.transfer(shareholder,amount) (#248)
State variables written after the call(s):
- shares[shareholder].totalRealised = shares[shareholder].totalRealised.add(amount) (#250)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#251)
Reentrancy in DividendDistributor.process(uint256) (#213-235):
External calls:
- distributeDividend(shareholders[currentIndex]) (#227)
- RewardToken.transfer(shareholder,amount) (#248)
State variables written after the call(s):
- currentIndex ++ (#232)
Reentrancy in DividendDistributor.setShare(address,uint256) (#176-191):
External calls:
- distributeDividend(shareholder) (#179)
- RewardToken.transfer(shareholder,amount) (#248)
State variables written after the call(s):
- shares[shareholder].amount = amount (#189)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#190)
Apply the check-effects-interactions pattern.

Additional information: link

HolidayDoge.swapBack() (#646-695) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendDistributor.setDistributionCriteria(uint256,uint256) (#171-174) should emit an event for:
- minPeriod = newMinPeriod (#172)
- minDistribution = newMinDistribution (#173)
HolidayDoge.changeFees(uint256,uint256,uint256,uint256) (#525-533) should emit an event for:
- liquidityFee = newLiqFee (#526)
- rewardsFee = newRewardFee (#527)
- totalFee = liquidityFee.add(marketingFee).add(rewardsFee) (#531)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (#532)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#353) lacks a zero-check on :
- owner = adr (#354)
HolidayDoge.changeFeeReceivers(address,address,address).newLiquidityReceiver (#535) lacks a zero-check on :
- autoLiquidityReceiver = newLiquidityReceiver (#536)
HolidayDoge.changeFeeReceivers(address,address,address).newMarketingWallet (#535) lacks a zero-check on :
- marketingWallet = newMarketingWallet (#537)
HolidayDoge.changeFeeReceivers(address,address,address).newanothermarketingWallet (#535) lacks a zero-check on :
- anothermarketingWallet = newanothermarketingWallet (#538)
Check that the address is not zero.

Additional information: link

DividendDistributor.distributeDividend(address) (#242-254) has external calls inside a loop: RewardToken.transfer(shareholder,amount) (#248)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in HolidayDoge._transferFrom(address,address,uint256) (#568-607):
External calls:
- swapBack() (#576)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#656-662)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
External calls sending eth:
- swapBack() (#576)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
State variables written after the call(s):
- launch() (#580)
- launchedAt = block.number (#491)
Reentrancy in HolidayDoge.constructor() (#421-453):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#424)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = uint256(- 1) (#425)
- _balances[msg.sender] = _totalSupply (#451)
- anothermarketingWallet = 0xd186F2b8054Bba4C7222C94b5E01E4E7a34827f8 (#446)
- autoLiquidityReceiver = msg.sender (#444)
- dividendDistributor = new DividendDistributor(address(router)) (#427)
- isDividendExempt[pair] = true (#437)
- isDividendExempt[address(this)] = true (#439)
- isDividendExempt[DEAD] = true (#440)
- isDividendExempt[ZERO] = true (#441)
- isFeeExempt[msg.sender] = true (#429)
- isFeeExempt[address(this)] = true (#430)
- isFeeExempt[anothermarketingWallet] = true (#431)
- isTxLimitExempt[msg.sender] = true (#433)
- isTxLimitExempt[pair] = true (#434)
- isTxLimitExempt[DEAD] = true (#435)
- marketingWallet = msg.sender (#445)
- totalFee = liquidityFee.add(marketingFee).add(rewardsFee) (#448)
- totalFeeIfSelling = totalFee.add(extraFeeOnSell) (#449)
Reentrancy in DividendDistributor.deposit() (#193-211):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#201-206)
State variables written after the call(s):
- dividendsPerShare = dividendsPerShare.add(dividendsPerShareAccuracyFactor.mul(amount).div(totalShares)) (#210)
- totalDividends = totalDividends.add(amount) (#209)
Reentrancy in DividendDistributor.distributeDividend(address) (#242-254):
External calls:
- RewardToken.transfer(shareholder,amount) (#248)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#249)
Reentrancy in DividendDistributor.setShare(address,uint256) (#176-191):
External calls:
- distributeDividend(shareholder) (#179)
- RewardToken.transfer(shareholder,amount) (#248)
State variables written after the call(s):
- addShareholder(shareholder) (#183)
- shareholderIndexes[shareholder] = shareholders.length (#272)
- removeShareholder(shareholder) (#185)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#278)
- addShareholder(shareholder) (#183)
- shareholders.push(shareholder) (#273)
- removeShareholder(shareholder) (#185)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#277)
- shareholders.pop() (#279)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#188)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in HolidayDoge._transferFrom(address,address,uint256) (#568-607):
External calls:
- swapBack() (#576)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#656-662)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
- dividendDistributor.setShare(sender,_balances[sender]) (#596)
- dividendDistributor.setShare(recipient,_balances[recipient]) (#600)
- dividendDistributor.process(distributorGas) (#603)
External calls sending eth:
- swapBack() (#576)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
Event emitted after the call(s):
- Transfer(sender,recipient,finalAmount) (#605)
Reentrancy in HolidayDoge._transferFrom(address,address,uint256) (#568-607):
External calls:
- swapBack() (#576)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#656-662)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
External calls sending eth:
- swapBack() (#576)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#622)
- finalAmount = takeFee(sender,recipient,amount) (#591)
Reentrancy in HolidayDoge.constructor() (#421-453):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#424)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#452)
Reentrancy in HolidayDoge.swapBack() (#646-695):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#656-662)
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
External calls sending eth:
- dividendDistributor.deposit{value: amountBNBReflection}() (#672)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#685-692)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#693)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.shouldDistribute(address) (#237-240) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#238-239)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#213-235) has costly operations inside a loop:
- currentIndex = 0 (#224)
DividendDistributor.distributeDividend(address) (#242-254) has costly operations inside a loop:
- totalDistributed = totalDistributed.add(amount) (#247)
DividendDistributor.process(uint256) (#213-235) has costly operations inside a loop:
- currentIndex ++ (#232)
Use a local variable to hold the loop computation result.

Additional information: link

HolidayDoge._maxTxAmount (#376) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 1 / 100
HolidayDoge._walletMax (#377) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 8 / 100
HolidayDoge.swapThreshold (#413) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 5 / 2000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.7.4 (#11) allows old versions
solc-0.7.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in HolidayDoge.swapBack() (#646-695):
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: marketingShare}() (#677)
- (tmpSuccess1) = address(anothermarketingWallet).call{gas: 30000,value: anothermarketingShare}() (#678)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IDEXRouter.WETH() (#70) is not in mixedCase
Variable DividendDistributor._token (#127) is not in mixedCase
Variable DividendDistributor.RewardToken (#137) is not in mixedCase
Function HolidayDoge.Antibot(address) (#634-638) is not in mixedCase
Parameter HolidayDoge.Antibot(address)._user (#634) is not in mixedCase
Parameter HolidayDoge.removeFrombot(address)._user (#640) is not in mixedCase
Constant HolidayDoge._name (#366) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HolidayDoge._symbol (#367) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HolidayDoge._decimals (#368) is not in UPPER_CASE_WITH_UNDERSCORES
Variable HolidayDoge.DEAD (#370) is not in mixedCase
Variable HolidayDoge.ZERO (#371) is not in mixedCase
Variable HolidayDoge.RewardToken (#373) is not in mixedCase
Variable HolidayDoge._totalSupply (#375) is not in mixedCase
Variable HolidayDoge._maxTxAmount (#376) is not in mixedCase
Variable HolidayDoge._walletMax (#377) is not in mixedCase
Variable HolidayDoge._balances (#381) is not in mixedCase
Variable HolidayDoge._allowances (#382) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#75) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#76)
Prevent variables from having similar names.

Additional information: link

HolidayDoge.slitherConstructorVariables() (#362-700) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#370)
HolidayDoge.slitherConstructorVariables() (#362-700) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#371)
HolidayDoge.slitherConstructorVariables() (#362-700) uses literals with too many digits:
- _totalSupply = 100000000 * (10 ** _decimals) (#375)
HolidayDoge.slitherConstructorVariables() (#362-700) uses literals with too many digits:
- distributorGas = 300000 (#407)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

HolidayDoge.RewardToken (#373) is never used in HolidayDoge (#362-700)
Remove unused state variables.

Additional information: link

DividendDistributor.dividendsPerShareAccuracyFactor (#148) should be constant
DividendDistributor.routerAddress (#136) should be constant
HolidayDoge.DEAD (#370) should be constant
HolidayDoge.RewardToken (#373) should be constant
HolidayDoge.ZERO (#371) should be constant
HolidayDoge.routerAddress (#372) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#313-315)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#320-322)
renounceOwnership() should be declared external:
- Auth.renounceOwnership() (#345-348)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#353-357)
getCirculatingSupply() should be declared external:
- HolidayDoge.getCirculatingSupply() (#463-465)
claim() should be declared external:
- HolidayDoge.claim() (#481-484)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Contract has 12% buy tax and 14% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Swap operations require suspiciously high gas. Contract logic is complex and may disguise some form of scam.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death