DUNK [MiniNBA] Token

Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (contracts/interfaces/DividendPayingToken.sol#87-103):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (contracts/interfaces/DividendPayingToken.sol#92)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (contracts/interfaces/DividendPayingToken.sol#95)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

MiniNBA._transfer(address,address,uint256).iterations (contracts/MiniNBA.sol#339) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

MiniNBA.addLiquidity(uint256,uint256) (contracts/MiniNBA.sol#392-407) ignores return value by pancakeswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (contracts/MiniNBA.sol#398-405)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.constructor(string,string,uint8)._decimals (contracts/interfaces/DividendPayingToken.sol#44) shadows:
- BEP20._decimals (contracts/interfaces/BEP20.sol#43) (state variable)
Rename the local variables that shadow another component.

Additional information: link

MiniNBA.setSwapAt(uint256) (contracts/MiniNBA.sol#199-201) should emit an event for:
- swapTokensAtAmount = swapAmount (contracts/MiniNBA.sol#200)
Emit an event for critical parameter changes.

Additional information: link

Variable 'MiniNBA._transfer(address,address,uint256).claims (contracts/MiniNBA.sol#339)' in MiniNBA._transfer(address,address,uint256) (contracts/MiniNBA.sol#255-346) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (contracts/MiniNBA.sol#340)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in MiniNBA.swapAndLiquify(uint256) (contracts/MiniNBA.sol#348-369):
External calls:
- swapTokensForEth(half) (contracts/MiniNBA.sol#360)
- pancakeswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (contracts/MiniNBA.sol#382-388)
- addLiquidity(otherHalf,newBalance) (contracts/MiniNBA.sol#366)
- pancakeswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (contracts/MiniNBA.sol#398-405)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (contracts/MiniNBA.sol#366)
- pancakeswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (contracts/MiniNBA.sol#398-405)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (contracts/MiniNBA.sol#366)
- _allowances[owner][spender] = amount (contracts/interfaces/BEP20.sol#287)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MiniNBA.swapAndSendDividends(uint256) (contracts/MiniNBA.sol#409-417):
External calls:
- swapTokensForEth(tokens) (contracts/MiniNBA.sol#410)
- pancakeswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (contracts/MiniNBA.sol#382-388)
- (success) = address(dividendTracker).call{value: dividends}() (contracts/MiniNBA.sol#412)
External calls sending eth:
- (success) = address(dividendTracker).call{value: dividends}() (contracts/MiniNBA.sol#412)
Event emitted after the call(s):
- SendDividends(tokens,dividends) (contracts/MiniNBA.sol#415)
Apply the check-effects-interactions pattern.

Additional information: link

MiniNBADividendTracker.canAutoClaim(uint256) (contracts/MiniNBADividendTracker.sol#133-139) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (contracts/MiniNBADividendTracker.sol#134)
- block.timestamp.sub(lastClaimTime) >= claimWait (contracts/MiniNBADividendTracker.sol#138)
Avoid relying on block.timestamp.

Additional information: link

SafeMathInt.mul(int256,int256) (contracts/library/SafeMathInt.sol#15-22) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.0 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in DividendPayingToken._withdrawDividendOfUser(address) (contracts/interfaces/DividendPayingToken.sol#87-103):
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (contracts/interfaces/DividendPayingToken.sol#92)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IPancakeswapV2Router01.WETH() (contracts/interfaces/IPancakeswapV2Router01.sol#7) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IPancakeswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (contracts/interfaces/IPancakeswapV2Router01.sol#12) is too similar to IPancakeswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (contracts/interfaces/IPancakeswapV2Router01.sol#13)
Prevent variables from having similar names.

Additional information: link

MiniNBADividendTracker.getAccountAtIndex(uint256) (contracts/MiniNBADividendTracker.sol#114-131) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (contracts/MiniNBADividendTracker.sol#125)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (contracts/library/SafeMathInt.sol#10) is never used in SafeMathInt (contracts/library/SafeMathInt.sol#8-67)
Remove unused state variables.

Additional information: link

MiniNBA.teamWallet (contracts/MiniNBA.sol#20) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (contracts/library/IterableMapping.sol#30-32)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death