DFNX [Definex Finance Ecosystem] Token

DefinexFinance.swapBack() (#1155-1199) sends eth to arbitrary user
Dangerous calls:
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in DefinexFinance._transfer(address,address,uint256) (#1051-1118):
External calls:
- swapBack() (#1077)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
External calls sending eth:
- swapBack() (#1077)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1111)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#368)
- _balances[recipient] = _balances[recipient].add(amount) (#369)
- super._transfer(from,to,amount) (#1117)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#368)
- _balances[recipient] = _balances[recipient].add(amount) (#369)
- swapping = false (#1079)
- tokensForBuyBack += fees * sellBuyBackFee / sellTotalFees (#1099)
- tokensForBuyBack += fees * buyBuyBackFee / buyTotalFees (#1107)
- tokensForDev += fees * sellDevFee / sellTotalFees (#1097)
- tokensForDev += fees * buyDevFee / buyTotalFees (#1105)
- tokensForLiquidity += fees * sellLiquidityFee / sellTotalFees (#1096)
- tokensForLiquidity += fees * buyLiquidityFee / buyTotalFees (#1104)
- tokensForMarketing += fees * sellMarketingFee / sellTotalFees (#1098)
- tokensForMarketing += fees * buyMarketingFee / buyTotalFees (#1106)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

DefinexFinance.swapBack().success (#1164) is written in both
(success,None) = address(devWallet).call{value: ethForDev}() (#1189)
(success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-tokensForLiquidity += fees * sellLiquidityFee / sellTotalFees (#1096)
-fees = amount.mul(buyTotalFees).div(100) (#1103)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-fees = amount.mul(buyTotalFees).div(100) (#1103)
-tokensForLiquidity += fees * buyLiquidityFee / buyTotalFees (#1104)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-tokensForDev += fees * sellDevFee / sellTotalFees (#1097)
-fees = amount.mul(buyTotalFees).div(100) (#1103)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-fees = amount.mul(buyTotalFees).div(100) (#1103)
-tokensForDev += fees * buyDevFee / buyTotalFees (#1105)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-tokensForMarketing += fees * sellMarketingFee / sellTotalFees (#1098)
-fees = amount.mul(buyTotalFees).div(100) (#1103)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-fees = amount.mul(buyTotalFees).div(100) (#1103)
-tokensForMarketing += fees * buyMarketingFee / buyTotalFees (#1106)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-tokensForBuyBack += fees * sellBuyBackFee / sellTotalFees (#1099)
-fees = amount.mul(buyTotalFees).div(100) (#1103)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) performs a multiplication on the result of a division:
-fees = amount.mul(buyTotalFees).div(100) (#1103)
-tokensForBuyBack += fees * buyBuyBackFee / buyTotalFees (#1107)
Consider ordering multiplication before division.

Additional information: link

Reentrancy in DefinexFinance.swapBack() (#1155-1199):
External calls:
- swapTokensForEth(amountToSwapForETH) (#1174)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
State variables written after the call(s):
- tokensForBuyBack = 0 (#1187)
- tokensForDev = 0 (#1186)
- tokensForLiquidity = 0 (#1184)
- tokensForMarketing = 0 (#1185)
Apply the check-effects-interactions pattern.

Additional information: link

DefinexFinance.addLiquidity(uint256,uint256) (#1140-1153) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
Ensure that all the return values of the function calls are used.

Additional information: link

DefinexFinance.constructor().totalSupply (#930) shadows:
- ERC20.totalSupply() (#242-244) (function)
- IERC20.totalSupply() (#92) (function)
Rename the local variables that shadow another component.

Additional information: link

DefinexFinance.updateSwapTokensAtAmount(uint256) (#985-989) should emit an event for:
- swapTokensAtAmount = newAmount (#987)
DefinexFinance.updateBuyFees(uint256,uint256,uint256,uint256) (#996-1003) should emit an event for:
- buyMarketingFee = _marketingFee (#997)
- buyLiquidityFee = _liquidityFee (#998)
- buyDevFee = _devFee (#999)
- buyBuyBackFee = _buyBackFee (#1000)
- buyTotalFees = buyMarketingFee + buyLiquidityFee + buyDevFee + buyBuyBackFee (#1001)
DefinexFinance.updateSellFees(uint256,uint256,uint256,uint256) (#1005-1012) should emit an event for:
- sellMarketingFee = _marketingFee (#1006)
- sellLiquidityFee = _liquidityFee (#1007)
- sellDevFee = _devFee (#1008)
- sellBuyBackFee = _buyBackFee (#1009)
- sellTotalFees = sellMarketingFee + sellLiquidityFee + sellDevFee + sellBuyBackFee (#1010)
Emit an event for critical parameter changes.

Additional information: link

DefinexFinance.updateMarketingWallet(address).newMarketingWallet (#1031) lacks a zero-check on :
- marketingWallet = newMarketingWallet (#1033)
DefinexFinance.updateDevWallet(address).newWallet (#1036) lacks a zero-check on :
- devWallet = newWallet (#1038)
DefinexFinance.updateBuyBackWallet(address).newWallet (#1041) lacks a zero-check on :
- buyBackWallet = newWallet (#1043)
Check that the address is not zero.

Additional information: link

DefinexFinance.swapTokensForEth(uint256) (#1120-1138) has external calls inside a loop: path[1] = uniswapV2Router.WETH() (#1125)
DefinexFinance.swapTokensForEth(uint256) (#1120-1138) has external calls inside a loop: uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
DefinexFinance.swapBack() (#1155-1199) has external calls inside a loop: (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
DefinexFinance.swapBack() (#1155-1199) has external calls inside a loop: (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
DefinexFinance.addLiquidity(uint256,uint256) (#1140-1153) has external calls inside a loop: uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
DefinexFinance.swapBack() (#1155-1199) has external calls inside a loop: (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in DefinexFinance.constructor() (#920-960):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#927)
State variables written after the call(s):
- _mint(msg.sender,totalSupply) (#959)
- _balances[account] = _balances[account].add(amount) (#388)
- excludeFromFees(owner(),true) (#951)
- _isExcludedFromFees[account] = excluded (#1015)
- excludeFromFees(address(this),true) (#952)
- _isExcludedFromFees[account] = excluded (#1015)
- excludeFromFees(address(0xdead),true) (#953)
- _isExcludedFromFees[account] = excluded (#1015)
- _mint(msg.sender,totalSupply) (#959)
- _totalSupply = _totalSupply.add(amount) (#387)
- _setAutomatedMarketMakerPair(address(uniswapV2Pair),true) (#928)
- automatedMarketMakerPairs[pair] = value (#1026)
- buyBackWallet = address(owner()) (#948)
- buyBuyBackFee = 1 (#937)
- buyDevFee = 1 (#936)
- buyLiquidityFee = 1 (#935)
- buyMarketingFee = 2 (#934)
- buyTotalFees = buyMarketingFee + buyLiquidityFee + buyDevFee + buyBuyBackFee (#938)
- devWallet = address(owner()) (#947)
- marketingWallet = address(owner()) (#946)
- sellBuyBackFee = 2 (#943)
- sellDevFee = 2 (#942)
- sellLiquidityFee = 2 (#941)
- sellMarketingFee = 4 (#940)
- sellTotalFees = sellMarketingFee + sellLiquidityFee + sellDevFee + sellBuyBackFee (#944)
- swapTokensAtAmount = totalSupply * 1 / 1000 (#932)
Reentrancy in DefinexFinance.swapBack() (#1155-1199):
External calls:
- swapTokensForEth(amountToSwapForETH) (#1174)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
External calls sending eth:
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
State variables written after the call(s):
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- _allowances[owner][spender] = amount (#434)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in DefinexFinance._transfer(address,address,uint256) (#1051-1118):
External calls:
- swapBack() (#1077)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
External calls sending eth:
- swapBack() (#1077)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#370)
- super._transfer(from,address(this),fees) (#1111)
- Transfer(sender,recipient,amount) (#370)
- super._transfer(from,to,amount) (#1117)
Reentrancy in DefinexFinance.constructor() (#920-960):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#927)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1016)
- excludeFromFees(address(0xdead),true) (#953)
- ExcludeFromFees(account,excluded) (#1016)
- excludeFromFees(address(this),true) (#952)
- ExcludeFromFees(account,excluded) (#1016)
- excludeFromFees(owner(),true) (#951)
- SetAutomatedMarketMakerPair(pair,value) (#1028)
- _setAutomatedMarketMakerPair(address(uniswapV2Pair),true) (#928)
- Transfer(address(0),account,amount) (#389)
- _mint(msg.sender,totalSupply) (#959)
Reentrancy in DefinexFinance.swapBack() (#1155-1199):
External calls:
- swapTokensForEth(amountToSwapForETH) (#1174)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1130-1136)
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
External calls sending eth:
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,deadAddress,block.timestamp) (#1145-1152)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#435)
- addLiquidity(liquidityTokens,ethForLiquidity) (#1193)
- SwapAndLiquify(amountToSwapForETH,ethForLiquidity,tokensForLiquidity) (#1194)
Apply the check-effects-interactions pattern.

Additional information: link

DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- swapping = true (#1075)
DefinexFinance.swapBack() (#1155-1199) has costly operations inside a loop:
- tokensForLiquidity = 0 (#1184)
DefinexFinance.swapBack() (#1155-1199) has costly operations inside a loop:
- tokensForMarketing = 0 (#1185)
DefinexFinance.swapBack() (#1155-1199) has costly operations inside a loop:
- tokensForDev = 0 (#1186)
DefinexFinance.swapBack() (#1155-1199) has costly operations inside a loop:
- tokensForBuyBack = 0 (#1187)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- swapping = false (#1079)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForLiquidity += fees * sellLiquidityFee / sellTotalFees (#1096)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForDev += fees * sellDevFee / sellTotalFees (#1097)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForMarketing += fees * sellMarketingFee / sellTotalFees (#1098)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForBuyBack += fees * sellBuyBackFee / sellTotalFees (#1099)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForLiquidity += fees * buyLiquidityFee / buyTotalFees (#1104)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForDev += fees * buyDevFee / buyTotalFees (#1105)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForMarketing += fees * buyMarketingFee / buyTotalFees (#1106)
DefinexFinance._transfer(address,address,uint256) (#1051-1118) has costly operations inside a loop:
- tokensForBuyBack += fees * buyBuyBackFee / buyTotalFees (#1107)
Use a local variable to hold the loop computation result.

Additional information: link

Context._msgData() (#15-18) is never used and should be removed
ERC20._burn(address,uint256) (#403-411) is never used and should be removed
SafeMath.mod(uint256,uint256) (#580-582) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#596-599) is never used and should be removed
SafeMathInt.abs(int256) (#704-707) is never used and should be removed
SafeMathInt.add(int256,int256) (#695-699) is never used and should be removed
SafeMathInt.div(int256,int256) (#675-681) is never used and should be removed
SafeMathInt.mul(int256,int256) (#663-670) is never used and should be removed
SafeMathInt.sub(int256,int256) (#686-690) is never used and should be removed
SafeMathInt.toUint256Safe(int256) (#710-713) is never used and should be removed
SafeMathUint.toInt256Safe(uint256) (#717-721) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version0.8.9 (#8) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in DefinexFinance.swapBack() (#1155-1199):
- (success,None) = address(devWallet).call{value: ethForDev}() (#1189)
- (success,None) = address(buyBackWallet).call{value: ethForBuyBack}() (#1190)
- (success,None) = address(marketingWallet).call{value: address(this).balance}() (#1197)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#36) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#37) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#54) is not in mixedCase
Function IUniswapV2Router01.WETH() (#727) is not in mixedCase
Event DefinexFinancemarketingWalletUpdated(address,address) (#908) is not in CapWords
Event DefinexFinancedevWalletUpdated(address,address) (#910) is not in CapWords
Event DefinexFinancebuyBackWalletUpdated(address,address) (#912) is not in CapWords
Parameter DefinexFinance.updateBuyFees(uint256,uint256,uint256,uint256)._marketingFee (#996) is not in mixedCase
Parameter DefinexFinance.updateBuyFees(uint256,uint256,uint256,uint256)._liquidityFee (#996) is not in mixedCase
Parameter DefinexFinance.updateBuyFees(uint256,uint256,uint256,uint256)._devFee (#996) is not in mixedCase
Parameter DefinexFinance.updateBuyFees(uint256,uint256,uint256,uint256)._buyBackFee (#996) is not in mixedCase
Parameter DefinexFinance.updateSellFees(uint256,uint256,uint256,uint256)._marketingFee (#1005) is not in mixedCase
Parameter DefinexFinance.updateSellFees(uint256,uint256,uint256,uint256)._liquidityFee (#1005) is not in mixedCase
Parameter DefinexFinance.updateSellFees(uint256,uint256,uint256,uint256)._devFee (#1005) is not in mixedCase
Parameter DefinexFinance.updateSellFees(uint256,uint256,uint256,uint256)._buyBackFee (#1005) is not in mixedCase
Constant DefinexFinance.deadAddress (#865) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#16)" inContext (#10-19)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#732) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#733)
Prevent variables from having similar names.

Additional information: link

DefinexFinance.updateSwapTokensAtAmount(uint256) (#985-989) uses literals with too many digits:
- require(bool,string)(newAmount >= totalSupply() * 1 / 100000,Swap amount cannot be lower than 0.001% total supply.) (#986)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#658) is never used in SafeMathInt (#656-714)
Remove unused state variables.

Additional information: link

name() should be declared external:
- ERC20.name() (#210-212)
symbol() should be declared external:
- ERC20.symbol() (#218-220)
decimals() should be declared external:
- ERC20.decimals() (#235-237)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#261-264)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#269-271)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#280-283)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#298-306)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#320-323)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#339-342)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#638-641)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#647-651)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token contract audit

Unable to find KYC or doxxing proof

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death