Cate [CateNftify] Token

CateNftify.claimStuckTokens(address) (#727-736) ignores return value by ERC20token.transfer(msg.sender,balance) (#735)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

CateNftify.sendBNB(address,uint256) (#742-753) sends eth to arbitrary user
Dangerous calls:
- (success) = recipient.call{value: amount}() (#748)
CateNftify.swapAndLiquify(uint256) (#932-962) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in CateNftify._transfer(address,address,uint256) (#855-929):
External calls:
- swapAndLiquify(liquidityTokens) (#887)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(half,0,path,address(this),block.timestamp) (#942-948)
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
- swapAndSendMarketing(marketingTokens) (#893)
- (success) = recipient.call{value: amount}() (#748)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#971-977)
External calls sending eth:
- swapAndLiquify(liquidityTokens) (#887)
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
- swapAndSendMarketing(marketingTokens) (#893)
- (success) = recipient.call{value: amount}() (#748)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#924)
- _balances[sender] = senderBalance - amount (#234)
- _balances[recipient] += amount (#236)
- super._transfer(from,to,amount) (#928)
- _balances[sender] = senderBalance - amount (#234)
- _balances[recipient] += amount (#236)
- swapping = false (#897)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

CateNftify.swapAndLiquify(uint256) (#932-962) ignores return value by uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
Ensure that all the return values of the function calls are used.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#81-84)
name() should be declared external:
- ERC20.name() (#111-113)
symbol() should be declared external:
- ERC20.symbol() (#115-117)
decimals() should be declared external:
- ERC20.decimals() (#119-121)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#137-145)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#147-155)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#157-165)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#167-186)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#188-199)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#201-216)
openTrade() should be declared external:
- CateNftify.openTrade() (#722-725)
isExcludedFromFees(address) should be declared external:
- CateNftify.isExcludedFromFees(address) (#800-802)
Use the external attribute for functions never called from the contract.

Additional information: link

CateNftify.setSwapTokensAtAmount(uint256) (#986-992) should emit an event for:
- swapTokensAtAmount = newAmount (#991)
Emit an event for critical parameter changes.

Additional information: link

CateNftify.updateUniswapV2Router(address)._uniswapV2Pair (#762-763) lacks a zero-check on :
- uniswapV2Pair = _uniswapV2Pair (#764)
CateNftify.changeOperatorWallet(address)._operatorWWallet (#848) lacks a zero-check on :
- operator = _operatorWWallet (#852)
Check that the address is not zero.

Additional information: link

Reentrancy in CateNftify.constructor(address) (#682-705):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#689-690)
State variables written after the call(s):
- _approve(address(this),address(uniswapV2Router),type()(uint256).max) (#695)
- _allowances[owner][spender] = amount (#280)
- _mint(owner(),100_000_000 * (10 ** 18)) (#703)
- _balances[account] += amount (#249)
- _isExcludedFromFees[owner()] = true (#699)
- _isExcludedFromFees[DEAD] = true (#700)
- _isExcludedFromFees[address(this)] = true (#701)
- _mint(owner(),100_000_000 * (10 ** 18)) (#703)
- _totalSupply += amount (#248)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#697)
- automatedMarketMakerPairs[pair] = value (#784)
- swapTokensAtAmount = totalSupply() / 5000 (#704)
- uniswapV2Pair = _uniswapV2Pair (#693)
- uniswapV2Router = _uniswapV2Router (#692)
Reentrancy in CateNftify.updateUniswapV2Router(address) (#755-765):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(uniswapV2Router.factory()).createPair(address(this),uniswapV2Router.WETH()) (#762-763)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#764)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in CateNftify._transfer(address,address,uint256) (#855-929):
External calls:
- swapAndLiquify(liquidityTokens) (#887)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(half,0,path,address(this),block.timestamp) (#942-948)
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
- swapAndSendMarketing(marketingTokens) (#893)
- (success) = recipient.call{value: amount}() (#748)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#971-977)
External calls sending eth:
- swapAndLiquify(liquidityTokens) (#887)
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
- swapAndSendMarketing(marketingTokens) (#893)
- (success) = recipient.call{value: amount}() (#748)
Event emitted after the call(s):
- SwapAndSendMarketing(tokenAmount,newBalance) (#983)
- swapAndSendMarketing(marketingTokens) (#893)
- Transfer(sender,recipient,amount) (#238)
- super._transfer(from,to,amount) (#928)
- Transfer(sender,recipient,amount) (#238)
- super._transfer(from,address(this),fees) (#924)
Reentrancy in CateNftify.constructor(address) (#682-705):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#689-690)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#281)
- _approve(address(this),address(uniswapV2Router),type()(uint256).max) (#695)
- SetAutomatedMarketMakerPair(pair,value) (#786)
- _setAutomatedMarketMakerPair(_uniswapV2Pair,true) (#697)
- Transfer(address(0),account,amount) (#250)
- _mint(owner(),100_000_000 * (10 ** 18)) (#703)
Reentrancy in CateNftify.swapAndLiquify(uint256) (#932-962):
External calls:
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(half,0,path,address(this),block.timestamp) (#942-948)
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
External calls sending eth:
- uniswapV2Router.addLiquidityETH{value: newBalance}(address(this),otherHalf,0,0,DEAD,block.timestamp) (#952-959)
Event emitted after the call(s):
- SwapAndLiquify(half,newBalance,otherHalf) (#961)
Reentrancy in CateNftify.swapAndSendMarketing(uint256) (#964-984):
External calls:
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#971-977)
- sendBNB(address(marketingWallet),newBalance) (#981)
- (success) = recipient.call{value: amount}() (#748)
External calls sending eth:
- sendBNB(address(marketingWallet),newBalance) (#981)
- (success) = recipient.call{value: amount}() (#748)
Event emitted after the call(s):
- SwapAndSendMarketing(tokenAmount,newBalance) (#983)
Apply the check-effects-interactions pattern.

Additional information: link

CateNftify.openTrade() (#722-725) compares to a boolean constant:
-require(bool,string)(isTradingEnabled == false,Trading is already open!) (#723)
Remove the equality to the boolean constant.

Additional information: link

Context._msgData() (#52-55) is never used and should be removed
ERC20._burn(address,uint256) (#255-270) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version0.8.16 (#7) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.16 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in CateNftify.sendBNB(address,uint256) (#742-753):
- (success) = recipient.call{value: amount}() (#748)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#356) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#358) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#389) is not in mixedCase
Function IUniswapV2Router01.WETH() (#433) is not in mixedCase
Parameter CateNftify.updateBuyFees(uint256,uint256)._liquidityFeeOnBuy (#805) is not in mixedCase
Parameter CateNftify.updateBuyFees(uint256,uint256)._marketingFeeOnBuy (#806) is not in mixedCase
Parameter CateNftify.updateSellFees(uint256,uint256)._liquidityFeeOnSell (#819) is not in mixedCase
Parameter CateNftify.updateSellFees(uint256,uint256)._marketingFeeOnSell (#820) is not in mixedCase
Parameter CateNftify.changeMarketingWallet(address)._marketingWallet (#832) is not in mixedCase
Parameter CateNftify.changeOperatorWallet(address)._operatorWWallet (#848) is not in mixedCase
Variable CateNftify.DEAD (#651) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#53)" inContext (#47-56)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#438) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#439)
Prevent variables from having similar names.

Additional information: link

CateNftify.setSwapTokensAtAmount(uint256) (#986-992) uses literals with too many digits:
- require(bool,string)(newAmount > totalSupply() / 100000,SwapTokensAtAmount must be greater than 0.001% of total supply) (#987-990)
CateNftify.slitherConstructorVariables() (#636-994) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#651)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

CateNftify.DEAD (#651) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to find KYC or doxxing proof

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank