Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
BinanceCat.addLiquidity(uint256,uint256) (#1709-1724) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
BinanceCat.Sweep(address) (#1745-1748) sends eth to arbitrary user
Dangerous calls:
- address(_to).transfer(balance) (#1747)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in BinanceCat._transfer(address,address,uint256) (#1546-1618):
External calls:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1600)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#853)
- _balances[recipient] = _balances[recipient].add(amount) (#854)
- super._transfer(from,to,amount) (#1603)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#853)
- _balances[recipient] = _balances[recipient].add(amount) (#854)
- launchCheck(from,to) (#1596)
- _isBlacklisted[recipient] = true (#1540)
- _isBlacklisted[sender] = true (#1542)
- swapping = false (#1579)
Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#1067-1083):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1072)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#1075)
Apply the check-effects-interactions pattern.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
SafeMathInt.MAX_INT256 (#211) is never used in SafeMathInt (#209-267)
Remove unused state variables.
Additional information: link
BinanceCat._total (#1178) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
Reentrancy in BinanceCat.updateDividendTracker(address) (#1317-1332):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1324)
- newDividendTracker.excludeFromDividends(address(this)) (#1325)
- newDividendTracker.excludeFromDividends(owner()) (#1326)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1327)
State variables written after the call(s):
- dividendTracker = newDividendTracker (#1331)
Apply the check-effects-interactions pattern.
Additional information: link
BinanceCat._transfer(address,address,uint256).iterations (#1611) is a local variable never initialized
BinanceCat._transfer(address,address,uint256).claims (#1611) is a local variable never initialized
BinanceCat._transfer(address,address,uint256).lastProcessedIndex (#1611) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
Additional information: link
BinanceCat.claim() (#1513-1515) ignores return value by dividendTracker.processAccount(msg.sender,false) (#1514)
BinanceCat._transfer(address,address,uint256) (#1546-1618) ignores return value by dividendTracker.process(gas) (#1611-1616)
BinanceCat.addLiquidity(uint256,uint256) (#1709-1724) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
Ensure that all the return values of the function calls are used.
Additional information: link
DividendPayingToken.constructor(string,string)._name (#1024) shadows:
- ERC20._name (#675) (state variable)
DividendPayingToken.constructor(string,string)._symbol (#1024) shadows:
- ERC20._symbol (#676) (state variable)
Rename the local variables that shadow another component.
Additional information: link
BinanceCat.setETHRewardsFee(uint256) (#1334-1337) should emit an event for:
- totalFees = ETHRewardsFee.add(buyBackFee).add(marketFee).add(liquidityFee) (#1336)
BinanceCat.setBuyBackFee(uint256) (#1339-1342) should emit an event for:
- totalFees = ETHRewardsFee.add(buyBackFee).add(marketFee).add(liquidityFee) (#1341)
BinanceCat.setMarketFee(uint256) (#1344-1347) should emit an event for:
- marketFee = value (#1345)
- totalFees = ETHRewardsFee.add(buyBackFee).add(marketFee).add(liquidityFee) (#1346)
BinanceCat.setLiquidityFee(uint256) (#1349-1352) should emit an event for:
- liquidityFee = value (#1350)
- totalFees = ETHRewardsFee.add(buyBackFee).add(marketFee).add(liquidityFee) (#1351)
BinanceCat.setSwapTokensAtAmount(uint256) (#1370-1372) should emit an event for:
- swapTokensAtAmount = value (#1371)
BinanceCat.setLaunchedAt(uint256) (#1382-1384) should emit an event for:
- launchedAt = value (#1383)
Emit an event for critical parameter changes.
Additional information: link
BinanceCat.setMarketWallet(address).wallet (#1354) lacks a zero-check on :
- _marketWallet = wallet (#1355)
BinanceCat.updateUniswapV2Router(address)._uniswapV2Pair (#1398-1399) lacks a zero-check on :
- uniswapV2Pair = _uniswapV2Pair (#1400)
BinanceCat.Sweep(address)._to (#1745) lacks a zero-check on :
- address(_to).transfer(balance) (#1747)
Check that the address is not zero.
Additional information: link
DividendPayingToken._withdrawDividendOfUser(address) (#1067-1083) has external calls inside a loop: (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1072)
Favor pull over push strategy for external calls.
Additional information: link
Variable 'BinanceCat._transfer(address,address,uint256).claims (#1611)' in BinanceCat._transfer(address,address,uint256) (#1546-1618) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1612)
Variable 'BinanceCat._transfer(address,address,uint256).iterations (#1611)' in BinanceCat._transfer(address,address,uint256) (#1546-1618) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1612)
Variable 'BinanceCat._transfer(address,address,uint256).lastProcessedIndex (#1611)' in BinanceCat._transfer(address,address,uint256) (#1546-1618) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1612)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.
Additional information: link
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
State variables written after the call(s):
- swapAndLiquify(liquidityTokens) (#1653)
- _allowances[owner][spender] = amount (#919)
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndSendDividends(sellTokens) (#1659)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- swapAndSendDividends(sellTokens) (#1659)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
State variables written after the call(s):
- swapAndSendDividends(sellTokens) (#1659)
- _allowances[owner][spender] = amount (#919)
Reentrancy in BinanceCat._transfer(address,address,uint256) (#1546-1618):
External calls:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
State variables written after the call(s):
- launch() (#1590)
- launchedAt = block.number (#1530)
- launch() (#1590)
- launchedAtTime = block.timestamp (#1531)
Reentrancy in BinanceCat.constructor() (#1257-1311):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1280-1281)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#1284)
- uniswapV2Router = _uniswapV2Router (#1283)
Reentrancy in BinanceCat.constructor() (#1257-1311):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1280-1281)
- _setAutomatedMarketMBinanceCaterPair(_uniswapV2Pair,true) (#1286)
- dividendTracker.excludeFromDividends(pair) (#1437)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1289)
- dividendTracker.excludeFromDividends(address(this)) (#1290)
- dividendTracker.excludeFromDividends(owner()) (#1291)
- dividendTracker.excludeFromDividends(address(_uniswapV2Router)) (#1292)
State variables written after the call(s):
- _mint(owner(),_total) (#1310)
- _balances[account] = _balances[account].add(amount) (#873)
- excludeFromFees(liquidityWallet,true) (#1295)
- _isExcludedFromFees[account] = excluded (#1405)
- excludeFromFees(address(this),true) (#1296)
- _isExcludedFromFees[account] = excluded (#1405)
- excludeFromFees(address(_marketWallet),true) (#1297)
- _isExcludedFromFees[account] = excluded (#1405)
- _managerMap[msg.sender] = true (#1307)
- _marketWallet = msg.sender (#1308)
- _mint(owner(),_total) (#1310)
- _totalSupply = _totalSupply.add(amount) (#872)
- canTransferBeforeTradingIsEnabled[owner()] = true (#1300)
Reentrancy in BinanceCatDividendTracker.processAccount(address,bool) (#1950-1960):
External calls:
- amount = _withdrawDividendOfUser(account) (#1951)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1072)
State variables written after the call(s):
- lastClaimTimes[account] = block.timestamp (#1954)
Reentrancy in BinanceCat.swapAndLiquify(uint256) (#1662-1686):
External calls:
- swapTokensForEth(half) (#1677)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- addLiquidity(otherHalf,newBalance) (#1683)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1683)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1683)
- _allowances[owner][spender] = amount (#919)
Reentrancy in BinanceCat.updateUniswapV2Router(address) (#1394-1401):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(uniswapV2Router.factory()).createPair(address(this),uniswapV2Router.WETH()) (#1398-1399)
State variables written after the call(s):
- uniswapV2Pair = _uniswapV2Pair (#1400)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in BinanceCat._setAutomatedMarketMBinanceCaterPair(address,bool) (#1432-1441):
External calls:
- dividendTracker.excludeFromDividends(pair) (#1437)
Event emitted after the call(s):
- SetAutomatedMarketMBinanceCaterPair(pair,value) (#1440)
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#920)
- swapAndLiquify(liquidityTokens) (#1653)
- SwapAndLiquify(half,newBalance,otherHalf) (#1685)
- swapAndLiquify(liquidityTokens) (#1653)
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- swapAndSendDividends(sellTokens) (#1659)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- swapAndSendDividends(sellTokens) (#1659)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#920)
- swapAndSendDividends(sellTokens) (#1659)
- SendDividends(tokens,dividends) (#1735)
- swapAndSendDividends(sellTokens) (#1659)
Reentrancy in BinanceCat._transfer(address,address,uint256) (#1546-1618):
External calls:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#855)
- super._transfer(from,to,amount) (#1603)
- Transfer(sender,recipient,amount) (#855)
- super._transfer(from,address(this),fees) (#1600)
Reentrancy in BinanceCat._transfer(address,address,uint256) (#1546-1618):
External calls:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- dividendTracker.setBalance(address(from),balanceOf(from)) (#1605)
- dividendTracker.setBalance(address(to),balanceOf(to)) (#1606)
- dividendTracker.process(gas) (#1611-1616)
External calls sending eth:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1612)
Reentrancy in BinanceCat.constructor() (#1257-1311):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1280-1281)
- _setAutomatedMarketMBinanceCaterPair(_uniswapV2Pair,true) (#1286)
- dividendTracker.excludeFromDividends(pair) (#1437)
Event emitted after the call(s):
- SetAutomatedMarketMBinanceCaterPair(pair,value) (#1440)
- _setAutomatedMarketMBinanceCaterPair(_uniswapV2Pair,true) (#1286)
Reentrancy in BinanceCat.constructor() (#1257-1311):
External calls:
- _uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#1280-1281)
- _setAutomatedMarketMBinanceCaterPair(_uniswapV2Pair,true) (#1286)
- dividendTracker.excludeFromDividends(pair) (#1437)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1289)
- dividendTracker.excludeFromDividends(address(this)) (#1290)
- dividendTracker.excludeFromDividends(owner()) (#1291)
- dividendTracker.excludeFromDividends(address(_uniswapV2Router)) (#1292)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1407)
- excludeFromFees(liquidityWallet,true) (#1295)
- ExcludeFromFees(account,excluded) (#1407)
- excludeFromFees(address(_marketWallet),true) (#1297)
- ExcludeFromFees(account,excluded) (#1407)
- excludeFromFees(address(this),true) (#1296)
- Transfer(address(0x641EC142E67ab213539815f67e4276975c2f8D50),account,amount) (#874)
- _mint(owner(),_total) (#1310)
Reentrancy in BinanceCatDividendTracker.processAccount(address,bool) (#1950-1960):
External calls:
- amount = _withdrawDividendOfUser(account) (#1951)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1072)
Event emitted after the call(s):
- Claim(account,amount,automatic) (#1955)
Reentrancy in BinanceCat.processDividendTracker(uint256) (#1508-1511):
External calls:
- (iterations,claims,lastProcessedIndex) = dividendTracker.process(gas) (#1509)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,false,gas,tx.origin) (#1510)
Reentrancy in BinanceCat.swapAndLiquify(uint256) (#1662-1686):
External calls:
- swapTokensForEth(half) (#1677)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- addLiquidity(otherHalf,newBalance) (#1683)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1683)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#920)
- addLiquidity(otherHalf,newBalance) (#1683)
- SwapAndLiquify(half,newBalance,otherHalf) (#1685)
Reentrancy in BinanceCat.swapAndSendDividends(uint256) (#1726-1737):
External calls:
- swapTokensForEth(tokens) (#1730)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1699-1705)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
External calls sending eth:
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
Event emitted after the call(s):
- SendDividends(tokens,dividends) (#1735)
Reentrancy in BinanceCat.updateDividendTracker(address) (#1317-1332):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1324)
- newDividendTracker.excludeFromDividends(address(this)) (#1325)
- newDividendTracker.excludeFromDividends(owner()) (#1326)
- newDividendTracker.excludeFromDividends(address(uniswapV2Router)) (#1327)
Event emitted after the call(s):
- UpdateDividendTracker(newAddress,address(dividendTracker)) (#1329)
Apply the check-effects-interactions pattern.
Additional information: link
Ownable.unlock() (#566-571) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(now > _lockTime,Contract is locked until 7 days) (#568)
BinanceCatDividendTracker.getAccount(address) (#1814-1857) uses timestamp for comparisons
Dangerous comparisons:
- nextClaimTime > block.timestamp (#1854-1856)
BinanceCatDividendTracker.canAutoClaim(uint256) (#1878-1884) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#1879)
- block.timestamp.sub(lastClaimTime) >= claimWait (#1883)
Avoid relying on block.timestamp.
Additional information: link
Context._msgData() (#486-489) is never used and should be removed
DividendPayingToken._transfer(address,address,uint256) (#1123-1129) is never used and should be removed
SafeMath.mod(uint256,uint256) (#187-189) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#203-206) is never used and should be removed
SafeMathInt.abs(int256) (#257-260) is never used and should be removed
SafeMathInt.div(int256,int256) (#228-234) is never used and should be removed
SafeMathInt.mul(int256,int256) (#216-223) is never used and should be removed
Remove unused functions.
Additional information: link
BinanceCat.maxSellTransactionAmount (#1182) is set pre-construction with a non-constant function or state variable:
- _total
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Pragma version^0.6.2 (#3) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Low level call in DividendPayingToken._withdrawDividendOfUser(address) (#1067-1083):
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1072)
Low level call in BinanceCat.swapAndSendDividends(uint256) (#1726-1737):
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#308) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#309) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#326) is not in mixedCase
Function IUniswapV2Router01.WETH() (#346) is not in mixedCase
Parameter DividendPayingToken.dividendOf(address)._owner (#1089) is not in mixedCase
Parameter DividendPayingToken.withdrawableDividendOf(address)._owner (#1096) is not in mixedCase
Parameter DividendPayingToken.withdrawnDividendOf(address)._owner (#1103) is not in mixedCase
Parameter DividendPayingToken.accumulativeDividendOf(address)._owner (#1113) is not in mixedCase
Constant DividendPayingToken.magnitude (#1004) is not in UPPER_CASE_WITH_UNDERSCORES
Parameter BinanceCat.transferForeignToken(address,address)._token (#1739) is not in mixedCase
Parameter BinanceCat.transferForeignToken(address,address)._to (#1739) is not in mixedCase
Function BinanceCat.Sweep(address) (#1745-1748) is not in mixedCase
Parameter BinanceCat.Sweep(address)._to (#1745) is not in mixedCase
Variable BinanceCat._maxTxAmount (#1181) is not in mixedCase
Variable BinanceCat._isBlacklisted (#1188) is not in mixedCase
Variable BinanceCat.ETHRewardsFee (#1193) is not in mixedCase
Variable BinanceCat._marketWallet (#1199) is not in mixedCase
Variable BinanceCat._managerMap (#1218) is not in mixedCase
Parameter BinanceCatDividendTracker.getAccount(address)._account (#1814) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#487)" inContext (#481-490)
Redundant expression "recipient (#1538)" inBinanceCat (#1166-1754)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
State variables written after the call(s):
- swapAndLiquify(liquidityTokens) (#1653)
- _allowances[owner][spender] = amount (#919)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#920)
- swapAndLiquify(liquidityTokens) (#1653)
- SwapAndLiquify(half,newBalance,otherHalf) (#1685)
- swapAndLiquify(liquidityTokens) (#1653)
Reentrancy in BinanceCat._swap() (#1643-1660):
External calls:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
External calls sending eth:
- swapForMarketing(swapTokens) (#1648)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
- swapAndLiquify(liquidityTokens) (#1653)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- swapAndSendDividends(sellTokens) (#1659)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
State variables written after the call(s):
- swapAndSendDividends(sellTokens) (#1659)
- _allowances[owner][spender] = amount (#919)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#920)
- swapAndSendDividends(sellTokens) (#1659)
- SendDividends(tokens,dividends) (#1735)
- swapAndSendDividends(sellTokens) (#1659)
Reentrancy in BinanceCat._transfer(address,address,uint256) (#1546-1618):
External calls:
- _swap() (#1577)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
External calls sending eth:
- _swap() (#1577)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1732)
- address(address(_marketWallet)).transfer(markingBalance) (#1634)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1600)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#853)
- _balances[recipient] = _balances[recipient].add(amount) (#854)
- super._transfer(from,to,amount) (#1603)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#853)
- _balances[recipient] = _balances[recipient].add(amount) (#854)
- launchCheck(from,to) (#1596)
- _isBlacklisted[recipient] = true (#1540)
- _isBlacklisted[sender] = true (#1542)
- launch() (#1590)
- launchedAt = block.number (#1530)
- launch() (#1590)
- launchedAtTime = block.timestamp (#1531)
- swapping = false (#1579)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1612)
- Transfer(sender,recipient,amount) (#855)
- super._transfer(from,address(this),fees) (#1600)
- Transfer(sender,recipient,amount) (#855)
- super._transfer(from,to,amount) (#1603)
Apply the check-effects-interactions pattern.
Additional information: link
Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#353) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#354)
Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#1068) is too similar to BinanceCatDividendTracker.getAccount(address).withdrawableDividends (#1819)
Prevent variables from having similar names.
Additional information: link
BinanceCat.updateGasForProcessing(uint256) (#1451-1456) uses literals with too many digits:
- require(bool,string)(newValue >= 200000 && newValue <= 500000,BinanceCat: gasForProcessing must be between 200,000 and 500,000) (#1452)
BinanceCat.addLiquidity(uint256,uint256) (#1709-1724) uses literals with too many digits:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,0x000000000000000000000000000000000000dEaD,block.timestamp) (#1715-1722)
BinanceCat.slitherConstructorVariables() (#1166-1754) uses literals with too many digits:
- gasForProcessing = 300000 (#1202)
BinanceCatDividendTracker.constructor() (#1776-1779) uses literals with too many digits:
- minimumTokenBalanceForDividends = 1000000 * (10 ** 18) (#1778)
BinanceCatDividendTracker.getAccountAtIndex(uint256) (#1859-1876) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#1870)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
get(IterableMapping.Map,address) should be declared external:
- IterableMapping.get(IterableMapping.Map,address) (#14-16)
getIndexOfKey(IterableMapping.Map,address) should be declared external:
- IterableMapping.getIndexOfKey(IterableMapping.Map,address) (#18-23)
getKeyAtIndex(IterableMapping.Map,uint256) should be declared external:
- IterableMapping.getKeyAtIndex(IterableMapping.Map,uint256) (#25-27)
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#31-33)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#530-533)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#539-543)
getUnlockTime() should be declared external:
- Ownable.getUnlockTime() (#545-547)
getTime() should be declared external:
- Ownable.getTime() (#555-557)
lock(uint256) should be declared external:
- Ownable.lock(uint256) (#559-564)
unlock() should be declared external:
- Ownable.unlock() (#566-571)
name() should be declared external:
- ERC20.name() (#695-697)
symbol() should be declared external:
- ERC20.symbol() (#703-705)
decimals() should be declared external:
- ERC20.decimals() (#720-722)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#746-749)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#754-756)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#765-768)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#783-791)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#805-808)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#824-827)
withdrawDividend() should be declared external:
- BinanceCatDividendTracker.withdrawDividend() (#1785-1787)
- DividendPayingToken.withdrawDividend() (#1061-1063)
dividendOf(address) should be declared external:
- DividendPayingToken.dividendOf(address) (#1089-1091)
withdrawnDividendOf(address) should be declared external:
- DividendPayingToken.withdrawnDividendOf(address) (#1103-1105)
updateDividendTracker(address) should be declared external:
- BinanceCat.updateDividendTracker(address) (#1317-1332)
setETHRewardsFee(uint256) should be declared external:
- BinanceCat.setETHRewardsFee(uint256) (#1334-1337)
setBuyBackFee(uint256) should be declared external:
- BinanceCat.setBuyBackFee(uint256) (#1339-1342)
setMarketFee(uint256) should be declared external:
- BinanceCat.setMarketFee(uint256) (#1344-1347)
setLiquidityFee(uint256) should be declared external:
- BinanceCat.setLiquidityFee(uint256) (#1349-1352)
setMarketWallet(address) should be declared external:
- BinanceCat.setMarketWallet(address) (#1354-1356)
setswapEnabled(bool) should be declared external:
- BinanceCat.setswapEnabled(bool) (#1358-1360)
setMaxSellTransactionAmount(uint256) should be declared external:
- BinanceCat.setMaxSellTransactionAmount(uint256) (#1374-1376)
updateUniswapV2Router(address) should be declared external:
- BinanceCat.updateUniswapV2Router(address) (#1394-1401)
excludeMultipleAccountsFromFees(address[],bool) should be declared external:
- BinanceCat.excludeMultipleAccountsFromFees(address[],bool) (#1410-1416)
setAutomatedMarketMBinanceCaterPair(address,bool) should be declared external:
- BinanceCat.setAutomatedMarketMBinanceCaterPair(address,bool) (#1426-1430)
updateLiquidityWallet(address) should be declared external:
- BinanceCat.updateLiquidityWallet(address) (#1444-1449)
updateGasForProcessing(uint256) should be declared external:
- BinanceCat.updateGasForProcessing(uint256) (#1451-1456)
isExcludedFromFees(address) should be declared external:
- BinanceCat.isExcludedFromFees(address) (#1470-1472)
withdrawableDividendOf(address) should be declared external:
- BinanceCat.withdrawableDividendOf(address) (#1474-1476)
dividendTokenBalanceOf(address) should be declared external:
- BinanceCat.dividendTokenBalanceOf(address) (#1478-1480)
swapAll() should be declared external:
- BinanceCat.swapAll() (#1637-1641)
transferForeignToken(address,address) should be declared external:
- BinanceCat.transferForeignToken(address,address) (#1739-1743)
getAccountAtIndex(uint256) should be declared external:
- BinanceCatDividendTracker.getAccountAtIndex(uint256) (#1859-1876)
process(uint256) should be declared external:
- BinanceCatDividendTracker.process(uint256) (#1903-1948)
Use the external attribute for functions never called from the contract.
Additional information: link
Unable to find website, listings and other project-related information
Young tokens have high risks of scam / price dump / death
Token is marked as risky (blacklisted creator, fake name, dead project, etc.)
Additional information: link
Token has no active CoinGecko listing / rank
Token has no active CoinMarketCap listing / rank
Unable to find Telegram and Twitter accounts