YANG [Yin & Yang Twin s] Token

YANG.swapBack() (#758-805) sends eth to arbitrary user
Dangerous calls:
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in YANG._transferFrom(address,address,uint256) (#633-669):
External calls:
- swapBack() (#650)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#769-775)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
External calls sending eth:
- swapBack() (#650)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#656)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#659)
- amountReceived = takeFee(sender,recipient,amount) (#658)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#698)
Reentrancy in YangDividendDistributor.distributeDividend(address) (#382-401):
External calls:
- rewardtoken.transfer(shareholder,amount) (#394)
External calls sending eth:
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- rewardshares[address(rewardtoken)][shareholder].totalRealised += (amount) (#398)
- rewardshares[address(rewardtoken)][shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#399)
Reentrancy in YangDividendDistributor.process(uint256) (#351-375):
External calls:
- distributeDividend(shareholders[currentIndex]) (#367)
- rewardtoken.transfer(shareholder,amount) (#394)
External calls sending eth:
- distributeDividend(shareholders[currentIndex]) (#367)
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- currentIndex ++ (#372)
Reentrancy in YangDividendDistributor.setShare(address,uint256) (#308-323):
External calls:
- distributeDividend(shareholder) (#310)
- rewardtoken.transfer(shareholder,amount) (#394)
External calls sending eth:
- distributeDividend(shareholder) (#310)
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- rewardshares[address(rewardtoken)][shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#322)
- shares[shareholder].amount = amount (#320)
Apply the check-effects-interactions pattern.

Additional information: link

YangDividendDistributor.claimUnsentTokens(IBEP20,address) (#274-277) ignores return value by tokenAddress.transfer(walletaddress,tokenAddress.balanceOf(address(this))) (#275)
YangDividendDistributor.distributeDividend(address) (#382-401) ignores return value by rewardtoken.transfer(shareholder,amount) (#394)
YANG.claimtokensback(IBEP20) (#705-708) ignores return value by tokenAddress.transfer(marketingFeeReceiver,tokenAddress.balanceOf(address(this))) (#707)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

YangDividendDistributor._token (#199) is never initialized. It is used in:
- YangDividendDistributor.constructor(address) (#245-252)
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

YANG.setSellPremium(uint256) (#604-608) contains a tautology or contradiction:
- require(bool)(premium >= 0 && premium + totalFee <= 45) (#605)
Fix the incorrect comparison by changing the value type or the comparison.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

YangDividendDistributor.setShareInternal(address,uint256) (#295-306) has costly operations inside a loop:
- totalShares += (shares[shareholder].amount) + (amount) (#303)
YangDividendDistributor.removeShareholder(address) (#427-431) has costly operations inside a loop:
- shareholders.pop() (#430)
YangDividendDistributor.process(uint256) (#351-375) has costly operations inside a loop:
- currentIndex = 0 (#363)
YangDividendDistributor.distributeDividend(address) (#382-401) has costly operations inside a loop:
- totalDistributed += amount (#388)
YangDividendDistributor.process(uint256) (#351-375) has costly operations inside a loop:
- currentIndex ++ (#372)
Use a local variable to hold the loop computation result.

Additional information: link

YANG._basicTransfer(address,address,uint256) (#671-676) is never used and should be removed
Remove unused functions.

Additional information: link

YANG.swapBack() (#758-805) ignores return value by address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
YANG.swapBack() (#758-805) ignores return value by address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
Ensure that the return value of a low-level call is checked or logged.

Additional information: link

YANG.swapBack() (#758-805) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
Ensure that all the return values of the function calls are used.

Additional information: link

YANG.setmaxholdpercentage(uint256) (#578-581) should emit an event for:
- _maxHoldAmount = _totalSupply * percentage / 100 (#580)
YANG.setSellPremium(uint256) (#604-608) should emit an event for:
- sellpremium = premium (#607)
YANG.setTxLimit(uint256) (#719-722) should emit an event for:
- _maxTxAmount = amount (#721)
YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256) (#742-751) should emit an event for:
- liquidityFee = _liquidityFee (#743)
- reflectionFee = _reflectionFee (#744)
- marketingFee = _marketingFee (#745)
- developmentfee = _devFee (#746)
- totalFee = _liquidityFee.add(_reflectionFee).add(_marketingFee).add(developmentfee).add(BurnYINCHI) (#748)
- feeDenominator = _feeDenominator (#749)
YANG.setSwapBackSettings(bool,uint256) (#817-820) should emit an event for:
- swapThreshold = _amount (#819)
YANG.setDistributorSettings(uint256) (#842-845) should emit an event for:
- distributorGas = gas (#844)
Emit an event for critical parameter changes.

Additional information: link

Auth.transferOwnership(address).adr (#124) lacks a zero-check on :
- owner = adr (#125)
YANG.setFeeReceivers(address,address,address)._autoLiquidityReceiver (#807) lacks a zero-check on :
- autoLiquidityReceiver = _autoLiquidityReceiver (#808)
YANG.setFeeReceivers(address,address,address)._marketingFeeReceiver (#807) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#809)
YANG.setFeeReceivers(address,address,address).devWallet (#807) lacks a zero-check on :
- devFeeReceiver = devWallet (#810)
YANG.setCharityWallet(address).charityWallet (#813) lacks a zero-check on :
- charityFeeReceiver = charityWallet (#814)
Check that the address is not zero.

Additional information: link

YangDividendDistributor.distributeDividend(address) (#382-401) has external calls inside a loop: address(shareholder).transfer(amount) (#392)
YangDividendDistributor.distributeDividend(address) (#382-401) has external calls inside a loop: rewardtoken.transfer(shareholder,amount) (#394)
YANG.airdropPresaleInternal(address,uint256) (#570-576) has external calls inside a loop: distributor.setInitialShare(recipient,amount) (#574)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in YANG._transferFrom(address,address,uint256) (#633-669):
External calls:
- swapBack() (#650)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#769-775)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
External calls sending eth:
- swapBack() (#650)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
State variables written after the call(s):
- launch() (#654)
- launchedAt = block.timestamp (#716)
Reentrancy in YangDividendDistributor.claimUnsentTokens(IBEP20,address) (#274-277):
External calls:
- tokenAddress.transfer(walletaddress,tokenAddress.balanceOf(address(this))) (#275)
State variables written after the call(s):
- totaldividendsOfToken[address(rewardtoken)] = 0 (#276)
Reentrancy in YANG.constructor() (#497-525):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#501)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = _totalSupply (#503)
- distributor = new YangDividendDistributor(address(router)) (#507)
- isMaxHoldExempt[pair] = true (#504)
- pairs[pair] = true (#502)
Reentrancy in YANG.constructor() (#497-525):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#501)
- distributor.addAdmin(address(msg.sender)) (#508)
State variables written after the call(s):
- _balances[owner] = _totalSupply (#523)
- authorizations[msg.sender] = true (#516)
- autoLiquidityReceiver = msg.sender (#518)
- devFeeReceiver = msg.sender (#520)
- isDividendExempt[pair] = true (#510)
- isDividendExempt[address(this)] = true (#511)
- isDividendExempt[DEAD] = true (#512)
- isFeeExempt[msg.sender] = true (#515)
- isMaxHoldExempt[owner] = true (#522)
- isTxLimitExempt[msg.sender] = true (#514)
- marketingFeeReceiver = msg.sender (#519)
- owner = msg.sender (#521)
Reentrancy in YangDividendDistributor.deposit() (#325-349):
External calls:
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: msg.value}(0,path,address(this),block.timestamp) (#333-338)
State variables written after the call(s):
- dividendsPerShareRewardToken[address(rewardtoken)] = dividendsPerShareRewardToken[address(rewardtoken)] + (dividendsPerShareAccuracyFactor * (amount) / (totalShares)) (#344)
- totaldividendsOfToken[address(rewardtoken)] = totaldividendsOfToken[address(rewardtoken)] + amount (#342)
Reentrancy in YangDividendDistributor.distributeDividend(address) (#382-401):
External calls:
- rewardtoken.transfer(shareholder,amount) (#394)
External calls sending eth:
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- shareholderClaims[shareholder] = block.timestamp (#397)
Reentrancy in YangDividendDistributor.setShare(address,uint256) (#308-323):
External calls:
- distributeDividend(shareholder) (#310)
- rewardtoken.transfer(shareholder,amount) (#394)
External calls sending eth:
- distributeDividend(shareholder) (#310)
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- addShareholder(shareholder) (#314)
- shareholderIndexes[shareholder] = shareholders.length (#423)
- removeShareholder(shareholder) (#316)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#429)
- addShareholder(shareholder) (#314)
- shareholders.push(shareholder) (#424)
- removeShareholder(shareholder) (#316)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#428)
- shareholders.pop() (#430)
- totalShares -= (shares[shareholder].amount) (#319)
- totalShares += (amount) (#321)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in YANG._transferFrom(address,address,uint256) (#633-669):
External calls:
- swapBack() (#650)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#769-775)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
- distributor.setShare(sender,_balances[sender]) (#661)
- distributor.setShare(recipient,_balances[recipient]) (#662)
- distributor.process(distributorGas) (#664)
External calls sending eth:
- swapBack() (#650)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#666)
Reentrancy in YANG._transferFrom(address,address,uint256) (#633-669):
External calls:
- swapBack() (#650)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#769-775)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
External calls sending eth:
- swapBack() (#650)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#699)
- amountReceived = takeFee(sender,recipient,amount) (#658)
Reentrancy in YANG.airdropPresale(address,uint256) (#562-568):
External calls:
- distributor.setShare(recipient,_balances[recipient]) (#566)
Event emitted after the call(s):
- Transfer(msg.sender,recipient,amount) (#567)
Reentrancy in YANG.airdropPresaleInternal(address,uint256) (#570-576):
External calls:
- distributor.setInitialShare(recipient,amount) (#574)
Event emitted after the call(s):
- Transfer(msg.sender,recipient,amount) (#575)
Reentrancy in YANG.constructor() (#497-525):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#501)
- distributor.addAdmin(address(msg.sender)) (#508)
Event emitted after the call(s):
- Transfer(address(0),owner,_totalSupply) (#524)
Reentrancy in YANG.swapBack() (#758-805):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#769-775)
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
External calls sending eth:
- distributor.deposit{value: amountBNBReflection}() (#785)
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#795-802)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#803)
Apply the check-effects-interactions pattern.

Additional information: link

YangDividendDistributor.shouldDistribute(address) (#377-380) uses timestamp for comparisons
Dangerous comparisons:
- shareholderClaims[shareholder] + minPeriod < block.timestamp && getUnpaidEarnings(shareholder) > minDistribution (#378-379)
YANG._transferFrom(address,address,uint256) (#633-669) uses timestamp for comparisons
Dangerous comparisons:
- ! launched() && pairs[recipient] (#654)
YANG.launched() (#711-713) uses timestamp for comparisons
Dangerous comparisons:
- launchedAt != 0 (#712)
Avoid relying on block.timestamp.

Additional information: link

YangDividendDistributor.rewardtoken (#210) is set pre-construction with a non-constant function or state variable:
- IBEP20(WBNB)
YANG._maxTxAmount (#446) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1
YANG._maxSellTxAMount (#447) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1
YANG._maxHoldAmount (#448) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1
YANG.swapThreshold (#493) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 200
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Low level call in YANG.swapBack() (#758-805):
- address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#791)
- address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#792)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

YANG (#434-856) should inherit from IpresaleAirdrop (#192-194)
Inherit from the missing interface or contract.

Additional information: link

Function IDEXRouter.WETH() (#139) is not in mixedCase
Parameter YangDividendDistributor.setDistributionCriteria(uint256,uint256)._minPeriod (#255) is not in mixedCase
Parameter YangDividendDistributor.setDistributionCriteria(uint256,uint256)._minDistribution (#255) is not in mixedCase
Variable YangDividendDistributor._token (#199) is not in mixedCase
Variable YangDividendDistributor.WBNB (#208) is not in mixedCase
Parameter YANG.addTeamWallet(address).Teamwallet (#592) is not in mixedCase
Parameter YANG.removeTeamWallet(address).Teamwallet (#596) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._liquidityFee (#742) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._reflectionFee (#742) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._marketingFee (#742) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._devFee (#742) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._charityFee (#742) is not in mixedCase
Parameter YANG.setFees(uint256,uint256,uint256,uint256,uint256,uint256)._feeDenominator (#742) is not in mixedCase
Parameter YANG.setFeeReceivers(address,address,address)._autoLiquidityReceiver (#807) is not in mixedCase
Parameter YANG.setFeeReceivers(address,address,address)._marketingFeeReceiver (#807) is not in mixedCase
Parameter YANG.setSwapBackSettings(bool,uint256)._enabled (#817) is not in mixedCase
Parameter YANG.setSwapBackSettings(bool,uint256)._amount (#817) is not in mixedCase
Parameter YANG.setTargetLiquidity(uint256,uint256)._target (#829) is not in mixedCase
Parameter YANG.setTargetLiquidity(uint256,uint256)._denominator (#829) is not in mixedCase
Parameter YANG.setDistributionCriteria(uint256,uint256)._minPeriod (#834) is not in mixedCase
Parameter YANG.setDistributionCriteria(uint256,uint256)._minDistribution (#834) is not in mixedCase
Variable YANG.WBNB (#437) is not in mixedCase
Variable YANG.DEAD (#438) is not in mixedCase
Variable YANG.ZERO (#439) is not in mixedCase
Constant YANG._name (#441) is not in UPPER_CASE_WITH_UNDERSCORES
Constant YANG._symbol (#442) is not in UPPER_CASE_WITH_UNDERSCORES
Constant YANG._decimals (#443) is not in UPPER_CASE_WITH_UNDERSCORES
Variable YANG._totalSupply (#445) is not in mixedCase
Variable YANG._maxTxAmount (#446) is not in mixedCase
Variable YANG._maxSellTxAMount (#447) is not in mixedCase
Variable YANG._maxHoldAmount (#448) is not in mixedCase
Variable YANG._balances (#450) is not in mixedCase
Variable YANG._allowances (#451) is not in mixedCase
Variable YANG.BurnYINCHI (#466) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in YangDividendDistributor.distributeDividend(address) (#382-401):
External calls:
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- rewardshares[address(rewardtoken)][shareholder].totalRealised += (amount) (#398)
- rewardshares[address(rewardtoken)][shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#399)
- shareholderClaims[shareholder] = block.timestamp (#397)
Reentrancy in YangDividendDistributor.process(uint256) (#351-375):
External calls:
- distributeDividend(shareholders[currentIndex]) (#367)
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- currentIndex ++ (#372)
Reentrancy in YangDividendDistributor.setShare(address,uint256) (#308-323):
External calls:
- distributeDividend(shareholder) (#310)
- address(shareholder).transfer(amount) (#392)
State variables written after the call(s):
- rewardshares[address(rewardtoken)][shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#322)
- addShareholder(shareholder) (#314)
- shareholderIndexes[shareholder] = shareholders.length (#423)
- removeShareholder(shareholder) (#316)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#429)
- addShareholder(shareholder) (#314)
- shareholders.push(shareholder) (#424)
- removeShareholder(shareholder) (#316)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#428)
- shareholders.pop() (#430)
- shares[shareholder].amount = amount (#320)
- totalShares -= (shares[shareholder].amount) (#319)
- totalShares += (amount) (#321)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#144) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#145)
Prevent variables from having similar names.

Additional information: link

YANG.slitherConstructorVariables() (#434-856) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#438)
YANG.slitherConstructorVariables() (#434-856) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#439)
YANG.slitherConstructorVariables() (#434-856) uses literals with too many digits:
- distributorGas = 500000 (#490)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

YANG.DEAD (#438) should be constant
YANG.WBNB (#437) should be constant
YANG.ZERO (#439) should be constant
YANG._totalSupply (#445) should be constant
YANG.presaleAddress (#475) should be constant
YANG.rewardtokenFee (#467) should be constant
YANG.teamcantrade (#459) should be constant
YangDividendDistributor.WBNB (#208) should be constant
YangDividendDistributor._token (#199) should be constant
YangDividendDistributor.dividendsPerShareAccuracyFactor (#227) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#96-98)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#103-105)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#124-128)
addAdmin(address) should be declared external:
- YangDividendDistributor.addAdmin(address) (#265-267)
removeAdmin(address) should be declared external:
- YangDividendDistributor.removeAdmin(address) (#270-272)
getCirculatingSupply() should be declared external:
- YANG.getCirculatingSupply() (#847-849)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract name (Yin & Yang Twin Tokens) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.

Contract has 0% buy tax and 29% sell tax.
Taxes are suspiciously high (over 10%) and contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank