The world as we know of today has changed a lot in the recent
past. Historians believe that more technological advancements and
progress have been made in the last fewdecades than as compared
to the entire history of humanity of thousands of years.
Our belief is we owe a lot of this progress to revolutionary
technologies like the internet, AI, machine learning, data sciences
and the one and only blockchain. While all the othertechnologies
help our world transition to a digital world, it
is blockchain, which holds this digital world together and
provides the security needed to build our confidence in the
digital world.
While blockchain has left no industry alone, it has
influenced the finance industry the most. Blockchain has
entirely changed the way finance industry worked.From the
decentralized finance applications to fungiblecurrencies,
nothing is left unaltered. However, in this paper we are
going to focus on something different, something new –
Non-fungible tokens.
Contract locking ether found:
Contract MillionPixel (#674-1122) has payable functions:
- MillionPixel.receive() (#898-899)
But does not have a function to withdraw the ether
Remove the payable attribute or add a withdraw function.
Additional information: link
Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains
MillionPixel.allowance(address,address).owner (#768) shadows:
- Ownable.owner() (#405-407) (function)
MillionPixel._approve(address,address,uint256).owner (#1004) shadows:
- Ownable.owner() (#405-407) (function)
Rename the local variables that shadow another component.
Additional information: link
MillionPixel.changeSellFees(uint256,uint256,uint256) (#858-862) should emit an event for:
- S_taxFee = taxFee (#859)
- S_BurnFee = burn (#860)
- S_liquidityFee = liquidityFee (#861)
Emit an event for critical parameter changes.
Additional information: link
MillionPixel.ChangeBurnAddress(address).BurnAddressr (#864) lacks a zero-check on :
- BurnAddress = BurnAddressr (#865)
MillionPixel.setLiquidityAddress(address)._liquidityAddr (#869) lacks a zero-check on :
- liquidityAddr = _liquidityAddr (#870)
Check that the address is not zero.
Additional information: link
Reentrancy in MillionPixel.constructor() (#721-740):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),BUSD) (#727-728)
Event emitted after the call(s):
- SetAutomatedMarketMakerPair(pair,value) (#886)
- _setAutomatedMarketMakerPair(uniswapV2Pair,true) (#729)
- Transfer(address(0),owner(),_tTotal) (#739)
Apply the check-effects-interactions pattern.
Additional information: link
Ownable.unlock() (#452-457) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp > _lockTime,Contract is locked until 7 days) (#454)
Avoid relying on block.timestamp.
Additional information: link
Address.isContract(address) (#264-273) uses assembly
- INLINE ASM (#271)
Address._functionCallWithValue(address,bytes,uint256,string) (#357-378) uses assembly
- INLINE ASM (#370-373)
Do not use evm assembly.
Additional information: link
Pragma version0.8.15 (#1) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.15 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Reentrancy in MillionPixel.constructor() (#721-740):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),BUSD) (#727-728)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#734)
- _isExcludedFromFee[address(this)] = true (#736)
- _isExcludedSS[owner()] = true (#735)
- _setAutomatedMarketMakerPair(uniswapV2Pair,true) (#729)
- automatedMarketMakerPairs[pair] = value (#885)
- uniswapV2Router = _uniswapV2Router (#731)
Reentrancy in MillionPixel.setRouter(address) (#873-880):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),BUSD) (#876-877)
State variables written after the call(s):
- uniswapV2Router = _uniswapV2Router (#879)
Apply the check-effects-interactions pattern.
Additional information: link
MillionPixel.includeInReward(address) (#829-840) has costly operations inside a loop:
- _excluded.pop() (#836)
Use a local variable to hold the loop computation result.
Additional information: link
Address._functionCallWithValue(address,bytes,uint256,string) (#357-378) is never used and should be removed
Address.functionCall(address,bytes) (#317-319) is never used and should be removed
Address.functionCall(address,bytes,string) (#327-329) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#342-344) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#352-355) is never used and should be removed
Address.isContract(address) (#264-273) is never used and should be removed
Address.sendValue(address,uint256) (#291-297) is never used and should be removed
Context._msgData() (#236-239) is never used and should be removed
SafeMath.mod(uint256,uint256) (#209-211) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#225-228) is never used and should be removed
Remove unused functions.
Additional information: link
MillionPixel._rTotal (#691) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
MillionPixel._previousTaxFee (#701) is set pre-construction with a non-constant function or state variable:
- _taxFee
MillionPixel._previousBurnFee (#707) is set pre-construction with a non-constant function or state variable:
- _BurnFee
MillionPixel._previousLiquidityFee (#712) is set pre-construction with a non-constant function or state variable:
- _liquidityFee
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Low level call in Address.sendValue(address,uint256) (#291-297):
- (success) = recipient.call{value: amount}() (#295)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#357-378):
- (success,returndata) = target.call{value: weiValue}(data) (#361)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Variable Ownable._owner (#394) is not in mixedCase
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#496) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#497) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#514) is not in mixedCase
Function IUniswapV2Router01.WETH() (#536) is not in mixedCase
Function MillionPixel.Exclude(address) (#850-852) is not in mixedCase
Function MillionPixel.Include(address) (#854-856) is not in mixedCase
Function MillionPixel.ChangeBurnAddress(address) (#864-866) is not in mixedCase
Parameter MillionPixel.ChangeBurnAddress(address).BurnAddressr (#864) is not in mixedCase
Parameter MillionPixel.setLiquidityAddress(address)._liquidityAddr (#869) is not in mixedCase
Function MillionPixel._Burn(uint256) (#954-960) is not in mixedCase
Parameter MillionPixel.calculateTaxFee(uint256)._amount (#962) is not in mixedCase
Parameter MillionPixel.calculateWalletFee(uint256)._amount (#969) is not in mixedCase
Parameter MillionPixel.calculateLiquidityFee(uint256)._amount (#975) is not in mixedCase
Variable MillionPixel._taxFee (#698) is not in mixedCase
Variable MillionPixel.S_taxFee (#699) is not in mixedCase
Variable MillionPixel._previousTaxFee (#701) is not in mixedCase
Variable MillionPixel._BurnFee (#704) is not in mixedCase
Variable MillionPixel.S_BurnFee (#705) is not in mixedCase
Variable MillionPixel._previousBurnFee (#707) is not in mixedCase
Variable MillionPixel._liquidityFee (#709) is not in mixedCase
Variable MillionPixel.S_liquidityFee (#710) is not in mixedCase
Variable MillionPixel._previousLiquidityFee (#712) is not in mixedCase
Variable MillionPixel.BurnAddress (#713) is not in mixedCase
Variable MillionPixel.BUSD (#714) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#237)" inContext (#231-240)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#541) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#542)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel._transferBothExcluded(address,address,uint256).rTransferAmount (#1108) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._transferStandard(address,address,uint256).rTransferAmount (#1070) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._getRValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#925) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel.reflectionFromToken(uint256,bool).rTransferAmount (#808) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._transferFromExcluded(address,address,uint256).tTransferAmount (#1095)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._getTValues(uint256).tTransferAmount (#916)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._transferToExcluded(address,address,uint256).rTransferAmount (#1082) is too similar to MillionPixel._transferStandard(address,address,uint256).tTransferAmount (#1070)
Variable MillionPixel._getValues(uint256).rTransferAmount (#908) is too similar to MillionPixel._transferToExcluded(address,address,uint256).tTransferAmount (#1082)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._transferBothExcluded(address,address,uint256).tTransferAmount (#1108)
Variable MillionPixel._transferFromExcluded(address,address,uint256).rTransferAmount (#1095) is too similar to MillionPixel._getValues(uint256).tTransferAmount (#907)
Prevent variables from having similar names.
Additional information: link
MillionPixel.slitherConstructorVariables() (#674-1122) uses literals with too many digits:
- BurnAddress = 0x000000000000000000000000000000000000dEaD (#713)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
MillionPixel.BUSD (#714) should be constant
MillionPixel._decimals (#696) should be constant
MillionPixel._name (#694) should be constant
MillionPixel._symbol (#695) should be constant
MillionPixel._tTotal (#690) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#424-427)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#433-437)
geUnlockTime() should be declared external:
- Ownable.geUnlockTime() (#439-441)
lock(uint256) should be declared external:
- Ownable.lock(uint256) (#444-449)
unlock() should be declared external:
- Ownable.unlock() (#452-457)
name() should be declared external:
- MillionPixel.name() (#742-744)
symbol() should be declared external:
- MillionPixel.symbol() (#746-748)
decimals() should be declared external:
- MillionPixel.decimals() (#750-752)
totalSupply() should be declared external:
- MillionPixel.totalSupply() (#754-756)
balanceOf(address) should be declared external:
- MillionPixel.balanceOf(address) (#758-761)
transfer(address,uint256) should be declared external:
- MillionPixel.transfer(address,uint256) (#763-766)
allowance(address,address) should be declared external:
- MillionPixel.allowance(address,address) (#768-770)
approve(address,uint256) should be declared external:
- MillionPixel.approve(address,uint256) (#772-775)
transferFrom(address,address,uint256) should be declared external:
- MillionPixel.transferFrom(address,address,uint256) (#777-781)
increaseAllowance(address,uint256) should be declared external:
- MillionPixel.increaseAllowance(address,uint256) (#783-786)
decreaseAllowance(address,uint256) should be declared external:
- MillionPixel.decreaseAllowance(address,uint256) (#788-791)
isExcludedFromReward(address) should be declared external:
- MillionPixel.isExcludedFromReward(address) (#793-795)
totalFees() should be declared external:
- MillionPixel.totalFees() (#797-799)
reflectionFromToken(uint256,bool) should be declared external:
- MillionPixel.reflectionFromToken(uint256,bool) (#802-811)
excludeFromReward(address) should be declared external:
- MillionPixel.excludeFromReward(address) (#819-827)
excludeFromFee(address) should be declared external:
- MillionPixel.excludeFromFee(address) (#842-844)
includeInFee(address) should be declared external:
- MillionPixel.includeInFee(address) (#846-848)
Exclude(address) should be declared external:
- MillionPixel.Exclude(address) (#850-852)
Include(address) should be declared external:
- MillionPixel.Include(address) (#854-856)
setRouter(address) should be declared external:
- MillionPixel.setRouter(address) (#873-880)
setAutomatedMarketMakerPair(address,bool) should be declared external:
- MillionPixel.setAutomatedMarketMakerPair(address,bool) (#890-894)
isExcludedFromFee(address) should be declared external:
- MillionPixel.isExcludedFromFee(address) (#1000-1002)
Use the external attribute for functions never called from the contract.
Additional information: link
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Token has relatively low CoinGecko rank
Twitter account seems to be suspended
Additional information: link