$WHALER [Whale Games] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in WhaleGames._transferFrom(address,address,uint256) (#617-660):
External calls:
- swapBack() (#632)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
External calls sending eth:
- swapBack() (#632)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
State variables written after the call(s):
- _checkTxLimit(sender,recipient,amount) (#634)
- Whale = marketingWallet (#459)
- Whale = recipient (#558)
- Whale = recipient (#566)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#643)
- _balances[sender] = _balances[sender].sub(amount) (#644)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#649)
- _balances[sender] = _balances[sender].sub(amount) (#650)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#655)
- _balances[sender] = _balances[sender].sub(amount) (#656)
- amountReceived = takeFee(sender,recipient,amount) (#637-639)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#685)
- autoBlacklist(recipient) (#645)
- _isBlackedlisted[addr] = true (#523)
Apply the check-effects-interactions pattern.

Additional information: link

WhaleGames.recoverLostTokens(address,uint256) (#771-776) ignores return value by IERC20(_token).transfer(msg.sender,_amount) (#775)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

WhaleGames.setFees(uint256,uint256,uint256) (#379-403) contains a tautology or contradiction:
- require(bool,string)(newLiquidityFee >= 0 && newLiquidityFee <= 10,Invalid fee) (#384-387)
WhaleGames.setFees(uint256,uint256,uint256) (#379-403) contains a tautology or contradiction:
- require(bool,string)(newMarketingFee >= 0 && newMarketingFee <= 10,Invalid fee) (#389-392)
WhaleGames.setFees(uint256,uint256,uint256) (#379-403) contains a tautology or contradiction:
- require(bool,string)(newwhaleFee >= 0 && newwhaleFee <= 10,Invalid fee) (#394-397)
Fix the incorrect comparison by changing the value type or the comparison.

Additional information: link

WhaleGames.swapBack().tmpSuccess (#736) is written in both
(tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
tmpSuccess = false (#751)
WhaleGames.swapBack().tmpSuccess2 (#740) is written in both
(tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
tmpSuccess2 = false (#752)
Fix or remove the writes.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ticker ($WHALER) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

Low level call in WhaleGames.swapBack() (#704-765):
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Context._msgData() (#166-168) is never used and should be removed
Remove unused functions.

Additional information: link

WhaleGames._maxTxAmount (#286) is set pre-construction with a non-constant function or state variable:
- _totalSupply
WhaleGames._maxWalletAmount (#287) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 33
WhaleGames.swapThreshold (#288) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 100
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.12 (#1) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.12 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

WhaleGames.swapBack() (#704-765) ignores return value by router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
Ensure that all the return values of the function calls are used.

Additional information: link

WhaleGames.setFees(uint256,uint256,uint256) (#379-403) should emit an event for:
- liquidityFee = newLiquidityFee (#399)
- marketingFee = newMarketingFee (#400)
- whaleFee = newwhaleFee (#401)
- totalFee = liquidityFee.add(marketingFee).add(whaleFee) (#402)
WhaleGames.setSwapThreshold(uint256) (#439-441) should emit an event for:
- swapThreshold = threshold (#440)
WhaleGames.setResetPeriodInSeconds(uint256) (#451-456) should emit an event for:
- resetPeriod = newResetPeriod (#455)
WhaleGames.setMaxWalletSize(uint256) (#496-500) should emit an event for:
- _maxWalletAmount = amount (#498)
WhaleGames.setMaxTransactionSize(uint256) (#502-506) should emit an event for:
- _maxTxAmount = amount (#504)
WhaleGames.setSwapBackSettings(bool,uint256) (#588-594) should emit an event for:
- swapThreshold = newSwapBackLimit (#593)
Emit an event for critical parameter changes.

Additional information: link

WhaleGames.setFeeReceivers(address,address).newLiquidityReceiver (#444) lacks a zero-check on :
- autoLiquidityReceiver = newLiquidityReceiver (#447)
WhaleGames.setFeeReceivers(address,address).newMarketingWallet (#445) lacks a zero-check on :
- marketingWallet = newMarketingWallet (#448)
Check that the address is not zero.

Additional information: link

Reentrancy in WhaleGames._transferFrom(address,address,uint256) (#617-660):
External calls:
- swapBack() (#632)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
External calls sending eth:
- swapBack() (#632)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
State variables written after the call(s):
- _checkTxLimit(sender,recipient,amount) (#634)
- biggestBuy = 0 (#460)
- biggestBuy = usedEth (#559)
- biggestBuy = usedEth (#567)
- _checkTxLimit(sender,recipient,amount) (#634)
- lastWhaleChange = block.timestamp (#461)
- lastWhaleChange = block.timestamp (#560)
- lastWhaleChange = block.timestamp (#568)
Reentrancy in WhaleGames.constructor() (#301-321):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#303-306)
State variables written after the call(s):
- Whale = msg.sender (#316)
- _allowances[address(this)][address(router)] = MAX (#307)
- _balances[msg.sender] = _totalSupply (#319)
- autoLiquidityReceiver = msg.sender (#314)
- isFeeExempt[DEAD] = true (#308)
- isFeeExempt[msg.sender] = true (#310)
- isFeeExempt[address(this)] = true (#311)
- isTxLimitExempt[DEAD] = true (#309)
- isTxLimitExempt[msg.sender] = true (#312)
- isTxLimitExempt[pair] = true (#313)
- marketingWallet = msg.sender (#315)
- totalFee = liquidityFee.add(marketingFee).add(whaleFee) (#317)
- totalFeeIfSelling = totalFee (#318)
Reentrancy in WhaleGames.swapBack() (#704-765):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
External calls sending eth:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
State variables written after the call(s):
- _lastWhaleTimer[Whale] = block.timestamp (#747)
- _payOut[Whale] = amountETHWhale (#745)
- previousWhaleHolder[Whale] = true (#746)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in WhaleGames._transferFrom(address,address,uint256) (#617-660):
External calls:
- swapBack() (#632)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
External calls sending eth:
- swapBack() (#632)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
Event emitted after the call(s):
- NewWhale(Whale,biggestBuy) (#561)
- _checkTxLimit(sender,recipient,amount) (#634)
- NewWhale(Whale,biggestBuy) (#569)
- _checkTxLimit(sender,recipient,amount) (#634)
- Transfer(sender,address(this),feeAmount) (#686)
- amountReceived = takeFee(sender,recipient,amount) (#637-639)
- Transfer(msg.sender,recipient,amountReceived) (#658)
- WhaleSold(Whale,biggestBuy) (#581)
- _checkTxLimit(sender,recipient,amount) (#634)
Reentrancy in WhaleGames.constructor() (#301-321):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#303-306)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#320)
Reentrancy in WhaleGames.swapBack() (#704-765):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
External calls sending eth:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
Event emitted after the call(s):
- WhalePayout(Whale,amountETHWhale) (#748)
Reentrancy in WhaleGames.swapBack() (#704-765):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#717-723)
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
External calls sending eth:
- (tmpSuccess) = address(marketingWallet).call{gas: 30000,value: amountETHMarketing}() (#736-739)
- (tmpSuccess2) = address(Whale).call{gas: 30000,value: amountETHWhale}() (#740-743)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#755-762)
Event emitted after the call(s):
- AutoLiquify(amountETHLiquidity,amountToLiquify) (#763)
Apply the check-effects-interactions pattern.

Additional information: link

WhaleGames.addBlacklist(address) (#508-512) uses timestamp for comparisons
Dangerous comparisons:
- require(bool)(block.timestamp < _launchTime + 2700) (#509)
WhaleGames._checkTxLimit(address,address,uint256) (#527-586) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp - lastWhaleChange > resetPeriod (#532)
- previousWhaleHolder[recipient] == true && _lastWhaleTimer[recipient] + 3600 < block.timestamp && usedEth > biggestBuy (#556)
Avoid relying on block.timestamp.

Additional information: link

WhaleGames.saucethen() (#484-494) compares to a boolean constant:
-require(bool,string)(_isLaunched == false,Already launched) (#485)
WhaleGames._checkTxLimit(address,address,uint256) (#527-586) compares to a boolean constant:
-previousWhaleHolder[recipient] == true && _lastWhaleTimer[recipient] + 3600 < block.timestamp && usedEth > biggestBuy (#556)
WhaleGames._checkTxLimit(address,address,uint256) (#527-586) compares to a boolean constant:
-previousWhaleHolder[recipient] == false && usedEth > biggestBuy (#564)
WhaleGames._transferFrom(address,address,uint256) (#617-660) compares to a boolean constant:
-require(bool,string)(_isBlackedlisted[sender] != true && _isBlackedlisted[recipient] != true,Blacklisted) (#622)
WhaleGames._transferFrom(address,address,uint256) (#617-660) compares to a boolean constant:
-_isLaunched != true && recipient != pair && sender != owner() && recipient != owner() (#641)
Remove the equality to the boolean constant.

Additional information: link

Function IDEXRouter.WETH() (#97) is not in mixedCase
Parameter WhaleGames.recoverLostTokens(address,uint256)._token (#771) is not in mixedCase
Parameter WhaleGames.recoverLostTokens(address,uint256)._amount (#771) is not in mixedCase
Constant WhaleGames._name (#244) is not in UPPER_CASE_WITH_UNDERSCORES
Constant WhaleGames._symbol (#245) is not in UPPER_CASE_WITH_UNDERSCORES
Constant WhaleGames._decimals (#246) is not in UPPER_CASE_WITH_UNDERSCORES
Variable WhaleGames.DEAD (#248) is not in mixedCase
Variable WhaleGames.ZERO (#249) is not in mixedCase
Variable WhaleGames._totalSupply (#253) is not in mixedCase
Variable WhaleGames._balances (#257) is not in mixedCase
Variable WhaleGames._allowances (#258) is not in mixedCase
Variable WhaleGames._lastWhaleTimer (#259) is not in mixedCase
Variable WhaleGames._payOut (#260) is not in mixedCase
Variable WhaleGames.Whale (#275) is not in mixedCase
Variable WhaleGames._payOutAddress (#276) is not in mixedCase
Variable WhaleGames._isLaunched (#278) is not in mixedCase
Variable WhaleGames._launchTime (#279) is not in mixedCase
Variable WhaleGames._maxTxAmount (#286) is not in mixedCase
Variable WhaleGames._maxWalletAmount (#287) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#107) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#108)
Prevent variables from having similar names.

Additional information: link

WhaleGames.slitherConstructorVariables() (#241-778) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#248)
WhaleGames.slitherConstructorVariables() (#241-778) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#249)
WhaleGames.slitherConstructorVariables() (#241-778) uses literals with too many digits:
- _totalSupply = 100000 * (10 ** _decimals) (#253)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

WhaleGames.DEAD (#248) should be constant
WhaleGames.ZERO (#249) should be constant
WhaleGames._payOutAddress (#276) should be constant
WhaleGames._totalSupply (#253) should be constant
WhaleGames.routerAddress (#250) should be constant
WhaleGames.timeToWait (#289) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#217-219)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#225-228)
balanceOf(address) should be declared external:
- ERC20Interface.balanceOf(address) (#238)
getCirculatingSupply() should be declared external:
- WhaleGames.getCirculatingSupply() (#345-347)
pasta() should be declared external:
- WhaleGames.pasta() (#353-368)
removeLiquidty() should be declared external:
- WhaleGames.removeLiquidty() (#370-377)
enableHappyHour() should be declared external:
- WhaleGames.enableHappyHour() (#468-474)
setDefaultTaxes() should be declared external:
- WhaleGames.setDefaultTaxes() (#476-482)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 16% buy tax and 15% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Average 30d PancakeSwap liquidity is low.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank