VCG [VCGamers] Token

VCG.distributeFee() (#405-425) sends eth to arbitrary user
Dangerous calls:
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in VCG._transferTax(address,address,uint256) (#371-397):
External calls:
- distributeFee() (#387)
- _router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapAmount,0,path,address(this),block.timestamp) (#414-423)
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
External calls sending eth:
- distributeFee() (#387)
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
State variables written after the call(s):
- _balances[recipient] = _balances[recipient].add(amountReceived) (#394)
Reentrancy in TaxCollector.distribute() (#220-233):
External calls:
- (sent_1) = address(teamWallet).call{gas: 30000,value: (amount * teamPercentage / maxPercent)}() (#230)
State variables written after the call(s):
- balance = address(this).balance (#230)
Reentrancy in TaxCollector.distribute() (#220-233):
External calls:
- (sent_1) = address(teamWallet).call{gas: 30000,value: (amount * teamPercentage / maxPercent)}() (#230)
- (sent_2) = address(partnershipWallet).call{gas: 30000,value: (amount * partnershipPercentage / maxPercent)}() (#231)
State variables written after the call(s):
- balance = address(this).balance (#231)
Reentrancy in TaxCollector.distribute() (#220-233):
External calls:
- (sent_1) = address(teamWallet).call{gas: 30000,value: (amount * teamPercentage / maxPercent)}() (#230)
- (sent_2) = address(partnershipWallet).call{gas: 30000,value: (amount * partnershipPercentage / maxPercent)}() (#231)
- (sent_3) = address(rndWallet).call{gas: 30000,value: (amount * rndPercentage / maxPercent)}() (#232)
State variables written after the call(s):
- balance = address(this).balance (#232)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

Reentrancy in VCG._transferTax(address,address,uint256) (#371-397):
External calls:
- distributeFee() (#387)
- _router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapAmount,0,path,address(this),block.timestamp) (#414-423)
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
External calls sending eth:
- distributeFee() (#387)
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#395)
Reentrancy in VCG.constructor() (#288-300):
External calls:
- _pair = IFactory(_router.factory()).createPair(WBNB,address(this)) (#291)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#434)
- _mint(_msgSender(),100000000 * 10 ** uint256(_decimals)) (#299)
Reentrancy in VCG.distributeFee() (#405-425):
External calls:
- _router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapAmount,0,path,address(this),block.timestamp) (#414-423)
Event emitted after the call(s):
- DistributeFailed(e) (#423)
Apply the check-effects-interactions pattern.

Additional information: link

Context._msgData() (#33) is never used and should be removed
VCG._burn(address,uint256) (#437-448) is never used and should be removed
Remove unused functions.

Additional information: link

Low level call in TaxCollector.distribute() (#220-233):
- (sent_1) = address(teamWallet).call{gas: 30000,value: (amount * teamPercentage / maxPercent)}() (#230)
- (sent_2) = address(partnershipWallet).call{gas: 30000,value: (amount * partnershipPercentage / maxPercent)}() (#231)
- (sent_3) = address(rndWallet).call{gas: 30000,value: (amount * rndPercentage / maxPercent)}() (#232)
Low level call in VCG.distributeFee() (#405-425):
- (sent) = address(_taxCollector).call{gas: 30000,value: amountBNB}() (#422)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

TaxCollector (#202-236) should inherit from ITaxCollector (#238-246)
Inherit from the missing interface or contract.

Additional information: link

VCG.distributeFee().e (#423) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

VCG.allowance(address,address).owner (#309) shadows:
- Ownable.owner() (#46-48) (function)
VCG._approve(address,address,uint256).owner (#451) shadows:
- Ownable.owner() (#46-48) (function)
Rename the local variables that shadow another component.

Additional information: link

VCG.setTax(uint256) (#262) should emit an event for:
- _tax = input_ (#262)
VCG.setTaxDivider(uint256) (#263) should emit an event for:
- _taxDivider = input_ (#263)
Emit an event for critical parameter changes.

Additional information: link

TaxCollector.setTeam(uint256,address).wallet_ (#209) lacks a zero-check on :
- teamWallet = wallet_ (#209)
TaxCollector.setPartnership(uint256,address).wallet_ (#212) lacks a zero-check on :
- partnershipWallet = wallet_ (#212)
TaxCollector.setRND(uint256,address).wallet_ (#215) lacks a zero-check on :
- rndWallet = wallet_ (#215)
Check that the address is not zero.

Additional information: link

Variable 'VCG.distributeFee().e (#423)' in VCG.distributeFee() (#405-425) potentially used before declaration: DistributeFailed(e) (#423)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in VCG.constructor() (#288-300):
External calls:
- _pair = IFactory(_router.factory()).createPair(WBNB,address(this)) (#291)
State variables written after the call(s):
- _allowances[address(this)][address(_router)] = ~ uint256(0) (#298)
- _mint(_msgSender(),100000000 * 10 ** uint256(_decimals)) (#299)
- _balances[account] += amount (#433)
- _excludedBuyFee[owner()] = true (#295)
- _excludedBuyFee[address(this)] = true (#296)
- _excludedBuyFee[DEAD] = true (#297)
- _excludedSellFee[owner()] = true (#292)
- _excludedSellFee[address(this)] = true (#293)
- _excludedSellFee[DEAD] = true (#294)
- _mint(_msgSender(),100000000 * 10 ** uint256(_decimals)) (#299)
- _totalSupply += amount (#432)
Apply the check-effects-interactions pattern.

Additional information: link

Variable Ownable._owner (#37) is not in mixedCase
Variable Ownable._creator (#38) is not in mixedCase
Function IRouter.WETH() (#85) is not in mixedCase
Variable VCG._tax (#259) is not in mixedCase
Variable VCG._taxDivider (#260) is not in mixedCase
Variable VCG._taxCollector (#261) is not in mixedCase
Variable VCG.DEAD (#270) is not in mixedCase
Variable VCG.ZERO (#271) is not in mixedCase
Variable VCG.ROUTER (#272) is not in mixedCase
Variable VCG.FACTORY (#273) is not in mixedCase
Variable VCG.WBNB (#274) is not in mixedCase
Variable VCG._pair (#275) is not in mixedCase
Variable VCG._router (#276) is not in mixedCase
Variable VCG._excludedBuyFee (#281) is not in mixedCase
Variable VCG._excludedSellFee (#282) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#89) is too similar to IRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#90)
Variable VCG._taxCollector (#261) is too similar to VCG.iTaxCollector (#286)
Prevent variables from having similar names.

Additional information: link

VCG.constructor() (#288-300) uses literals with too many digits:
- _mint(_msgSender(),100000000 * 10 ** uint256(_decimals)) (#299)
VCG.slitherConstructorVariables() (#248-462) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#270)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

VCG.ZERO (#271) is never used in VCG (#248-462)
VCG.FACTORY (#273) is never used in VCG (#248-462)
Remove unused state variables.

Additional information: link

TaxCollector.maxPercent (#206) should be constant
VCG.DEAD (#270) should be constant
VCG.FACTORY (#273) should be constant
VCG.ROUTER (#272) should be constant
VCG.WBNB (#274) should be constant
VCG.ZERO (#271) should be constant
VCG._decimals (#257) should be constant
VCG._name (#255) should be constant
VCG._symbol (#256) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#55-57)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#59-62)
setTeam(uint256,address) should be declared external:
- TaxCollector.setTeam(uint256,address) (#209)
setPartnership(uint256,address) should be declared external:
- TaxCollector.setPartnership(uint256,address) (#212)
setRND(uint256,address) should be declared external:
- TaxCollector.setRND(uint256,address) (#215)
distribute() should be declared external:
- TaxCollector.distribute() (#220-233)
kill() should be declared external:
- TaxCollector.kill() (#235)
setTax(uint256) should be declared external:
- VCG.setTax(uint256) (#262)
setTaxDivider(uint256) should be declared external:
- VCG.setTaxDivider(uint256) (#263)
setTaxCollector(address) should be declared external:
- VCG.setTaxCollector(address) (#264-268)
changeExcludeBuyFee(address) should be declared external:
- VCG.changeExcludeBuyFee(address) (#283)
changeExcludeSellFee(address) should be declared external:
- VCG.changeExcludeSellFee(address) (#284)
name() should be declared external:
- VCG.name() (#304)
symbol() should be declared external:
- VCG.symbol() (#305)
decimals() should be declared external:
- VCG.decimals() (#306)
totalSupply() should be declared external:
- VCG.totalSupply() (#307)
allowance(address,address) should be declared external:
- VCG.allowance(address,address) (#309)
currentBalance() should be declared external:
- VCG.currentBalance() (#310)
contractBalance() should be declared external:
- VCG.contractBalance() (#311)
taxBalance() should be declared external:
- VCG.taxBalance() (#312)
distributeTax() should be declared external:
- VCG.distributeTax() (#313)
setTeamTax(uint256,address) should be declared external:
- VCG.setTeamTax(uint256,address) (#314)
setPartnershipTax(uint256,address) should be declared external:
- VCG.setPartnershipTax(uint256,address) (#315)
setRNDTax(uint256,address) should be declared external:
- VCG.setRNDTax(uint256,address) (#316)
setTaxTransferOwner(address) should be declared external:
- VCG.setTaxTransferOwner(address) (#317)
transfer(address,uint256) should be declared external:
- VCG.transfer(address,uint256) (#318-321)
approve(address,uint256) should be declared external:
- VCG.approve(address,uint256) (#322-325)
transferFrom(address,address,uint256) should be declared external:
- VCG.transferFrom(address,address,uint256) (#326-338)
increaseAllowance(address,uint256) should be declared external:
- VCG.increaseAllowance(address,uint256) (#339-342)
decreaseAllowance(address,uint256) should be declared external:
- VCG.decreaseAllowance(address,uint256) (#343-350)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 6% buy tax and 6% sell tax.
Taxes are low but contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death