A valentines play brought to you by a safe dev
@RichiesCalls
*Degen*
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
ValentInuVal.swapBack() (#327-368) sends eth to arbitrary user
Dangerous calls:
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in ValentInuVal._transferFrom(address,address,uint256) (#268-288):
External calls:
- swapBack() (#277)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#338-344)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
External calls sending eth:
- swapBack() (#277)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#281)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#284)
- amountReceived = takeFee(sender,recipient,amount) (#283)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#314)
Apply the check-effects-interactions pattern.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#142) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#143)
Prevent variables from having similar names.
Additional information: link
ValentInuVal.slitherConstructorVariables() (#183-452) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#187)
ValentInuVal.slitherConstructorVariables() (#183-452) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#188)
ValentInuVal.slitherConstructorVariables() (#183-452) uses literals with too many digits:
- _totalSupply = 1000000 * (10 ** _decimals) (#194)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
ValentInuVal.DEAD (#187) should be constant
ValentInuVal.WBNB (#186) should be constant
ValentInuVal.ZERO (#188) should be constant
ValentInuVal._totalSupply (#194) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
authorize(address) should be declared external:
- Auth.authorize(address) (#94-96)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#101-103)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#122-126)
transferForeignToken(address) should be declared external:
- ValentInuVal.transferForeignToken(address) (#432-436)
isOverLiquified(uint256,uint256) should be declared external:
- ValentInuVal.isOverLiquified(uint256,uint256) (#446-448)
Use the external attribute for functions never called from the contract.
Additional information: link
ValentInuVal.slitherConstructorVariables() (#183-452) performs a multiplication on the result of a division:
-swapThreshold = _totalSupply / 1000 * 1 (#219)
Consider ordering multiplication before division.
Additional information: link
ValentInuVal.swapBack() (#327-368) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
Ensure that all the return values of the function calls are used.
Additional information: link
ValentInuVal.setTxLimit(uint256) (#391-394) should emit an event for:
- _maxTxAmount = amount (#393)
ValentInuVal.setFees(uint256,uint256,uint256,uint256) (#409-415) should emit an event for:
- liquidityFee = _liquidityFee (#410)
- buybackFee = _buybackFee (#411)
- marketingFee = _marketingFee (#412)
- totalFee = _liquidityFee.add(_buybackFee).add(_marketingFee) (#413)
- feeDenominator = _feeDenominator (#414)
Emit an event for critical parameter changes.
Additional information: link
Auth.transferOwnership(address).adr (#122) lacks a zero-check on :
- owner = adr (#123)
ValentInuVal.setFeeReceiver(address,address)._marketingFeeReceiver (#417) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#418)
ValentInuVal.setFeeReceiver(address,address)._buybackFeeReceiver (#417) lacks a zero-check on :
- buybackFeeReceiver = _buybackFeeReceiver (#419)
Check that the address is not zero.
Additional information: link
Reentrancy in ValentInuVal._transferFrom(address,address,uint256) (#268-288):
External calls:
- swapBack() (#277)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#338-344)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
External calls sending eth:
- swapBack() (#277)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
State variables written after the call(s):
- launch() (#279)
- launchedAt = block.number (#388)
Reentrancy in ValentInuVal.constructor() (#223-234):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#225)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#226)
- _balances[_owner] = _totalSupply (#232)
- isFeeExempt[_owner] = true (#229)
- isTxLimitExempt[_owner] = true (#230)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in ValentInuVal._transferFrom(address,address,uint256) (#268-288):
External calls:
- swapBack() (#277)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#338-344)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
External calls sending eth:
- swapBack() (#277)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#315)
- amountReceived = takeFee(sender,recipient,amount) (#283)
- Transfer(sender,recipient,amountReceived) (#286)
Reentrancy in ValentInuVal.constructor() (#223-234):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#225)
Event emitted after the call(s):
- Transfer(address(0),_owner,_totalSupply) (#233)
Reentrancy in ValentInuVal.swapBack() (#327-368):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#338-344)
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
External calls sending eth:
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#358-365)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#366)
Apply the check-effects-interactions pattern.
Additional information: link
ValentInuVal.buyTokens(uint256,address) (#370-381) is never used and should be removed
Remove unused functions.
Additional information: link
ValentInuVal._maxTxAmount (#195) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 1) / 100
ValentInuVal._maxWalletSize (#196) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 2) / 100
ValentInuVal.swapThreshold (#219) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1000 * 1
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Low level call in ValentInuVal.swapBack() (#327-368):
- (MarketingSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#352)
- (buybackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#354)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Function IDEXRouter.WETH() (#137) is not in mixedCase
Parameter ValentInuVal.setFees(uint256,uint256,uint256,uint256)._liquidityFee (#409) is not in mixedCase
Parameter ValentInuVal.setFees(uint256,uint256,uint256,uint256)._buybackFee (#409) is not in mixedCase
Parameter ValentInuVal.setFees(uint256,uint256,uint256,uint256)._marketingFee (#409) is not in mixedCase
Parameter ValentInuVal.setFees(uint256,uint256,uint256,uint256)._feeDenominator (#409) is not in mixedCase
Parameter ValentInuVal.setFeeReceiver(address,address)._marketingFeeReceiver (#417) is not in mixedCase
Parameter ValentInuVal.setFeeReceiver(address,address)._buybackFeeReceiver (#417) is not in mixedCase
Parameter ValentInuVal.setSwapBackSettings(bool,uint256)._enabled (#422) is not in mixedCase
Parameter ValentInuVal.setSwapBackSettings(bool,uint256)._amount (#422) is not in mixedCase
Parameter ValentInuVal.transferForeignToken(address)._token (#432) is not in mixedCase
Variable ValentInuVal.WBNB (#186) is not in mixedCase
Variable ValentInuVal.DEAD (#187) is not in mixedCase
Variable ValentInuVal.ZERO (#188) is not in mixedCase
Constant ValentInuVal._name (#190) is not in UPPER_CASE_WITH_UNDERSCORES
Constant ValentInuVal._symbol (#191) is not in UPPER_CASE_WITH_UNDERSCORES
Constant ValentInuVal._decimals (#192) is not in UPPER_CASE_WITH_UNDERSCORES
Variable ValentInuVal._totalSupply (#194) is not in mixedCase
Variable ValentInuVal._maxTxAmount (#195) is not in mixedCase
Variable ValentInuVal._maxWalletSize (#196) is not in mixedCase
Variable ValentInuVal._balances (#198) is not in mixedCase
Variable ValentInuVal._allowances (#199) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Unable to find website, listings and other project-related information
Young tokens have high risks of scam / price dump / death
Token has no active CoinGecko listing / rank
Token has no active CoinMarketCap listing / rank
Unable to find Twitter account
Telegram account has less than 100 subscribers
Unable to find Blog account (Reddit or Medium)
Unable to find Youtube account
Unable to find Discord account