STC [Shitcoin] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

ShitCoin.distributeAndLiquify(address,address) (#554-611) sends eth to arbitrary user
Dangerous calls:
- devWallet.transfer(bnbForDev) (#589)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in ShitCoin._transfer(address,address,uint256) (#421-455):
External calls:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#629-635)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#454)
- _balances[stakingPool] = _balances[stakingPool].add(fee) (#502)
- _balances[stakingPool] = _balances[stakingPool].add(fee) (#529)
- _balances[address(this)] = _balances[address(this)].add(_devFee) (#511)
- _balances[address(this)] = _balances[address(this)].add(_devFee) (#538)
- _balances[address(this)] = _balances[address(this)].add(_lpFee) (#522)
- _balances[address(this)] = _balances[address(this)].add(_lpFee) (#549)
- _balances[sender] = _balances[sender].sub(amount) (#472)
- _balances[recipient] = _balances[recipient].add(tTransferAmount) (#473)
- _balances[sender] = _balances[sender].sub(amount) (#483)
- _balances[recipient] = _balances[recipient].add(tTransferAmount_scope_1) (#484)
- _balances[sender] = _balances[sender].sub(amount) (#491)
- _balances[recipient] = _balances[recipient].add(amount) (#492)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- lpFeeCounter = lpFeeCounter.add(_lpFee) (#547)
- lpFeeCounter = lpFeeCounter.add(_lpFee) (#520)
Reentrancy in ShitCoin.distributeAndLiquify(address,address) (#554-611):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- lpFeeCounter = 0 (#608)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

ShitCoin.distributeAndLiquify(address,address) (#554-611) performs a multiplication on the result of a division:
-halfLiquidity = lpFeeCounter.div(2) (#572)
-bnbToBeAddedToLiquidity = deltaBalance.mul(halfLiquidity).div(tokenAmountToBeSwapped) (#583-585)
Consider ordering multiplication before division.

Additional information: link

Utils.addLiquidity(address,address,uint256,uint256) (#638-655) ignores return value by dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
Ensure that all the return values of the function calls are used.

Additional information: link

ShitCoin.allowance(address,address).owner (#266) shadows:
- Ownable.owner() (#138-140) (function)
ShitCoin._approve(address,address,uint256).owner (#410) shadows:
- Ownable.owner() (#138-140) (function)
Rename the local variables that shadow another component.

Additional information: link

ShitCoin.setMinTokenToSwap(uint256) (#344-346) should emit an event for:
- minTokenToSwap = _amount (#345)
ShitCoin.setRoute(uint256) (#377-380) should emit an event for:
- maxHolding = _maxHolding (#378)
Emit an event for critical parameter changes.

Additional information: link

ShitCoin.constructor(address,address)._stakingPool (#208) lacks a zero-check on :
- stakingPool = _stakingPool (#210)
ShitCoin.constructor(address,address)._devWallet (#208) lacks a zero-check on :
- devWallet = _devWallet (#211)
ShitCoin.updateAddresses(address,address)._stakingPool (#357) lacks a zero-check on :
- stakingPool = _stakingPool (#364)
ShitCoin.updateAddresses(address,address)._devWallet (#358) lacks a zero-check on :
- devWallet = _devWallet (#365)
ShitCoin.setRoute(IDexRouter,address)._pair (#372) lacks a zero-check on :
- dexPair = _pair (#374)
Check that the address is not zero.

Additional information: link

Reentrancy in ShitCoin._transfer(address,address,uint256) (#421-455):
External calls:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#629-635)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#454)
- devFeeCounter = devFeeCounter.add(_devFee) (#536)
- devFeeCounter = devFeeCounter.add(_devFee) (#509)
Reentrancy in ShitCoin.constructor(address,address) (#208-232):
External calls:
- dexPair = IdexFacotry(_pancakeRouter.factory()).createPair(address(this),_pancakeRouter.WETH()) (#215-218)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#224)
- _isExcludedFromFee[address(this)] = true (#225)
- _isExcludedFromMaxTx[owner()] = true (#228)
- _isExcludedFromMaxTx[address(this)] = true (#229)
- dexRouter = _pancakeRouter (#221)
Reentrancy in ShitCoin.distributeAndLiquify(address,address) (#554-611):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- devFeeCounter = 0 (#609)
Reentrancy in ShitCoin.transferFrom(address,address,uint256) (#284-299):
External calls:
- _transfer(sender,recipient,amount) (#289)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#629-635)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- _transfer(sender,recipient,amount) (#289)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,STC: transfer amount exceeds allowance)) (#290-297)
- _allowances[owner][spender] = amount (#417)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in ShitCoin._transfer(address,address,uint256) (#421-455):
External calls:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#629-635)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
Event emitted after the call(s):
- Transfer(sender,stakingPool,fee) (#504)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,stakingPool,fee) (#531)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_lpFee) (#551)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_lpFee) (#524)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_devFee) (#513)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_devFee) (#540)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,tTransferAmount) (#474)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,tTransferAmount_scope_1) (#485)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,amount) (#494)
- _tokenTransfer(from,to,amount,takeFee) (#454)
Reentrancy in ShitCoin.constructor(address,address) (#208-232):
External calls:
- dexPair = IdexFacotry(_pancakeRouter.factory()).createPair(address(this),_pancakeRouter.WETH()) (#215-218)
Event emitted after the call(s):
- Transfer(address(0),owner(),_totalSupply) (#231)
Reentrancy in ShitCoin.distributeAndLiquify(address,address) (#554-611):
External calls:
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- devWallet.transfer(bnbForDev) (#589)
Event emitted after the call(s):
- SwapAndLiquify(halfLiquidity,bnbToBeAddedToLiquidity,otherHalfLiquidity) (#600-604)
Reentrancy in ShitCoin.transferFrom(address,address,uint256) (#284-299):
External calls:
- _transfer(sender,recipient,amount) (#289)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp + 300) (#629-635)
- Utils.swapTokensForEth(address(dexRouter),tokenAmountToBeSwapped) (#580)
- Utils.addLiquidity(address(dexRouter),owner(),otherHalfLiquidity,bnbToBeAddedToLiquidity) (#593-598)
External calls sending eth:
- _transfer(sender,recipient,amount) (#289)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#418)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,STC: transfer amount exceeds allowance)) (#290-297)
Apply the check-effects-interactions pattern.

Additional information: link

ShitCoin._transfer(address,address,uint256) (#421-455) compares to a boolean constant:
-_isExcludedFromMaxTx[from] == false && _isExcludedFromMaxTx[to] == false (#431-432)
Remove the equality to the boolean constant.

Additional information: link

Pragma version^0.8.9 (#40) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function IDexRouter.WETH() (#87) is not in mixedCase
Parameter ShitCoin.includeOrExcludeFromMaxTx(address,bool)._address (#337) is not in mixedCase
Parameter ShitCoin.setMinTokenToSwap(uint256)._amount (#344) is not in mixedCase
Parameter ShitCoin.setDistributionStatus(bool)._value (#348) is not in mixedCase
Parameter ShitCoin.enableOrDisableFees(bool)._value (#352) is not in mixedCase
Parameter ShitCoin.updateAddresses(address,address)._stakingPool (#357) is not in mixedCase
Parameter ShitCoin.updateAddresses(address,address)._devWallet (#358) is not in mixedCase
Parameter ShitCoin.setRoute(IDexRouter,address)._router (#372) is not in mixedCase
Parameter ShitCoin.setRoute(IDexRouter,address)._pair (#372) is not in mixedCase
Parameter ShitCoin.setRoute(uint256)._maxHolding (#377) is not in mixedCase
Variable ShitCoin._isExcludedFromFee (#167) is not in mixedCase
Variable ShitCoin._isExcludedFromMaxTx (#168) is not in mixedCase
Variable ShitCoin._launchTime (#183) is not in mixedCase
Variable ShitCoin._tradingOpen (#187) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in ShitCoin._transfer(address,address,uint256) (#421-455):
External calls:
- distributeAndLiquify(from,to) (#443)
- devWallet.transfer(bnbForDev) (#589)
External calls sending eth:
- distributeAndLiquify(from,to) (#443)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#454)
- _balances[stakingPool] = _balances[stakingPool].add(fee) (#502)
- _balances[stakingPool] = _balances[stakingPool].add(fee) (#529)
- _balances[address(this)] = _balances[address(this)].add(_devFee) (#511)
- _balances[address(this)] = _balances[address(this)].add(_devFee) (#538)
- _balances[address(this)] = _balances[address(this)].add(_lpFee) (#522)
- _balances[address(this)] = _balances[address(this)].add(_lpFee) (#549)
- _balances[sender] = _balances[sender].sub(amount) (#472)
- _balances[recipient] = _balances[recipient].add(tTransferAmount) (#473)
- _balances[sender] = _balances[sender].sub(amount) (#483)
- _balances[recipient] = _balances[recipient].add(tTransferAmount_scope_1) (#484)
- _balances[sender] = _balances[sender].sub(amount) (#491)
- _balances[recipient] = _balances[recipient].add(amount) (#492)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- devFeeCounter = devFeeCounter.add(_devFee) (#536)
- devFeeCounter = devFeeCounter.add(_devFee) (#509)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- lpFeeCounter = lpFeeCounter.add(_lpFee) (#547)
- lpFeeCounter = lpFeeCounter.add(_lpFee) (#520)
Event emitted after the call(s):
- Transfer(sender,stakingPool,fee) (#504)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,stakingPool,fee) (#531)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_lpFee) (#551)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_lpFee) (#524)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_devFee) (#513)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,address(this),_devFee) (#540)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,tTransferAmount) (#474)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,tTransferAmount_scope_1) (#485)
- _tokenTransfer(from,to,amount,takeFee) (#454)
- Transfer(sender,recipient,amount) (#494)
- _tokenTransfer(from,to,amount,takeFee) (#454)
Reentrancy in ShitCoin.distributeAndLiquify(address,address) (#554-611):
External calls:
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- devFeeCounter = 0 (#609)
- lpFeeCounter = 0 (#608)
Event emitted after the call(s):
- SwapAndLiquify(halfLiquidity,bnbToBeAddedToLiquidity,otherHalfLiquidity) (#600-604)
Reentrancy in ShitCoin.transferFrom(address,address,uint256) (#284-299):
External calls:
- _transfer(sender,recipient,amount) (#289)
- devWallet.transfer(bnbForDev) (#589)
External calls sending eth:
- _transfer(sender,recipient,amount) (#289)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 300) (#647-654)
- devWallet.transfer(bnbForDev) (#589)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,STC: transfer amount exceeds allowance)) (#290-297)
- _allowances[owner][spender] = amount (#417)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#418)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,STC: transfer amount exceeds allowance)) (#290-297)
Apply the check-effects-interactions pattern.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#147-150)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#152-159)
name() should be declared external:
- ShitCoin.name() (#237-239)
symbol() should be declared external:
- ShitCoin.symbol() (#241-243)
decimals() should be declared external:
- ShitCoin.decimals() (#245-247)
totalSupply() should be declared external:
- ShitCoin.totalSupply() (#249-251)
transfer(address,uint256) should be declared external:
- ShitCoin.transfer(address,uint256) (#257-264)
allowance(address,address) should be declared external:
- ShitCoin.allowance(address,address) (#266-273)
approve(address,uint256) should be declared external:
- ShitCoin.approve(address,uint256) (#275-282)
transferFrom(address,address,uint256) should be declared external:
- ShitCoin.transferFrom(address,address,uint256) (#284-299)
increaseAllowance(address,uint256) should be declared external:
- ShitCoin.increaseAllowance(address,uint256) (#301-312)
decreaseAllowance(address,uint256) should be declared external:
- ShitCoin.decreaseAllowance(address,uint256) (#314-328)
setDistributionStatus(bool) should be declared external:
- ShitCoin.setDistributionStatus(bool) (#348-350)
Use the external attribute for functions never called from the contract.

Additional information: link

Redundant expression "this (#120)" inContext (#114-123)
Remove redundant statements if they congest code but offer no value.

Additional information: link

ShitCoin.slitherConstructorVariables() (#162-612) uses literals with too many digits:
- minTokenToSwap = 100000 * 1e8 (#180)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

ShitCoin._decimals (#172) should be constant
ShitCoin._name (#170) should be constant
ShitCoin._symbol (#171) should be constant
ShitCoin._totalSupply (#173) should be constant
ShitCoin.devFeeOnBuying (#191) should be constant
ShitCoin.devFeeOnSelling (#196) should be constant
ShitCoin.liquidityFeeOnBuying (#192) should be constant
ShitCoin.liquidityFeeOnSelling (#197) should be constant
ShitCoin.percentDivider (#182) should be constant
ShitCoin.stakingFeeOnBuying (#190) should be constant
ShitCoin.stakingFeeOnSelling (#195) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Context._msgData() (#119-122) is never used and should be removed
SafeMath.mod(uint256,uint256) (#711-713) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#715-722) is never used and should be removed
Remove unused functions.

Additional information: link

ShitCoin.maxHolding (#181) is set pre-construction with a non-constant function or state variable:
- _totalSupply.mul(42).div(1000)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Average 30d PancakeSwap volume is low.

Average 30d number of PancakeSwap swaps is low.

Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.

Token is deployed only at one blockchain

Contract has 6% buy tax and 9% sell tax.
Taxes are low and contract ownership is renounced.

Unable to find token on CoinGecko

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Token is not listed at Mobula.Finance

Additional information: link

Token has no active CoinGecko listing / rank

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Token has relatively low CoinMarketCap rank