ShibaLottery.claimWeeklyReward(uint64,uint32) (#751-775) ignores return value by SHIB.transfer(msg.sender,prizeLottery.prizeAmount) (#770)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
ShibaLottery.getFee() (#452-455) uses a dangerous strict equality:
- launchedAt == 0 || launchedAt + 1 >= block.number (#453)
Don't use strict equality to determine if an account has enough Ether or tokens.
Additional information: link
Reentrancy in ShibaLottery.weeklyDrawLottery() (#715-743):
External calls:
- SHIB.transfer(devAddress,devAmount) (#734)
- SHIB.transfer(marketingAddress,marketingAmount) (#738)
State variables written after the call(s):
- processingDrawWeeklyLottery = false (#742)
Apply the check-effects-interactions pattern.
Additional information: link
ShibaLottery.approveCake() (#923-926) ignores return value by CAKE.approve(CAKE_VAULT,0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF) (#925)
Ensure that all the return values of the function calls are used.
Additional information: link
ShibaLottery.setFees(uint8,uint8,uint8) (#513-519) should emit an event for:
- totalFee = _feeInDailyPool + _feeInWeeklyPool (#516)
- feeDenominator = _feeDenominator (#517)
Emit an event for critical parameter changes.
Additional information: link
Auth.transferOwnership(address).adr (#179) lacks a zero-check on :
- owner = adr (#180)
Check that the address is not zero.
Additional information: link
Reentrancy in ShibaLottery.weeklyDrawLottery() (#715-743):
External calls:
- SHIB.transfer(devAddress,devAmount) (#734)
- SHIB.transfer(marketingAddress,marketingAmount) (#738)
State variables written after the call(s):
- currentWeeklyLotteryId = currentWeeklyLotteryId + 1 (#741)
- currentWeeklyTicket = 0 (#740)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in ShibaLottery.unstakeCakeAndConvertWeeklyPrize(uint256,uint256,uint256) (#861-905):
External calls:
- vault.leaveStaking(getCakeStaked()) (#865)
- (cakeStakedAmount,rewardDebt) = vault.userInfo(0,(address(this))) (#856)
- router.swapExactTokensForTokensSupportingFeeOnTransferTokens(prizeAmount,0,pathPrize,address(this),block.timestamp) (#876-882)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(buybackAmount,0,pathBuyback,address(this),block.timestamp) (#893-899)
- buyback() (#900)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: balance}(0,path,DEAD,block.timestamp) (#914-919)
External calls sending eth:
- buyback() (#900)
- router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: balance}(0,path,DEAD,block.timestamp) (#914-919)
Event emitted after the call(s):
- Buyback(balance) (#920)
- buyback() (#900)
Apply the check-effects-interactions pattern.
Additional information: link
ShibaLottery.launched() (#496-498) is never used and should be removed
Remove unused functions.
Additional information: link
solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Variable ShibaLottery._allowances (#277) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Variable IPancakeRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#213) is too similar to IPancakeRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#214)
Prevent variables from having similar names.
Additional information: link
ShibaLottery.slitherConstructorVariables() (#254-928) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#264)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
ShibaLottery.BUSD (#266) is never used in ShibaLottery (#254-928)
Remove unused state variables.
Additional information: link
ShibaLottery.weeklyLock (#290) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
getCirculatingSupply() should be declared external:
- ShibaLottery.getCirculatingSupply() (#521-523)
Use the external attribute for functions never called from the contract.
Additional information: link
Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.
Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.
Token is deployed only at one blockchain
Token has only one trading pair
Unable to find PancakeSwap trading pair to compute liquidity.
Unable to find PancakeSwap trading pair to compute volume.
Unable to find PancakeSwap trading pair to compute number of swaps.
Unable to find website, listings and other project-related information
Young tokens have high risks of price dump / death
Token has no active CoinGecko listing / rank
Token has no active CoinMarketCap listing / rank
Unable to find Telegram and Twitter accounts