SHIVA Token

Reentrancy in SHIVA._transfer(address,address,uint256) (#1800-1902):
External calls:
- swapAndSendToFee(marketingTokens) (#1852)
- (success) = recipient.call{value: amount}() (#1291)
- address(_marketingWalletAddress).sendValue(newBalance) (#1909)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1950-1956)
- swapAndLiquify(swapTokens) (#1855)
- (liquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#2003-2010)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1950-1956)
- swapAndSendDividends(sellTokens) (#1858)
- IERC20(BTCB).transfer(address(dividendTracker),dividends) (#2017-2023)
- dividendTracker.distributeBTCBDividends(dividends) (#2018)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1988-1994)
- swapEthForTokens(BuybackAmount) (#1861)
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,deadWallet,block.timestamp.add(300)) (#1968-1973)
- swapTokensForBuyback(TokensforBuyback) (#1879)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1950-1956)
External calls sending eth:
- swapAndSendToFee(marketingTokens) (#1852)
- (success) = recipient.call{value: amount}() (#1291)
- swapAndLiquify(swapTokens) (#1855)
- (liquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,address(0),block.timestamp) (#2003-2010)
- swapEthForTokens(BuybackAmount) (#1861)
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,deadWallet,block.timestamp.add(300)) (#1968-1973)
State variables written after the call(s):
- swapTokensForBuyback(TokensforBuyback) (#1879)
- BuybackAmount += newBalance (#1917)
- super._transfer(from,address(this),fees) (#1884)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#927)
- _balances[recipient] = _balances[recipient].add(amount) (#928)
- super._transfer(from,to,amount) (#1887)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#927)
- _balances[recipient] = _balances[recipient].add(amount) (#928)
Apply the check-effects-interactions pattern.

Additional information: link

SHIVA.swapAndSendDividends(uint256) (#2014-2024) ignores return value by IERC20(BTCB).transfer(address(dividendTracker),dividends) (#2017-2023)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

SHIVA._writeCheckpoint(address,uint32,uint256,uint256) (#2241-2259) uses a dangerous strict equality:
- nCheckpoints > 0 && checkpoints[delegatee][nCheckpoints - 1].fromBlock == blockNumber (#2251)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

SHIVA.updateMaxSaleAmountRate(uint16) (#1613-1618) contains a tautology or contradiction:
- require(bool,string)(_maxSaleAmountRate <= 1000000,SHIVA::updateMaxSaleAmountRate: Max sale amount rate must not exceed the maximum rate.) (#1614)
Fix the incorrect comparison by changing the value type or the comparison.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

SwapEnabled() should be declared external:
- SHIVA.SwapEnabled() (#1721-1723)
Use the external attribute for functions never called from the contract.

Additional information: link

SHIVADividendTracker.getAccountAtIndex(uint256) (#2384-2401) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#2395)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#575) is never used in SafeMathInt (#573-631)
Remove unused state variables.

Additional information: link

Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#1148) is too similar to SHIVADividendTracker.getAccount(address).withdrawableDividends (#2344)
Prevent variables from having similar names.

Additional information: link

Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#1147-1161):
External calls:
- success = IERC20(BTCB).transfer(user,_withdrawableDividend) (#1152)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#1155)
Apply the check-effects-interactions pattern.

Additional information: link

SHIVA._transfer(address,address,uint256).lastProcessedIndex (#1895) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

SHIVA._transfer(address,address,uint256) (#1800-1902) ignores return value by dividendTracker.process(gas) (#1895-1900)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.accumulativeDividendOf(address)._owner (#1189) shadows:
- Ownable._owner (#367) (state variable)
Rename the local variables that shadow another component.

Additional information: link

Variable 'SHIVA._transfer(address,address,uint256).lastProcessedIndex (#1895)' in SHIVA._transfer(address,address,uint256) (#1800-1902) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1896)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in SHIVA.swapTokensForBuyback(uint256) (#1912-1919):
External calls:
- swapTokensForEth(tokens) (#1915)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1950-1956)
State variables written after the call(s):
- BuybackAmount += newBalance (#1917)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in SHIVA.withdrawBNB(address,uint256) (#2035-2042):
External calls:
- address(toAddress).sendValue(amount) (#2040)
Event emitted after the call(s):
- BNBWithdrawn(msg.sender,toAddress,amount) (#2041)
Apply the check-effects-interactions pattern.

Additional information: link

SHIVADividendTracker.canAutoClaim(uint256) (#2403-2409) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#2404)
- block.timestamp.sub(lastClaimTime) >= claimWait (#2408)
Avoid relying on block.timestamp.

Additional information: link

SHIVA.getChainId() (#2266-2270) uses assembly
- INLINE ASM (#2268)
Do not use evm assembly.

Additional information: link

SHIVA.antiWhale(address,address,uint256) (#1514-1528) compares to a boolean constant:
-_excludedFromAntiWhale[sender] == false && _excludedFromAntiWhale[recipient] == false (#1517-1518)
Remove the equality to the boolean constant.

Additional information: link

Different versions of Solidity is used:
- Version used: ['^0.6.12', '^0.6.2']
- ^0.6.12 (#30)
- ^0.6.2 (#111)
- ^0.6.2 (#135)
- ^0.6.2 (#271)
- ^0.6.2 (#288)
- ^0.6.2 (#338)
- ^0.6.2 (#364)
- ^0.6.2 (#420)
- ^0.6.2 (#567)
- ^0.6.2 (#635)
- ^0.6.2 (#651)
- ^0.6.2 (#714)
- ^0.6.2 (#1020)
- ^0.6.2 (#1057)
- ^0.6.2 (#1083)
Use one Solidity version.

Additional information: link

SafeMathInt.mul(int256,int256) (#580-587) is never used and should be removed
Remove unused functions.

Additional information: link

SHIVA.totalFees (#1459) is set pre-construction with a non-constant function or state variable:
- BTCBRewardsFee.add(liquidityFee).add(marketingFee)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.6.2 (#1083) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.functionDelegateCall(address,bytes,string) (#1397-1403):
- (success,returndata) = target.delegatecall(data) (#1401)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Parameter SHIVADividendTracker.getAccount(address)._account (#2339) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#128)" inContext (#123-131)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank