SHIBO [Shiboshi] Token

Reentrancy in Shiboshi._transfer(address,address,uint256) (#811-848):
External calls:
- swapAndLiquify() (#832)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#907)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#882-888)
- swapAndSendToFee(sellTokens) (#834)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#882-888)
External calls sending eth:
- swapAndLiquify() (#832)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
- swapAndSendToFee(sellTokens) (#834)
- address(_marketingWallet).transfer(ethToSend) (#855)
State variables written after the call(s):
- _tOwned[from] -= amount (#838)
- transferAmount = _getValues(amount,from) (#843)
- _tOwned[address(this)] += marketingFee + liquidityFee (#793)
- _tOwned[to] += transferAmount (#846)
- swapping = false (#835)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Shiboshi.setMarketingWallet(address).marketingWallet (#770) lacks a zero-check on :
- _marketingWallet = marketingWallet (#771)
Check that the address is not zero.

Additional information: link

Shiboshi._approve(address,address,uint256).owner (#803) shadows:
- Ownable.owner() (#411-413) (function)
Rename the local variables that shadow another component.

Additional information: link

Shiboshi.setMaxBuySellPercent(uint256) (#782-784) should emit an event for:
- _maxTxAmount = _tTotal * maxTxPercent / 10 ** 2 (#783)
Emit an event for critical parameter changes.

Additional information: link

Reentrancy in Shiboshi.transferFrom(address,address,uint256) (#742-746):
External calls:
- _transfer(sender,recipient,amount) (#743)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#907)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#882-888)
External calls sending eth:
- _transfer(sender,recipient,amount) (#743)
- address(_marketingWallet).transfer(ethToSend) (#855)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#744)
- _allowances[owner][spender] = amount (#807)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Shiboshi.transferFrom(address,address,uint256) (#742-746):
External calls:
- _transfer(sender,recipient,amount) (#743)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
- address(_marketingWallet).sendValue(ethAmount - ethFromLiquidity) (#907)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#882-888)
External calls sending eth:
- _transfer(sender,recipient,amount) (#743)
- address(_marketingWallet).transfer(ethToSend) (#855)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#808)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#744)
Apply the check-effects-interactions pattern.

Additional information: link

Shiboshi.addLiquidity(uint256,uint256) (#892-908) uses timestamp for comparisons
Dangerous comparisons:
- ethAmount - ethFromLiquidity > 0 (#906)
Avoid relying on block.timestamp.

Additional information: link

Address._functionCallWithValue(address,bytes,uint256,string) (#358-379) uses assembly
- INLINE ASM (#371-374)
Do not use evm assembly.

Additional information: link

SafeMath.sub(uint256,uint256,string) (#131-136) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.6 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#358-379):
- (success,returndata) = target.call{value: weiValue}(data) (#362)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable Shiboshi._buyCooldown (#683) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#238)" inContext (#232-241)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in Shiboshi.transferFrom(address,address,uint256) (#742-746):
External calls:
- _transfer(sender,recipient,amount) (#743)
- address(_marketingWallet).transfer(ethToSend) (#855)
External calls sending eth:
- _transfer(sender,recipient,amount) (#743)
- address(_marketingWallet).transfer(ethToSend) (#855)
- (ethFromLiquidity) = uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#897-904)
- (success) = recipient.call{value: amount}() (#296)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#744)
- _allowances[owner][spender] = amount (#807)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#808)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#744)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#527) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#528)
Prevent variables from having similar names.

Additional information: link

Address.sendValue(address,uint256) (#292-298) uses literals with too many digits:
- recipient = address(0x000000000000000000000000000000000000dEaD) (#294)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Shiboshi._tTotal (#672) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

isExcludedFromFee(address) should be declared external:
- Shiboshi.isExcludedFromFee(address) (#799-801)
Use the external attribute for functions never called from the contract.

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank