ShibaPuppy [Shiba Puppy] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

ShibaPuppy.addLiquidity(uint256,uint256) (#857-870) sends eth to arbitrary user
Dangerous calls:
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in ShibaPuppy.transferOwner(address) (#497-515):
External calls:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#848-854)
External calls sending eth:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- _marketingWallet.transfer(((address(this).balance - liquidityBalance) * _marketingRatio) / totalFee) (#835)
- _developmentWallet.transfer(address(this).balance) (#836)
State variables written after the call(s):
- _owner = newOwner (#512)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Variable ShibaPuppy._hasLiqBeenAdded (#403) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#10)" inContext (#4-13)
Remove redundant statements if they congest code but offer no value.

Additional information: link

ShibaPuppy.swapAmount (#398) is set pre-construction with a non-constant function or state variable:
- (_tTotal * 5) / 1000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

ShibaPuppy.swapAndLiquify(uint256) (#816-837) performs a multiplication on the result of a division:
-half = toLiquify / 2 (#823)
-liquidityBalance = (address(this).balance * half) / toSwapForEth (#829)
Consider ordering multiplication before division.

Additional information: link

ShibaPuppy._getValues(address,address,uint256,bool).values (#973) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

ShibaPuppy.addLiquidity(uint256,uint256) (#857-870) ignores return value by dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
Ensure that all the return values of the function calls are used.

Additional information: link

ShibaPuppy.setSwapSettings(uint256,uint256,uint256,uint256) (#688-691) should emit an event for:
- swapThreshold = (_tTotal * thresholdPercent) / thresholdDivisor (#689)
- swapAmount = (_tTotal * amountPercent) / amountDivisor (#690)
Emit an event for critical parameter changes.

Additional information: link

ShibaPuppy.setWallets(address,address).developmentWallet (#693) lacks a zero-check on :
- _developmentWallet = address(developmentWallet) (#695)
Check that the address is not zero.

Additional information: link

Reentrancy in ShibaPuppy.transferFrom(address,address,uint256) (#552-556):
External calls:
- _transfer(sender,recipient,amount) (#553)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#848-854)
External calls sending eth:
- _transfer(sender,recipient,amount) (#553)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- _marketingWallet.transfer(((address(this).balance - liquidityBalance) * _marketingRatio) / totalFee) (#835)
- _developmentWallet.transfer(address(this).balance) (#836)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#554)
- _allowances[sender][spender] = amount (#768)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in ShibaPuppy.transferOwner(address) (#497-515):
External calls:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#848-854)
External calls sending eth:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- _marketingWallet.transfer(((address(this).balance - liquidityBalance) * _marketingRatio) / totalFee) (#835)
- _developmentWallet.transfer(address(this).balance) (#836)
Event emitted after the call(s):
- OwnershipTransferred(_owner,newOwner) (#513)
Apply the check-effects-interactions pattern.

Additional information: link

ShibaPuppy.setLpPair(address,bool) (#580-590) uses timestamp for comparisons
Dangerous comparisons:
- timeSinceLastPair != 0 (#584)
- require(bool,string)(block.timestamp - timeSinceLastPair > 604800,Cannot set a new pair this week!) (#585)
Avoid relying on block.timestamp.

Additional information: link

ShibaPuppy.setExcludedFromReward(address,bool) (#707-727) compares to a boolean constant:
-enabled == false (#715)
Remove the equality to the boolean constant.

Additional information: link

Context._msgData() (#9-12) is never used and should be removed
Remove unused functions.

Additional information: link

Reentrancy in ShibaPuppy.transferOwner(address) (#497-515):
External calls:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- _marketingWallet.transfer(((address(this).balance - liquidityBalance) * _marketingRatio) / totalFee) (#835)
- _developmentWallet.transfer(address(this).balance) (#836)
External calls sending eth:
- _transfer(_owner,newOwner,balanceOf(_owner)) (#509)
- dexRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,DEAD,block.timestamp) (#862-869)
- _marketingWallet.transfer(((address(this).balance - liquidityBalance) * _marketingRatio) / totalFee) (#835)
- _developmentWallet.transfer(address(this).balance) (#836)
State variables written after the call(s):
- _owner = newOwner (#512)
Event emitted after the call(s):
- OwnershipTransferred(_owner,newOwner) (#513)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#182) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#183)
Prevent variables from having similar names.

Additional information: link

ShibaPuppy.slitherConstructorVariables() (#310-1046) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#378)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

ShibaPuppy._previousMaxWalletSize (#394) is never used in ShibaPuppy (#310-1046)
Remove unused state variables.

Additional information: link

ShibaPuppy.startingSupply (#329) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

setSwapAndLiquifyEnabled(bool) should be declared external:
- ShibaPuppy.setSwapAndLiquifyEnabled(bool) (#698-701)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank