SHIBACUP Token

Shibacup.contractSwap(uint256) (#565-597) sends eth to arbitrary user
Dangerous calls:
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Shibacup._transfer(address,address,uint256) (#491-563):
External calls:
- v2Pair_lpPair.sync() (#546)
- contractSwap(contractTokenBalance) (#557)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#579-585)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
External calls sending eth:
- contractSwap(contractTokenBalance) (#557)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
State variables written after the call(s):
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- _tOwned[DEAD] += firePitAmount (#674)
- _tOwned[address(this)] += swpAmt (#678)
- _tOwned[from] -= amount (#648)
- _tOwned[to] += amountReceived (#650)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- contractSwapEnabled = true (#609)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Contract ownership is not renounced (belongs to a wallet)

Shibacup._transfer(address,address,uint256) (#491-563) performs a multiplication on the result of a division:
-rebaseAmounts = deltaTime / (rebaseMinutes) (#517)
-epoch = rebaseAmounts * rebaseTimeInMinutes (#518)
Shibacup._transfer(address,address,uint256) (#491-563) performs a multiplication on the result of a division:
-rebaseAmounts = deltaTime / (rebaseMinutes) (#517)
-autoRebaseLastTriggered += rebaseAmounts * rebaseMinutes (#544)
Shibacup.takeTaxes(address,bool,bool,uint256,uint256) (#656-683) performs a multiplication on the result of a division:
-feeAmount = (amount / masterTaxDivisor) * currentFee (#670)
Shibacup.takeTaxes(address,bool,bool,uint256,uint256) (#656-683) performs a multiplication on the result of a division:
-firePitAmount = (feeAmount / (ratios.total + ratios.firePit)) * ratios.firePit (#671)
Consider ordering multiplication before division.

Additional information: link

Reentrancy in Shibacup.transferOwner(address) (#250-264):
External calls:
- finalizeTransfer(_owner,newOwner,balanceOf(_owner),false,false,true) (#257)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
State variables written after the call(s):
- _owner = newOwner (#261)
Apply the check-effects-interactions pattern.

Additional information: link

Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool).checked (#635) is a local variable never initialized
Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool).check (#636) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool) (#627-654) ignores return value by antiSnipe.checkUser(from,to,amount) (#636-637)
Ensure that all the return values of the function calls are used.

Additional information: link

Shibacup.setSwapSettings(uint256,uint256,uint256,uint256) (#433-438) should emit an event for:
- swapThreshold = (_tTotal * thresholdPercent) / thresholdDivisor (#434)
- swapAmount = (_tTotal * amountPercent) / amountDivisor (#435)
Shibacup.setPriceImpactSwapAmount(uint256) (#440-443) should emit an event for:
- piSwapPercent = priceImpactSwapPercent (#442)
Emit an event for critical parameter changes.

Additional information: link

Shibacup.setOperator(address).newOperator (#275) lacks a zero-check on :
- operator = newOperator (#282)
Check that the address is not zero.

Additional information: link

Shibacup._checkLiquidityAdd(address,address) (#599-612) has external calls inside a loop: antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool) (#627-654) has external calls inside a loop: antiSnipe.checkUser(from,to,amount) (#636-637)
Favor pull over push strategy for external calls.

Additional information: link

Variable 'Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool).check (#636)' in Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool) (#627-654) potentially used before declaration: checked = check (#637)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in Shibacup._checkLiquidityAdd(address,address) (#599-612):
External calls:
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
State variables written after the call(s):
- allowedPresaleExclusion = false (#608)
- contractSwapEnabled = true (#609)
Reentrancy in Shibacup._transfer(address,address,uint256) (#491-563):
External calls:
- v2Pair_lpPair.sync() (#546)
- contractSwap(contractTokenBalance) (#557)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#579-585)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
External calls sending eth:
- contractSwap(contractTokenBalance) (#557)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
State variables written after the call(s):
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- allowedPresaleExclusion = false (#608)
Reentrancy in Shibacup.constructor() (#207-241):
External calls:
- lpPair = IFactoryV2(dexRouter.factory()).createPair(dexRouter.WETH(),address(this)) (#230)
State variables written after the call(s):
- _approve(_owner,address(dexRouter),type()(uint256).max) (#234)
- _allowances[sender][spender] = amount (#315)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#235)
- _allowances[sender][spender] = amount (#315)
- _isExcludedFromFees[_owner] = true (#237)
- _isExcludedFromFees[address(this)] = true (#238)
- _isExcludedFromFees[DEAD] = true (#239)
- _liquidityHolders[_owner] = true (#240)
- lpPairs[lpPair] = true (#231)
- v2Pair_lpPair = IV2Pair(lpPair) (#232)
Reentrancy in Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool) (#627-654):
External calls:
- _checkLiquidityAdd(from,to) (#629)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
State variables written after the call(s):
- _tOwned[from] -= amount (#648)
- _tOwned[to] += amountReceived (#650)
- amountReceived = takeTaxes(from,buy,sell,amount,aSupply) (#649)
- _tOwned[DEAD] += firePitAmount (#674)
- _tOwned[address(this)] += swpAmt (#678)
Reentrancy in Shibacup.setNewRouter(address) (#332-345):
External calls:
- lpPair = IFactoryV2(_newRouter.factory()).createPair(address(this),_newRouter.WETH()) (#337)
State variables written after the call(s):
- _approve(address(this),address(dexRouter),type()(uint256).max) (#344)
- _allowances[sender][spender] = amount (#315)
- dexRouter = _newRouter (#342)
- v2Pair_lpPair = IV2Pair(lpPair) (#343)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Shibacup._checkLiquidityAdd(address,address) (#599-612):
External calls:
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
Event emitted after the call(s):
- ContractSwapEnabledUpdated(true) (#610)
Reentrancy in Shibacup._transfer(address,address,uint256) (#491-563):
External calls:
- v2Pair_lpPair.sync() (#546)
Event emitted after the call(s):
- LogRebase(epoch,_tTotal) (#548)
Reentrancy in Shibacup._transfer(address,address,uint256) (#491-563):
External calls:
- v2Pair_lpPair.sync() (#546)
- contractSwap(contractTokenBalance) (#557)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#579-585)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
External calls sending eth:
- contractSwap(contractTokenBalance) (#557)
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
Event emitted after the call(s):
- ContractSwapEnabledUpdated(true) (#610)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- Transfer(from,DEAD,firePitAmount / aSupply) (#675)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- Transfer(from,address(this),swpAmt / aSupply) (#679)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
- Transfer(from,to,amountReceived / aSupply) (#652)
- finalizeTransfer(from,to,amount,buy,sell,other) (#562)
Reentrancy in Shibacup.constructor() (#207-241):
External calls:
- lpPair = IFactoryV2(dexRouter.factory()).createPair(dexRouter.WETH(),address(this)) (#230)
Event emitted after the call(s):
- Approval(sender,spender,amount) (#316)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#235)
- Approval(sender,spender,amount) (#316)
- _approve(_owner,address(dexRouter),type()(uint256).max) (#234)
Reentrancy in Shibacup.finalizeTransfer(address,address,uint256,bool,bool,bool) (#627-654):
External calls:
- _checkLiquidityAdd(from,to) (#629)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
Event emitted after the call(s):
- Transfer(from,DEAD,firePitAmount / aSupply) (#675)
- amountReceived = takeTaxes(from,buy,sell,amount,aSupply) (#649)
- Transfer(from,address(this),swpAmt / aSupply) (#679)
- amountReceived = takeTaxes(from,buy,sell,amount,aSupply) (#649)
- Transfer(from,to,amountReceived / aSupply) (#652)
Reentrancy in Shibacup.setNewRouter(address) (#332-345):
External calls:
- lpPair = IFactoryV2(_newRouter.factory()).createPair(address(this),_newRouter.WETH()) (#337)
Event emitted after the call(s):
- Approval(sender,spender,amount) (#316)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#344)
Reentrancy in Shibacup.transferOwner(address) (#250-264):
External calls:
- finalizeTransfer(_owner,newOwner,balanceOf(_owner),false,false,true) (#257)
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#607)
- antiSnipe.checkUser(from,to,amount) (#636-637)
Event emitted after the call(s):
- OwnershipTransferred(oldOwner,newOwner) (#262)
Apply the check-effects-interactions pattern.

Additional information: link

Shibacup.setLpPair(address,bool) (#347-359) uses timestamp for comparisons
Dangerous comparisons:
- timeSinceLastPair != 0 (#352)
- require(bool,string)(block.timestamp - timeSinceLastPair > 259200,3 Day cooldown.!) (#353)
Shibacup.setAutoRebaseEnabled(bool) (#451-459) uses timestamp for comparisons
Dangerous comparisons:
- autoRebaseInitializationStamp == 0 (#454)
Shibacup._transfer(address,address,uint256) (#491-563) uses timestamp for comparisons
Dangerous comparisons:
- autoRebaseEnabled && block.timestamp >= autoRebaseLastTriggered + rebaseMinutes (#512-513)
- deltaTimeFromInitialization < (31536000) (#520)
- deltaTimeFromInitialization >= (31536000) (#522)
- deltaTimeFromInitialization >= ((15 * 31536000) / 10) (#524)
- deltaTimeFromInitialization >= (7 * 31536000) (#526)
- i < rebaseAmounts (#533)
Avoid relying on block.timestamp.

Additional information: link

Shibacup._checkLiquidityAdd(address,address) (#599-612) has costly operations inside a loop:
- _hasLiqBeenAdded = true (#603)
Shibacup._checkLiquidityAdd(address,address) (#599-612) has costly operations inside a loop:
- antiSnipe = AntiSnipe(address(this)) (#605)
Shibacup._checkLiquidityAdd(address,address) (#599-612) has costly operations inside a loop:
- allowedPresaleExclusion = false (#608)
Shibacup._checkLiquidityAdd(address,address) (#599-612) has costly operations inside a loop:
- contractSwapEnabled = true (#609)
Use a local variable to hold the loop computation result.

Additional information: link

Shibacup._rTotal (#123) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
Shibacup._aSupply (#124) is set pre-construction with a non-constant function or state variable:
- _rTotal / _tTotal
Shibacup.swapThreshold (#175) is set pre-construction with a non-constant function or state variable:
- (_tTotal * 1) / 10000
Shibacup.swapAmount (#176) is set pre-construction with a non-constant function or state variable:
- (_tTotal * 5) / 10000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version>=0.6.0<0.9.0 (#2) is too complex
solc-0.8.15 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Shibacup.contractSwap(uint256) (#565-597):
- (success,None) = _taxWallets.treasury.call{gas: 35000,value: treasuryAmount}() (#592)
- (success,None) = _taxWallets.insurance.call{gas: 35000,value: insuranceAmount}() (#595)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IRouter01.WETH() (#33) is not in mixedCase
Parameter Shibacup.setProtectionSettings(bool,bool)._antiSnipe (#400) is not in mixedCase
Parameter Shibacup.setProtectionSettings(bool,bool)._antiBlock (#400) is not in mixedCase
Constant Shibacup.startingSupply (#116) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup._name (#117) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup._symbol (#118) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup._decimals (#119) is not in UPPER_CASE_WITH_UNDERSCORES
Variable Shibacup._taxRates (#139-143) is not in mixedCase
Variable Shibacup._ratios (#145-150) is not in mixedCase
Constant Shibacup.maxBuyTaxes (#152) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup.maxSellTaxes (#153) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup.maxTransferTaxes (#154) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup.maxRoundtripTax (#155) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup.masterTaxDivisor (#156) is not in UPPER_CASE_WITH_UNDERSCORES
Variable Shibacup.v2Pair_lpPair (#160) is not in mixedCase
Variable Shibacup._taxWallets (#168-171) is not in mixedCase
Variable Shibacup._hasLiqBeenAdded (#180) is not in mixedCase
Constant Shibacup.maxSupply (#183) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Shibacup._rateDecimals (#189) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Variable IRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#45) is too similar to IRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#46)
Prevent variables from having similar names.

Additional information: link

Shibacup.slitherConstructorConstantVariables() (#99-685) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#161)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Shibacup.rebaseTimeInMinutes (#187) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

transfer(address,uint256) should be declared external:
- Shibacup.transfer(address,uint256) (#301-304)
approve(address,uint256) should be declared external:
- Shibacup.approve(address,uint256) (#306-309)
isExcludedFromFees(address) should be declared external:
- Shibacup.isExcludedFromFees(address) (#367-369)
getCirculatingSupply() should be declared external:
- Shibacup.getCirculatingSupply() (#383-385)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Token is relatively young, but twitter if very old (probably it's fake).