SGC [SafeGame Cash] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

RewardStaker.reward(address,uint256) (#2170-2179) sends eth to arbitrary user
Dangerous calls:
- (success) = reciever.call{gas: 3000,value: amount}() (#2172)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#1128-1144):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1133)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#1136)
Apply the check-effects-interactions pattern.

Additional information: link

SafeGameCash.getHoldTimeFromStakingStart(address) (#1411-1417) uses a dangerous strict equality:
- _stakingStartTimeForAddress[addr] == 0 (#1412)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

SafeGameCash.deployTimeStamp (#1290) is written in both
deployTimeStamp = block.timestamp (#1367)
deployTimeStamp = block.timestamp (#1373)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.

SafeGameCash._transfer(address,address,uint256) (#1614-1866) performs a multiplication on the result of a division:
-rewardStaker.reward(_holderMap.keys[_loopIndexRewardStakerCheck],_getBNBbalanceFromToken(balanceOf(_holderMap.keys[_loopIndexRewardStakerCheck]).div(1000).mul(30))) (#1846)
Consider ordering multiplication before division.

Additional information: link

SafeGameCash._transfer(address,address,uint256).distributionAmount (#1737) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

SafeGameCash.addLiquidity(uint256,uint256) (#1930-1945) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1936-1943)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.constructor(string,string)._symbol (#1085) shadows:
- ERC20._symbol (#731) (state variable)
Rename the local variables that shadow another component.

Additional information: link

RewardStaker.reward(address,uint256).reciever (#2170) lacks a zero-check on :
- (success) = reciever.call{gas: 3000,value: amount}() (#2172)
Check that the address is not zero.

Additional information: link

SafeGameCash._transfer(address,address,uint256) (#1614-1866) has external calls inside a loop: rewardStaker.reward(_holderMap.keys[_loopIndexRewardStakerCheck],_getBNBbalanceFromToken(balanceOf(_holderMap.keys[_loopIndexRewardStakerCheck]).div(1000).mul(30))) (#1846)
Favor pull over push strategy for external calls.

Additional information: link

Variable 'SafeGameCash._transfer(address,address,uint256).claims (#1799)' in SafeGameCash._transfer(address,address,uint256) (#1614-1866) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1800)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in SafeGameCash.swapAndLiquify(uint256) (#1878-1899):
External calls:
- swapTokensForEth(half) (#1890)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1912-1918)
- addLiquidity(otherHalf,newBalance) (#1896)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1936-1943)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1896)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1936-1943)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1896)
- _allowances[owner][spender] = amount (#974)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in SafeGameCash.swapAndSendDividends(uint256) (#1947-1955):
External calls:
- swapTokensForEth(tokens) (#1948)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1912-1918)
- (success) = address(dividendTracker).call{value: dividends}() (#1950)
External calls sending eth:
- (success) = address(dividendTracker).call{value: dividends}() (#1950)
Event emitted after the call(s):
- SendDividends(tokens,dividends) (#1953)
Apply the check-effects-interactions pattern.

Additional information: link

DividendTracker.process() (#2109-2142) uses timestamp for comparisons
Dangerous comparisons:
- canAutoClaim(lastClaimTimes[account]) && withdrawableDividendOf(account) > 0 (#2130)
Avoid relying on block.timestamp.

Additional information: link

SafeGameCash._transfer(address,address,uint256) (#1614-1866) has costly operations inside a loop:
- _loopIndexRewardStakerCheck = 0 (#1857)
Use a local variable to hold the loop computation result.

Additional information: link

SafeMathInt.mul(int256,int256) (#208-215) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version^0.6.2 (#1227) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in RewardStaker.reward(address,uint256) (#2170-2179):
- (success) = reciever.call{gas: 3000,value: amount}() (#2172)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Event RewardStakerwithdrawBNB(address,uint256) (#2160) is not in CapWords
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#279)" inContext (#273-282)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in SafeGameCash._transfer(address,address,uint256) (#1614-1866):
External calls:
- swapAndSendToFee(address(marketingWallet),marketingTokensAcummulated) (#1713)
- toWalletAddress.transfer(toSend) (#1927)
- swapAndSendToFee(address(gameWallet),gameTokensAcummulated) (#1715)
- toWalletAddress.transfer(toSend) (#1927)
External calls sending eth:
- swapAndSendToFee(address(marketingWallet),marketingTokensAcummulated) (#1713)
- toWalletAddress.transfer(toSend) (#1927)
- swapAndSendToFee(address(gameWallet),gameTokensAcummulated) (#1715)
- toWalletAddress.transfer(toSend) (#1927)
- swapAndLiquify(liquidityAcummulated) (#1718)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#1936-1943)
- swapAndSendDividends(sellTokens) (#1722)
- (success) = address(dividendTracker).call{value: dividends}() (#1950)
State variables written after the call(s):
- swapAndSendDividends(sellTokens) (#1722)
- _allowances[owner][spender] = amount (#974)
- super._transfer(from,address(this),marketingAmount + gameAmount + liquidityAmount + distributionAmount) (#1783)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#908)
- _balances[recipient] = _balances[recipient].add(amount) (#909)
- super._transfer(from,DEAD,burnAmount) (#1784)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#908)
- _balances[recipient] = _balances[recipient].add(amount) (#909)
- super._transfer(from,to,amount) (#1791)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#908)
- _balances[recipient] = _balances[recipient].add(amount) (#909)
- _loopIndexRewardStakerCheck ++ (#1855)
- _loopIndexRewardStakerCheck = 0 (#1857)
- _recievedRewardForAddress[to] = 0 (#1812)
- _recievedRewardForAddress[from] = 0 (#1818)
- _recievedRewardForAddress[_holderMap.keys[_loopIndexRewardStakerCheck]] = 3 (#1829)
- _recievedRewardForAddress[_holderMap.keys[_loopIndexRewardStakerCheck]] = 6 (#1835)
- _recievedRewardForAddress[_holderMap.keys[_loopIndexRewardStakerCheck]] = 9 (#1841)
- _recievedRewardForAddress[_holderMap.keys[_loopIndexRewardStakerCheck]] = 0 (#1848)
- _stakingStartTimeForAddress[to] = block.timestamp (#1811)
- _stakingStartTimeForAddress[from] = block.timestamp + 31104000 (#1817)
- _stakingStartTimeForAddress[_holderMap.keys[_loopIndexRewardStakerCheck]] = block.timestamp (#1847)
- distributionAcummulated = 0 (#1723)
- distributionAcummulated += distributionAmount (#1788)
- gameTokensAcummulated += gameAmount (#1786)
- liquidityAcummulated += liquidityAmount (#1787)
- marketingTokensAcummulated += marketingAmount (#1785)
- swapping = false (#1724)
- tradingEnabledTimestamp = block.timestamp (#1864)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#975)
- swapAndSendDividends(sellTokens) (#1722)
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1800)
- SendDividends(tokens,dividends) (#1953)
- swapAndSendDividends(sellTokens) (#1722)
- Transfer(sender,recipient,amount) (#910)
- super._transfer(from,DEAD,burnAmount) (#1784)
- Transfer(sender,recipient,amount) (#910)
- super._transfer(from,to,amount) (#1791)
- Transfer(sender,recipient,amount) (#910)
- super._transfer(from,address(this),marketingAmount + gameAmount + liquidityAmount + distributionAmount) (#1783)
Apply the check-effects-interactions pattern.

Additional information: link

Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#1129) is too similar to DividendTracker.getAccount(address).withdrawableDividends (#2023)
Prevent variables from having similar names.

Additional information: link

DividendTracker.process() (#2109-2142) uses literals with too many digits:
- gasleft()() > 100000 && iterations < numberOfTokenHolders (#2121)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Ownable.coreTeam (#290) is never used in RewardStaker (#2157-2181)
Remove unused state variables.

Additional information: link

SafeGameCash.swapTokensAtAmount (#1251) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

reward(address,uint256) should be declared external:
- RewardStaker.reward(address,uint256) (#2170-2179)
Use the external attribute for functions never called from the contract.

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank