SD [StarDust] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

StarDust.addLiquidity(uint256,uint256) (#2195-2207) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#2198-2205)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#1426-1442):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1431)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#1434)
Apply the check-effects-interactions pattern.

Additional information: link

SafeToken.withdraw(address,uint256) (#1748-1751) ignores return value by IERC20(_token).transfer(safeManager,_amount) (#1750)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

StarDust.swapAndLiquify(uint256) (#2130-2165) performs a multiplication on the result of a division:
-MarketingAmount = deltaBalance.sub(bnbToAddLiquidityWith).div(totalFees.sub(liquidityFee)).mul(MarketingFee) (#2154)
Consider ordering multiplication before division.

Additional information: link

StarDust._transfer(address,address,uint256).iterations (#2121) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

StarDust.addLiquidity(uint256,uint256) (#2195-2207) ignores return value by uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#2198-2205)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.constructor(string,string)._symbol (#1383) shadows:
- ERC20._symbol (#846) (state variable)
Rename the local variables that shadow another component.

Additional information: link

StarDust.setSWapToensAtAmount(uint256) (#1965-1967) should emit an event for:
- swapTokensAtAmount = _newAmount (#1966)
Emit an event for critical parameter changes.

Additional information: link

StarDust.setMarketingWallet(address)._newMarketingWallet (#1873) lacks a zero-check on :
- MarketingWallet = _newMarketingWallet (#1874)
Check that the address is not zero.

Additional information: link

Variable 'StarDust._transfer(address,address,uint256).lastProcessedIndex (#2121)' in StarDust._transfer(address,address,uint256) (#2070-2128) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#2122)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in StarDustDividendTracker.processAccount(address,bool) (#1724-1734):
External calls:
- amount = _withdrawDividendOfUser(account) (#1725)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#1431)
State variables written after the call(s):
- lastClaimTimes[account] = block.timestamp (#1728)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in StarDust.swapAndLiquify(uint256) (#2130-2165):
External calls:
- swapTokensForBnb(toSwap,address(this)) (#2143)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,_to,block.timestamp) (#2180-2186)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#2152)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#2198-2205)
- (success) = address(dividendTracker).call{value: dividends}() (#2158)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#2152)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#2198-2205)
- MarketingWallet.transfer(MarketingAmount) (#2155)
- (success) = address(dividendTracker).call{value: dividends}() (#2158)
Event emitted after the call(s):
- SendDividends(toSwap - tokensToAddLiquidityWith,dividends) (#2161)
- SwapAndLiquify(tokensToAddLiquidityWith,deltaBalance) (#2164)
Apply the check-effects-interactions pattern.

Additional information: link

StarDustDividendTracker.canAutoClaim(uint256) (#1652-1658) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#1653)
- block.timestamp.sub(lastClaimTime) >= claimWait (#1657)
Avoid relying on block.timestamp.

Additional information: link

StarDust.swapAndSendBNBToMarketing(uint256) (#2190-2192) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.4 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in StarDust.swapAndLiquify(uint256) (#2130-2165):
- (success) = address(dividendTracker).call{value: dividends}() (#2158)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable StarDust.MarketingWallet (#1807) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in StarDust.swapAndLiquify(uint256) (#2130-2165):
External calls:
- MarketingWallet.transfer(MarketingAmount) (#2155)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#2152)
- uniswapV2Router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#2198-2205)
- MarketingWallet.transfer(MarketingAmount) (#2155)
- (success) = address(dividendTracker).call{value: dividends}() (#2158)
Event emitted after the call(s):
- SendDividends(toSwap - tokensToAddLiquidityWith,dividends) (#2161)
- SwapAndLiquify(tokensToAddLiquidityWith,deltaBalance) (#2164)
Apply the check-effects-interactions pattern.

Additional information: link

Variable StarDust.BNBRewardsFee (#1802) is too similar to StarDust.setFee(uint256,uint256,uint256)._bnbRewardFee (#1857)
Prevent variables from having similar names.

Additional information: link

StarDust.slitherConstructorVariables() (#1787-2210) uses literals with too many digits:
- gasForProcessing = 300000 (#1810)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

setSwapAndLiquifyEnabled(bool) should be declared external:
- StarDust.setSwapAndLiquifyEnabled(bool) (#2065-2068)
Use the external attribute for functions never called from the contract.

Additional information: link

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to crawl data from the website

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted from CoinGecko

Additional information: link

Unable to find token contract audit

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Young tokens have high risks of price dump / death

Token has relatively low CoinMarketCap rank