$RVLVR [Revolver] Token

RevolverToken.buyBackAndBurn(uint256) (#1810-1831) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,marketingWallet,block.timestamp.add(300)) (#1819-1824)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in RevolverToken.buyBackAndBurn(uint256) (#1810-1831):
External calls:
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,marketingWallet,block.timestamp.add(300)) (#1819-1824)
State variables written after the call(s):
- _burn(marketingWallet,swappedBalance) (#1828)
- _balances[account] = _balances[account].sub(amount,Rev20: burn amount exceeds balance) (#432)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

RevolverToken.rand() (#1647-1663) uses a dangerous strict equality:
- randNumber == 0 (#1657)
Don't use strict equality to determine if an account has enough Ether or tokens.

Additional information: link

Contract locking ether found:
Contract RevolverDividendTracker (#1891-2107) has payable functions:
- DividendPayingToken.receive() (#588-589)
But does not have a function to withdraw the ether
Remove the payable attribute or add a withdraw function.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ticker ($RVLVR) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

RevolverToken._transfer(address,address,uint256) (#1676-1776) performs a multiplication on the result of a division:
-swapAndSendrevolverDividends(sellTokens.div(10 ** 2).mul(rand())) (#1739)
Consider ordering multiplication before division.

Additional information: link

Reentrancy in RevolverToken.whitelistPresale(address,address) (#1395-1402):
External calls:
- revolverDividendTracker.excludeFromDividends(_presaleAddress) (#1397)
- revolverDividendTracker.excludeFromDividends(_routerAddress) (#1400)
State variables written after the call(s):
- excludeFromFees(_routerAddress,true) (#1401)
- isExcludedFromFees[account] = excluded (#1548)
Apply the check-effects-interactions pattern.

Additional information: link

RevolverToken._transfer(address,address,uint256).lastProcessedIndex (#1769) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

RevolverToken.addLiquidity(uint256,uint256) (#1794-1808) ignores return value by uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#1800-1807)
Ensure that all the return values of the function calls are used.

Additional information: link

DividendPayingToken.accumulativeDividendOf(address)._owner (#678) shadows:
- Ownable._owner (#54) (state variable)
Rename the local variables that shadow another component.

Additional information: link

RevolverToken.updateBuyBackAndLiquidityFee(uint8) (#1534-1538) should emit an event for:
- buyBackAndLiquidityFee = newFee (#1536)
- totalFees = buyBackAndLiquidityFee.add(revolverDividendRewardsFee).add(marketingFee) (#1537)
Emit an event for critical parameter changes.

Additional information: link

RevolverDividendTracker.setDividendTokenAddress(address).newToken (#1924) lacks a zero-check on :
- dividendToken = newToken (#1925)
Check that the address is not zero.

Additional information: link

Variable 'RevolverToken._transfer(address,address,uint256).lastProcessedIndex (#1769)' in RevolverToken._transfer(address,address,uint256) (#1676-1776) potentially used before declaration: ProcessedrevolverDividendTracker(iterations,claims,lastProcessedIndex,true,gas,msg.sender) (#1770)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Reentrancy in RevolverToken.whitelistPresale(address,address) (#1395-1402):
External calls:
- revolverDividendTracker.excludeFromDividends(_presaleAddress) (#1397)
State variables written after the call(s):
- excludeFromFees(_presaleAddress,true) (#1398)
- isExcludedFromFees[account] = excluded (#1548)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in RevolverToken.whitelistPresale(address,address) (#1395-1402):
External calls:
- revolverDividendTracker.excludeFromDividends(_presaleAddress) (#1397)
- revolverDividendTracker.excludeFromDividends(_routerAddress) (#1400)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1550)
- excludeFromFees(_routerAddress,true) (#1401)
Apply the check-effects-interactions pattern.

Additional information: link

RevolverDividendTracker.canAutoClaim(uint256) (#2023-2029) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#2024)
- block.timestamp.sub(lastClaimTime) >= claimWait (#2028)
Avoid relying on block.timestamp.

Additional information: link

RevolverToken.setMarketingEnabled(bool) (#1490-1503) compares to a boolean constant:
-_enabled == false (#1492)
Remove the equality to the boolean constant.

Additional information: link

SafeMathInt.mul(int256,int256) (#1220-1228) is never used and should be removed
Remove unused functions.

Additional information: link

solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Parameter RevolverDividendTracker.getAccount(address)._account (#1959) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#36)" inContext (#30-39)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Reentrancy in RevolverToken._transfer(address,address,uint256) (#1676-1776):
External calls:
- transferToWallet(address(marketingWallet),marketingPortion) (#1719)
- recipient.transfer(amount) (#1878)
External calls sending eth:
- transferToWallet(address(marketingWallet),marketingPortion) (#1719)
- recipient.transfer(amount) (#1878)
- buyBackAndBurn(buyBackBalance.div(10 ** 2).mul(rand())) (#1727)
- uniswapV2Router.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,marketingWallet,block.timestamp.add(300)) (#1819-1824)
- swapAndLiquify(contractTokenBalance.div(totalFees).mul(buyBackAndLiquidityFee)) (#1733)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,marketingWallet,block.timestamp) (#1800-1807)
State variables written after the call(s):
- swapAndSendrevolverDividends(sellTokens.div(10 ** 2).mul(rand())) (#1739)
- _allowances[owner][spender] = amount (#454)
- super._transfer(from,address(this),fees) (#1758)
- _balances[sender] = _balances[sender].sub(amount,Rev20: transfer amount exceeds balance) (#392)
- _balances[recipient] = _balances[recipient].add(amount) (#393)
- super._transfer(from,to,amount) (#1761)
- _balances[sender] = _balances[sender].sub(amount,Rev20: transfer amount exceeds balance) (#392)
- _balances[recipient] = _balances[recipient].add(amount) (#393)
- swapping = false (#1742)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#455)
- swapAndSendrevolverDividends(sellTokens.div(10 ** 2).mul(rand())) (#1739)
- ProcessedrevolverDividendTracker(iterations,claims,lastProcessedIndex,true,gas,msg.sender) (#1770)
- SendDividends(amount) (#1886)
- swapAndSendrevolverDividends(sellTokens.div(10 ** 2).mul(rand())) (#1739)
- Transfer(sender,recipient,amount) (#394)
- super._transfer(from,address(this),fees) (#1758)
- Transfer(sender,recipient,amount) (#394)
- super._transfer(from,to,amount) (#1761)
Apply the check-effects-interactions pattern.

Additional information: link

Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#633) is too similar to RevolverDividendTracker.getAccount(address).withdrawableDividends (#1964)
Prevent variables from having similar names.

Additional information: link

RevolverDividendTracker.getAccountAtIndex(uint256) (#2004-2021) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#2015)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

DividendPayingToken.lastAmount (#564) is never used in RevolverDividendTracker (#1891-2107)
Remove unused state variables.

Additional information: link

RevolverToken.deadAddress (#1278) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

process(uint256) should be declared external:
- RevolverDividendTracker.process(uint256) (#2048-2093)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Token has relatively low CoinGecko rank