RonaldMCD [Ronald McDonald] Token

RonaldMcdonald.swapBack() (#434-471) sends eth to arbitrary user
Dangerous calls:
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in RonaldMcdonald._transfer(address,address,uint256) (#295-358):
External calls:
- swapBack() (#354)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- swapBack() (#354)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
State variables written after the call(s):
- _tokenTransfer(sender,recipient,amount) (#356)
- _rOwned[address(this)] = _rOwned[address(this)] + (rLiquidity) + (rMarketing) (#395)
- _rOwned[sender] = _rOwned[sender] - (rAmount) (#385)
- _rOwned[recipient] = _rOwned[recipient] + (rTransferAmount) (#386)
- _tokenTransfer(sender,recipient,amount) (#356)
- _rTotal = _rTotal - (rFee) (#396)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

RonaldMcdonald.slitherConstructorVariables() (#132-602) performs a multiplication on the result of a division:
-_maxTxAmount = _tTotal / 190 * 1 (#173)
RonaldMcdonald.slitherConstructorVariables() (#132-602) performs a multiplication on the result of a division:
-_maxWalletSize = _tTotal / 190 * 1 (#174)
RonaldMcdonald.slitherConstructorVariables() (#132-602) performs a multiplication on the result of a division:
-swapThreshold = _tTotal / 3000 * 1 (#222)
Consider ordering multiplication before division.

Additional information: link

RonaldMcdonald.swapBack() (#434-471) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
Ensure that all the return values of the function calls are used.

Additional information: link

RonaldMcdonald._approve(address,address,uint256).owner (#288) shadows:
- Ownable.owner (#29) (state variable)
Rename the local variables that shadow another component.

Additional information: link

RonaldMcdonald.setOperator(address)._operator (#523) lacks a zero-check on :
- operator = _operator (#524)
RonaldMcdonald.setFeeReceiver(address)._marketingFeeReceiver (#534) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#535)
Check that the address is not zero.

Additional information: link

Reentrancy in RonaldMcdonald._transfer(address,address,uint256) (#295-358):
External calls:
- swapBack() (#354)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- swapBack() (#354)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
State variables written after the call(s):
- _tokenTransfer(sender,recipient,amount) (#356)
- _tFeeTotal = _tFeeTotal + (tFee) (#397)
- _tokenTransfer(sender,recipient,amount) (#356)
- isSniper[recipient] = true (#374)
Reentrancy in RonaldMcdonald.constructor() (#230-249):
External calls:
- pair = IDEXFactory(router.factory()).createPair(address(this),router.WETH()) (#232)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#233)
- _isExcludedFromFee[owner] = true (#243)
- _isExcludedFromFee[address(this)] = true (#244)
- _isExcludedFromFee[marketingFeeReceiver] = true (#245)
- _rOwned[msg.sender] = _rTotal (#247)
- buyFee.liquidityFee = 2 (#235)
- buyFee.marketingFee = 6 (#236)
- buyFee.taxFee = 2 (#237)
- sellFee.liquidityFee = 2 (#239)
- sellFee.marketingFee = 6 (#240)
- sellFee.taxFee = 2 (#241)
Reentrancy in RonaldMcdonald.transferFrom(address,address,uint256) (#270-274):
External calls:
- _transfer(sender,recipient,amount) (#271)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- _transfer(sender,recipient,amount) (#271)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
State variables written after the call(s):
- _approve(sender,msg.sender,_allowances[sender][msg.sender] - (amount)) (#272)
- _allowances[owner][spender] = amount (#291)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in RonaldMcdonald._transfer(address,address,uint256) (#295-358):
External calls:
- swapBack() (#354)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- swapBack() (#354)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
Event emitted after the call(s):
- SniperCaught(recipient) (#375)
- _tokenTransfer(sender,recipient,amount) (#356)
- Transfer(sender,recipient,tTransferAmount) (#388)
- _tokenTransfer(sender,recipient,amount) (#356)
Reentrancy in RonaldMcdonald.constructor() (#230-249):
External calls:
- pair = IDEXFactory(router.factory()).createPair(address(this),router.WETH()) (#232)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_tTotal) (#248)
Reentrancy in RonaldMcdonald.swapBack() (#434-471):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#469)
Reentrancy in RonaldMcdonald.transferFrom(address,address,uint256) (#270-274):
External calls:
- _transfer(sender,recipient,amount) (#271)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#445-451)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
External calls sending eth:
- _transfer(sender,recipient,amount) (#271)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#292)
- _approve(sender,msg.sender,_allowances[sender][msg.sender] - (amount)) (#272)
Apply the check-effects-interactions pattern.

Additional information: link

Ownable.Ownershipunlock() (#64-69) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp > _lockTime,Contract is locked until 7 days) (#66)
RonaldMcdonald._transfer(address,address,uint256) (#295-358) uses timestamp for comparisons
Dangerous comparisons:
- ! launched() && recipient == pair (#300)
RonaldMcdonald.launched() (#412-414) uses timestamp for comparisons
Dangerous comparisons:
- launchedAt != 0 (#413)
Avoid relying on block.timestamp.

Additional information: link

Pragma version^0.8.9 (#3) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.9 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function Ownable.Ownershiplock(uint256) (#57-62) is not in mixedCase
Function Ownable.Ownershipunlock() (#64-69) is not in mixedCase
Function IDEXRouter.WETH() (#82) is not in mixedCase
Parameter RonaldMcdonald.setOperator(address)._operator (#523) is not in mixedCase
Parameter RonaldMcdonald.setSwapBackSettings(bool,uint256)._enabled (#528) is not in mixedCase
Parameter RonaldMcdonald.setSwapBackSettings(bool,uint256)._swapThreshold (#528) is not in mixedCase
Parameter RonaldMcdonald.setFeeReceiver(address)._marketingFeeReceiver (#534) is not in mixedCase
Parameter RonaldMcdonald.setMaxWallet(uint256)._maxWallet (#573) is not in mixedCase
Parameter RonaldMcdonald.setMaxTX(uint256)._maxTX (#580) is not in mixedCase
Function RonaldMcdonald.ClearStuckBalance() (#589-593) is not in mixedCase
Parameter RonaldMcdonald.transferForeignToken(address)._token (#595) is not in mixedCase
Constant RonaldMcdonald._tTotal (#161) is not in UPPER_CASE_WITH_UNDERSCORES
Constant RonaldMcdonald._name (#165) is not in UPPER_CASE_WITH_UNDERSCORES
Constant RonaldMcdonald._symbol (#166) is not in UPPER_CASE_WITH_UNDERSCORES
Constant RonaldMcdonald._decimals (#167) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Reentrancy in RonaldMcdonald.ClearStuckBalance() (#589-593):
External calls:
- address(marketingFeeReceiver).transfer(contractBalance) (#591)
Event emitted after the call(s):
- StuckBalanceSent(contractBalance,marketingFeeReceiver) (#592)
Reentrancy in RonaldMcdonald._transfer(address,address,uint256) (#295-358):
External calls:
- swapBack() (#354)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
External calls sending eth:
- swapBack() (#354)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
State variables written after the call(s):
- _tokenTransfer(sender,recipient,amount) (#356)
- _rOwned[address(this)] = _rOwned[address(this)] + (rLiquidity) + (rMarketing) (#395)
- _rOwned[sender] = _rOwned[sender] - (rAmount) (#385)
- _rOwned[recipient] = _rOwned[recipient] + (rTransferAmount) (#386)
- _tokenTransfer(sender,recipient,amount) (#356)
- _rTotal = _rTotal - (rFee) (#396)
- _tokenTransfer(sender,recipient,amount) (#356)
- _tFeeTotal = _tFeeTotal + (tFee) (#397)
- _tokenTransfer(sender,recipient,amount) (#356)
- isSniper[recipient] = true (#374)
Event emitted after the call(s):
- SniperCaught(recipient) (#375)
- _tokenTransfer(sender,recipient,amount) (#356)
- Transfer(sender,recipient,tTransferAmount) (#388)
- _tokenTransfer(sender,recipient,amount) (#356)
Reentrancy in RonaldMcdonald.swapBack() (#434-471):
External calls:
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
External calls sending eth:
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#469)
Reentrancy in RonaldMcdonald.transferForeignToken(address) (#595-600):
External calls:
- address(marketingFeeReceiver).transfer(_contractBalance) (#598)
Event emitted after the call(s):
- ForeignTokenTransfer(_token,_contractBalance) (#599)
Reentrancy in RonaldMcdonald.transferFrom(address,address,uint256) (#270-274):
External calls:
- _transfer(sender,recipient,amount) (#271)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
External calls sending eth:
- _transfer(sender,recipient,amount) (#271)
- address(marketingFeeReceiver).transfer(amountBNBMarketing) (#457)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,marketingFeeReceiver,block.timestamp) (#461-468)
State variables written after the call(s):
- _approve(sender,msg.sender,_allowances[sender][msg.sender] - (amount)) (#272)
- _allowances[owner][spender] = amount (#291)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#292)
- _approve(sender,msg.sender,_allowances[sender][msg.sender] - (amount)) (#272)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#87) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#88)
Variable RonaldMcdonald._transferStandard(address,address,uint256).rTransferAmount (#384) is too similar to RonaldMcdonald._calculateTokenValues(uint256).tTransferAmount (#484)
Variable RonaldMcdonald._transferStandard(address,address,uint256).rTransferAmount (#384) is too similar to RonaldMcdonald._getValues(uint256).tTransferAmount (#475)
Variable RonaldMcdonald._transferStandard(address,address,uint256).rTransferAmount (#384) is too similar to RonaldMcdonald._transferStandard(address,address,uint256).tTransferAmount (#384)
Variable RonaldMcdonald._calculateRateValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#493) is too similar to RonaldMcdonald._calculateTokenValues(uint256).tTransferAmount (#484)
Variable RonaldMcdonald._calculateRateValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#493) is too similar to RonaldMcdonald._getValues(uint256).tTransferAmount (#475)
Variable RonaldMcdonald._getValues(uint256).rTransferAmount (#476) is too similar to RonaldMcdonald._calculateTokenValues(uint256).tTransferAmount (#484)
Variable RonaldMcdonald._calculateRateValues(uint256,uint256,uint256,uint256,uint256).rTransferAmount (#493) is too similar to RonaldMcdonald._transferStandard(address,address,uint256).tTransferAmount (#384)
Variable RonaldMcdonald._getValues(uint256).rTransferAmount (#476) is too similar to RonaldMcdonald._getValues(uint256).tTransferAmount (#475)
Variable RonaldMcdonald._getValues(uint256).rTransferAmount (#476) is too similar to RonaldMcdonald._transferStandard(address,address,uint256).tTransferAmount (#384)
Prevent variables from having similar names.

Additional information: link

RonaldMcdonald.slitherConstructorVariables() (#132-602) uses literals with too many digits:
- marketingFeeReceiver = 0x0000000000000000000000000000000000000000 (#205)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

RonaldMcdonald._tOwned (#153) is never used in RonaldMcdonald (#132-602)
Remove unused state variables.

Additional information: link

RonaldMcdonald.snipeBlocks (#213) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#47-51)
getUnlockTime() should be declared external:
- Ownable.getUnlockTime() (#53-55)
Ownershiplock(uint256) should be declared external:
- Ownable.Ownershiplock(uint256) (#57-62)
Ownershipunlock() should be declared external:
- Ownable.Ownershipunlock() (#64-69)
transfer(address,uint256) should be declared external:
- RonaldMcdonald.transfer(address,uint256) (#260-263)
approve(address,uint256) should be declared external:
- RonaldMcdonald.approve(address,uint256) (#265-268)
transferFrom(address,address,uint256) should be declared external:
- RonaldMcdonald.transferFrom(address,address,uint256) (#270-274)
transferForeignToken(address) should be declared external:
- RonaldMcdonald.transferForeignToken(address) (#595-600)
Use the external attribute for functions never called from the contract.

Additional information: link

Attempt to swap token was unsuccessful. For some reason it is untradeable. If token is not in presale stage and is not traded outside PancakeSwap, then it's a scam

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find code repository for the project

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank