RIV2 [RiseUpV2] Token

RiseUpV2.swapBack(uint256) (#1671-1712) sends eth to arbitrary user
Dangerous calls:
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in DividendPayingToken._withdrawDividendOfUser(address) (#719-735):
External calls:
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#724)
State variables written after the call(s):
- withdrawnDividends[user] = withdrawnDividends[user].sub(_withdrawableDividend) (#727)
Reentrancy in RiseUpV2._transfer(address,address,uint256) (#1609-1669):
External calls:
- swapBack(contractTokenBalance) (#1634)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokensToLiquify,0,path,address(this),block.timestamp) (#1680-1686)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
External calls sending eth:
- swapBack(contractTokenBalance) (#1634)
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1652)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#505)
- _balances[recipient] = _balances[recipient].add(amount) (#506)
- super._transfer(from,to,amount) (#1656)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#505)
- _balances[recipient] = _balances[recipient].add(amount) (#506)
Apply the check-effects-interactions pattern.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Contract ownership is not renounced (belongs to a wallet)

RiseUpV2._transfer(address,address,uint256).lastProcessedIndex (#1664) is a local variable never initialized
RiseUpV2._transfer(address,address,uint256).claims (#1664) is a local variable never initialized
RiseUpV2._transfer(address,address,uint256).iterations (#1664) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

RiseUpV2.claim() (#1578-1580) ignores return value by dividendTracker.processAccount(address(msg.sender),false) (#1579)
RiseUpV2._transfer(address,address,uint256) (#1609-1669) ignores return value by dividendTracker.process(gas) (#1664-1667)
Ensure that all the return values of the function calls are used.

Additional information: link

Variable 'RiseUpV2._transfer(address,address,uint256).iterations (#1664)' in RiseUpV2._transfer(address,address,uint256) (#1609-1669) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1665)
Variable 'RiseUpV2._transfer(address,address,uint256).claims (#1664)' in RiseUpV2._transfer(address,address,uint256) (#1609-1669) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1665)
Variable 'RiseUpV2._transfer(address,address,uint256).lastProcessedIndex (#1664)' in RiseUpV2._transfer(address,address,uint256) (#1609-1669) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1665)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

Redundant expression "this (#221)" inContext (#215-224)
Remove redundant statements if they congest code but offer no value.

Additional information: link

setMarketPairStatus(address,bool) should be declared external:
- RiseUpV2.setMarketPairStatus(address,bool) (#1479-1481)
get(IterableMapping.Map,address) should be declared external:
- IterableMapping.get(IterableMapping.Map,address) (#879-881)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#435-443)
getKeyAtIndex(IterableMapping.Map,uint256) should be declared external:
- IterableMapping.getKeyAtIndex(IterableMapping.Map,uint256) (#890-892)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#854-857)
updateGasForProcessing(uint256) should be declared external:
- RiseUpV2.updateGasForProcessing(uint256) (#1542-1547)
decimals() should be declared external:
- ERC20.decimals() (#372-374)
dividendOf(address) should be declared external:
- DividendPayingToken.dividendOf(address) (#741-743)
getIndexOfKey(IterableMapping.Map,address) should be declared external:
- IterableMapping.getIndexOfKey(IterableMapping.Map,address) (#883-888)
withdrawableDividendOf(address) should be declared external:
- RiseUpV2.withdrawableDividendOf(address) (#1565-1567)
setBuyBackWallet(address) should be declared external:
- RiseUpV2.setBuyBackWallet(address) (#1517-1519)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#476-479)
symbol() should be declared external:
- ERC20.symbol() (#355-357)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#398-401)
process(uint256) should be declared external:
- RiseUpV2DividendTracker.process(uint256) (#1093-1138)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#457-460)
setMarketingWallet(address) should be declared external:
- RiseUpV2.setMarketingWallet(address) (#1513-1515)
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#894-896)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#863-867)
name() should be declared external:
- ERC20.name() (#347-349)
setDevWallet(address) should be declared external:
- RiseUpV2.setDevWallet(address) (#1521-1523)
blacklistAddress(address,bool) should be declared external:
- RiseUpV2.blacklistAddress(address,bool) (#1531-1533)
dividendTokenBalanceOf(address) should be declared external:
- RiseUpV2.dividendTokenBalanceOf(address) (#1569-1571)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#417-420)
getAccountAtIndex(uint256) should be declared external:
- RiseUpV2DividendTracker.getAccountAtIndex(uint256) (#1049-1066)
updateUniswapV2Router(address) should be declared external:
- RiseUpV2.updateUniswapV2Router(address) (#1525-1529)
withdrawDividend() should be declared external:
- DividendPayingToken.withdrawDividend() (#713-715)
- RiseUpV2DividendTracker.withdrawDividend() (#957-959)
withdrawnDividendOf(address) should be declared external:
- DividendPayingToken.withdrawnDividendOf(address) (#755-757)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#406-408)
Use the external attribute for functions never called from the contract.

Additional information: link

Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#720) is too similar to RiseUpV2DividendTracker.getAccount(address).withdrawableDividends (#1009)
Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#1227) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#1228)
Prevent variables from having similar names.

Additional information: link

Reentrancy in RiseUpV2.swapBack(uint256) (#1671-1712):
External calls:
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
External calls sending eth:
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
Event emitted after the call(s):
- SendDividends(tDividends,bnbForReflection) (#1709)
Reentrancy in RiseUpV2._transfer(address,address,uint256) (#1609-1669):
External calls:
- swapBack(contractTokenBalance) (#1634)
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
External calls sending eth:
- swapBack(contractTokenBalance) (#1634)
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1652)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#505)
- _balances[recipient] = _balances[recipient].add(amount) (#506)
- super._transfer(from,to,amount) (#1656)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#505)
- _balances[recipient] = _balances[recipient].add(amount) (#506)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1665)
- Transfer(sender,recipient,amount) (#507)
- super._transfer(from,to,amount) (#1656)
- Transfer(sender,recipient,amount) (#507)
- super._transfer(from,address(this),fees) (#1652)
Apply the check-effects-interactions pattern.

Additional information: link

DividendPayingToken.constructor(string,string)._name (#676) shadows:
- ERC20._name (#327) (state variable)
DividendPayingToken.constructor(string,string)._symbol (#676) shadows:
- ERC20._symbol (#328) (state variable)
Rename the local variables that shadow another component.

Additional information: link

RiseUpV2.setMaxTxAMount(uint256) (#1582-1584) should emit an event for:
- maxTxAmount = amount (#1583)
RiseUpV2.setSellTaxes(uint256,uint256,uint256,uint256) (#1492-1499) should emit an event for:
- _rewardsFeeOnSell = newRewardsFee (#1493)
- _devFeeOnSell = newDevFee (#1495)
- _buyBackFeeOnSell = newBuyBackFee (#1496)
- _totalTaxIfSelling = _rewardsFeeOnSell.add(_marketingFeeOnSell).add(_devFeeOnSell).add(_buyBackFeeOnSell) (#1498)
RiseUpV2.changeWalletLimit(uint256) (#1586-1588) should emit an event for:
- walletMax = newLimit (#1587)
RiseUpV2.setBuyTaxes(uint256,uint256,uint256,uint256) (#1483-1490) should emit an event for:
- _totalTaxIfBuying = _rewardsFeeOnBuy.add(_marketingFeeOnBuy).add(_devFeeOnBuy).add(_buyBackFeeOnBuy) (#1489)
Emit an event for critical parameter changes.

Additional information: link

RiseUpV2.setMarketingWallet(address).wallet (#1513) lacks a zero-check on :
- _marketingWallet = address(wallet) (#1514)
RiseUpV2.setBuyBackWallet(address).wallet (#1517) lacks a zero-check on :
- _buyBackWallet = address(wallet) (#1518)
RiseUpV2.setDevWallet(address).wallet (#1521) lacks a zero-check on :
- _devWallet = address(wallet) (#1522)
Check that the address is not zero.

Additional information: link

DividendPayingToken._withdrawDividendOfUser(address) (#719-735) has external calls inside a loop: (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#724)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in RiseUpV2DividendTracker.processAccount(address,bool) (#1140-1150):
External calls:
- amount = _withdrawDividendOfUser(account) (#1141)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#724)
State variables written after the call(s):
- lastClaimTimes[account] = block.timestamp (#1144)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in RiseUpV2._transfer(address,address,uint256) (#1609-1669):
External calls:
- swapBack(contractTokenBalance) (#1634)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokensToLiquify,0,path,address(this),block.timestamp) (#1680-1686)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
- dividendTracker.setBalance(address(from),balanceOf(from)) (#1658)
- dividendTracker.setBalance(address(to),balanceOf(to)) (#1659)
- dividendTracker.process(gas) (#1664-1667)
External calls sending eth:
- swapBack(contractTokenBalance) (#1634)
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1665)
Reentrancy in RiseUpV2.swapBack(uint256) (#1671-1712):
External calls:
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokensToLiquify,0,path,address(this),block.timestamp) (#1680-1686)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
External calls sending eth:
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
Event emitted after the call(s):
- SendDividends(tDividends,bnbForReflection) (#1709)
Reentrancy in RiseUpV2DividendTracker.processAccount(address,bool) (#1140-1150):
External calls:
- amount = _withdrawDividendOfUser(account) (#1141)
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#724)
Event emitted after the call(s):
- Claim(account,amount,automatic) (#1145)
Reentrancy in RiseUpV2.processDividendTracker(uint256) (#1573-1576):
External calls:
- (iterations,claims,lastProcessedIndex) = dividendTracker.process(gas) (#1574)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,false,gas,tx.origin) (#1575)
Reentrancy in RiseUpV2._transfer(address,address,uint256) (#1609-1669):
External calls:
- swapBack(contractTokenBalance) (#1634)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokensToLiquify,0,path,address(this),block.timestamp) (#1680-1686)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
External calls sending eth:
- swapBack(contractTokenBalance) (#1634)
- address(_marketingWallet).transfer(bnbForMarketing) (#1696)
- address(_buyBackWallet).transfer(bnbForBuyBack) (#1699)
- address(_devWallet).transfer(bnbForDev) (#1702)
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#507)
- super._transfer(from,to,amount) (#1656)
- Transfer(sender,recipient,amount) (#507)
- super._transfer(from,address(this),fees) (#1652)
Apply the check-effects-interactions pattern.

Additional information: link

RiseUpV2DividendTracker.canAutoClaim(uint256) (#1068-1074) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#1069)
- block.timestamp.sub(lastClaimTime) >= claimWait (#1073)
RiseUpV2DividendTracker.getAccount(address) (#1004-1047) uses timestamp for comparisons
Dangerous comparisons:
- nextClaimTime > block.timestamp (#1044-1046)
Avoid relying on block.timestamp.

Additional information: link

SafeMathInt.div(int256,int256) (#166-172) is never used and should be removed
SafeMathInt.abs(int256) (#195-198) is never used and should be removed
SafeMathInt.mul(int256,int256) (#154-161) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#141-144) is never used and should be removed
Context._msgData() (#220-223) is never used and should be removed
SafeMath.mod(uint256,uint256) (#125-127) is never used and should be removed
DividendPayingToken._transfer(address,address,uint256) (#775-781) is never used and should be removed
Remove unused functions.

Additional information: link

Low level call in DividendPayingToken._withdrawDividendOfUser(address) (#719-735):
- (success) = user.call{gas: 3000,value: _withdrawableDividend}() (#724)
Low level call in RiseUpV2.swapBack(uint256) (#1671-1712):
- (success) = address(dividendTracker).call{value: bnbForReflection}() (#1706)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable RiseUpV2._totalTaxIfBuying (#1383) is not in mixedCase
Variable RiseUpV2._buyBackWallet (#1365) is not in mixedCase
Variable RiseUpV2._buyBackFeeOnSell (#1381) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#1185) is not in mixedCase
Variable RiseUpV2._buyBackFeeOnBuy (#1376) is not in mixedCase
Variable RiseUpV2._totalTaxIfSelling (#1384) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#1202) is not in mixedCase
Variable RiseUpV2._rewardsFeeOnBuy (#1373) is not in mixedCase
Constant DividendPayingToken.magnitude (#656) is not in UPPER_CASE_WITH_UNDERSCORES
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#1184) is not in mixedCase
Variable RiseUpV2._devWallet (#1364) is not in mixedCase
Parameter DividendPayingToken.dividendOf(address)._owner (#741) is not in mixedCase
Variable RiseUpV2._rewardsFeeOnSell (#1378) is not in mixedCase
Parameter RiseUpV2DividendTracker.getAccount(address)._account (#1004) is not in mixedCase
Parameter DividendPayingToken.withdrawnDividendOf(address)._owner (#755) is not in mixedCase
Parameter DividendPayingToken.withdrawableDividendOf(address)._owner (#748) is not in mixedCase
Variable RiseUpV2._marketingFeeOnBuy (#1374) is not in mixedCase
Variable RiseUpV2._marketingFeeOnSell (#1379) is not in mixedCase
Function IUniswapV2Router01.WETH() (#1222) is not in mixedCase
Variable RiseUpV2._devFeeOnBuy (#1375) is not in mixedCase
Variable RiseUpV2._marketingWallet (#1363) is not in mixedCase
Parameter DividendPayingToken.accumulativeDividendOf(address)._owner (#765) is not in mixedCase
Variable RiseUpV2._devFeeOnSell (#1380) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

RiseUpV2DividendTracker.getAccountAtIndex(uint256) (#1049-1066) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#1060)
RiseUpV2.slitherConstructorVariables() (#1355-1715) uses literals with too many digits:
- gasForProcessing = 300000 (#1387)
RiseUpV2.updateGasForProcessing(uint256) (#1542-1547) uses literals with too many digits:
- require(bool,string)(newValue >= 200000 && newValue <= 750000,RiseUpV2: gasForProcessing must be between 200,000 and 750,000) (#1543)
RiseUpV2.constructor() (#1419-1475) uses literals with too many digits:
- dividendTracker.excludeFromDividends(0x000000000000000000000000000000000000dEaD) (#1445)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#149) is never used in SafeMathInt (#147-205)
Remove unused state variables.

Additional information: link

Contract has 11% buy tax and 12% sell tax.
Taxes are suspiciously high (over 10%) and contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Token was delisted (assigned to inactive / untracked listing) from CoinMarketCap

Additional information: link

Unable to find token contract audit

Unable to find audit link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Token has no active CoinMarketCap listing / rank

Token has a considerable age, but average PancakeSwap 30d trading volume is low

Token has relatively low CoinGecko rank