RDFi [RapiDefi] Token

RapiDefi.swapBack() (#481-495) sends eth to arbitrary user
Dangerous calls:
- rdfiTreasury.deposit{value: address(this).balance}() (#494)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

RapiDefi.emergencyWithdrawTokens(address) (#578-581) ignores return value by tokenIB20.transfer(msg.sender,tokenIB20.balanceOf(address(this))) (#580)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Reentrancy in RapiDefi._transferFrom(address,address,uint256) (#376-425):
External calls:
- swapBack() (#407)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#486-492)
- rdfiTreasury.deposit{value: address(this).balance}() (#494)
External calls sending eth:
- swapBack() (#407)
- rdfiTreasury.deposit{value: address(this).balance}() (#494)
State variables written after the call(s):
- _basicTransfer(address(this),DEAD,taxBurnAmount) (#409)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#432-435)
- _balances[recipient] = _balances[recipient].add(amount) (#436)
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#413-416)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#421)
- amountReceived = takeFee(sender,amount,recipient) (#418-420)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#460)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

RapiDefi.setSwapBackSettings(bool,uint256,uint256) (#516-528) should emit an event for:
- swapThreshold = _amount * 10 ** 9 (#526)
Emit an event for critical parameter changes.

Additional information: link

Reentrancy in RapiDefi.constructor() (#283-308):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#289)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#290)
- _balances[msg.sender] = _totalSupply (#306)
- isFeeExempt[msg.sender] = true (#293)
- isFeeExempt[DEAD] = true (#294)
- isFeeExempt[address(this)] = true (#295)
- isMaxWalletExempt[msg.sender] = true (#298)
- isMaxWalletExempt[DEAD] = true (#299)
- isMaxWalletExempt[address(this)] = true (#300)
- isMaxWalletExempt[pair] = true (#301)
- pairs[pair] = true (#304)
Apply the check-effects-interactions pattern.

Additional information: link

RapiDefi.slitherConstructorVariables() (#225-583) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#229)
RapiDefi.slitherConstructorVariables() (#225-583) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#230)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

Auth.transferOwnership(address).adr (#186) lacks a zero-check on :
- owner = adr (#187)
Check that the address is not zero.

Additional information: link

Reentrancy in RapiDefi._transferFrom(address,address,uint256) (#376-425):
External calls:
- swapBack() (#407)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(swapThreshold,0,path,address(this),block.timestamp) (#486-492)
- rdfiTreasury.deposit{value: address(this).balance}() (#494)
External calls sending eth:
- swapBack() (#407)
- rdfiTreasury.deposit{value: address(this).balance}() (#494)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#437)
- _basicTransfer(address(this),DEAD,taxBurnAmount) (#409)
- Transfer(sender,address(this),feeAmount) (#461)
- amountReceived = takeFee(sender,amount,recipient) (#418-420)
- Transfer(sender,recipient,amountReceived) (#423)
Reentrancy in RapiDefi.constructor() (#283-308):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#289)
Event emitted after the call(s):
- Transfer(address(0),msg.sender,_totalSupply) (#307)
Apply the check-effects-interactions pattern.

Additional information: link

RapiDefi._maxWalletToken (#239) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 2) / 100
RapiDefi.swapThreshold (#272) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 2) / 1000
RapiDefi.taxBurnAmount (#274) is set pre-construction with a non-constant function or state variable:
- swapThreshold.div(10)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.10 (#32) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.10 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in RapiDefi.emergencyWithdraw() (#571-576):
- (success) = address(msg.sender).call{value: address(this).balance}() (#572-574)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Parameter RapiDefi.setSwapBackSettings(bool,uint256,uint256)._enabled (#517) is not in mixedCase
Parameter RapiDefi.setSwapBackSettings(bool,uint256,uint256)._amount (#518) is not in mixedCase
Parameter RapiDefi.setSwapBackSettings(bool,uint256,uint256)._taxBurnAmount (#519) is not in mixedCase
Parameter RapiDefi.setFeesOn(bool)._feesOn (#540) is not in mixedCase
Variable RapiDefi.WBNB (#228) is not in mixedCase
Variable RapiDefi.DEAD (#229) is not in mixedCase
Variable RapiDefi.ZERO (#230) is not in mixedCase
Constant RapiDefi._name (#232) is not in UPPER_CASE_WITH_UNDERSCORES
Constant RapiDefi._symbol (#233) is not in UPPER_CASE_WITH_UNDERSCORES
Constant RapiDefi._decimals (#234) is not in UPPER_CASE_WITH_UNDERSCORES
Variable RapiDefi._totalSupply (#236) is not in mixedCase
Variable RapiDefi._maxWalletToken (#239) is not in mixedCase
Variable RapiDefi._balances (#241) is not in mixedCase
Variable RapiDefi._allowances (#242) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

RapiDefi.DEAD (#229) should be constant
RapiDefi.WBNB (#228) should be constant
RapiDefi.ZERO (#230) should be constant
RapiDefi._totalSupply (#236) should be constant
RapiDefi.feeDenominator (#260) should be constant
RapiDefi.totalSellFee (#258) should be constant
RapiDefi.totalTransferFee (#259) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

authorize(address) should be declared external:
- Auth.authorize(address) (#158-160)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#165-167)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#186-190)
approve(address,uint256) should be declared external:
- RapiDefi.approve(address,uint256) (#345-353)
getCirculatingSupply() should be declared external:
- RapiDefi.getCirculatingSupply() (#530-532)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract has 3% buy tax and 5% sell tax.
Taxes are low but contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap liquidity is low.

Average 30d PancakeSwap volume is low.

Average 30d number of PancakeSwap swaps is low.

Number of Binance Smart Chain (BSC) token holders is low.

Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find Telegram link on the website

Unable to find Twitter link on the website

Token is not listed at Mobula.Finance

Additional information: link

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of scam / price dump / death

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death