Pera Finance is a multi-layered and sustainable trading & yield farming protocol integrated with a fully-decentralized daily trading competition.
PERA.depositLPtoken(uint256) (#798-815) ignores return value by BEP20(lpTokenAddress).transferFrom(msg.sender,address(this),_amount) (#812)
PERA.emergencyWithdraw(uint256) (#848-857) ignores return value by BEP20(lpTokenAddress).transfer(msg.sender,user.userLPamount) (#851)
PERA.withdraw(uint256) (#860-879) ignores return value by BEP20(lpTokenAddress).transfer(msg.sender,_amount) (#873)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
Contract ownership is not renounced (belongs to a wallet)
PERA.updateLPMultiplier(uint256) (#291-295) contains a tautology or contradiction:
- require(bool)(newLPMultiplier >= 0 && newLPMultiplier <= 200) (#293)
PERA.updateTCMultiplier(uint256) (#300-304) contains a tautology or contradiction:
- require(bool)(newTCMultiplier >= 0 && newTCMultiplier <= 100) (#302)
Fix the incorrect comparison by changing the value type or the comparison.
Additional information: link
PERA.addLPToken(address)._addr (#317) lacks a zero-check on :
- lpTokenAddress = _addr (#319)
Check that the address is not zero.
Additional information: link
PERA._transfer(address,address,uint256) (#355-429) performs a multiplication on the result of a division:
-tenthousandthofamonut = _value.div(10000) (#369)
-totalRewardforTC[_bnum] += uint256(tenthousandthofamonut.mul(tradingCompFee)) (#377)
PERA._transfer(address,address,uint256) (#355-429) performs a multiplication on the result of a division:
-tenthousandthofamonut = _value.div(10000) (#369)
-FeeRewPoolLP += uint256(tenthousandthofamonut.mul(liqproviderFee)) (#381)
PERA._transfer(address,address,uint256) (#355-429) performs a multiplication on the result of a division:
-tenthousandthofamonut = _value.div(10000) (#369)
-totalOut = uint256(tenthousandthofamonut.mul(tradingCompFee)) + uint256(tenthousandthofamonut.mul(holderFee)) + uint256(tenthousandthofamonut.mul(liqproviderFee)) (#385)
PERA._transfer(address,address,uint256) (#355-429) performs a multiplication on the result of a division:
-tenthousandthofamonut = _value.div(10000) (#369)
-includedRewards = tenthousandthofamonut.mul(holderFee) (#406)
PERA.calculateUserTCreward(address,uint256) (#655-689) performs a multiplication on the result of a division:
-rewardFee = rewardFee.mul(rewardRate).div(100) (#680)
-rewardFee = rewardFee.mul(51 + (7 * rDayDifference)).div(100) (#683)
PERA.calculateUserTCreward(address,uint256) (#655-689) performs a multiplication on the result of a division:
-rewardEmission = dailyRewardForTC.mul(TCRewardMultiplier).mul(rewardRate).div(1000) (#677)
-rewardEmission = rewardEmission.mul(51 + (7 * rDayDifference)).div(100) (#684)
PERA.calculateUserTCreward(address,uint256) (#655-689) performs a multiplication on the result of a division:
-rDayDifference = (block.number.sub(genesisBlock.add(_bnum.mul(BlockSizeForTC)))).div(BlockSizeForTC) (#661)
-traderRewardEligible = traderReward.mul(51 + (7 * rDayDifference)).div(100) (#685)
PERA.pendingTCreward(address,uint256) (#692-716) performs a multiplication on the result of a division:
-rewardFee = rewardFee.mul(rewardRate).div(100) (#708)
-rewardFee = rewardFee.mul(51 + (7 * rDayDifference)).div(100) (#710)
PERA.pendingTCreward(address,uint256) (#692-716) performs a multiplication on the result of a division:
-rewardEmission = dailyRewardForTC.mul(TCRewardMultiplier).mul(rewardRate).div(1000) (#705)
-rewardEmission = rewardEmission.mul(51 + (7 * rDayDifference)).div(100) (#711)
PERA.pendingTCreward(address,uint256) (#692-716) performs a multiplication on the result of a division:
-rDayDifference = (block.number.sub(genesisBlock.add(_Vbnum.mul(BlockSizeForTC)))).div(BlockSizeForTC) (#696)
-traderRewardEligible = traderReward.mul(51 + (7 * rDayDifference)).div(100) (#712)
Consider ordering multiplication before division.
Additional information: link
Reentrancy in PERA.depositLPtoken(uint256) (#798-815):
External calls:
- BEP20(lpTokenAddress).transferFrom(msg.sender,address(this),_amount) (#812)
State variables written after the call(s):
- user.userReflectedLP = user.userLPamount.mul(LPRate).div(1e12) (#814)
Reentrancy in PERA.emergencyWithdraw(uint256) (#848-857):
External calls:
- BEP20(lpTokenAddress).transfer(msg.sender,user.userLPamount) (#851)
State variables written after the call(s):
- user.userLPamount = 0 (#852)
- user.userReflectedLP = 0 (#853)
Reentrancy in PERA.withdraw(uint256) (#860-879):
External calls:
- BEP20(lpTokenAddress).transfer(msg.sender,_amount) (#873)
State variables written after the call(s):
- FeeRewPoolLP = 0 (#876)
- user.userReflectedLP = user.userLPamount.mul(LPRate).div(1e12) (#878)
Apply the check-effects-interactions pattern.
Additional information: link
PERA.updateLastTrader(uint256,uint256,address).minIndex (#537) is a local variable never initialized
PERA.isTopTrader(uint256,address).checkTopTrader (#571) is a local variable never initialized
PERA.topTradersList(uint256,uint256,address).minIndex (#555) is a local variable never initialized
PERA.findTraderIndex(uint256,address).checkIndex (#582) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
Additional information: link
PERA.updateHolderFee(uint256) (#264-268) should emit an event for:
- holderFee = newHolderFee (#267)
PERA.updateLPStakerFee(uint256) (#273-277) should emit an event for:
- liqproviderFee = newLPStakerFee (#276)
PERA.updateTCFee(uint256) (#282-286) should emit an event for:
- tradingCompFee = newTCFee (#285)
PERA.updateLPMultiplier(uint256) (#291-295) should emit an event for:
- LPRewardMultiplier = newLPMultiplier (#294)
PERA.updateTCMultiplier(uint256) (#300-304) should emit an event for:
- TCRewardMultiplier = newTCMultiplier (#303)
PERA.updateminTCamount(uint256) (#309-313) should emit an event for:
- minTCamount = newminTCamount (#312)
PERA.depositLPtoken(uint256) (#798-815) should emit an event for:
- totalStakedLP += _amount (#810)
PERA.withdraw(uint256) (#860-879) should emit an event for:
- totalStakedLP -= _amount (#872)
Emit an event for critical parameter changes.
Additional information: link
Reentrancy in PERA.emergencyWithdraw(uint256) (#848-857):
External calls:
- BEP20(lpTokenAddress).transfer(msg.sender,user.userLPamount) (#851)
State variables written after the call(s):
- FeeRewPoolLP = 0 (#855)
Apply the check-effects-interactions pattern.
Additional information: link
PERA.includeAccount(address) (#220-231) has costly operations inside a loop:
- _excluded.pop() (#226)
Use a local variable to hold the loop computation result.
Additional information: link
PERA.PERASupply (#98) is set pre-construction with a non-constant function or state variable:
- 44950800 * 10 ** uint256(decimals)
PERA.transferRate (#103) is set pre-construction with a non-constant function or state variable:
- (transferRateInitial - (transferRateInitial % PERASupply)) / PERASupply
PERA.oneWeekasBlock (#107) is set pre-construction with a non-constant function or state variable:
- BlockSizeForTC * 7
PERA.tenYearsasBlock (#109) is set pre-construction with a non-constant function or state variable:
- oneWeekasBlock * 520
PERA.dailyRewardForTC (#112) is set pre-construction with a non-constant function or state variable:
- 9800 * 10 ** uint256(decimals)
PERA.minTCamount (#120) is set pre-construction with a non-constant function or state variable:
- 100 * 10 ** decimals
PERA.blockRewardLP (#127) is set pre-construction with a non-constant function or state variable:
- 175 * 10 ** uint256(decimals)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Contract tokenRecipient (#2-4) is not in CapWords
Parameter BEP20.transfer(address,uint256)._to (#21) is not in mixedCase
Parameter BEP20.transfer(address,uint256)._value (#21) is not in mixedCase
Parameter BEP20.transferFrom(address,address,uint256)._from (#26) is not in mixedCase
Parameter BEP20.transferFrom(address,address,uint256)._to (#26) is not in mixedCase
Parameter BEP20.transferFrom(address,address,uint256)._value (#26) is not in mixedCase
Parameter BEP20.approve(address,uint256)._spender (#33) is not in mixedCase
Parameter BEP20.approve(address,uint256)._value (#33) is not in mixedCase
Parameter BEP20.approveAndCall(address,uint256,bytes)._spender (#40) is not in mixedCase
Parameter BEP20.approveAndCall(address,uint256,bytes)._value (#40) is not in mixedCase
Parameter BEP20.approveAndCall(address,uint256,bytes)._extraData (#40) is not in mixedCase
Struct PERA.topTraders (#438-441) is not in CapWords
Struct PERA.findTopLast (#446-449) is not in CapWords
Parameter PERA.transfer(address,uint256)._to (#173) is not in mixedCase
Parameter PERA.transfer(address,uint256)._value (#173) is not in mixedCase
Parameter PERA.transferFrom(address,address,uint256)._from (#178) is not in mixedCase
Parameter PERA.transferFrom(address,address,uint256)._to (#178) is not in mixedCase
Parameter PERA.transferFrom(address,address,uint256)._value (#178) is not in mixedCase
Parameter PERA.approve(address,uint256)._spender (#185) is not in mixedCase
Parameter PERA.approve(address,uint256)._value (#185) is not in mixedCase
Parameter PERA.approveAndCall(address,uint256,bytes)._spender (#192) is not in mixedCase
Parameter PERA.approveAndCall(address,uint256,bytes)._value (#192) is not in mixedCase
Parameter PERA.approveAndCall(address,uint256,bytes)._extraData (#192) is not in mixedCase
Function PERA._isExcluded(address) (#234-241) is not in mixedCase
Parameter PERA._isExcluded(address)._addr (#234) is not in mixedCase
Function PERA._removeExcludedAmounts() (#244-250) is not in mixedCase
Parameter PERA.excludeFromTax(address,uint256)._account (#252) is not in mixedCase
Parameter PERA.excludeFromTax(address,uint256)._checkTax (#252) is not in mixedCase
Parameter PERA.addLPToken(address)._addr (#317) is not in mixedCase
Parameter PERA.balanceOf(address)._addr (#325) is not in mixedCase
Parameter PERA.isManager(address)._addr (#347) is not in mixedCase
Parameter PERA.tradingComp(uint256,address,uint256)._value (#454) is not in mixedCase
Parameter PERA.tradingComp(uint256,address,uint256)._addr (#454) is not in mixedCase
Parameter PERA.tradingComp(uint256,address,uint256)._bnum (#454) is not in mixedCase
Parameter PERA.updateLastTrader(uint256,uint256,address)._value (#524) is not in mixedCase
Parameter PERA.updateLastTrader(uint256,uint256,address)._bnum (#524) is not in mixedCase
Parameter PERA.updateLastTrader(uint256,uint256,address)._addr (#524) is not in mixedCase
Parameter PERA.topTradersList(uint256,uint256,address)._value (#552) is not in mixedCase
Parameter PERA.topTradersList(uint256,uint256,address)._bnum (#552) is not in mixedCase
Parameter PERA.topTradersList(uint256,uint256,address)._addr (#552) is not in mixedCase
Parameter PERA.isTopTrader(uint256,address)._bnum (#570) is not in mixedCase
Parameter PERA.isTopTrader(uint256,address)._addr (#570) is not in mixedCase
Parameter PERA.findTraderIndex(uint256,address)._bnum (#581) is not in mixedCase
Parameter PERA.findTraderIndex(uint256,address)._addr (#581) is not in mixedCase
Parameter PERA.checkTopTraderList(uint256,uint256)._bnum (#592) is not in mixedCase
Parameter PERA.checkTopTraderList(uint256,uint256)._Ranking (#592) is not in mixedCase
Parameter PERA.sortTraders(uint256)._bnum (#599) is not in mixedCase
Parameter PERA.isUserWinner(address[],address)._addr (#623) is not in mixedCase
Parameter PERA.checkUserVolume(address,uint256)._addr (#633) is not in mixedCase
Parameter PERA.checkUserPayment(address,uint256)._addr (#639) is not in mixedCase
Parameter PERA.checkUserTCPosition(address[],address)._addr (#645) is not in mixedCase
Parameter PERA.calculateUserTCreward(address,uint256)._addr (#655) is not in mixedCase
Parameter PERA.calculateUserTCreward(address,uint256)._bnum (#655) is not in mixedCase
Parameter PERA.pendingTCreward(address,uint256)._addr (#692) is not in mixedCase
Parameter PERA.pendingTCreward(address,uint256)._bnum (#692) is not in mixedCase
Parameter PERA.getTCreward(uint256)._bnum (#719) is not in mixedCase
Parameter PERA.nMixAddrandSpBlock(address,uint256)._addr (#739) is not in mixedCase
Parameter PERA.nAddrHash(address)._address (#759) is not in mixedCase
Parameter PERA.getDistReward(uint256,uint256)._from (#768) is not in mixedCase
Parameter PERA.getDistReward(uint256,uint256)._to (#768) is not in mixedCase
Parameter PERA.pendingPERA(address)._user (#780) is not in mixedCase
Parameter PERA.depositLPtoken(uint256)._amount (#798) is not in mixedCase
Parameter PERA.updateRate(uint256)._totalStakedLP (#818) is not in mixedCase
Parameter PERA.withdraw(uint256)._amount (#860) is not in mixedCase
Variable PERA.LPTokenDecimals (#96) is not in mixedCase
Variable PERA.PERASupply (#98) is not in mixedCase
Constant PERA.transferRateInitial (#102) is not in UPPER_CASE_WITH_UNDERSCORES
Variable PERA.BlockSizeForTC (#105) is not in mixedCase
Variable PERA.TCRewardMultiplier (#115) is not in mixedCase
Variable PERA.LPRewardMultiplier (#130) is not in mixedCase
Variable PERA.LPRate (#132) is not in mixedCase
Variable PERA.FeeRewPoolLP (#134) is not in mixedCase
Variable PERA._excluded (#149) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Variable PERA.updateRate(uint256)._totalStakedLP (#818) is too similar to PERA.pendingPERA(address).vtotalStakedLP (#784)
Prevent variables from having similar names.
Additional information: link
PERA.nAddrHash(address) (#759-761) uses literals with too many digits:
- uint256(_address) % 10000000000 (#760)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
PERA.LPTokenDecimals (#96) is never used in PERA (#91-881)
PERA.userLPamount (#138) is never used in PERA (#91-881)
Remove unused state variables.
Additional information: link
PERA.BlockSizeForTC (#105) should be constant
PERA.LPTokenDecimals (#96) should be constant
PERA.decimals (#95) should be constant
PERA.totalTCwinners (#117) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
transfer(address,uint256) should be declared external:
- BEP20.transfer(address,uint256) (#21-24)
transferFrom(address,address,uint256) should be declared external:
- BEP20.transferFrom(address,address,uint256) (#26-31)
approveAndCall(address,uint256,bytes) should be declared external:
- BEP20.approveAndCall(address,uint256,bytes) (#40-48)
transfer(address,uint256) should be declared external:
- PERA.transfer(address,uint256) (#173-176)
transferFrom(address,address,uint256) should be declared external:
- PERA.transferFrom(address,address,uint256) (#178-183)
approveAndCall(address,uint256,bytes) should be declared external:
- PERA.approveAndCall(address,uint256,bytes) (#192-200)
balanceOf(address) should be declared external:
- PERA.balanceOf(address) (#325-331)
transferOwnership(address) should be declared external:
- PERA.transferOwnership(address) (#337-344)
checkTopTraderList(uint256,uint256) should be declared external:
- PERA.checkTopTraderList(uint256,uint256) (#592-594)
checkUserPayment(address,uint256) should be declared external:
- PERA.checkUserPayment(address,uint256) (#639-641)
Use the external attribute for functions never called from the contract.
Additional information: link
Unable to find audit link on the website
Unable to find Telegram link on the website
Unable to find Twitter link on the website
Unable to find token on CoinHunt
Additional information: link
Young tokens have high risks of price dump / death
Unable to find Youtube account