PALM [PALM PROTOCOL] Token (3)

PalmProtocol.swapBack() (#875-942) sends eth to arbitrary user
Dangerous calls:
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

PalmProtocol.blacklist (#723) is never initialized. It is used in:
- PalmProtocol._transferFrom(address,address,uint256) (#823-858)
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

PalmProtocol._totalSupply (#718) shadows:
- ERC20._totalSupply (#317)
Remove the state variable shadowing.

Additional information: link

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

Reentrancy in PalmProtocol._transferFrom(address,address,uint256) (#823-858):
External calls:
- swapBack() (#840)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#900-906)
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,owner(),block.timestamp) (#933-940)
External calls sending eth:
- swapBack() (#840)
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,owner(),block.timestamp) (#933-940)
State variables written after the call(s):
- _gonBalances[sender] = _gonBalances[sender].sub(gonAmount) (#843)
- _gonBalances[recipient] = _gonBalances[recipient].add(gonAmountReceived) (#848-850)
- gonAmountReceived = takeFee(sender,gonAmount) (#845-847)
- _gonBalances[address(this)] = _gonBalances[address(this)].add(feeAmount) (#950)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

PalmProtocol.swapBack().success (#921) is written in both
(success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
(success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
PalmProtocol.swapBack().success (#921) is written in both
(success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
success = false (#930)
Fix or remove the writes.

Additional information: link

PalmProtocol.swapBack() (#875-942) performs a multiplication on the result of a division:
-contractTokenBalance = _gonBalances[address(this)].div(_gonsPerFragment) (#876)
-amountToLiquify = contractTokenBalance.mul(dynamicLiquidityFee).div(totalFee).div(2) (#888-891)
PalmProtocol.setSwapThreshold(uint256,uint256) (#1044-1049) performs a multiplication on the result of a division:
-gonSwapThreshold = TOTAL_GONS.div(_denom).mul(_num) (#1048)
PalmProtocol.getLiquidityBacking(uint256) (#1100-1108) performs a multiplication on the result of a division:
-liquidityBalance = _gonBalances[pair].div(_gonsPerFragment) (#1105)
-accuracy.mul(liquidityBalance.mul(2)).div(getCirculatingSupply()) (#1106-1107)
Consider ordering multiplication before division.

Additional information: link

PalmProtocol.swapBack() (#875-942) ignores return value by router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,owner(),block.timestamp) (#933-940)
Ensure that all the return values of the function calls are used.

Additional information: link

PalmProtocol.DEAD (#694) should be constant
PalmProtocol.ZERO (#695) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#162-164)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#170-173)
name() should be declared external:
- ERC20.name() (#339-341)
symbol() should be declared external:
- ERC20.symbol() (#347-349)
decimals() should be declared external:
- ERC20.decimals() (#364-366)
totalSupply() should be declared external:
- ERC20.totalSupply() (#371-373)
- PalmProtocol.totalSupply() (#785-787)
balanceOf(address) should be declared external:
- ERC20.balanceOf(address) (#378-380)
- PalmProtocol.balanceOf(address) (#808-810)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#390-393)
- PalmProtocol.transfer(address,uint256) (#789-797)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#398-400)
- PalmProtocol.allowance(address,address) (#799-806)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#409-412)
- PalmProtocol.approve(address,uint256) (#992-1000)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#427-441)
- PalmProtocol.transferFrom(address,address,uint256) (#860-873)
excludeFromFee(address) should be declared external:
- PalmProtocol.excludeFromFee(address) (#1010-1012)
includeInFee(address) should be declared external:
- PalmProtocol.includeInFee(address) (#1014-1016)
Use the external attribute for functions never called from the contract.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#606) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#607)
Prevent variables from having similar names.

Additional information: link

PalmProtocol.setMaxTxAmount(uint256) (#1002-1004) should emit an event for:
- _maxTxAmount = amount (#1003)
PalmProtocol.setSwapThreshold(uint256,uint256) (#1044-1049) should emit an event for:
- gonSwapThreshold = TOTAL_GONS.div(_denom).mul(_num) (#1048)
PalmProtocol.setTargetLiquidity(uint256,uint256) (#1066-1069) should emit an event for:
- targetLiquidity = target (#1067)
- targetLiquidityDenominator = accuracy (#1068)
PalmProtocol.setFees(uint256,uint256,uint256,uint256) (#1087-1098) should emit an event for:
- liquidityFee = _liquidityFee (#1093)
- RiskFreeValue = _RiskFreeValue (#1094)
- Treasury = _Treasury (#1095)
- totalFee = liquidityFee.add(Treasury).add(RiskFreeValue) (#1096)
- feeDenominator = _feeDenominator (#1097)
Emit an event for critical parameter changes.

Additional information: link

PalmProtocol.setFeeReceivers(address,address)._TreasuryReceiver (#1080) lacks a zero-check on :
- TreasuryReceiver = _TreasuryReceiver (#1083)
PalmProtocol.setFeeReceivers(address,address)._RiskFreeValueReceiver (#1081) lacks a zero-check on :
- RiskFreeValueReceiver = _RiskFreeValueReceiver (#1084)
Check that the address is not zero.

Additional information: link

Reentrancy in PalmProtocol.constructor() (#729-755):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#733-736)
State variables written after the call(s):
- RiskFreeValueReceiver = 0xF5489E512751629c42999b03d29554B9F0D94DcA (#741)
- TreasuryReceiver = 0x01400305582423d74468535200ec8fCF4acC5983 (#740)
- _allowedFragments[address(this)][address(router)] = uint256(0) (#743)
- _gonBalances[owner()] = TOTAL_GONS (#747)
- _gonsPerFragment = TOTAL_GONS.div(_totalSupply) (#748)
- _isExcludedFromFee[owner()] = true (#750)
- _isExcludedFromFee[TreasuryReceiver] = true (#751)
- _isExcludedFromFee[address(this)] = true (#752)
- _totalSupply = INITIAL_SUPPLY (#746)
- _setAutomatedMarketMakerPair(pair,true) (#738)
- automatedMarketMakerPairs[_pair] = value (#1041)
- pairContract = InterfaceLP(pair) (#744)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in PalmProtocol._transferFrom(address,address,uint256) (#823-858):
External calls:
- swapBack() (#840)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#900-906)
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,owner(),block.timestamp) (#933-940)
External calls sending eth:
- swapBack() (#840)
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,owner(),block.timestamp) (#933-940)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount.div(_gonsPerFragment)) (#952)
- gonAmountReceived = takeFee(sender,gonAmount) (#845-847)
- Transfer(sender,recipient,gonAmountReceived.div(_gonsPerFragment)) (#852-856)
Reentrancy in PalmProtocol.constructor() (#729-755):
External calls:
- pair = IDEXFactory(router.factory()).createPair(router.WETH(),address(this)) (#733-736)
Event emitted after the call(s):
- Transfer(address(0x0),owner(),_totalSupply) (#754)
Reentrancy in PalmProtocol.rebase(uint256,int256) (#757-783):
External calls:
- pairContract.sync() (#779)
Event emitted after the call(s):
- LogRebase(epoch,_totalSupply) (#781)
Apply the check-effects-interactions pattern.

Additional information: link

Context._msgData() (#111-113) is never used and should be removed
ERC20._afterTokenTransfer(address,address,uint256) (#587-591) is never used and should be removed
ERC20._approve(address,address,uint256) (#541-551) is never used and should be removed
ERC20._beforeTokenTransfer(address,address,uint256) (#567-571) is never used and should be removed
ERC20._burn(address,uint256) (#511-526) is never used and should be removed
ERC20._mint(address,uint256) (#488-498) is never used and should be removed
ERC20._transfer(address,address,uint256) (#457-477) is never used and should be removed
SafeMath.mod(uint256,uint256) (#90-93) is never used and should be removed
SafeMathInt.abs(int256) (#35-38) is never used and should be removed
SafeMathInt.add(int256,int256) (#29-33) is never used and should be removed
SafeMathInt.div(int256,int256) (#17-21) is never used and should be removed
SafeMathInt.mul(int256,int256) (#9-15) is never used and should be removed
SafeMathInt.sub(int256,int256) (#23-27) is never used and should be removed
Remove unused functions.

Additional information: link

PalmProtocol.totalFee (#689) is set pre-construction with a non-constant function or state variable:
- liquidityFee.add(Treasury).add(RiskFreeValue)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.0 (#3) allows old versions
solc-0.8.0 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in PalmProtocol.swapBack() (#875-942):
- (success) = address(TreasuryReceiver).call{gas: 30000,value: amountETHTreasury}() (#921-924)
- (success,None) = address(RiskFreeValueReceiver).call{gas: 30000,value: amountETHRiskFreeValue}() (#925-928)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IDEXRouter.WETH() (#601) is not in mixedCase
Parameter PalmProtocol.isExcludedFromFee(address)._addr (#1006) is not in mixedCase
Parameter PalmProtocol.enableRebase(bool)._enabled (#1022) is not in mixedCase
Parameter PalmProtocol.enableSwap(bool)._enabled (#1026) is not in mixedCase
Parameter PalmProtocol.setLP(address)._address (#1030) is not in mixedCase
Parameter PalmProtocol.setAutomatedMarketMakerPair(address,bool)._pair (#1034) is not in mixedCase
Parameter PalmProtocol.setSwapThreshold(uint256,uint256)._num (#1045) is not in mixedCase
Parameter PalmProtocol.setSwapThreshold(uint256,uint256)._denom (#1046) is not in mixedCase
Parameter PalmProtocol.setFeeReceivers(address,address)._TreasuryReceiver (#1080) is not in mixedCase
Parameter PalmProtocol.setFeeReceivers(address,address)._RiskFreeValueReceiver (#1081) is not in mixedCase
Parameter PalmProtocol.setFees(uint256,uint256,uint256,uint256)._liquidityFee (#1088) is not in mixedCase
Parameter PalmProtocol.setFees(uint256,uint256,uint256,uint256)._RiskFreeValue (#1089) is not in mixedCase
Parameter PalmProtocol.setFees(uint256,uint256,uint256,uint256)._Treasury (#1090) is not in mixedCase
Parameter PalmProtocol.setFees(uint256,uint256,uint256,uint256)._feeDenominator (#1091) is not in mixedCase
Variable PalmProtocol._isExcludedFromFee (#674) is not in mixedCase
Variable PalmProtocol.Treasury (#687) is not in mixedCase
Variable PalmProtocol.RiskFreeValue (#688) is not in mixedCase
Variable PalmProtocol.DEAD (#694) is not in mixedCase
Variable PalmProtocol.ZERO (#695) is not in mixedCase
Variable PalmProtocol.TreasuryReceiver (#697) is not in mixedCase
Variable PalmProtocol.RiskFreeValueReceiver (#698) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

PalmProtocol.slitherConstructorVariables() (#666-1120) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#694)
PalmProtocol.slitherConstructorVariables() (#666-1120) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#695)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

SafeMathInt.MAX_INT256 (#7) is never used in SafeMathInt (#5-39)
Remove unused state variables.

Additional information: link

Contract has 12% buy tax and 0% sell tax.
Taxes are suspiciously high (over 10%) and contract ownership is not renounced. Token has a high risk of becoming a honeypot.

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Alexa traffic rank is very low

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Young tokens have high risks of scam / price dump / death