OST [OctoSquid] Token

OctoSquid.addLiquidity(address,address,uint256,uint256) (#1166-1180) sends eth to arbitrary user
Dangerous calls:
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in OctoSquid._transfer(address,address,uint256) (#999-1029):
External calls:
- swapAndLiquify(to) (#1016)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- markets[pair].swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1157-1163)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
External calls sending eth:
- swapAndLiquify(to) (#1016)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1024)
- _liquidityFee = _previousLiquidityFee (#966)
- _liquidityFee = 0 (#960)
- _tokenTransfer(from,to,amount,takeFee) (#1024)
- _rOwned[address(this)] += rLiquidity (#926)
- _rOwned[sender] -= rAmount (#1072)
- _rOwned[burnAddress] += rBurn (#931)
- _rOwned[recipient] += rTransferAmount (#1077)
- _tokenTransfer(from,to,amount,takeFee) (#1024)
- _rTotal = _rTotal - rFee (#824)
- _tokenTransfer(from,to,amount,takeFee) (#1024)
- _tOwned[address(this)] += tLiquidity (#928)
- _tOwned[sender] -= tAmount (#1074)
- _tOwned[recipient] += tTransferAmount (#1076)
- _tOwned[burnAddress] += tBurn (#933)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

OctoSquid._takeLiquidity(uint256) (#919-937) performs a multiplication on the result of a division:
-tBurn = (tLiquidity * totalFeesToBurn) / _liquidityFee (#922)
-rBurn = tBurn * currentRate (#923)
Consider ordering multiplication before division.

Additional information: link

OctoSquid.addLiquidity(address,address,uint256,uint256) (#1166-1180) ignores return value by markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
Ensure that all the return values of the function calls are used.

Additional information: link

OctoSquid.addLiquidity(address,address,uint256,uint256).owner (#1168) shadows:
- Ownable.owner() (#54-56) (function)
Rename the local variables that shadow another component.

Additional information: link

OctoSquid.updateGnosisGas(uint256) (#1104-1106) should emit an event for:
- gnosisGas = _amount (#1105)
Emit an event for critical parameter changes.

Additional information: link

OctoSquid.setLiquidityWallet(address)._newAddress (#781) lacks a zero-check on :
- liquidityWallet = _newAddress (#782)
Check that the address is not zero.

Additional information: link

Reentrancy in OctoSquid.transferFrom(address,address,uint256) (#698-710):
External calls:
- _transfer(sender,recipient,amount) (#703)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- markets[pair].swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1157-1163)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
- antisnipe.onPreTransferCheck(from,to,amount) (#1027)
External calls sending eth:
- _transfer(sender,recipient,amount) (#703)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#704-708)
- _allowances[_owner][spender] = amount (#987)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in OctoSquid.transferFrom(address,address,uint256) (#698-710):
External calls:
- _transfer(sender,recipient,amount) (#703)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- markets[pair].swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1157-1163)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
- antisnipe.onPreTransferCheck(from,to,amount) (#1027)
External calls sending eth:
- _transfer(sender,recipient,amount) (#703)
- markets[pair].addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner,block.timestamp + 360) (#1172-1179)
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
Event emitted after the call(s):
- Approval(_owner,spender,amount) (#988)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()] - amount) (#704-708)
Apply the check-effects-interactions pattern.

Additional information: link

Address.verifyCallResult(bool,bytes,string) (#328-348) uses assembly
- INLINE ASM (#340-343)
Do not use evm assembly.

Additional information: link

Context._msgData() (#22-24) is never used and should be removed
Remove unused functions.

Additional information: link

OctoSquid.minTokenNumberToSell (#542) is set pre-construction with a non-constant function or state variable:
- _tTotal / 1000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

solc-0.8.8 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in OctoSquid.swapAndLiquify(address) (#1118-1147):
- (sent,data) = marketingWallet.call{gas: gnosisGas,value: bnbToBeAddedToMarketing}() (#1142)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable OctoSquid._liquidityFee (#539) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable OctoSquid._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#893) is too similar to OctoSquid._transferStandard(address,address,uint256).tTransferAmount (#1068)
Prevent variables from having similar names.

Additional information: link

OctoSquid.slitherConstructorVariables() (#496-1197) uses literals with too many digits:
- burnAddress = 0x000000000000000000000000000000000000dEaD (#524)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

OctoSquid.protectedFrom (#550) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

setMaxWalletPercent(uint256) should be declared external:
- OctoSquid.setMaxWalletPercent(uint256) (#1113-1116)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank