ONI [Yokai] Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in Yokai._transfer(address,address,uint256) (#1378-1459):
External calls:
- swapAndLiquify(swapTokens) (#1427)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
- pancakeswapV2Router.swapExactTokensForEthSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1495-1501)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1427)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1452)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#808)
- _balances[recipient] = _balances[recipient].add(amount) (#809)
- super._transfer(from,to,amount) (#1455)
- _balances[sender] = _balances[sender].sub(amount,ERC20: transfer amount exceeds balance) (#808)
- _balances[recipient] = _balances[recipient].add(amount) (#809)
- swapping = false (#1431)
Apply the check-effects-interactions pattern.

Additional information: link

Yokai.authorize(address,uint256) (#1355-1362) ignores return value by token.transfer(msg.sender,amount) (#1361)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Yokai._isBlacklisted (#1149) is never initialized. It is used in:
- Yokai._transfer(address,address,uint256) (#1378-1459)
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

Contract locking ether found:
Contract BEP20PayingToken (#920-1104) has payable functions:
- IBEP20PayingToken.distributeBEP20s() (#509)
- BEP20PayingToken.receive() (#956-957)
- BEP20PayingToken.distributeBEP20s() (#972-983)
But does not have a function to withdraw the ether
Remove the payable attribute or add a withdraw function.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Yokai._transfer(address,address,uint256) (#1378-1459) performs a multiplication on the result of a division:
-fees = amount.mul(totalFee).div(100) (#1443)
-fees = fees.mul(FeeSellIncrease).div(100) (#1447)
Consider ordering multiplication before division.

Additional information: link

Reentrancy in BEP20PayingToken._withdrawBEP20OfUser(address) (#1007-1023):
External calls:
- success = IERC20(WBNB).transfer(user,_withdrawableBEP20) (#1012)
State variables written after the call(s):
- withdrawnBEP20s[user] = withdrawnBEP20s[user].sub(_withdrawableBEP20) (#1015)
Apply the check-effects-interactions pattern.

Additional information: link

Yokai.addLiquidity(uint256,uint256) (#1530-1545) ignores return value by pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
Ensure that all the return values of the function calls are used.

Additional information: link

BEP20PayingToken.constructor(string,string)._name (#951) shadows:
- ERC20._name (#636) (state variable)
BEP20PayingToken.constructor(string,string)._symbol (#951) shadows:
- ERC20._symbol (#637) (state variable)
Rename the local variables that shadow another component.

Additional information: link

Yokai.clearStuckBalance(uint256) (#1306-1309) should emit an event for:
- _val = amountpercentage * 10 ** 9 (#1307)
Yokai.setFees(uint256,uint256,uint256,uint256) (#1330-1336) should emit an event for:
- liquidityFee = _liquidityFee (#1332)
Emit an event for critical parameter changes.

Additional information: link

Yokai.setFeeReceiver(address,address)._marketingFeeReceiver (#1310) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#1311)
Yokai.setFeeReceiver(address,address)._devFeeReceiver (#1310) lacks a zero-check on :
- devFeeReceiver = _devFeeReceiver (#1312)
Yokai.changeHyperFlate(address)._hyperFlateContract (#1315) lacks a zero-check on :
- hyperFlate = _hyperFlateContract (#1316)
Check that the address is not zero.

Additional information: link

Reentrancy in Yokai.constructor() (#1202-1254):
External calls:
- _pancakeswapV2Pair = IpancakeswapV2Factory(_pancakeswapV2Router.factory()).createPair(address(this),_pancakeswapV2Router.WETH()) (#1231-1232)
State variables written after the call(s):
- _mint(owner(),100000000000 * (10 ** 9)) (#1253)
- _balances[account] = _balances[account].add(amount) (#828)
- _mint(owner(),100000000000 * (10 ** 9)) (#1253)
- _totalSupply = _totalSupply.add(amount) (#827)
- _setAutomatedMarketMakerPair(_pancakeswapV2Pair,true) (#1237)
- automatedMarketMakerPairs[pair] = value (#1280)
- canTransferBeforehyperFlateEnabled[owner()] = true (#1248)
- pancakeswapV2Pair = _pancakeswapV2Pair (#1235)
- pancakeswapV2Router = _pancakeswapV2Router (#1234)
Reentrancy in Yokai.swapAndLiquify(uint256) (#1461-1482):
External calls:
- swapTokensForEth(half) (#1473)
- pancakeswapV2Router.swapExactTokensForEthSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1495-1501)
- addLiquidity(otherHalf,newBalance) (#1479)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1479)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1479)
- _allowances[owner][spender] = amount (#870)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Yokai._transfer(address,address,uint256) (#1378-1459):
External calls:
- swapAndLiquify(swapTokens) (#1427)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
- pancakeswapV2Router.swapExactTokensForEthSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1495-1501)
External calls sending eth:
- swapAndLiquify(swapTokens) (#1427)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#810)
- super._transfer(from,to,amount) (#1455)
- Transfer(sender,recipient,amount) (#810)
- super._transfer(from,address(this),fees) (#1452)
Reentrancy in Yokai.constructor() (#1202-1254):
External calls:
- _pancakeswapV2Pair = IpancakeswapV2Factory(_pancakeswapV2Router.factory()).createPair(address(this),_pancakeswapV2Router.WETH()) (#1231-1232)
Event emitted after the call(s):
- SetAutomatedMarketMakerPair(pair,value) (#1286)
- _setAutomatedMarketMakerPair(_pancakeswapV2Pair,true) (#1237)
- SetIsFeeExempt(liquidityWallet,true) (#1244)
- SetIsFeeExempt(address(this),true) (#1245)
- Transfer(address(0),account,amount) (#829)
- _mint(owner(),100000000000 * (10 ** 9)) (#1253)
Reentrancy in Yokai.swapAndLiquify(uint256) (#1461-1482):
External calls:
- swapTokensForEth(half) (#1473)
- pancakeswapV2Router.swapExactTokensForEthSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1495-1501)
- addLiquidity(otherHalf,newBalance) (#1479)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1479)
- pancakeswapV2Router.addLiquidityEth{value: EthAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp) (#1536-1543)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#871)
- addLiquidity(otherHalf,newBalance) (#1479)
- SwapAndLiquify(half,newBalance,otherHalf) (#1481)
Apply the check-effects-interactions pattern.

Additional information: link

Yokai._transfer(address,address,uint256) (#1378-1459) compares to a boolean constant:
-require(bool,string)(_isBlacklisted[from] == false,You are Blacklist) (#1385)
Remove the equality to the boolean constant.

Additional information: link

Different versions of Solidity is used:
- Version used: ['>=0.5.0', '>=0.6.2', '^0.8.0', '^0.8.5']
- ^0.8.5 (#4)
- >=0.6.2 (#119)
- >=0.6.2 (#216)
- >=0.5.0 (#261)
- >=0.5.0 (#280)
- ^0.8.0 (#335)
- ^0.8.0 (#401)
- ^0.8.0 (#468)
- ^0.8.0 (#493)
- ^0.8.0 (#534)
- ^0.8.0 (#581)
- ^0.8.0 (#600)
- ^0.8.0 (#904)
- ^0.8.0 (#1110)
Use one Solidity version.

Additional information: link

BEP20PayingToken._burn(address,uint256) (#1086-1091) is never used and should be removed
BEP20PayingToken._mint(address,uint256) (#1075-1080) is never used and should be removed
BEP20PayingToken._setBalance(address,uint256) (#1093-1103) is never used and should be removed
BEP20PayingToken._withdrawBEP20OfUser(address) (#1007-1023) is never used and should be removed
Context._msgData() (#110-113) is never used and should be removed
ERC20._burn(address,uint256) (#843-851) is never used and should be removed
ERC20._setupDecimals(uint8) (#881-883) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#81-84) is never used and should be removed
SafeMath.mod(uint256,uint256) (#69-72) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#86-89) is never used and should be removed
SafeMath.tryAdd(uint256,uint256) (#9-13) is never used and should be removed
SafeMath.tryDiv(uint256,uint256) (#33-36) is never used and should be removed
SafeMath.tryMod(uint256,uint256) (#38-41) is never used and should be removed
SafeMath.tryMul(uint256,uint256) (#22-30) is never used and should be removed
SafeMath.trySub(uint256,uint256) (#16-19) is never used and should be removed
SafeMathInt.div(int256,int256) (#554-560) is never used and should be removed
SafeMathInt.mul(int256,int256) (#544-552) is never used and should be removed
Yokai.setAutomatedMarketMakerPair(address,bool) (#1272-1276) is never used and should be removed
Yokai.swapTokensForTokens(uint256,address) (#1507-1526) is never used and should be removed
Yokai.updateLiquidityWallet(address) (#1290-1295) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version>=0.6.2 (#119) allows old versions
Pragma version>=0.6.2 (#216) allows old versions
Pragma version>=0.5.0 (#261) allows old versions
Pragma version>=0.5.0 (#280) allows old versions
Pragma version^0.8.0 (#335) allows old versions
Pragma version^0.8.0 (#401) allows old versions
Pragma version^0.8.0 (#468) allows old versions
Pragma version^0.8.0 (#493) allows old versions
Pragma version^0.8.0 (#534) allows old versions
Pragma version^0.8.0 (#581) allows old versions
Pragma version^0.8.0 (#600) allows old versions
Pragma version^0.8.0 (#904) allows old versions
Pragma version^0.8.0 (#1110) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function IpancakeswapV2Router01.WETH() (#123) is not in mixedCase
Function IpancakeswapV2Pair.DOMAIN_SEPARATOR() (#297) is not in mixedCase
Function IpancakeswapV2Pair.PERMIT_TYPEHASH() (#298) is not in mixedCase
Function IpancakeswapV2Pair.MINIMUM_LIQUIDITY() (#315) is not in mixedCase
Parameter BEP20PayingToken.reflectionTaxOf(address)._owner (#1029) is not in mixedCase
Parameter BEP20PayingToken.withdrawableBEP20Of(address)._owner (#1036) is not in mixedCase
Parameter BEP20PayingToken.withdrawnBEP20Of(address)._owner (#1043) is not in mixedCase
Parameter BEP20PayingToken.accumulativeBEP20Of(address)._owner (#1053) is not in mixedCase
Constant BEP20PayingToken.magnitude (#928) is not in UPPER_CASE_WITH_UNDERSCORES
Variable BEP20PayingToken.WBNB (#933) is not in mixedCase
Event YokaiupdatepancakeswapV2Router(address,address) (#1166) is not in CapWords
Event YokaiexcludeMultipleAccountFromRewards(address[],bool) (#1170) is not in CapWords
Parameter Yokai.setFeeReceiver(address,address)._marketingFeeReceiver (#1310) is not in mixedCase
Parameter Yokai.setFeeReceiver(address,address)._devFeeReceiver (#1310) is not in mixedCase
Parameter Yokai.changeHyperFlate(address)._hyperFlateContract (#1315) is not in mixedCase
Parameter Yokai.setMaxWallet(uint256).MaxWalletPercent (#1326) is not in mixedCase
Parameter Yokai.setFees(uint256,uint256,uint256,uint256)._marketingFee (#1330) is not in mixedCase
Parameter Yokai.setFees(uint256,uint256,uint256,uint256)._liquidityFee (#1330) is not in mixedCase
Parameter Yokai.setFees(uint256,uint256,uint256,uint256)._devFee (#1330) is not in mixedCase
Parameter Yokai.setFees(uint256,uint256,uint256,uint256)._hyperFlateFee (#1330) is not in mixedCase
Parameter Yokai.tradingStatus(bool)._status (#1338) is not in mixedCase
Parameter Yokai.setHyperFlate(bool,uint256)._enabled (#1344) is not in mixedCase
Parameter Yokai.setHyperFlate(bool,uint256)._amount (#1344) is not in mixedCase
Function Yokai._Lock(address,uint256) (#1371-1376) is not in mixedCase
Parameter Yokai.addLiquidity(uint256,uint256).EthAmount (#1530) is not in mixedCase
Variable Yokai.WBNB (#1119) is not in mixedCase
Variable Yokai.DEAD (#1120) is not in mixedCase
Variable Yokai.ZERO (#1121) is not in mixedCase
Variable Yokai._maxTxAmount (#1131) is not in mixedCase
Variable Yokai._maxWalletToken (#1132) is not in mixedCase
Variable Yokai.FeeSellIncrease (#1143) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#111)" inContext (#105-114)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IpancakeswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#128) is too similar to IpancakeswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#129)
Prevent variables from having similar names.

Additional information: link

Yokai.constructor() (#1202-1254) uses literals with too many digits:
- _mint(owner(),100000000000 * (10 ** 9)) (#1253)
Yokai.setDistributorSettings(uint256) (#1297-1302) uses literals with too many digits:
- require(bool,string)(gas >= 200000 && gas <= 500000,Yokai: distributorGas must be between 200,000 and 500,000) (#1298)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- DEAD = address(0x000000000000000000000000000000000000dEaD) (#1120)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- ZERO = address(0x0000000000000000000000000000000000000000) (#1121)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- _maxTxAmount = 1000000000 * (10 ** 9) (#1131)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- _maxWalletToken = 2000000000 * (10 ** 9) (#1132)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- distributorGas = 300000 (#1144)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- tokenThreshold = 10000000000 * (10 ** 9) (#1147)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- _swapTokensAtAmount = 200000 * (10 ** 9) (#1157)
Yokai.slitherConstructorVariables() (#1112-1550) uses literals with too many digits:
- _val = 100000000 * (10 ** 18) (#1176)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

BEP20PayingToken.lastAmount (#931) is never used in BEP20PayingToken (#920-1104)
Yokai.DEAD (#1120) is never used in Yokai (#1112-1550)
Yokai.ZERO (#1121) is never used in Yokai (#1112-1550)
Yokai.presaleAddress (#1145) is never used in Yokai (#1112-1550)
Remove unused state variables.

Additional information: link

BEP20PayingToken.lastAmount (#931) should be constant
Yokai.FeeSellIncrease (#1143) should be constant
Yokai._swapTokensAtAmount (#1157) should be constant
Yokai.presaleAddress (#1145) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

get(IterableMapping.Map,address) should be declared external:
- IterableMapping.get(IterableMapping.Map,address) (#346-348)
getIndexOfKey(IterableMapping.Map,address) should be declared external:
- IterableMapping.getIndexOfKey(IterableMapping.Map,address) (#350-355)
getKeyAtIndex(IterableMapping.Map,uint256) should be declared external:
- IterableMapping.getKeyAtIndex(IterableMapping.Map,uint256) (#357-359)
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#363-365)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#451-454)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#460-464)
name() should be declared external:
- ERC20.name() (#658-660)
symbol() should be declared external:
- ERC20.symbol() (#666-668)
decimals() should be declared external:
- ERC20.decimals() (#683-685)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#709-712)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#717-719)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#728-731)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#746-750)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#764-767)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#783-786)
distributeBEP20s() should be declared external:
- BEP20PayingToken.distributeBEP20s() (#972-983)
distributeAUBEP20s(uint256) should be declared external:
- BEP20PayingToken.distributeAUBEP20s(uint256) (#986-997)
withdrawBEP20() should be declared external:
- BEP20PayingToken.withdrawBEP20() (#1001-1003)
reflectionTaxOf(address) should be declared external:
- BEP20PayingToken.reflectionTaxOf(address) (#1029-1031)
withdrawnBEP20Of(address) should be declared external:
- BEP20PayingToken.withdrawnBEP20Of(address) (#1043-1045)
setIsFeeExempt(address,bool) should be declared external:
- Yokai.setIsFeeExempt(address,bool) (#1259-1262)
setIsTxLimitExempt(address,bool) should be declared external:
- Yokai.setIsTxLimitExempt(address,bool) (#1264-1269)
setDistributorSettings(uint256) should be declared external:
- Yokai.setDistributorSettings(uint256) (#1297-1302)
tradingStatus(bool) should be declared external:
- Yokai.tradingStatus(bool) (#1338-1342)
setHyperFlate(bool,uint256) should be declared external:
- Yokai.setHyperFlate(bool,uint256) (#1344-1348)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank