Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
OlympicKing.swapBack() (#456-478) sends eth to arbitrary user
Dangerous calls:
- address(marketingWallet).transfer(amountMarketing) (#476)
- address(treasury).transfer(amountTreasury) (#477)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in OlympicKing._transferFrom(address,address,uint256) (#405-432):
External calls:
- swapBack() (#419)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#464-470)
External calls sending eth:
- swapBack() (#419)
- address(marketingWallet).transfer(amountMarketing) (#476)
- address(treasury).transfer(amountTreasury) (#477)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#421)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#425)
- amountReceived = takeFee(sender,amount) (#423)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#449)
Apply the check-effects-interactions pattern.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
DividendDistributor.setShare(address,uint256) (#220-234) should emit an event for:
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#231)
OlympicKing.setFee(uint256) (#531-534) should emit an event for:
- totalFee = _fee (#533)
Emit an event for critical parameter changes.
Additional information: link
DividendDistributor.constructor(address,address).owner (#212) lacks a zero-check on :
- _owner = address(owner) (#214)
DividendDistributor.constructor(address,address).treasury (#212) lacks a zero-check on :
- _treasury = address(treasury) (#215)
DividendDistributor.manualSend(uint256,address).holder (#286) lacks a zero-check on :
- address(holder).transfer(amount) (#288)
- address(holder).transfer(contractETHBalance) (#288)
DividendDistributor.setTreasury(address).treasury (#291) lacks a zero-check on :
- _treasury = address(treasury) (#292)
Auth.transferOwnership(address).adr (#112) lacks a zero-check on :
- owner = adr (#113)
OlympicKing.setMarketingWallet(address)._marketingWallet (#562) lacks a zero-check on :
- marketingWallet = address(_marketingWallet) (#563)
OlympicKing.setTreasury(address)._treasury (#566) lacks a zero-check on :
- treasury = address(_treasury) (#567)
Check that the address is not zero.
Additional information: link
OlympicKing._setIsDividendExempt(address,bool) (#513-521) has external calls inside a loop: distributor.setShare(holder,0) (#517)
OlympicKing._setIsDividendExempt(address,bool) (#513-521) has external calls inside a loop: distributor.setShare(holder,_balances[holder]) (#519)
Favor pull over push strategy for external calls.
Additional information: link
Reentrancy in OlympicKing.constructor() (#348-371):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WETH,address(this)) (#354)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#356)
- _balances[_owner] = _totalSupply (#368)
- distributor = new DividendDistributor(_owner,treasury) (#358)
- isDividendExempt[pair] = true (#364)
- isDividendExempt[address(this)] = true (#365)
- isDividendExempt[DEAD] = true (#366)
- isFeeExempt[_owner] = true (#360)
- isFeeExempt[marketingWallet] = true (#361)
- isFeeExempt[treasury] = true (#362)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in OlympicKing._transferFrom(address,address,uint256) (#405-432):
External calls:
- swapBack() (#419)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#464-470)
- distributor.setShare(sender,_balances[sender]) (#427)
- distributor.setShare(recipient,_balances[recipient]) (#428)
External calls sending eth:
- swapBack() (#419)
- address(marketingWallet).transfer(amountMarketing) (#476)
- address(treasury).transfer(amountTreasury) (#477)
Event emitted after the call(s):
- Transfer(sender,recipient,amountReceived) (#430)
Reentrancy in OlympicKing._transferFrom(address,address,uint256) (#405-432):
External calls:
- swapBack() (#419)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#464-470)
External calls sending eth:
- swapBack() (#419)
- address(marketingWallet).transfer(amountMarketing) (#476)
- address(treasury).transfer(amountTreasury) (#477)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#450)
- amountReceived = takeFee(sender,amount) (#423)
Reentrancy in OlympicKing.constructor() (#348-371):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WETH,address(this)) (#354)
Event emitted after the call(s):
- Transfer(address(0),_owner,_totalSupply) (#370)
Apply the check-effects-interactions pattern.
Additional information: link
OlympicKing._maxTxAmountBuy (#314) is set pre-construction with a non-constant function or state variable:
- _totalSupply
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Function IDEXRouter.WETH() (#126) is not in mixedCase
Variable DividendDistributor._token (#183) is not in mixedCase
Variable DividendDistributor._owner (#184) is not in mixedCase
Variable DividendDistributor._treasury (#185) is not in mixedCase
Parameter OlympicKing.setBot(address)._address (#487) is not in mixedCase
Parameter OlympicKing.isInBot(address)._address (#509) is not in mixedCase
Parameter OlympicKing.setFee(uint256)._fee (#531) is not in mixedCase
Parameter OlympicKing.setMarketingWallet(address)._marketingWallet (#562) is not in mixedCase
Parameter OlympicKing.setTreasury(address)._treasury (#566) is not in mixedCase
Variable OlympicKing.WETH (#305) is not in mixedCase
Variable OlympicKing.DEAD (#306) is not in mixedCase
Variable OlympicKing.ZERO (#307) is not in mixedCase
Constant OlympicKing._name (#309) is not in UPPER_CASE_WITH_UNDERSCORES
Constant OlympicKing._symbol (#310) is not in UPPER_CASE_WITH_UNDERSCORES
Constant OlympicKing._decimals (#311) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.
Additional information: link
Reentrancy in OlympicKing._transferFrom(address,address,uint256) (#405-432):
External calls:
- swapBack() (#419)
- address(marketingWallet).transfer(amountMarketing) (#476)
- address(treasury).transfer(amountTreasury) (#477)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#421)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#425)
- amountReceived = takeFee(sender,amount) (#423)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#449)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#450)
- amountReceived = takeFee(sender,amount) (#423)
- Transfer(sender,recipient,amountReceived) (#430)
Reentrancy in DividendDistributor.setShare(address,uint256) (#220-234):
External calls:
- distributeDividend(shareholder) (#222)
- address(shareholder).transfer(amount) (#252)
State variables written after the call(s):
- addShareholder(shareholder) (#226)
- shareholderIndexes[shareholder] = shareholders.length (#276)
- removeShareholder(shareholder) (#228)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#282)
- addShareholder(shareholder) (#226)
- shareholders.push(shareholder) (#277)
- removeShareholder(shareholder) (#228)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#281)
- shareholders.pop() (#283)
- shares[shareholder].amount = amount (#232)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#233)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#231)
Apply the check-effects-interactions pattern.
Additional information: link
Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#131) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#132)
Prevent variables from having similar names.
Additional information: link
OlympicKing.slitherConstructorVariables() (#302-587) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#306)
OlympicKing.slitherConstructorVariables() (#302-587) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#307)
OlympicKing.slitherConstructorVariables() (#302-587) uses literals with too many digits:
- _totalSupply = 10000000000 * (10 ** _decimals) (#313)
OlympicKing.slitherConstructorVariables() (#302-587) uses literals with too many digits:
- maxBuy = 10000000000 * (10 ** _decimals) (#338)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
OlympicKing._maxTxAmountBuy (#314) is never used in OlympicKing (#302-587)
Remove unused state variables.
Additional information: link
DividendDistributor.dividendsPerShareAccuracyFactor (#202) should be constant
OlympicKing.DEAD (#306) should be constant
OlympicKing.ZERO (#307) should be constant
OlympicKing._totalSupply (#313) should be constant
OlympicKing.feeDenominator (#327) should be constant
OlympicKing.maxBuy (#338) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#112-115)
getClaimableDividendOf(address) should be declared external:
- OlympicKing.getClaimableDividendOf(address) (#550-552)
getCirculatingSupply() should be declared external:
- OlympicKing.getCirculatingSupply() (#558-560)
Use the external attribute for functions never called from the contract.
Additional information: link
Unable to find website, listings and other project-related information
Young tokens have high risks of scam / price dump / death
Token has no active CoinGecko listing / rank
Token has no active CoinMarketCap listing / rank
Unable to find Telegram and Twitter accounts