Our project main theme — New Year celebration and everything connected with this.
We have special Magic boxes with NFTs. There are a total of 10 different NFTs.
We have unique NFTs with real usage. Every NFT has its own rarity — the better rarity = the better reward you will get from the NFT rewards pool.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
Distribution.recoverEth(uint256) (#974-976) sends eth to arbitrary user
Dangerous calls:
- address(_msgSender()).transfer(_amount) (#975)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
NewYearToken.recoverTokens(address,uint256) (#1170-1172) ignores return value by IERC20(_address).transfer(_msgSender(),_amount) (#1171)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
NewYearToken.setRewardBuyRate(uint256) (#1335-1338) contains a tautology or contradiction:
- require(bool)(0 <= _rewardBuyRate && _rewardBuyRate <= 5000) (#1336)
Fix the incorrect comparison by changing the value type or the comparison.
Additional information: link
Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Reentrancy in NewYearToken.swapMarketingFees(uint256) (#1372-1376):
External calls:
- _swapMarketingFees(amount) (#1374)
- router.swapExactTokensForTokensSupportingFeeOnTransferTokens(_tokenAmount,0,path,_recipient,block.timestamp) (#1574-1580)
- distribution.recoverTokensFor(address(_busd),_calcAmount,marketingReceivers[i]) (#1391)
State variables written after the call(s):
- marketingAmount = marketingAmount.sub(amount) (#1375)
Apply the check-effects-interactions pattern.
Additional information: link
NewYearToken.setRewardSwapAddress(address)._rewardSwapAddress (#1207) lacks a zero-check on :
- rewardSwapAddress = _rewardSwapAddress (#1208)
Check that the address is not zero.
Additional information: link
NewYearToken._swapMarketingFees(uint256) (#1378-1396) has external calls inside a loop: distribution.recoverTokensFor(address(_busd),_calcAmount,marketingReceivers[i]) (#1391)
Favor pull over push strategy for external calls.
Additional information: link
Reentrancy in NewYearToken.transferFrom(address,address,uint256) (#1122-1132):
External calls:
- _transfer(sender,recipient,amount) (#1123)
- router.swapExactTokensForTokensSupportingFeeOnTransferTokens(_tokenAmount,0,path,_recipient,block.timestamp) (#1574-1580)
- distribution.recoverTokensFor(address(_busd),_calcAmount,marketingReceivers[i]) (#1391)
- distribution.recoverTokensFor(address(_busd),_calcAmount,rewardSwapReceivers[i]) (#1363)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#1128)
- _allowances[owner][spender] = amount (#1497)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in NewYearToken.transferFrom(address,address,uint256) (#1122-1132):
External calls:
- _transfer(sender,recipient,amount) (#1123)
- router.swapExactTokensForTokensSupportingFeeOnTransferTokens(_tokenAmount,0,path,_recipient,block.timestamp) (#1574-1580)
- distribution.recoverTokensFor(address(_busd),_calcAmount,marketingReceivers[i]) (#1391)
- distribution.recoverTokensFor(address(_busd),_calcAmount,rewardSwapReceivers[i]) (#1363)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1498)
- _approve(sender,_msgSender(),currentAllowance - amount) (#1128)
Apply the check-effects-interactions pattern.
Additional information: link
Different versions of Solidity is used:
- Version used: ['>=0.5.0', '>=0.6.2', '^0.8.0', '^0.8.2']
- >=0.5.0 (#3)
- >=0.6.2 (#23)
- >=0.6.2 (#121)
- ^0.8.0 (#169)
- ^0.8.0 (#398)
- ^0.8.0 (#425)
- ^0.8.0 (#455)
- ^0.8.0 (#524)
- ^0.8.0 (#614)
- ^0.8.0 (#698)
- ^0.8.0 (#727)
- ^0.8.0 (#753)
- ^0.8.2 (#964)
- ^0.8.2 (#991)
Use one Solidity version.
Additional information: link
Strings.toString(uint256) (#466-486) is never used and should be removed
Remove unused functions.
Additional information: link
solc-0.8.2 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Parameter NewYearToken.setRewardBuyLimit(uint256)._rewardBuyLimit (#1340) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#32) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#33)
Prevent variables from having similar names.
Additional information: link
NewYearToken.slitherConstructorVariables() (#1001-1584) uses literals with too many digits:
- deadAddress = 0x000000000000000000000000000000000000dEaD (#1013)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
NewYearToken.deadAddress (#1013) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
swapMarketingFees(uint256) should be declared external:
- NewYearToken.swapMarketingFees(uint256) (#1372-1376)
Use the external attribute for functions never called from the contract.
Additional information: link
Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.
Number of Binance Smart Chain (BSC) token holders is low.
Token is deployed only at one blockchain
Unable to find PancakeSwap trading pair to compute liquidity.
Unable to find PancakeSwap trading pair to compute volume.
Unable to find PancakeSwap trading pair to compute number of swaps.
BscScan page for the token does not contain additional info: website, socials, description, etc.
Additional information: link
Unable to find token contract audit
Unable to find whitepaper link on the website
Young tokens have high risks of price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of price dump / death
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank
Token has relatively low CoinMarketCap rank
Twitter account link seems to be invalid
Unable to find Youtube account
Unable to find Discord account