MKD [Metakingdom Defenders] Token

MKD.addLiquidity(uint256,uint256) (#713-726) sends eth to arbitrary user
Dangerous calls:
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in MKD._transfer(address,address,uint256) (#562-649):
External calls:
- handle_fees(feeswap,currentTaxes) (#637)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- address(marketingWallet).sendValue(marketingAmt) (#679)
- address(gamedevWallet).sendValue(gamedevAmt) (#684)
- address(devWallet).sendValue(devAmt) (#689)
External calls sending eth:
- handle_fees(feeswap,currentTaxes) (#637)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
State variables written after the call(s):
- super._transfer(sender,recipient,amount - fee) (#640)
- _balances[sender] = senderBalance - amount (#269)
- _balances[recipient] += amount (#270)
- super._transfer(sender,address(this),feeAmount) (#645)
- _balances[sender] = senderBalance - amount (#269)
- _balances[recipient] += amount (#270)
Apply the check-effects-interactions pattern.

Additional information: link

MKD.rescueBSC20(address,uint256) (#832-834) ignores return value by IERC20(tokenAdd).transfer(devWallet,amount) (#833)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

MKD._transfer(address,address,uint256).fee (#600) is written in both
fee = 0 (#609)
fee = (amount * feesum) / 100 (#633)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Contract ownership is not renounced (belongs to a wallet)

MKD.handle_fees(uint256,MKD.Taxes) (#651-693) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - swapTaxes.liquidity) (#669)
-bnbToAddLiquidityWith = unitBalance * swapTaxes.liquidity (#670)
MKD.handle_fees(uint256,MKD.Taxes) (#651-693) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - swapTaxes.liquidity) (#669)
-marketingAmt = unitBalance * 2 * swapTaxes.marketing (#677)
MKD.handle_fees(uint256,MKD.Taxes) (#651-693) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - swapTaxes.liquidity) (#669)
-gamedevAmt = unitBalance * 2 * swapTaxes.gamedev (#682)
MKD.handle_fees(uint256,MKD.Taxes) (#651-693) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - swapTaxes.liquidity) (#669)
-devAmt = unitBalance * 2 * swapTaxes.dev (#687)
Consider ordering multiplication before division.

Additional information: link

MKD._transfer(address,address,uint256).currentTaxes (#601) is a local variable never initialized
MKD._transfer(address,address,uint256).feesum (#599) is a local variable never initialized
MKD._transfer(address,address,uint256).feeswap (#598) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

MKD.addLiquidity(uint256,uint256) (#713-726) ignores return value by router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
Ensure that all the return values of the function calls are used.

Additional information: link

MKD.updateLiquidityTreshhold(uint256) (#733-736) should emit an event for:
- tokenLiquidityThreshold = new_amount * 10 ** decimals() (#735)
MKD.updatedeadline(uint256) (#770-773) should emit an event for:
- deadline = _deadline (#772)
MKD.updateCooldown(bool,uint256) (#787-791) should emit an event for:
- coolDownTime = time * 1 (#788)
MKD.updateMaxBuyTxLimit(uint256) (#813-816) should emit an event for:
- maxBuyLimit = maxBuy * 10 ** decimals() (#814)
MKD.updateMaxSellTxLimit(uint256) (#818-821) should emit an event for:
- maxSellLimit = maxSell * 10 ** decimals() (#819)
MKD.updateMaxWalletlimit(uint256) (#823-826) should emit an event for:
- maxWalletLimit = amount * 10 ** decimals() (#824)
Emit an event for critical parameter changes.

Additional information: link

MKD.constructor(address)._pair (#497) lacks a zero-check on :
- pair = _pair (#500)
MKD.updateRouterAndPair(address,address).newPair (#758) lacks a zero-check on :
- pair = newPair (#760)
MKD.updateMarketingWallet(address).newWallet (#775) lacks a zero-check on :
- marketingWallet = newWallet (#776)
MKD.updateGamedevWallet(address).newWallet (#779) lacks a zero-check on :
- gamedevWallet = newWallet (#780)
MKD.updateDevWallet(address).newWallet (#783) lacks a zero-check on :
- devWallet = newWallet (#784)
Check that the address is not zero.

Additional information: link

Modifier MKD.mutexLock() (#483-489) does not always execute _; or revert
All the paths in a modifier must execute _ or revert.

Additional information: link

Reentrancy in MKD.constructor(address) (#491-515):
External calls:
- _pair = IFactory(_router.factory()).createPair(address(this),_router.WETH()) (#497)
State variables written after the call(s):
- allowedTransfer[address(this)] = true (#507)
- allowedTransfer[owner()] = true (#508)
- allowedTransfer[pair] = true (#509)
- allowedTransfer[marketingWallet] = true (#510)
- allowedTransfer[gamedevWallet] = true (#511)
- allowedTransfer[devWallet] = true (#512)
- allowedTransfer[deadWallet] = true (#513)
- exemptFee[address(this)] = true (#501)
- exemptFee[marketingWallet] = true (#502)
- exemptFee[gamedevWallet] = true (#503)
- exemptFee[devWallet] = true (#504)
- exemptFee[deadWallet] = true (#505)
- pair = _pair (#500)
- router = _router (#499)
Reentrancy in MKD.handle_fees(uint256,MKD.Taxes) (#651-693):
External calls:
- swapTokensForETH(toSwap) (#666)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
State variables written after the call(s):
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
- _allowances[owner][spender] = amount (#339)
Reentrancy in MKD.transferFrom(address,address,uint256) (#522-534):
External calls:
- _transfer(sender,recipient,amount) (#527)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- address(marketingWallet).sendValue(marketingAmt) (#679)
- address(gamedevWallet).sendValue(gamedevAmt) (#684)
- address(devWallet).sendValue(devAmt) (#689)
External calls sending eth:
- _transfer(sender,recipient,amount) (#527)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#531)
- _allowances[owner][spender] = amount (#339)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MKD._transfer(address,address,uint256) (#562-649):
External calls:
- handle_fees(feeswap,currentTaxes) (#637)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- address(marketingWallet).sendValue(marketingAmt) (#679)
- address(gamedevWallet).sendValue(gamedevAmt) (#684)
- address(devWallet).sendValue(devAmt) (#689)
External calls sending eth:
- handle_fees(feeswap,currentTaxes) (#637)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#272)
- super._transfer(sender,address(this),feeAmount) (#645)
- Transfer(sender,recipient,amount) (#272)
- super._transfer(sender,recipient,amount - fee) (#640)
Reentrancy in MKD.handle_fees(uint256,MKD.Taxes) (#651-693):
External calls:
- swapTokensForETH(toSwap) (#666)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#340)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#674)
Reentrancy in MKD.transferFrom(address,address,uint256) (#522-534):
External calls:
- _transfer(sender,recipient,amount) (#527)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#704-710)
- address(marketingWallet).sendValue(marketingAmt) (#679)
- address(gamedevWallet).sendValue(gamedevAmt) (#684)
- address(devWallet).sendValue(devAmt) (#689)
External calls sending eth:
- _transfer(sender,recipient,amount) (#527)
- router.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#718-725)
- (success) = recipient.call{value: amount}() (#368)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#340)
- _approve(sender,_msgSender(),currentAllowance - amount) (#531)
Apply the check-effects-interactions pattern.

Additional information: link

MKD._transfer(address,address,uint256) (#562-649) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(timePassed >= coolDownTime,Cooldown enabled) (#593)
Avoid relying on block.timestamp.

Additional information: link

Context._msgData() (#11-14) is never used and should be removed
ERC20._burn(address,uint256) (#305-316) is never used and should be removed
Remove unused functions.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#365-370):
- (success) = recipient.call{value: amount}() (#368)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable ERC20._balances (#57) is not in mixedCase
Variable ERC20._allowances (#59) is not in mixedCase
Function IRouter.WETH() (#414) is not in mixedCase
Function MKD.handle_fees(uint256,MKD.Taxes) (#651-693) is not in mixedCase
Parameter MKD.updateLiquidityTreshhold(uint256).new_amount (#733) is not in mixedCase
Function MKD.SetBuyTaxes(uint256,uint256,uint256,uint256) (#738-746) is not in mixedCase
Parameter MKD.SetBuyTaxes(uint256,uint256,uint256,uint256)._marketing (#739) is not in mixedCase
Parameter MKD.SetBuyTaxes(uint256,uint256,uint256,uint256)._liquidity (#740) is not in mixedCase
Parameter MKD.SetBuyTaxes(uint256,uint256,uint256,uint256)._gamedev (#741) is not in mixedCase
Parameter MKD.SetBuyTaxes(uint256,uint256,uint256,uint256)._dev (#742) is not in mixedCase
Function MKD.SetSellTaxes(uint256,uint256,uint256,uint256) (#748-756) is not in mixedCase
Parameter MKD.SetSellTaxes(uint256,uint256,uint256,uint256)._marketing (#749) is not in mixedCase
Parameter MKD.SetSellTaxes(uint256,uint256,uint256,uint256)._liquidity (#750) is not in mixedCase
Parameter MKD.SetSellTaxes(uint256,uint256,uint256,uint256)._gamedev (#751) is not in mixedCase
Parameter MKD.SetSellTaxes(uint256,uint256,uint256,uint256)._dev (#752) is not in mixedCase
Function MKD.EnableTrading() (#763-768) is not in mixedCase
Parameter MKD.updatedeadline(uint256)._deadline (#770) is not in mixedCase
Parameter MKD.updateExemptFee(address,bool)._address (#803) is not in mixedCase
Variable MKD.genesis_block (#456) is not in mixedCase
Constant MKD.deadWallet (#463) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#12)" inContext (#6-15)
Remove redundant statements if they congest code but offer no value.

Additional information: link

MKD.slitherConstructorConstantVariables() (#441-839) uses literals with too many digits:
- deadWallet = 0x000000000000000000000000000000000000dEaD (#463)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

MKD.launchtax (#458) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

name() should be declared external:
- ERC20.name() (#83-85)
symbol() should be declared external:
- ERC20.symbol() (#91-93)
totalSupply() should be declared external:
- ERC20.totalSupply() (#115-117)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#134-142)
- MKD.transfer(address,uint256) (#557-560)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#147-155)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#164-167)
- MKD.approve(address,uint256) (#517-520)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#182-194)
- MKD.transferFrom(address,address,uint256) (#522-534)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#208-215)
- MKD.increaseAllowance(address,uint256) (#536-543)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#231-241)
- MKD.decreaseAllowance(address,uint256) (#545-555)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#391-393)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#395-398)
Use the external attribute for functions never called from the contract.

Additional information: link

Attempt to swap token was unsuccessful. For some reason it is untradeable. If token is not in presale stage and is not traded outside PancakeSwap, then it's a scam

Additional information: link

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average 30d PancakeSwap liquidity is low.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank