MFC [Monster Finance] Token

Monster.addLiquidity(uint256,uint256) (#570-583) sends eth to arbitrary user
Dangerous calls:
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in Monster._transfer(address,address,uint256) (#466-513):
External calls:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
- _rOwned[address(this)] += rLiquidity (#367)
- _rOwned[address(this)] += rInsurance (#387)
- _rOwned[address(this)] += rtreasury (#377)
- _rOwned[sender] = _rOwned[sender] - s.rAmount (#528)
- _rOwned[recipient] = _rOwned[recipient] + s.rTransferAmount (#529)
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
- _rTotal -= rRfi (#356)
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
- _tOwned[address(this)] += tInsurance (#385)
- _tOwned[address(this)] += ttreasury (#375)
- _tOwned[address(this)] += tLiquidity (#365)
- _tOwned[sender] = _tOwned[sender] - tAmount (#522)
- _tOwned[recipient] = _tOwned[recipient] + s.tTransferAmount (#525)
Apply the check-effects-interactions pattern.

Additional information: link

Monster.rescueAnyBEP20Tokens(address,address,uint256) (#674-676) ignores return value by IERC20(_tokenAddr).transfer(_to,_amount) (#675)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Unable to verify that contract auditor is trusted: Certik, Quantstamp, Hacken, Solidity, Paladinsec, Openzeppelin, Verichains

Contract ownership is not renounced (belongs to a wallet)

Monster.initialsupply (#141) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Function IRouter.WETH() (#78) is not in mixedCase
Struct Monster.valuesFromGetValues (#177-189) is not in CapWords
Parameter Monster.setTaxes(uint256,uint256,uint256,uint256)._rfi (#345) is not in mixedCase
Parameter Monster.setTaxes(uint256,uint256,uint256,uint256)._treasury (#345) is not in mixedCase
Parameter Monster.setTaxes(uint256,uint256,uint256,uint256)._liquidity (#345) is not in mixedCase
Parameter Monster.setTaxes(uint256,uint256,uint256,uint256)._Insurance (#345) is not in mixedCase
Parameter Monster.setSellTaxes(uint256,uint256,uint256,uint256)._rfi (#350) is not in mixedCase
Parameter Monster.setSellTaxes(uint256,uint256,uint256,uint256)._treasury (#350) is not in mixedCase
Parameter Monster.setSellTaxes(uint256,uint256,uint256,uint256)._liquidity (#350) is not in mixedCase
Parameter Monster.setSellTaxes(uint256,uint256,uint256,uint256)._Insurance (#350) is not in mixedCase
Parameter Monster.updateSwapEnabled(bool)._enabled (#634) is not in mixedCase
Parameter Monster.rescueAnyBEP20Tokens(address,address,uint256)._tokenAddr (#674) is not in mixedCase
Parameter Monster.rescueAnyBEP20Tokens(address,address,uint256)._to (#674) is not in mixedCase
Parameter Monster.rescueAnyBEP20Tokens(address,address,uint256)._amount (#674) is not in mixedCase
Constant Monster._decimals (#138) is not in UPPER_CASE_WITH_UNDERSCORES
Variable Monster.genesis_block (#150) is not in mixedCase
Variable Monster.InsuranceReceiver (#153) is not in mixedCase
Constant Monster._name (#155) is not in UPPER_CASE_WITH_UNDERSCORES
Constant Monster._symbol (#156) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#56-58)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#60-63)
name() should be declared external:
- Monster.name() (#226-228)
symbol() should be declared external:
- Monster.symbol() (#229-231)
totalSupply() should be declared external:
- Monster.totalSupply() (#237-239)
allowance(address,address) should be declared external:
- Monster.allowance(address,address) (#246-248)
approve(address,uint256) should be declared external:
- Monster.approve(address,uint256) (#250-253)
transferFrom(address,address,uint256) should be declared external:
- Monster.transferFrom(address,address,uint256) (#255-263)
increaseAllowance(address,uint256) should be declared external:
- Monster.increaseAllowance(address,uint256) (#265-268)
decreaseAllowance(address,uint256) should be declared external:
- Monster.decreaseAllowance(address,uint256) (#270-276)
transfer(address,uint256) should be declared external:
- Monster.transfer(address,uint256) (#278-282)
isExcludedFromReward(address) should be declared external:
- Monster.isExcludedFromReward(address) (#284-286)
reflectionFromToken(uint256,bool) should be declared external:
- Monster.reflectionFromToken(uint256,bool) (#288-297)
excludeFromFee(address) should be declared external:
- Monster.excludeFromFee(address) (#333-335)
includeInFee(address) should be declared external:
- Monster.includeInFee(address) (#337-339)
isExcludedFromFee(address) should be declared external:
- Monster.isExcludedFromFee(address) (#341-343)
setTaxes(uint256,uint256,uint256,uint256) should be declared external:
- Monster.setTaxes(uint256,uint256,uint256,uint256) (#345-348)
setSellTaxes(uint256,uint256,uint256,uint256) should be declared external:
- Monster.setSellTaxes(uint256,uint256,uint256,uint256) (#350-353)
rescueAnyBEP20Tokens(address,address,uint256) should be declared external:
- Monster.rescueAnyBEP20Tokens(address,address,uint256) (#674-676)
Use the external attribute for functions never called from the contract.

Additional information: link

Monster.allowance(address,address).owner (#246) shadows:
- Ownable.owner() (#47-49) (function)
Monster._approve(address,address,uint256).owner (#459) shadows:
- Ownable.owner() (#47-49) (function)
Rename the local variables that shadow another component.

Additional information: link

Monster.updateCooldown(bool,uint256) (#625-628) should emit an event for:
- coolDownTime = time * 1 (#626)
Monster.updateSwapTokensAtAmount(uint256) (#630-632) should emit an event for:
- swapTokensAtAmount = amount * 10 ** _decimals (#631)
Monster.updateMaxTxLimit(uint256,uint256) (#653-656) should emit an event for:
- maxBuyLimit = maxBuy * 10 ** decimals() (#654)
- maxSellLimit = maxSell * 10 ** decimals() (#655)
Monster.updateMaxWalletlimit(uint256) (#658-660) should emit an event for:
- maxWalletLimit = amount * 10 ** decimals() (#659)
Emit an event for critical parameter changes.

Additional information: link

Monster.setTradingStatus(bool) (#299-303) compares to a boolean constant:
-state == true && genesis_block == 0 (#302)
Remove the equality to the boolean constant.

Additional information: link

Monster.includeInReward(address) (#320-331) has costly operations inside a loop:
- _excluded.pop() (#327)
Monster._reflectRfi(uint256,uint256) (#355-358) has costly operations inside a loop:
- _rTotal -= rRfi (#356)
Use a local variable to hold the loop computation result.

Additional information: link

Redundant expression "this (#33)" inContext (#27-36)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Monster.swapAndLiquify(uint256,Monster.Taxes) (#542-568) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - temp.liquidity) (#552)
-bnbToAddLiquidityWith = unitBalance * temp.liquidity (#553)
Monster.swapAndLiquify(uint256,Monster.Taxes) (#542-568) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - temp.liquidity) (#552)
-treasuryAmt = unitBalance * 2 * temp.treasury (#560)
Monster.swapAndLiquify(uint256,Monster.Taxes) (#542-568) performs a multiplication on the result of a division:
-unitBalance = deltaBalance / (denominator - temp.liquidity) (#552)
-InsuranceAmt = unitBalance * 2 * temp.Insurance (#564)
Consider ordering multiplication before division.

Additional information: link

Monster.addLiquidity(uint256,uint256) (#570-583) ignores return value by router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
Ensure that all the return values of the function calls are used.

Additional information: link

Monster.constructor(address)._pair (#202-203) lacks a zero-check on :
- pair = _pair (#206)
Monster.updatetreasuryReceiver(address).newWallet (#616) lacks a zero-check on :
- treasuryReceiver = newWallet (#617)
Monster.updateInsuranceReceiver(address).newWallet (#620) lacks a zero-check on :
- InsuranceReceiver = newWallet (#621)
Monster.updateRouterAndPair(address,address).newPair (#662) lacks a zero-check on :
- pair = newPair (#664)
Check that the address is not zero.

Additional information: link

Reentrancy in Monster._transfer(address,address,uint256) (#466-513):
External calls:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
- totFeesPaid.Insurance += tInsurance (#381)
- totFeesPaid.treasury += ttreasury (#371)
- totFeesPaid.liquidity += tLiquidity (#361)
- totFeesPaid.rfi += tRfi (#357)
Reentrancy in Monster.constructor(address) (#200-223):
External calls:
- _pair = IFactory(_router.factory()).createPair(address(this),_router.WETH()) (#202-203)
State variables written after the call(s):
- excludeFromReward(pair) (#208)
- _excluded.push(account) (#317)
- excludeFromReward(pair) (#208)
- _isExcluded[account] = true (#316)
- _isExcludedFromFee[address(this)] = true (#211)
- _isExcludedFromFee[owner()] = true (#212)
- _isExcludedFromFee[treasuryReceiver] = true (#213)
- _isExcludedFromFee[InsuranceReceiver] = true (#214)
- _rOwned[owner()] = _rTotal (#210)
- excludeFromReward(pair) (#208)
- _tOwned[account] = tokenFromReflection(_rOwned[account]) (#314)
- allowedTransfer[address(this)] = true (#216)
- allowedTransfer[owner()] = true (#217)
- allowedTransfer[pair] = true (#218)
- allowedTransfer[treasuryReceiver] = true (#219)
- allowedTransfer[InsuranceReceiver] = true (#220)
- pair = _pair (#206)
- router = _router (#205)
Reentrancy in Monster.swapAndLiquify(uint256,Monster.Taxes) (#542-568):
External calls:
- swapTokensForBNB(toSwap) (#549)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
State variables written after the call(s):
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
- _allowances[owner][spender] = amount (#462)
Reentrancy in Monster.transferFrom(address,address,uint256) (#255-263):
External calls:
- _transfer(sender,recipient,amount) (#256)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
External calls sending eth:
- _transfer(sender,recipient,amount) (#256)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#260)
- _allowances[owner][spender] = amount (#462)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in Monster._transfer(address,address,uint256) (#466-513):
External calls:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
External calls sending eth:
- swapAndLiquify(swapTokensAtAmount,sellTaxes) (#504)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- swapAndLiquify(swapTokensAtAmount,taxes) (#505)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
Event emitted after the call(s):
- Transfer(sender,address(this),s.tLiquidity + s.ttreasury + s.tInsurance) (#534)
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
- Transfer(sender,recipient,s.tTransferAmount) (#538)
- _tokenTransfer(from,to,amount,takeFee,isSell) (#512)
Reentrancy in Monster.constructor(address) (#200-223):
External calls:
- _pair = IFactory(_router.factory()).createPair(address(this),_router.WETH()) (#202-203)
Event emitted after the call(s):
- Transfer(address(0),owner(),_tTotal) (#222)
Reentrancy in Monster.swapAndLiquify(uint256,Monster.Taxes) (#542-568):
External calls:
- swapTokensForBNB(toSwap) (#549)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#463)
- addLiquidity(tokensToAddLiquidityWith,bnbToAddLiquidityWith) (#557)
Reentrancy in Monster.transferFrom(address,address,uint256) (#255-263):
External calls:
- _transfer(sender,recipient,amount) (#256)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#594-600)
- address(treasuryReceiver).sendValue(treasuryAmt) (#562)
- address(InsuranceReceiver).sendValue(InsuranceAmt) (#566)
External calls sending eth:
- _transfer(sender,recipient,amount) (#256)
- router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,owner(),block.timestamp) (#575-582)
- (success) = recipient.call{value: amount}() (#100)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#463)
- _approve(sender,_msgSender(),currentAllowance - amount) (#260)
Apply the check-effects-interactions pattern.

Additional information: link

Monster._transfer(address,address,uint256) (#466-513) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(timePassed >= coolDownTime,Cooldown enabled) (#493)
Avoid relying on block.timestamp.

Additional information: link

Context._msgData() (#32-35) is never used and should be removed
Remove unused functions.

Additional information: link

Monster._tTotal (#142) is set pre-construction with a non-constant function or state variable:
- initialsupply * 10 ** _decimals
Monster._rTotal (#143) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#97-102):
- (success) = recipient.call{value: amount}() (#100)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Contract has 37% buy tax and 96% sell tax.
Taxes are extremely high (over 30%)

Additional information: link

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap liquidity is low.

Average 30d number of PancakeSwap swaps is low.

Token is deployed only at one blockchain

Token has only one trading pair

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Token is not listed at Mobula.Finance

Additional information: link

Young tokens have high risks of scam / price dump / death

Token is marked as scam (rug pull, honeypot, phishing, etc.)

Additional information: link

Young tokens have high risks of scam / price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank