Meta Decentraland is a fantastic 3D metaverse world featuring different kinds of NFTs. In this world, you can navigate your NFTs freely through the three sections of the map.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
MDL.swapAndDistributeBNB(uint256) (#1749-1777) sends eth to arbitrary user
Dangerous calls:
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
MDL.addLiquidity(uint256,uint256) (#1783-1797) sends eth to arbitrary user
Dangerous calls:
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in MDL._transfer(address,address,uint256) (#1674-1727):
External calls:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
External calls sending eth:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
State variables written after the call(s):
- super._transfer(from,address(this),fees) (#1708)
- _balances[sender] = senderBalance - amount (#358)
- _balances[recipient] += amount (#360)
- super._transfer(from,to,amount) (#1711)
- _balances[sender] = senderBalance - amount (#358)
- _balances[recipient] += amount (#360)
- swapping = false (#1697)
Apply the check-effects-interactions pattern.
Additional information: link
DividendPayingToken._withdrawDividendOfUser(address) (#915-925) ignores return value by usdtTokenAddress.transfer(user,_withdrawableDividend) (#920)
MDLDividendTracker.withdrawStuckTokens(address,address,uint256) (#1220-1222) ignores return value by IERC20(_token).transfer(_receiver,_amount) (#1221)
MDL.withdrawStuckTokens(address,uint256) (#1779-1781) ignores return value by IERC20(_token).transfer(msg.sender,_amount) (#1780)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Reentrancy in MDL.constructor() (#1485-1507):
External calls:
- updatePancakeRouter(0x10ED43C718714eb63d5aA57B78B54704E256024E) (#1488)
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
- dividendTracker.excludeFromDividends(address(pancakeRouter)) (#1516)
- dividendTracker.excludeFromDividends(pancakePair) (#1517)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1491)
- dividendTracker.excludeFromDividends(address(this)) (#1492)
- dividendTracker.excludeFromDividends(address(0)) (#1493)
State variables written after the call(s):
- _mint(owner(),10 ** 9 * (10 ** decimals())) (#1504)
- _balances[account] += amount (#382)
- _mint(owner(),10 ** 9 * (10 ** decimals())) (#1504)
- _totalSupply += amount (#381)
- liquidityWallet = owner() (#1506)
- marketingWallet = owner() (#1505)
Reentrancy in DividendPayingToken.distributeDividends() (#875-890):
External calls:
- swapETHForTokens(msg.value) (#880)
- pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,address(this),block.timestamp.add(300)) (#899-904)
State variables written after the call(s):
- magnifiedDividendPerShare = magnifiedDividendPerShare.add((swapBalance).mul(magnitude) / totalSupply()) (#883-885)
- totalDividendsDistributed = totalDividendsDistributed.add(swapBalance) (#888)
Reentrancy in MDLDividendTracker.processAccount(address,bool) (#1208-1218):
External calls:
- amount = _withdrawDividendOfUser(account) (#1209)
- usdtTokenAddress.transfer(user,_withdrawableDividend) (#920)
State variables written after the call(s):
- lastClaimTimes[account] = block.timestamp (#1212)
Reentrancy in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
External calls:
- swapTokensForEth(tokens.sub(liquidityTokens)) (#1753)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
External calls sending eth:
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
State variables written after the call(s):
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
- _allowances[owner][spender] = amount (#437)
Reentrancy in MDL.updatePancakeRouter(address) (#1508-1520):
External calls:
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
State variables written after the call(s):
- pancakePair = _pancakePair (#1514)
Reentrancy in MDL.updatePancakeRouter(address) (#1508-1520):
External calls:
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
- dividendTracker.excludeFromDividends(address(pancakeRouter)) (#1516)
- dividendTracker.excludeFromDividends(pancakePair) (#1517)
State variables written after the call(s):
- excludeFromFees(newAddress,true) (#1519)
- _isExcludedFromFees[account] = excluded (#1574)
Apply the check-effects-interactions pattern.
Additional information: link
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#52-55)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#61-65)
name() should be declared external:
- ERC20.name() (#186-188)
symbol() should be declared external:
- ERC20.symbol() (#194-196)
transfer(address,uint256) should be declared external:
- ERC20.transfer(address,uint256) (#237-240)
allowance(address,address) should be declared external:
- ERC20.allowance(address,address) (#245-247)
approve(address,uint256) should be declared external:
- ERC20.approve(address,uint256) (#256-259)
transferFrom(address,address,uint256) should be declared external:
- ERC20.transferFrom(address,address,uint256) (#274-288)
increaseAllowance(address,uint256) should be declared external:
- ERC20.increaseAllowance(address,uint256) (#302-305)
decreaseAllowance(address,uint256) should be declared external:
- ERC20.decreaseAllowance(address,uint256) (#321-329)
get(IterableMapping.Map,address) should be declared external:
- IterableMapping.get(IterableMapping.Map,address) (#749-751)
getIndexOfKey(IterableMapping.Map,address) should be declared external:
- IterableMapping.getIndexOfKey(IterableMapping.Map,address) (#753-758)
getKeyAtIndex(IterableMapping.Map,uint256) should be declared external:
- IterableMapping.getKeyAtIndex(IterableMapping.Map,uint256) (#760-762)
size(IterableMapping.Map) should be declared external:
- IterableMapping.size(IterableMapping.Map) (#766-768)
withdrawDividend() should be declared external:
- DividendPayingToken.withdrawDividend() (#909-911)
- MDLDividendTracker.withdrawDividend() (#1038-1040)
dividendOf(address) should be declared external:
- DividendPayingToken.dividendOf(address) (#931-933)
withdrawnDividendOf(address) should be declared external:
- DividendPayingToken.withdrawnDividendOf(address) (#945-947)
getAccountAtIndex(uint256) should be declared external:
- MDLDividendTracker.getAccountAtIndex(uint256) (#1115-1132)
process(uint256) should be declared external:
- MDLDividendTracker.process(uint256) (#1161-1206)
withdrawStuckTokens(address,address,uint256) should be declared external:
- MDLDividendTracker.withdrawStuckTokens(address,address,uint256) (#1220-1222)
updateDividendTracker(address) should be declared external:
- MDL.updateDividendTracker(address) (#1556-1570)
excludeMultipleAccountsFromFees(address[],bool) should be declared external:
- MDL.excludeMultipleAccountsFromFees(address[],bool) (#1579-1585)
updateGasForProcessing(uint256) should be declared external:
- MDL.updateGasForProcessing(uint256) (#1587-1592)
isExcludedFromFees(address) should be declared external:
- MDL.isExcludedFromFees(address) (#1610-1612)
withdrawableDividendOf(address) should be declared external:
- MDL.withdrawableDividendOf(address) (#1614-1616)
dividendTokenBalanceOf(address) should be declared external:
- MDL.dividendTokenBalanceOf(address) (#1618-1620)
withdrawInDividend(address,uint256) should be declared external:
- MDL.withdrawInDividend(address,uint256) (#1622-1624)
withdrawStuckTokens(address,uint256) should be declared external:
- MDL.withdrawStuckTokens(address,uint256) (#1779-1781)
Use the external attribute for functions never called from the contract.
Additional information: link
Reentrancy in MDL.constructor() (#1485-1507):
External calls:
- updatePancakeRouter(0x10ED43C718714eb63d5aA57B78B54704E256024E) (#1488)
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
- dividendTracker.excludeFromDividends(address(pancakeRouter)) (#1516)
- dividendTracker.excludeFromDividends(pancakePair) (#1517)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1491)
- dividendTracker.excludeFromDividends(address(this)) (#1492)
- dividendTracker.excludeFromDividends(address(0)) (#1493)
State variables written after the call(s):
- excludeFromFees(owner(),true) (#1496)
- _isExcludedFromFees[account] = excluded (#1574)
- excludeFromFees(address(this),true) (#1497)
- _isExcludedFromFees[account] = excluded (#1574)
Reentrancy in MDL.updateDividendTracker(address) (#1556-1570):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1563)
- newDividendTracker.excludeFromDividends(address(this)) (#1564)
- newDividendTracker.excludeFromDividends(address(pancakeRouter)) (#1565)
State variables written after the call(s):
- dividendTracker = newDividendTracker (#1569)
Apply the check-effects-interactions pattern.
Additional information: link
MDL._transfer(address,address,uint256).iterations (#1720) is a local variable never initialized
MDL._transfer(address,address,uint256).claims (#1720) is a local variable never initialized
MDL._transfer(address,address,uint256).lastProcessedIndex (#1720) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
Additional information: link
MDL.claim() (#1657-1659) ignores return value by dividendTracker.processAccount(address(msg.sender),false) (#1658)
MDL._transfer(address,address,uint256) (#1674-1727) ignores return value by dividendTracker.process(gas) (#1720-1725)
MDL.addLiquidity(uint256,uint256) (#1783-1797) ignores return value by pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
Ensure that all the return values of the function calls are used.
Additional information: link
DividendPayingToken.constructor(string,string)._name (#852) shadows:
- ERC20._name (#166) (state variable)
DividendPayingToken.constructor(string,string)._symbol (#852) shadows:
- ERC20._symbol (#167) (state variable)
Rename the local variables that shadow another component.
Additional information: link
MDL.updatePancakeRouter(address)._pancakePair (#1512-1513) lacks a zero-check on :
- pancakePair = _pancakePair (#1514)
Check that the address is not zero.
Additional information: link
Variable 'MDL._transfer(address,address,uint256).claims (#1720)' in MDL._transfer(address,address,uint256) (#1674-1727) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1721)
Variable 'MDL._transfer(address,address,uint256).iterations (#1720)' in MDL._transfer(address,address,uint256) (#1674-1727) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1721)
Variable 'MDL._transfer(address,address,uint256).lastProcessedIndex (#1720)' in MDL._transfer(address,address,uint256) (#1674-1727) potentially used before declaration: ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1721)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.
Additional information: link
Reentrancy in MDL._transfer(address,address,uint256) (#1674-1727):
External calls:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
External calls sending eth:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
Event emitted after the call(s):
- Transfer(sender,recipient,amount) (#362)
- super._transfer(from,to,amount) (#1711)
- Transfer(sender,recipient,amount) (#362)
- super._transfer(from,address(this),fees) (#1708)
Reentrancy in MDL._transfer(address,address,uint256) (#1674-1727):
External calls:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
- dividendTracker.setBalance(address(from),balanceOf(from)) (#1714)
- dividendTracker.setBalance(address(to),balanceOf(to)) (#1715)
- dividendTracker.process(gas) (#1720-1725)
External calls sending eth:
- swapAndDistributeBNB(swapTokensAtAmount) (#1696)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
Event emitted after the call(s):
- ErrorInProcess(msg.sender) (#1724)
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,true,gas,tx.origin) (#1721)
Reentrancy in MDL.constructor() (#1485-1507):
External calls:
- updatePancakeRouter(0x10ED43C718714eb63d5aA57B78B54704E256024E) (#1488)
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
- dividendTracker.excludeFromDividends(address(pancakeRouter)) (#1516)
- dividendTracker.excludeFromDividends(pancakePair) (#1517)
- dividendTracker.excludeFromDividends(address(dividendTracker)) (#1491)
- dividendTracker.excludeFromDividends(address(this)) (#1492)
- dividendTracker.excludeFromDividends(address(0)) (#1493)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1576)
- excludeFromFees(address(this),true) (#1497)
- ExcludeFromFees(account,excluded) (#1576)
- excludeFromFees(owner(),true) (#1496)
- Transfer(address(0),account,amount) (#383)
- _mint(owner(),10 ** 9 * (10 ** decimals())) (#1504)
Reentrancy in DividendPayingToken.distributeDividends() (#875-890):
External calls:
- swapETHForTokens(msg.value) (#880)
- pancakeRouter.swapExactETHForTokensSupportingFeeOnTransferTokens{value: amount}(0,path,address(this),block.timestamp.add(300)) (#899-904)
Event emitted after the call(s):
- DividendsDistributed(msg.sender,swapBalance) (#886)
Reentrancy in MDLDividendTracker.processAccount(address,bool) (#1208-1218):
External calls:
- amount = _withdrawDividendOfUser(account) (#1209)
- usdtTokenAddress.transfer(user,_withdrawableDividend) (#920)
Event emitted after the call(s):
- Claim(account,amount,automatic) (#1213)
Reentrancy in MDL.processDividendTracker(uint256) (#1652-1655):
External calls:
- (iterations,claims,lastProcessedIndex) = dividendTracker.process(gas) (#1653)
Event emitted after the call(s):
- ProcessedDividendTracker(iterations,claims,lastProcessedIndex,false,gas,tx.origin) (#1654)
Reentrancy in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
External calls:
- swapTokensForEth(tokens.sub(liquidityTokens)) (#1753)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
Event emitted after the call(s):
- CalculatedBNBForEachRecipient(forMarketing,forLiquidity,forDividends) (#1761)
Reentrancy in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
External calls:
- swapTokensForEth(tokens.sub(liquidityTokens)) (#1753)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
External calls sending eth:
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
Event emitted after the call(s):
- SwapAndSendTo(forMarketing,MARKETING) (#1766)
Reentrancy in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
External calls:
- swapTokensForEth(tokens.sub(liquidityTokens)) (#1753)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
External calls sending eth:
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
Event emitted after the call(s):
- SwapAndSendTo(forDividends,DIVIDENDS) (#1772)
Reentrancy in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
External calls:
- swapTokensForEth(tokens.sub(liquidityTokens)) (#1753)
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
External calls sending eth:
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
- pancakeRouter.addLiquidityETH{value: ethAmount}(address(this),tokenAmount,0,0,liquidityWallet,block.timestamp.add(300)) (#1789-1796)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#438)
- addLiquidity(liquidityTokens,forLiquidity) (#1775)
Reentrancy in MDL.swapTokensForEth(uint256) (#1729-1747):
External calls:
- pancakeRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1739-1745)
Event emitted after the call(s):
- FinishSwapTokensForEth(address(this).balance) (#1746)
Reentrancy in MDL.updateDividendTracker(address) (#1556-1570):
External calls:
- newDividendTracker.excludeFromDividends(address(newDividendTracker)) (#1563)
- newDividendTracker.excludeFromDividends(address(this)) (#1564)
- newDividendTracker.excludeFromDividends(address(pancakeRouter)) (#1565)
Event emitted after the call(s):
- UpdateDividendTracker(newAddress,address(dividendTracker)) (#1567)
Reentrancy in MDL.updatePancakeRouter(address) (#1508-1520):
External calls:
- _pancakePair = IPancakeFactory(pancakeRouter.factory()).createPair(address(this),pancakeRouter.WETH()) (#1512-1513)
- dividendTracker.excludeFromDividends(address(pancakeRouter)) (#1516)
- dividendTracker.excludeFromDividends(pancakePair) (#1517)
Event emitted after the call(s):
- ExcludeFromFees(account,excluded) (#1576)
- excludeFromFees(newAddress,true) (#1519)
Apply the check-effects-interactions pattern.
Additional information: link
MDLDividendTracker.getAccount(address) (#1072-1113) uses timestamp for comparisons
Dangerous comparisons:
- nextClaimTime > block.timestamp (#1110-1112)
MDLDividendTracker.canAutoClaim(uint256) (#1134-1140) uses timestamp for comparisons
Dangerous comparisons:
- lastClaimTime > block.timestamp (#1135)
- block.timestamp.sub(lastClaimTime) >= claimWait (#1139)
Avoid relying on block.timestamp.
Additional information: link
Context._msgData() (#10-12) is never used and should be removed
DividendPayingToken._transfer(address,address,uint256) (#965-971) is never used and should be removed
SafeMath.div(uint256,uint256,string) (#702-711) is never used and should be removed
SafeMath.mod(uint256,uint256) (#662-664) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#728-737) is never used and should be removed
SafeMath.sub(uint256,uint256,string) (#679-688) is never used and should be removed
SafeMath.tryAdd(uint256,uint256) (#533-539) is never used and should be removed
SafeMath.tryDiv(uint256,uint256) (#575-580) is never used and should be removed
SafeMath.tryMod(uint256,uint256) (#587-592) is never used and should be removed
SafeMath.tryMul(uint256,uint256) (#558-568) is never used and should be removed
SafeMath.trySub(uint256,uint256) (#546-551) is never used and should be removed
SafeMathInt.div(int256,int256) (#501-507) is never used and should be removed
SafeMathInt.mul(int256,int256) (#491-499) is never used and should be removed
Remove unused functions.
Additional information: link
MDL.swapTokensAtAmount (#1439) is set pre-construction with a non-constant function or state variable:
- 10000 * (10 ** decimals())
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Pragma version^0.8.0 (#3) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6
solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Low level call in MDL.swapAndDistributeBNB(uint256) (#1749-1777):
- (success) = address(marketingWallet).call{value: forMarketing}() (#1763)
- (success,None) = address(dividendTracker).call{value: forDividends}() (#1769)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Parameter DividendPayingToken.dividendOf(address)._owner (#931) is not in mixedCase
Parameter DividendPayingToken.withdrawableDividendOf(address)._owner (#938) is not in mixedCase
Parameter DividendPayingToken.withdrawnDividendOf(address)._owner (#945) is not in mixedCase
Parameter DividendPayingToken.accumulativeDividendOf(address)._owner (#955) is not in mixedCase
Constant DividendPayingToken.magnitude (#829) is not in UPPER_CASE_WITH_UNDERSCORES
Parameter MDLDividendTracker.getAccount(address)._account (#1072) is not in mixedCase
Parameter MDLDividendTracker.withdrawStuckTokens(address,address,uint256)._token (#1220) is not in mixedCase
Parameter MDLDividendTracker.withdrawStuckTokens(address,address,uint256)._receiver (#1220) is not in mixedCase
Parameter MDLDividendTracker.withdrawStuckTokens(address,address,uint256)._amount (#1220) is not in mixedCase
Function IPancakePair.DOMAIN_SEPARATOR() (#1256) is not in mixedCase
Function IPancakePair.PERMIT_TYPEHASH() (#1257) is not in mixedCase
Function IPancakePair.MINIMUM_LIQUIDITY() (#1274) is not in mixedCase
Function IPancakeRouter01.WETH() (#1294) is not in mixedCase
Parameter MDL.setFees(uint256,uint256,uint256)._LiquidityFee (#1530) is not in mixedCase
Parameter MDL.setFees(uint256,uint256,uint256)._DividendFee (#1530) is not in mixedCase
Parameter MDL.setFees(uint256,uint256,uint256)._MarketingFee (#1530) is not in mixedCase
Parameter MDL.withdrawInDividend(address,uint256)._token (#1622) is not in mixedCase
Parameter MDL.withdrawInDividend(address,uint256)._amount (#1622) is not in mixedCase
Parameter MDL.withdrawStuckTokens(address,uint256)._token (#1779) is not in mixedCase
Parameter MDL.withdrawStuckTokens(address,uint256)._amount (#1779) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Variable DividendPayingToken._withdrawDividendOfUser(address)._withdrawableDividend (#916) is too similar to MDLDividendTracker.getAccount(address).withdrawableDividends (#1076)
Variable IPancakeRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#1299) is too similar to IPancakeRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#1300)
Prevent variables from having similar names.
Additional information: link
MDLDividendTracker.getAccountAtIndex(uint256) (#1115-1132) uses literals with too many digits:
- (0x0000000000000000000000000000000000000000,- 1,- 1,0,0,0,0,0) (#1126)
MDL.updateGasForProcessing(uint256) (#1587-1592) uses literals with too many digits:
- require(bool,string)(newValue >= 200000 && newValue <= 500000,MDL: gasForProcessing must be between 200,000 and 500,000) (#1588)
MDL.slitherConstructorVariables() (#1427-1803) uses literals with too many digits:
- gasForProcessing = 300000 (#1447)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
Ownable._previousOwner (#17) is never used in MDLDividendTracker (#1008-1223)
Ownable._previousOwner (#17) is never used in MDL (#1427-1803)
Remove unused state variables.
Additional information: link
Ownable._previousOwner (#17) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.
Average 30d PancakeSwap volume is low.
Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.
Token is deployed only at one blockchain
Unable to find PancakeSwap trading pair to compute liquidity.
Unable to find PancakeSwap trading pair to compute number of swaps.
BscScan page for the token does not contain additional info: website, socials, description, etc.
Additional information: link
Unable to find token contract audit
Unable to find audit link on the website
Young tokens have high risks of price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank
Token has relatively low CoinMarketCap rank
Twitter account link seems to be invalid
Unable to find Youtube account