$MDeFi [Mysterious DeFi] Token

MysteriousDeFi.contractSwap(uint256) (#669-706) sends eth to arbitrary user
Dangerous calls:
- reflector.load{value: rewardsBalance}() (#697)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in MysteriousDeFi._transfer(address,address,uint256) (#540-592):
External calls:
- contractSwap(contractTokenBalance) (#584)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#683-689)
- reflector.load{value: rewardsBalance}() (#697)
External calls sending eth:
- contractSwap(contractTokenBalance) (#584)
- reflector.load{value: rewardsBalance}() (#697)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
State variables written after the call(s):
- lastSwap = block.timestamp (#585)
Reentrancy in MysteriousDeFi._transfer(address,address,uint256) (#540-592):
External calls:
- contractSwap(contractTokenBalance) (#584)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#683-689)
- reflector.load{value: rewardsBalance}() (#697)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- reflector.tally(from,_tOwned[from]) (#630)
- reflector.tally(to,_tOwned[to]) (#633)
- antiSnipe.checkUser(from,to,amount) (#604-608)
- reflector.cashout(reflectorGas) (#636)
External calls sending eth:
- contractSwap(contractTokenBalance) (#584)
- reflector.load{value: rewardsBalance}() (#697)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
State variables written after the call(s):
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- _liquidityHolders[from] = true (#711)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- _tOwned[address(this)] += feeAmount (#663)
- _tOwned[from] -= amount (#615)
- _tOwned[to] += amountReceived (#620)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- contractSwapEnabled = true (#719)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- reflector = Cashier(address(this)) (#717)
Apply the check-effects-interactions pattern.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Contract ownership is not renounced (belongs to a wallet)

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Variable 'MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool).check (#604)' in MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626) potentially used before declaration: checked = check (#605)
Move all variable declarations prior to any usage of the variable, and ensure that reaching a variable declaration does not depend on some conditional if it is used unconditionally.

Additional information: link

MysteriousDeFi.setLpPair(address,bool) (#342-354) compares to a boolean constant:
-enabled == false (#343)
Remove the equality to the boolean constant.

Additional information: link

Contract ticker ($MDeFi) contains non-alphanumeric characters.
Not a direct threat, but may indicate unreliable intentions of developer. Non-alphanumeric chars (,.;!#*&") are extremely rare among low risk tokens.

Reentrancy in MysteriousDeFi.enableTrading() (#433-444):
External calls:
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#439)
- reflector.initialize() (#440)
State variables written after the call(s):
- tradingEnabled = true (#441)
Reentrancy in MysteriousDeFi.transferOwner(address) (#261-276):
External calls:
- _finalizeTransfer(_owner,newOwner,balanceOf(_owner),false,false,false,true) (#270)
- reflector.tally(from,_tOwned[from]) (#630)
- reflector.tally(to,_tOwned[to]) (#633)
- antiSnipe.checkUser(from,to,amount) (#604-608)
- reflector.cashout(reflectorGas) (#636)
State variables written after the call(s):
- _owner = newOwner (#273)
Apply the check-effects-interactions pattern.

Additional information: link

MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool).check (#604) is a local variable never initialized
MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool).checked (#603) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626) ignores return value by antiSnipe.checkUser(from,to,amount) (#604-608)
Ensure that all the return values of the function calls are used.

Additional information: link

MysteriousDeFi.setMaxTxPercent(uint256,uint256) (#470-473) should emit an event for:
- _maxTxAmount = (_tTotal * percent) / divisor (#472)
MysteriousDeFi.setMaxWalletSize(uint256,uint256) (#475-478) should emit an event for:
- _maxWalletSize = (_tTotal * percent) / divisor (#477)
MysteriousDeFi.setSwapSettings(uint256,uint256,uint256,uint256,uint256) (#493-497) should emit an event for:
- swapThreshold = (_tTotal * thresholdPercent) / thresholdDivisor (#494)
- swapAmount = (_tTotal * amountPercent) / amountDivisor (#495)
- contractSwapTimer = time (#496)
MysteriousDeFi.setReflectorSettings(uint256) (#504-507) should emit an event for:
- reflectorGas = gas (#506)
Emit an event for critical parameter changes.

Additional information: link

MysteriousDeFi.setDividendExcluded(address,bool) (#383-391) has external calls inside a loop: reflector.tally(holder,0) (#387)
MysteriousDeFi.setDividendExcluded(address,bool) (#383-391) has external calls inside a loop: reflector.tally(holder,_tOwned[holder]) (#389)
MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626) has external calls inside a loop: antiSnipe.checkUser(from,to,amount) (#604-608)
MysteriousDeFi.processTokenReflect(address,address) (#628-638) has external calls inside a loop: reflector.tally(from,_tOwned[from]) (#630)
MysteriousDeFi.processTokenReflect(address,address) (#628-638) has external calls inside a loop: reflector.tally(to,_tOwned[to]) (#633)
MysteriousDeFi.processTokenReflect(address,address) (#628-638) has external calls inside a loop: reflector.cashout(reflectorGas) (#636)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626):
External calls:
- antiSnipe.checkUser(from,to,amount) (#604-608)
State variables written after the call(s):
- _tOwned[from] -= amount (#615)
- amountReceived = takeTaxes(from,amount,buy,sell,other) (#618)
- _tOwned[address(this)] += feeAmount (#663)
- _tOwned[to] += amountReceived (#620)
Reentrancy in MysteriousDeFi.constructor() (#218-254):
External calls:
- lpPair = IFactoryV2(dexRouter.factory()).createPair(dexRouter.WETH(),address(this)) (#240)
State variables written after the call(s):
- _approve(_owner,address(dexRouter),type()(uint256).max) (#243)
- _allowances[sender][spender] = amount (#308)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#244)
- _allowances[sender][spender] = amount (#308)
- _isExcludedFromDividends[_owner] = true (#249)
- _isExcludedFromDividends[lpPair] = true (#250)
- _isExcludedFromDividends[address(this)] = true (#251)
- _isExcludedFromDividends[DEAD] = true (#252)
- _isExcludedFromDividends[ZERO] = true (#253)
- _isExcludedFromFees[_owner] = true (#246)
- _isExcludedFromFees[address(this)] = true (#247)
- _isExcludedFromFees[DEAD] = true (#248)
- lpPairs[lpPair] = true (#241)
Reentrancy in MysteriousDeFi.enableTrading() (#433-444):
External calls:
- antiSnipe.setLaunch(lpPair,uint32(block.number),uint64(block.timestamp),_decimals) (#439)
- reflector.initialize() (#440)
State variables written after the call(s):
- swapAmount = (balanceOf(lpPair) * 1) / 1000 (#443)
- swapThreshold = (balanceOf(lpPair) * 5) / 10000 (#442)
Reentrancy in MysteriousDeFi.setBlacklistEnabled(address,bool) (#403-406):
External calls:
- antiSnipe.setBlacklistEnabled(account,enabled) (#404)
- setDividendExcluded(account,enabled) (#405)
- reflector.tally(holder,0) (#387)
- reflector.tally(holder,_tOwned[holder]) (#389)
State variables written after the call(s):
- setDividendExcluded(account,enabled) (#405)
- _isExcludedFromDividends[holder] = enabled (#385)
Reentrancy in MysteriousDeFi.setBlacklistEnabledMultiple(address[],bool) (#408-413):
External calls:
- antiSnipe.setBlacklistEnabledMultiple(accounts,enabled) (#409)
- setDividendExcluded(accounts[i],enabled) (#411)
- reflector.tally(holder,0) (#387)
- reflector.tally(holder,_tOwned[holder]) (#389)
State variables written after the call(s):
- setDividendExcluded(accounts[i],enabled) (#411)
- _isExcludedFromDividends[holder] = enabled (#385)
Reentrancy in MysteriousDeFi.setNewRouter(address) (#329-340):
External calls:
- lpPair = IFactoryV2(_newRouter.factory()).createPair(address(this),_newRouter.WETH()) (#333)
State variables written after the call(s):
- _approve(address(this),address(dexRouter),type()(uint256).max) (#339)
- _allowances[sender][spender] = amount (#308)
- dexRouter = _newRouter (#338)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626):
External calls:
- antiSnipe.checkUser(from,to,amount) (#604-608)
Event emitted after the call(s):
- Transfer(from,address(this),feeAmount) (#664)
- amountReceived = takeTaxes(from,amount,buy,sell,other) (#618)
Reentrancy in MysteriousDeFi._finalizeTransfer(address,address,uint256,bool,bool,bool,bool) (#594-626):
External calls:
- antiSnipe.checkUser(from,to,amount) (#604-608)
- processTokenReflect(from,to) (#622)
- reflector.tally(from,_tOwned[from]) (#630)
- reflector.tally(to,_tOwned[to]) (#633)
- reflector.cashout(reflectorGas) (#636)
Event emitted after the call(s):
- Transfer(from,to,amountReceived) (#624)
Reentrancy in MysteriousDeFi._transfer(address,address,uint256) (#540-592):
External calls:
- contractSwap(contractTokenBalance) (#584)
- dexRouter.swapExactTokensForETHSupportingFeeOnTransferTokens(contractTokenBalance,0,path,address(this),block.timestamp) (#683-689)
- reflector.load{value: rewardsBalance}() (#697)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- reflector.tally(from,_tOwned[from]) (#630)
- reflector.tally(to,_tOwned[to]) (#633)
- antiSnipe.checkUser(from,to,amount) (#604-608)
- reflector.cashout(reflectorGas) (#636)
External calls sending eth:
- contractSwap(contractTokenBalance) (#584)
- reflector.load{value: rewardsBalance}() (#697)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
Event emitted after the call(s):
- ContractSwapEnabledUpdated(true) (#720)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- Transfer(from,address(this),feeAmount) (#664)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- Transfer(from,to,amountReceived) (#624)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
Reentrancy in MysteriousDeFi.constructor() (#218-254):
External calls:
- lpPair = IFactoryV2(dexRouter.factory()).createPair(dexRouter.WETH(),address(this)) (#240)
Event emitted after the call(s):
- Approval(sender,spender,amount) (#309)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#244)
- Approval(sender,spender,amount) (#309)
- _approve(_owner,address(dexRouter),type()(uint256).max) (#243)
Reentrancy in MysteriousDeFi.setNewRouter(address) (#329-340):
External calls:
- lpPair = IFactoryV2(_newRouter.factory()).createPair(address(this),_newRouter.WETH()) (#333)
Event emitted after the call(s):
- Approval(sender,spender,amount) (#309)
- _approve(address(this),address(dexRouter),type()(uint256).max) (#339)
Reentrancy in MysteriousDeFi.transferOwner(address) (#261-276):
External calls:
- _finalizeTransfer(_owner,newOwner,balanceOf(_owner),false,false,false,true) (#270)
- reflector.tally(from,_tOwned[from]) (#630)
- reflector.tally(to,_tOwned[to]) (#633)
- antiSnipe.checkUser(from,to,amount) (#604-608)
- reflector.cashout(reflectorGas) (#636)
Event emitted after the call(s):
- OwnershipTransferred(_owner,newOwner) (#274)
Apply the check-effects-interactions pattern.

Additional information: link

MysteriousDeFi.setLpPair(address,bool) (#342-354) uses timestamp for comparisons
Dangerous comparisons:
- timeSinceLastPair != 0 (#347)
- require(bool,string)(block.timestamp - timeSinceLastPair > 259200,Cannot set a new pair this week!) (#348)
MysteriousDeFi._transfer(address,address,uint256) (#540-592) uses timestamp for comparisons
Dangerous comparisons:
- lastSwap + contractSwapTimer < block.timestamp (#580)
Avoid relying on block.timestamp.

Additional information: link

MysteriousDeFi._checkLiquidityAdd(address,address) (#708-722) has costly operations inside a loop:
- _hasLiqBeenAdded = true (#712)
MysteriousDeFi._checkLiquidityAdd(address,address) (#708-722) has costly operations inside a loop:
- antiSnipe = AntiSnipe(address(this)) (#714)
MysteriousDeFi._checkLiquidityAdd(address,address) (#708-722) has costly operations inside a loop:
- reflector = Cashier(address(this)) (#717)
MysteriousDeFi._checkLiquidityAdd(address,address) (#708-722) has costly operations inside a loop:
- contractSwapEnabled = true (#719)
Use a local variable to hold the loop computation result.

Additional information: link

MysteriousDeFi._basicTransfer(address,address,uint256) (#640-645) is never used and should be removed
Remove unused functions.

Additional information: link

Pragma version>=0.6.0<0.9.0 (#2) is too complex
solc-0.8.13 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Function IRouter01.WETH() (#33) is not in mixedCase
Parameter MysteriousDeFi.setProtectionSettings(bool,bool)._antiSnipe (#429) is not in mixedCase
Parameter MysteriousDeFi.setProtectionSettings(bool,bool)._antiBlock (#429) is not in mixedCase
Parameter MysteriousDeFi.setContractSwapSettings(bool,bool)._enabled (#488) is not in mixedCase
Parameter MysteriousDeFi.setRewardsProperties(uint256,uint256,uint256)._minPeriod (#499) is not in mixedCase
Parameter MysteriousDeFi.setRewardsProperties(uint256,uint256,uint256)._minReflection (#499) is not in mixedCase
Variable MysteriousDeFi._tOwned (#121) is not in mixedCase
Variable MysteriousDeFi._allowances (#124) is not in mixedCase
Constant MysteriousDeFi.startingSupply (#131) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi._name (#133) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi._symbol (#134) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi._decimals (#135) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi._tTotal (#137) is not in UPPER_CASE_WITH_UNDERSCORES
Variable MysteriousDeFi._taxRates (#152-156) is not in mixedCase
Variable MysteriousDeFi._ratios (#158-163) is not in mixedCase
Constant MysteriousDeFi.maxBuyTaxes (#165) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi.maxSellTaxes (#166) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi.maxTransferTaxes (#167) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MysteriousDeFi.masterTaxDivisor (#168) is not in UPPER_CASE_WITH_UNDERSCORES
Variable MysteriousDeFi._taxWallets (#180-183) is not in mixedCase
Variable MysteriousDeFi._hasLiqBeenAdded (#200) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Reentrancy in MysteriousDeFi._transfer(address,address,uint256) (#540-592):
External calls:
- contractSwap(contractTokenBalance) (#584)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
External calls sending eth:
- contractSwap(contractTokenBalance) (#584)
- reflector.load{value: rewardsBalance}() (#697)
- _taxWallets.marketing.transfer(marketingBalance) (#701)
- _taxWallets.team.transfer(teamBalance) (#704)
State variables written after the call(s):
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- _hasLiqBeenAdded = true (#712)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- _liquidityHolders[from] = true (#711)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- _tOwned[address(this)] += feeAmount (#663)
- _tOwned[from] -= amount (#615)
- _tOwned[to] += amountReceived (#620)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- antiSnipe = AntiSnipe(address(this)) (#714)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- contractSwapEnabled = true (#719)
- lastSwap = block.timestamp (#585)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- reflector = Cashier(address(this)) (#717)
Event emitted after the call(s):
- ContractSwapEnabledUpdated(true) (#720)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- Transfer(from,address(this),feeAmount) (#664)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
- Transfer(from,to,amountReceived) (#624)
- _finalizeTransfer(from,to,amount,takeFee,buy,sell,other) (#591)
Apply the check-effects-interactions pattern.

Additional information: link

Variable IRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#45) is too similar to IRouter01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#46)
Variable MysteriousDeFi.setInitializers(address,address).aInitializer (#356) is too similar to MysteriousDeFi.setInitializers(address,address).cInitializer (#356)
Prevent variables from having similar names.

Additional information: link

MysteriousDeFi.slitherConstructorVariables() (#117-736) uses literals with too many digits:
- reflectorGas = 300000 (#189)
MysteriousDeFi.slitherConstructorConstantVariables() (#117-736) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#172)
MysteriousDeFi.slitherConstructorConstantVariables() (#117-736) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#173)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

renounceOwnership() should be declared external:
- MysteriousDeFi.renounceOwnership() (#278-283)
approve(address,uint256) should be declared external:
- MysteriousDeFi.approve(address,uint256) (#298-302)
approveContractContingency() should be declared external:
- MysteriousDeFi.approveContractContingency() (#312-315)
setNewRouter(address) should be declared external:
- MysteriousDeFi.setNewRouter(address) (#329-340)
setExcludedFromFees(address,bool) should be declared external:
- MysteriousDeFi.setExcludedFromFees(address,bool) (#393-395)
isBlacklisted(address) should be declared external:
- MysteriousDeFi.isBlacklisted(address) (#417-419)
enableTrading() should be declared external:
- MysteriousDeFi.enableTrading() (#433-444)
getMaxTX() should be declared external:
- MysteriousDeFi.getMaxTX() (#480-482)
getMaxWallet() should be declared external:
- MysteriousDeFi.getMaxWallet() (#484-486)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank