MCVALENTINE Token

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Reentrancy in MCV._transfer(address,address,uint256) (#1003-1054):
External calls:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- devAddress.sendValue(devFee) (#1111)
- treasuryAddress.sendValue(treasuryFee) (#1112)
External calls sending eth:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1053)
- _rOwned[address(this)] += rToSwap (#910)
- _rOwned[sender] -= s.rAmount (#1072)
- _rOwned[recipient] += s.rTransferAmount (#1073)
- _tokenTransfer(from,to,amount,takeFee) (#1053)
- _rTotal -= rRfi (#905)
- _tokenTransfer(from,to,amount,takeFee) (#1053)
- _tOwned[address(this)] += tToSwap (#911)
- _tOwned[sender] -= tAmount (#1066)
- _tOwned[recipient] += s.tTransferAmount (#1069)
Reentrancy in MCV.transferFrom(address,address,uint256) (#771-788):
External calls:
- _transfer(sender,recipient,amount) (#776)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- devAddress.sendValue(devFee) (#1111)
- treasuryAddress.sendValue(treasuryFee) (#1112)
External calls sending eth:
- _transfer(sender,recipient,amount) (#776)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
State variables written after the call(s):
- _approve(sender,_msgSender(),currentAllowance - amount) (#784)
- _allowances[owner][spender] = amount (#999)
Apply the check-effects-interactions pattern.

Additional information: link

MCV.rescueAnyBEP20Tokens(address,address,uint256) (#1232-1234) ignores return value by IERC20(_tokenAddr).transfer(_to,_amount) (#1233)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

MCV.addLiquidity(uint256,uint256) (#1135-1146) ignores return value by UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
Ensure that all the return values of the function calls are used.

Additional information: link

MCV.allowance(address,address).owner (#753) shadows:
- Ownable.owner() (#79-81) (function)
MCV._approve(address,address,uint256).owner (#993) shadows:
- Ownable.owner() (#79-81) (function)
Rename the local variables that shadow another component.

Additional information: link

MCV.setMaxTransactionAmount(uint256,uint256) (#1190-1196) should emit an event for:
- maxTxAmountBuy = _tTotal / _maxTxAmountBuyPct (#1194)
- maxTxAmountSell = _tTotal / _maxTxAmountSellPct (#1195)
MCV.setNumTokensSellToAddToLiq(uint256) (#1198-1203) should emit an event for:
- numTokensSellToAddToLiquidity = amountTokens * 10 ** _decimals (#1202)
Emit an event for critical parameter changes.

Additional information: link

MCV.setTreasuryAddress(address)._treasuryAddress (#1205) lacks a zero-check on :
- treasuryAddress = _treasuryAddress (#1209)
MCV.setDevAddress(address)._devAddress (#1212) lacks a zero-check on :
- devAddress = _devAddress (#1213)
Check that the address is not zero.

Additional information: link

Reentrancy in MCV._transfer(address,address,uint256) (#1003-1054):
External calls:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- devAddress.sendValue(devFee) (#1111)
- treasuryAddress.sendValue(treasuryFee) (#1112)
External calls sending eth:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1053)
- totFeesPaid.rfi += tRfi (#906)
- totFeesPaid.toSwap += tToSwap (#912)
Reentrancy in MCV.constructor() (#695-719):
External calls:
- uniswapPair = IUniswapV2Factory(_UniswapV2Router.factory()).createPair(address(this),_UniswapV2Router.WETH()) (#699)
State variables written after the call(s):
- UniswapV2Router = _UniswapV2Router (#702)
- _isExcludedFromFee[owner()] = true (#706)
- _isExcludedFromFee[treasuryAddress] = true (#707)
- _isExcludedFromFee[devAddress] = true (#708)
- _isExcludedFromFee[address(this)] = true (#709)
- _isExcludedFromMaxWallet[owner()] = true (#711)
- _isExcludedFromMaxWallet[treasuryAddress] = true (#712)
- _isExcludedFromMaxWallet[devAddress] = true (#713)
- _isExcludedFromMaxWallet[address(this)] = true (#714)
- _isExcludedFromMaxWallet[uniswapPair] = true (#716)
- _rOwned[owner()] = _rTotal (#703)
- devAddress = address(msg.sender) (#705)
- isAutomatedMarketMakerPair[uniswapPair] = true (#700)
- treasuryAddress = address(msg.sender) (#704)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in MCV._transfer(address,address,uint256) (#1003-1054):
External calls:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- devAddress.sendValue(devFee) (#1111)
- treasuryAddress.sendValue(treasuryFee) (#1112)
External calls sending eth:
- swapAndLiquify(numTokensSellToAddToLiquidity) (#1050)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
Event emitted after the call(s):
- Transfer(sender,address(this),s.tToSwap) (#1077)
- _tokenTransfer(from,to,amount,takeFee) (#1053)
- Transfer(sender,recipient,s.tTransferAmount) (#1084)
- _tokenTransfer(from,to,amount,takeFee) (#1053)
Reentrancy in MCV.addLiquidity(uint256,uint256) (#1135-1146):
External calls:
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
Event emitted after the call(s):
- LiquidityAdded(tokenAmount,ETHAmount) (#1145)
Reentrancy in MCV.constructor() (#695-719):
External calls:
- uniswapPair = IUniswapV2Factory(_UniswapV2Router.factory()).createPair(address(this),_UniswapV2Router.WETH()) (#699)
Event emitted after the call(s):
- SetAutomatedMarketMakerPair(uniswapPair,true) (#701)
- Transfer(address(0),owner(),_tTotal) (#718)
Reentrancy in MCV.swapAndLiquify(uint256) (#1087-1113):
External calls:
- swapTokensForETH(toSwap) (#1096)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- addLiquidity(tokensToAddLiquidityWith,ETHToAddLiquidityWith) (#1103)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
External calls sending eth:
- addLiquidity(tokensToAddLiquidityWith,ETHToAddLiquidityWith) (#1103)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
Event emitted after the call(s):
- LiquidityAdded(tokenAmount,ETHAmount) (#1145)
- addLiquidity(tokensToAddLiquidityWith,ETHToAddLiquidityWith) (#1103)
Reentrancy in MCV.transferFrom(address,address,uint256) (#771-788):
External calls:
- _transfer(sender,recipient,amount) (#776)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
- UniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1126-1132)
- devAddress.sendValue(devFee) (#1111)
- treasuryAddress.sendValue(treasuryFee) (#1112)
External calls sending eth:
- _transfer(sender,recipient,amount) (#776)
- UniswapV2Router.addLiquidityETH{value: ETHAmount}(address(this),tokenAmount,0,0,devAddress,block.timestamp) (#1137-1144)
- (success) = recipient.call{value: amount}() (#424)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1000)
- _approve(sender,_msgSender(),currentAllowance - amount) (#784)
Apply the check-effects-interactions pattern.

Additional information: link

Address.isContract(address) (#393-403) uses assembly
- INLINE ASM (#399-401)
Address.verifyCallResult(bool,bytes,string) (#562-582) uses assembly
- INLINE ASM (#574-577)
Do not use evm assembly.

Additional information: link

Different versions of Solidity is used:
- Version used: ['>=0.5.0', '>=0.6.2', '^0.8.0']
- ^0.8.0 (#25)
- ^0.8.0 (#50)
- ^0.8.0 (#121)
- >=0.6.2 (#204)
- >=0.6.2 (#303)
- >=0.5.0 (#349)
- ^0.8.0 (#370)
- ^0.8.0 (#587)
Use one Solidity version.

Additional information: link

MCV.includeInReward(address) (#862-873) has costly operations inside a loop:
- _excluded.pop() (#869)
Use a local variable to hold the loop computation result.

Additional information: link

Address.functionCall(address,bytes) (#446-448) is never used and should be removed
Address.functionCall(address,bytes,string) (#456-462) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#475-481) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#489-500) is never used and should be removed
Address.functionDelegateCall(address,bytes) (#535-537) is never used and should be removed
Address.functionDelegateCall(address,bytes,string) (#545-554) is never used and should be removed
Address.functionStaticCall(address,bytes) (#508-510) is never used and should be removed
Address.functionStaticCall(address,bytes,string) (#518-527) is never used and should be removed
Address.isContract(address) (#393-403) is never used and should be removed
Address.verifyCallResult(bool,bytes,string) (#562-582) is never used and should be removed
Context._msgData() (#42-44) is never used and should be removed
Remove unused functions.

Additional information: link

MCV._rTotal (#608) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
MCV.maxTxAmountBuy (#610) is set pre-construction with a non-constant function or state variable:
- _tTotal / 1
MCV.maxTxAmountSell (#611) is set pre-construction with a non-constant function or state variable:
- _tTotal / 1
MCV.maxWalletAmount (#612) is set pre-construction with a non-constant function or state variable:
- _tTotal / 1
MCV.numTokensSellToAddToLiquidity (#630) is set pre-construction with a non-constant function or state variable:
- _tTotal / 350
MCV.appliedRates (#658) is set pre-construction with a non-constant function or state variable:
- buyRates
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.8.0 (#25) allows old versions
Pragma version^0.8.0 (#50) allows old versions
Pragma version^0.8.0 (#121) allows old versions
Pragma version>=0.6.2 (#204) allows old versions
Pragma version>=0.6.2 (#303) allows old versions
Pragma version>=0.5.0 (#349) allows old versions
Pragma version^0.8.0 (#370) allows old versions
Pragma version^0.8.0 (#587) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in Address.sendValue(address,uint256) (#421-426):
- (success) = recipient.call{value: amount}() (#424)
Low level call in Address.functionCallWithValue(address,bytes,uint256,string) (#489-500):
- (success,returndata) = target.call{value: value}(data) (#498)
Low level call in Address.functionStaticCall(address,bytes,string) (#518-527):
- (success,returndata) = target.staticcall(data) (#525)
Low level call in Address.functionDelegateCall(address,bytes,string) (#545-554):
- (success,returndata) = target.delegatecall(data) (#552)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Function IUniswapV2Router01.WETH() (#208) is not in mixedCase
Struct MCV.feeRatesStruct (#632-638) is not in CapWords
Struct MCV.valuesFromGetValues (#666-674) is not in CapWords
Parameter MCV.setSwapAndLiquifyEnabled(bool)._enabled (#896) is not in mixedCase
Parameter MCV.addLiquidity(uint256,uint256).ETHAmount (#1135) is not in mixedCase
Parameter MCV.setAutomatedMarketMakerPair(address,bool)._pair (#1148) is not in mixedCase
Parameter MCV.setBuyFees(uint8,uint8,uint8,uint8)._rfi (#1165) is not in mixedCase
Parameter MCV.setBuyFees(uint8,uint8,uint8,uint8)._treasury (#1166) is not in mixedCase
Parameter MCV.setBuyFees(uint8,uint8,uint8,uint8)._dev (#1167) is not in mixedCase
Parameter MCV.setBuyFees(uint8,uint8,uint8,uint8)._lp (#1168) is not in mixedCase
Parameter MCV.setSellFees(uint8,uint8,uint8,uint8)._rfi (#1178) is not in mixedCase
Parameter MCV.setSellFees(uint8,uint8,uint8,uint8)._treasury (#1179) is not in mixedCase
Parameter MCV.setSellFees(uint8,uint8,uint8,uint8)._dev (#1180) is not in mixedCase
Parameter MCV.setSellFees(uint8,uint8,uint8,uint8)._lp (#1181) is not in mixedCase
Parameter MCV.setMaxTransactionAmount(uint256,uint256)._maxTxAmountBuyPct (#1191) is not in mixedCase
Parameter MCV.setMaxTransactionAmount(uint256,uint256)._maxTxAmountSellPct (#1192) is not in mixedCase
Parameter MCV.setTreasuryAddress(address)._treasuryAddress (#1205) is not in mixedCase
Parameter MCV.setDevAddress(address)._devAddress (#1212) is not in mixedCase
Parameter MCV.rescueAnyBEP20Tokens(address,address,uint256)._tokenAddr (#1232) is not in mixedCase
Parameter MCV.rescueAnyBEP20Tokens(address,address,uint256)._to (#1232) is not in mixedCase
Parameter MCV.rescueAnyBEP20Tokens(address,address,uint256)._amount (#1232) is not in mixedCase
Parameter MCV.setMaxWalletAmount(uint256)._maxWalletAmountPct (#1241) is not in mixedCase
Constant MCV._decimals (#604) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MCV._name (#623) is not in UPPER_CASE_WITH_UNDERSCORES
Constant MCV._symbol (#624) is not in UPPER_CASE_WITH_UNDERSCORES
Variable MCV.UniswapV2Router (#627) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#213) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#214)
Prevent variables from having similar names.

Additional information: link

MCV._tTotal (#607) should be constant
MCV.blocksToWait (#617) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#98-100)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#106-109)
name() should be declared external:
- MCV.name() (#722-724)
symbol() should be declared external:
- MCV.symbol() (#726-728)
decimals() should be declared external:
- MCV.decimals() (#730-732)
totalSupply() should be declared external:
- MCV.totalSupply() (#735-737)
transfer(address,uint256) should be declared external:
- MCV.transfer(address,uint256) (#744-751)
approve(address,uint256) should be declared external:
- MCV.approve(address,uint256) (#762-769)
transferFrom(address,address,uint256) should be declared external:
- MCV.transferFrom(address,address,uint256) (#771-788)
increaseAllowance(address,uint256) should be declared external:
- MCV.increaseAllowance(address,uint256) (#790-801)
decreaseAllowance(address,uint256) should be declared external:
- MCV.decreaseAllowance(address,uint256) (#803-818)
isExcludedFromReward(address) should be declared external:
- MCV.isExcludedFromReward(address) (#820-822)
reflectionFromToken(uint256,bool) should be declared external:
- MCV.reflectionFromToken(uint256,bool) (#824-837)
isExcludedFromFee(address) should be declared external:
- MCV.isExcludedFromFee(address) (#884-886)
isExcludedFromMaxWallet(address) should be declared external:
- MCV.isExcludedFromMaxWallet(address) (#888-894)
setSwapAndLiquifyEnabled(bool) should be declared external:
- MCV.setSwapAndLiquifyEnabled(bool) (#896-899)
rescueAnyBEP20Tokens(address,address,uint256) should be declared external:
- MCV.rescueAnyBEP20Tokens(address,address,uint256) (#1232-1234)
Use the external attribute for functions never called from the contract.

Additional information: link

Token seems to be untradeable: there is no PancakeSwap trading pair and no trading volumes. Ignore for presale.

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Unable to find website, listings and other project-related information

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank