Milk and Butter is the original BSC charity project. Charity fees are collected on every transaction
MilkAndButter.recoverERC20(address,uint256) (#817-820) ignores return value by IERC20(tokenAddress).transfer(owner(),tokenAmount) (#819)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
MilkAndButter.addLiquidity(uint256,uint256) (#1213-1253) sends eth to arbitrary user
Dangerous calls:
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in MilkAndButter._transfer(address,address,uint256) (#1090-1134):
External calls:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _charityFee = _previousCharityFee (#1073)
- _charityFee = 0 (#1066)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _expenseFee = _previousExpenseFee (#1074)
- _expenseFee = 0 (#1067)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _liquidityFee = _previousLiquidityFee (#1072)
- _liquidityFee = 0 (#1065)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _rOwned[address(this)] = _rOwned[address(this)].add(rFunds) (#1039)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1288)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1279)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1280)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#969)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#1299)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1290)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#1300)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#971)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _rTotal = _rTotal.sub(rFee) (#994)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _tOwned[address(this)] = _tOwned[address(this)].add(tFunds) (#1041)
- _tOwned[sender] = _tOwned[sender].sub(tAmount) (#1298)
- _tOwned[sender] = _tOwned[sender].sub(tAmount) (#968)
- _tOwned[recipient] = _tOwned[recipient].add(tTransferAmount) (#1289)
- _tOwned[recipient] = _tOwned[recipient].add(tTransferAmount) (#970)
Apply the check-effects-interactions pattern.
Additional information: link
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Contract ownership is not renounced (belongs to a wallet)
Not a direct threat, but may indicate unreliable intentions of developer. Widespread names (e.g. Elon, King, Moon, Doge) are common among meme-tokens and scams. The allow to gain free hype and attract unexperienced investors.
MilkAndButter.allowance(address,address).owner (#883) shadows:
- Ownable.owner() (#420-422) (function)
MilkAndButter._approve(address,address,uint256).owner (#1082) shadows:
- Ownable.owner() (#420-422) (function)
Rename the local variables that shadow another component.
Additional information: link
MilkAndButter.addLiquidity(uint256,uint256) (#1213-1253) ignores return value by uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
MilkAndButter.addLiquidity(uint256,uint256) (#1213-1253) ignores return value by uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
MilkAndButter.addLiquidity(uint256,uint256) (#1213-1253) ignores return value by uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
Ensure that all the return values of the function calls are used.
Additional information: link
MilkAndButter.setLiquidityPercentages(uint256,uint256,uint256) (#794-800) should emit an event for:
- _liquidityToBurn = toBurn (#797)
- _liquidityToManager = toManager (#798)
- _liquidityToLock = toLock (#799)
MilkAndButter.setFees(uint256,uint256,uint256,uint256) (#802-809) should emit an event for:
- _taxFee = reflectFee (#805)
- _liquidityFee = liquidityFee (#806)
- _charityFee = charityFee (#807)
- _expenseFee = expenseFee (#808)
Emit an event for critical parameter changes.
Additional information: link
Ownable.transferOwnership(address).newOwner (#432) lacks a zero-check on :
- _owner = newOwner (#435)
MilkAndButter.setUSDTAddress(address).USDTAddress (#769) lacks a zero-check on :
- _USDTAddress = USDTAddress (#771)
MilkAndButter.setCharityAddress(address).charityAddress (#774) lacks a zero-check on :
- _charity = charityAddress (#776)
MilkAndButter.setLockedLiquidity(address).lockedLiquidityAddress (#779) lacks a zero-check on :
- _lockedLiquidity = lockedLiquidityAddress (#781)
MilkAndButter.setLiquidityManager(address).liquidityManagerAddress (#784) lacks a zero-check on :
- _liquidityManager = liquidityManagerAddress (#786)
MilkAndButter.setExpenseAddress(address).expenseAddress (#789) lacks a zero-check on :
- _expense = expenseAddress (#791)
MilkAndButter.setRouterAndPair(address,address).pair (#811) lacks a zero-check on :
- uniswapV2Pair = pair (#814)
Check that the address is not zero.
Additional information: link
Reentrancy in MilkAndButter._transfer(address,address,uint256) (#1090-1134):
External calls:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _previousCharityFee = _charityFee (#1061)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _previousExpenseFee = _expenseFee (#1062)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _previousLiquidityFee = _liquidityFee (#1060)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _previousTaxFee = _taxFee (#1059)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _tFeeTotal = _tFeeTotal.add(tFee) (#995)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- _taxFee = _previousTaxFee (#1071)
- _taxFee = 0 (#1064)
Reentrancy in MilkAndButter.constructor() (#838-855):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#843-844)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#850)
- _isExcludedFromFee[address(this)] = true (#851)
- _isExcludedFromFee[burn()] = true (#852)
- uniswapV2Router = _uniswapV2Router (#847)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
State variables written after the call(s):
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- _allowances[owner][spender] = amount (#1086)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForEth(half) (#1164)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
State variables written after the call(s):
- swapTokensForEth(half) (#1164)
- _allowances[owner][spender] = amount (#1086)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForEth(half) (#1164)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- addLiquidity(otherHalf,newBalance) (#1168)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1168)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#1168)
- _allowances[owner][spender] = amount (#1086)
Reentrancy in MilkAndButter.transferFrom(address,address,uint256) (#892-896):
External calls:
- _transfer(sender,recipient,amount) (#893)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- _transfer(sender,recipient,amount) (#893)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#894)
- _allowances[owner][spender] = amount (#1086)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in MilkAndButter._transfer(address,address,uint256) (#1090-1134):
External calls:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#1121)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
Event emitted after the call(s):
- Transfer(sender,recipient,tTransferAmount) (#1283)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- Transfer(sender,recipient,tTransferAmount) (#1293)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- Transfer(sender,recipient,tTransferAmount) (#1303)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
- Transfer(sender,recipient,tTransferAmount) (#974)
- _tokenTransfer(from,to,amount,takeFee) (#1133)
Reentrancy in MilkAndButter.constructor() (#838-855):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#843-844)
Event emitted after the call(s):
- Transfer(address(0),_msgSender(),_tTotal) (#854)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1087)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForEth(half) (#1164)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1087)
- swapTokensForEth(half) (#1164)
Reentrancy in MilkAndButter.swapAndLiquify(uint256) (#1141-1169):
External calls:
- swapTokensForUSDT(tokensForCharity,_charity) (#1155)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForUSDT(tokensForExpense,_expense) (#1156)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- swapTokensForEth(half) (#1164)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- addLiquidity(otherHalf,newBalance) (#1168)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#1168)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1087)
- addLiquidity(otherHalf,newBalance) (#1168)
Reentrancy in MilkAndButter.transferFrom(address,address,uint256) (#892-896):
External calls:
- _transfer(sender,recipient,amount) (#893)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#1183-1189)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.swapExactTokensForTokensSupportingFeeOnTransferTokens(tokenAmount,0,path,destination,block.timestamp) (#1204-1210)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
External calls sending eth:
- _transfer(sender,recipient,amount) (#893)
- uniswapV2Router.addLiquidityETH{value: ethToLock}(address(this),tokensToLock,0,0,lockedLiquidity(),block.timestamp) (#1227-1234)
- uniswapV2Router.addLiquidityETH{value: ethToManager}(address(this),tokensToManager,0,0,liquidityManager(),block.timestamp) (#1236-1243)
- uniswapV2Router.addLiquidityETH{value: ethToBurn}(address(this),tokensToBurn,0,0,burn(),block.timestamp) (#1245-1252)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#1087)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#894)
Apply the check-effects-interactions pattern.
Additional information: link
Address.isContract(address) (#274-283) uses assembly
- INLINE ASM (#281)
Address._functionCallWithValue(address,bytes,uint256,string) (#367-388) uses assembly
- INLINE ASM (#380-383)
Do not use evm assembly.
Additional information: link
MilkAndButter.includeInReward(address) (#952-963) has costly operations inside a loop:
- _excluded.pop() (#959)
Use a local variable to hold the loop computation result.
Additional information: link
Address._functionCallWithValue(address,bytes,uint256,string) (#367-388) is never used and should be removed
Address.functionCall(address,bytes) (#327-329) is never used and should be removed
Address.functionCall(address,bytes,string) (#337-339) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256) (#352-354) is never used and should be removed
Address.functionCallWithValue(address,bytes,uint256,string) (#362-365) is never used and should be removed
Address.isContract(address) (#274-283) is never used and should be removed
Address.sendValue(address,uint256) (#301-307) is never used and should be removed
Context._msgData() (#246-249) is never used and should be removed
SafeMath.mod(uint256,uint256) (#219-221) is never used and should be removed
SafeMath.mod(uint256,uint256,string) (#235-238) is never used and should be removed
Remove unused functions.
Additional information: link
MilkAndButter._rTotal (#677) is set pre-construction with a non-constant function or state variable:
- (MAX - (MAX % _tTotal))
MilkAndButter._previousTaxFee (#713) is set pre-construction with a non-constant function or state variable:
- _taxFee
MilkAndButter._previousLiquidityFee (#716) is set pre-construction with a non-constant function or state variable:
- _liquidityFee
MilkAndButter._previousCharityFee (#719) is set pre-construction with a non-constant function or state variable:
- _charityFee
MilkAndButter._previousExpenseFee (#722) is set pre-construction with a non-constant function or state variable:
- _expenseFee
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Low level call in Address.sendValue(address,uint256) (#301-307):
- (success) = recipient.call{value: amount}() (#305)
Low level call in Address._functionCallWithValue(address,bytes,uint256,string) (#367-388):
- (success,returndata) = target.call{value: weiValue}(data) (#371)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#484) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#485) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#502) is not in mixedCase
Function IUniswapV2Router01.WETH() (#524) is not in mixedCase
Parameter MilkAndButter.setUSDTAddress(address).USDTAddress (#769) is not in mixedCase
Parameter MilkAndButter.setSwapAndLiquifyEnabled(bool)._enabled (#985) is not in mixedCase
Parameter MilkAndButter.calculateTaxFee(uint256)._amount (#1044) is not in mixedCase
Parameter MilkAndButter.calculateFundsFee(uint256)._amount (#1050) is not in mixedCase
Variable MilkAndButter._maxTxAmount (#690) is not in mixedCase
Variable MilkAndButter._charity (#699) is not in mixedCase
Variable MilkAndButter._burn (#700) is not in mixedCase
Variable MilkAndButter._expense (#701) is not in mixedCase
Variable MilkAndButter._lockedLiquidity (#702) is not in mixedCase
Variable MilkAndButter._liquidityManager (#703) is not in mixedCase
Variable MilkAndButter._USDTAddress (#704) is not in mixedCase
Variable MilkAndButter._liquidityToBurn (#707) is not in mixedCase
Variable MilkAndButter._liquidityToManager (#708) is not in mixedCase
Variable MilkAndButter._liquidityToLock (#709) is not in mixedCase
Variable MilkAndButter._taxFee (#712) is not in mixedCase
Variable MilkAndButter._liquidityFee (#715) is not in mixedCase
Variable MilkAndButter._charityFee (#718) is not in mixedCase
Variable MilkAndButter._expenseFee (#721) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Redundant expression "this (#247)" inContext (#241-250)
Remove redundant statements if they congest code but offer no value.
Additional information: link
Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#529) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#530)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._transferFromExcluded(address,address,uint256).rTransferAmount (#1297) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._getValues(uint256).rTransferAmount (#1000) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._transferFromExcluded(address,address,uint256).tTransferAmount (#1297)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._transferStandard(address,address,uint256).tTransferAmount (#1278)
Variable MilkAndButter.reflectionFromToken(uint256,bool).rTransferAmount (#931) is too similar to MilkAndButter._transferToExcluded(address,address,uint256).tTransferAmount (#1287)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter._transferToExcluded(address,address,uint256).rTransferAmount (#1287) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Variable MilkAndButter._transferStandard(address,address,uint256).rTransferAmount (#1278) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._getValues(uint256).tTransferAmount (#999)
Variable MilkAndButter._transferBothExcluded(address,address,uint256).rTransferAmount (#967) is too similar to MilkAndButter._getTValues(uint256).tTransferAmount (#1007)
Variable MilkAndButter._getRValues(uint256,uint256,uint256,uint256).rTransferAmount (#1015) is too similar to MilkAndButter._transferBothExcluded(address,address,uint256).tTransferAmount (#967)
Prevent variables from having similar names.
Additional information: link
MilkAndButter.slitherConstructorVariables() (#662-1306) uses literals with too many digits:
- _tTotal = 1000000000 * 10 ** 3 * 10 ** 9 (#676)
MilkAndButter.slitherConstructorVariables() (#662-1306) uses literals with too many digits:
- _maxTxAmount = 1000000000 * 10 ** 3 * 10 ** 9 (#690)
MilkAndButter.slitherConstructorVariables() (#662-1306) uses literals with too many digits:
- _burn = address(0x0000000000000000000000000000000000000001) (#700)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
MilkAndButter._burn (#700) should be constant
MilkAndButter._decimals (#682) should be constant
MilkAndButter._maxTxAmount (#690) should be constant
MilkAndButter._name (#680) should be constant
MilkAndButter._symbol (#681) should be constant
MilkAndButter._tTotal (#676) should be constant
MilkAndButter.numTokensSellToAddToLiquidity (#691) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#432-436)
charity() should be declared external:
- MilkAndButter.charity() (#727-730)
expense() should be declared external:
- MilkAndButter.expense() (#747-750)
liquidityToBurn() should be declared external:
- MilkAndButter.liquidityToBurn() (#752-755)
liquidityToManager() should be declared external:
- MilkAndButter.liquidityToManager() (#757-760)
liquidityToLock() should be declared external:
- MilkAndButter.liquidityToLock() (#762-765)
setUSDTAddress(address) should be declared external:
- MilkAndButter.setUSDTAddress(address) (#769-772)
setCharityAddress(address) should be declared external:
- MilkAndButter.setCharityAddress(address) (#774-777)
setLockedLiquidity(address) should be declared external:
- MilkAndButter.setLockedLiquidity(address) (#779-782)
setLiquidityManager(address) should be declared external:
- MilkAndButter.setLiquidityManager(address) (#784-787)
setExpenseAddress(address) should be declared external:
- MilkAndButter.setExpenseAddress(address) (#789-792)
setLiquidityPercentages(uint256,uint256,uint256) should be declared external:
- MilkAndButter.setLiquidityPercentages(uint256,uint256,uint256) (#794-800)
setFees(uint256,uint256,uint256,uint256) should be declared external:
- MilkAndButter.setFees(uint256,uint256,uint256,uint256) (#802-809)
setRouterAndPair(address,address) should be declared external:
- MilkAndButter.setRouterAndPair(address,address) (#811-815)
recoverERC20(address,uint256) should be declared external:
- MilkAndButter.recoverERC20(address,uint256) (#817-820)
name() should be declared external:
- MilkAndButter.name() (#857-859)
symbol() should be declared external:
- MilkAndButter.symbol() (#861-863)
decimals() should be declared external:
- MilkAndButter.decimals() (#865-867)
totalSupply() should be declared external:
- MilkAndButter.totalSupply() (#869-871)
transfer(address,uint256) should be declared external:
- MilkAndButter.transfer(address,uint256) (#878-881)
allowance(address,address) should be declared external:
- MilkAndButter.allowance(address,address) (#883-885)
approve(address,uint256) should be declared external:
- MilkAndButter.approve(address,uint256) (#887-890)
transferFrom(address,address,uint256) should be declared external:
- MilkAndButter.transferFrom(address,address,uint256) (#892-896)
increaseAllowance(address,uint256) should be declared external:
- MilkAndButter.increaseAllowance(address,uint256) (#898-901)
decreaseAllowance(address,uint256) should be declared external:
- MilkAndButter.decreaseAllowance(address,uint256) (#903-906)
isExcludedFromReward(address) should be declared external:
- MilkAndButter.isExcludedFromReward(address) (#908-910)
totalFees() should be declared external:
- MilkAndButter.totalFees() (#912-914)
deliver(uint256) should be declared external:
- MilkAndButter.deliver(uint256) (#916-923)
reflectionFromToken(uint256,bool) should be declared external:
- MilkAndButter.reflectionFromToken(uint256,bool) (#925-934)
excludeFromReward(address) should be declared external:
- MilkAndButter.excludeFromReward(address) (#942-950)
excludeFromFee(address) should be declared external:
- MilkAndButter.excludeFromFee(address) (#977-979)
includeInFee(address) should be declared external:
- MilkAndButter.includeInFee(address) (#981-983)
setSwapAndLiquifyEnabled(bool) should be declared external:
- MilkAndButter.setSwapAndLiquifyEnabled(bool) (#985-988)
isExcludedFromFee(address) should be declared external:
- MilkAndButter.isExcludedFromFee(address) (#1078-1080)
manualSwapAndLiquify() should be declared external:
- MilkAndButter.manualSwapAndLiquify() (#1136-1139)
Use the external attribute for functions never called from the contract.
Additional information: link
Contract has 10% buy tax and 9% sell tax.
Taxes are low but contract ownership is not renounced. Token has a high risk of becoming a honeypot.
Swap operations require suspiciously high gas. Contract logic is complex and may disguise some form of scam.
Average 30d PancakeSwap volume is low.
Average 30d number of PancakeSwap swaps is low.
Average PancakeSwap trading volume, liqudity, number of swaps are low. Token seems to be inactive.
Token is deployed only at one blockchain
Token has only one trading pair
Token has relatively low CoinGecko rank
Young tokens have high risks of price dump / death
Token has relatively low CoinMarketCap rank