LMAO [Lucky ChairmanMao] Token

LuckyMAOToken.random(uint256,uint8) (#805-827) uses a weak PRNG: "_rnd = _rnd % _totalPlayers (#825)"
Do not use block.timestamp, now or blockhash as a source of randomness

Additional information: link

Reentrancy in LuckyMAOToken._transfer(address,address,uint256) (#664-701):
External calls:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- _balances[sender] = _balances[sender].sub(fd.tAmount) (#765)
- _balances[recipient] = _balances[recipient].add(fd.tTransferAmount) (#766)
- _balances[address(this)] = _balances[address(this)].add(fd.tLiquidity) (#768)
- _balances[_marketingWallet] = _balances[_marketingWallet].add(fd.tMarketing) (#769)
- _balances[_winnerAddress] = _balances[_winnerAddress].add(_pot) (#865)
Apply the check-effects-interactions pattern.

Additional information: link

LuckyMAOToken.withdraw(address,uint256) (#903-906) ignores return value by IERC20(_token).transfer(msg.sender,_amount) (#905)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

LuckyMAOToken._getValues(uint256,bool).fd (#790) is a local variable never initialized
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

Additional information: link

LuckyMAOToken.addLiquidity(uint256,uint256) (#746-759) ignores return value by uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
Ensure that all the return values of the function calls are used.

Additional information: link

LuckyMAOToken.allowance(address,address).owner (#593) shadows:
- Ownable.owner() (#185-187) (function)
LuckyMAOToken._approve(address,address,uint256).owner (#656) shadows:
- Ownable.owner() (#185-187) (function)
Rename the local variables that shadow another component.

Additional information: link

LuckyMAOToken.setFeesPercent(uint256,uint256,uint256,uint256) (#626-631) should emit an event for:
- _liquidityFee = liquidityFee (#627)
- _marketingFee = marketingFee (#628)
- _burnFee = burnFee (#629)
- _potFee = potFee (#630)
LuckyMAOToken.setMaxTx(uint256) (#633-635) should emit an event for:
- _maxTxAmount = maxTx (#634)
Emit an event for critical parameter changes.

Additional information: link

LuckyMAOToken.setSafeManager(address)._safeManager (#642) lacks a zero-check on :
- safeManager = _safeManager (#643)
LuckyMAOToken.setMarketingAddress(address)._marketingAddress (#646) lacks a zero-check on :
- _marketingWallet = _marketingAddress (#647)
Check that the address is not zero.

Additional information: link

Reentrancy in LuckyMAOToken._transfer(address,address,uint256) (#664-701):
External calls:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- _allWon = _allWon.add(_pot) (#882)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- _countUsers += 1 (#551)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- _totalSupply = _totalSupply.sub(fd.tBurn) (#771)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- _txCounter += 1 (#898)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- lastWinner_address = userAddress (#581)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- lastWinner_value = _lastWon (#580)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- potBalance = potBalance.add(fd.tPot) (#770)
- potBalance = 0 (#864)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- transactionsSinceLastLottery = transactionsSinceLastLottery.add(1) (#841)
- transactionsSinceLastLottery = 0 (#885)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- userByAddress[userAddress] = userData(userAddress,winnings,winnings,_countUsers,true) (#548)
- userByAddress[_winnerAddress].lastWon = _pot (#874)
- userByAddress[_winnerAddress].totalWon = totalWon (#875)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- userByIndex[_countUsers] = userData(userAddress,winnings,winnings,_countUsers,true) (#549)
- userByIndex[_index].lastWon = _pot (#877)
- userByIndex[_index].totalWon = totalWon (#878)
Reentrancy in LuckyMAOToken.constructor() (#493-515):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#500-501)
State variables written after the call(s):
- _isExcludedFromFee[owner()] = true (#505)
- _isExcludedFromFee[address(this)] = true (#506)
- _isExcludedFromFee[_marketingWallet] = true (#507)
- _isExcludedFromLottery[uniswapV2Pair] = true (#509)
- _isExcludedFromLottery[address(this)] = true (#510)
- safeManager = _msgSender() (#512)
- uniswapV2Router = _uniswapV2Router (#502)
Reentrancy in LuckyMAOToken.swapAndLiquify(uint256) (#703-726):
External calls:
- swapTokensForBnb(half) (#717)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
- addLiquidity(otherHalf,newBalance) (#723)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#723)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
State variables written after the call(s):
- addLiquidity(otherHalf,newBalance) (#723)
- _allowances[owner][spender] = amount (#660)
Reentrancy in LuckyMAOToken.transferFrom(address,address,uint256) (#602-606):
External calls:
- _transfer(sender,recipient,amount) (#603)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
External calls sending eth:
- _transfer(sender,recipient,amount) (#603)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#604)
- _allowances[owner][spender] = amount (#660)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in LuckyMAOToken._transfer(address,address,uint256) (#664-701):
External calls:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
External calls sending eth:
- swapAndLiquify(contractTokenBalance) (#698)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
Event emitted after the call(s):
- LotterySkipped(_winnerAddress,_pot.sub(potContribution),_pot) (#889)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- LotteryWon(_winnerAddress,_pot,prevBalance,newBalance) (#868)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- Transfer(sender,address(this),fd.tLiquidity) (#773)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- Transfer(sender,_marketingWallet,fd.tMarketing) (#774)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- Transfer(sender,address(0),fd.tBurn) (#775)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- Transfer(sender,recipient,fd.tTransferAmount) (#776)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
- Transfer(address(0),_winnerAddress,_pot) (#869)
- _tokenTransfer(from,to,amount,! (_isExcludedFromFee[from] || _isExcludedFromFee[to])) (#700)
Reentrancy in LuckyMAOToken.constructor() (#493-515):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#500-501)
Event emitted after the call(s):
- Transfer(address(0),owner(),_totalSupply) (#514)
Reentrancy in LuckyMAOToken.swapAndLiquify(uint256) (#703-726):
External calls:
- swapTokensForBnb(half) (#717)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
- addLiquidity(otherHalf,newBalance) (#723)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
External calls sending eth:
- addLiquidity(otherHalf,newBalance) (#723)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#661)
- addLiquidity(otherHalf,newBalance) (#723)
- SwapAndLiquify(half,newBalance,otherHalf) (#725)
Reentrancy in LuckyMAOToken.transferFrom(address,address,uint256) (#602-606):
External calls:
- _transfer(sender,recipient,amount) (#603)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#737-743)
External calls sending eth:
- _transfer(sender,recipient,amount) (#603)
- uniswapV2Router.addLiquidityETH{value: bnbAmount}(address(this),tokenAmount,0,0,address(this),block.timestamp) (#751-758)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#661)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#604)
Apply the check-effects-interactions pattern.

Additional information: link

Context._msgData() (#14-17) is never used and should be removed
Remove unused functions.

Additional information: link

LuckyMAOToken._totalSupply (#445) is set pre-construction with a non-constant function or state variable:
- 888888888888888888 * 10 ** _decimals
LuckyMAOToken._maxTxAmount (#453) is set pre-construction with a non-constant function or state variable:
- _totalSupply.mul(1).div(100)
LuckyMAOToken.numTokensSellToAddToLiquidity (#454) is set pre-construction with a non-constant function or state variable:
- _maxTxAmount.div(10)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Function IUniswapV2Pair.DOMAIN_SEPARATOR() (#237) is not in mixedCase
Function IUniswapV2Pair.PERMIT_TYPEHASH() (#238) is not in mixedCase
Function IUniswapV2Pair.MINIMUM_LIQUIDITY() (#255) is not in mixedCase
Function IUniswapV2Router01.WETH() (#275) is not in mixedCase
Struct LuckyMAOToken.userData (#417-423) is not in CapWords
Struct LuckyMAOToken.feeData (#779-787) is not in CapWords
Parameter LuckyMAOToken.addWinner(address,uint256)._lastWon (#578) is not in mixedCase
Parameter LuckyMAOToken.setSwapAndLiquifyEnabled(bool)._enabled (#637) is not in mixedCase
Parameter LuckyMAOToken.setSafeManager(address)._safeManager (#642) is not in mixedCase
Parameter LuckyMAOToken.setMarketingAddress(address)._marketingAddress (#646) is not in mixedCase
Parameter LuckyMAOToken.random(uint256,uint8)._totalPlayers (#805) is not in mixedCase
Parameter LuckyMAOToken.random(uint256,uint8)._w_rt (#805) is not in mixedCase
Parameter LuckyMAOToken.withdraw(address,uint256)._token (#903) is not in mixedCase
Parameter LuckyMAOToken.withdraw(address,uint256)._amount (#903) is not in mixedCase
Parameter LuckyMAOToken.withdrawBNB(uint256)._amount (#908) is not in mixedCase
Variable LuckyMAOToken._marketingWallet (#433) is not in mixedCase
Variable LuckyMAOToken._burnAddress (#439) is not in mixedCase
Variable LuckyMAOToken._liquidityFee (#447) is not in mixedCase
Variable LuckyMAOToken._marketingFee (#448) is not in mixedCase
Variable LuckyMAOToken._burnFee (#449) is not in mixedCase
Variable LuckyMAOToken._potFee (#450) is not in mixedCase
Variable LuckyMAOToken._maxTxAmount (#453) is not in mixedCase
Variable LuckyMAOToken.lastWinner_value (#457) is not in mixedCase
Variable LuckyMAOToken.lastWinner_address (#458) is not in mixedCase
Variable LuckyMAOToken.w_rt (#463) is not in mixedCase
Constant LuckyMAOToken.transactionsPerLottery (#468) is not in UPPER_CASE_WITH_UNDERSCORES
Follow the Solidity naming convention.

Additional information: link

Redundant expression "this (#15)" inContext (#9-18)
Remove redundant statements if they congest code but offer no value.

Additional information: link

Variable IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#280) is too similar to IUniswapV2Router01.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#281)
Prevent variables from having similar names.

Additional information: link

LuckyMAOToken.slitherConstructorVariables() (#413-913) uses literals with too many digits:
- _burnAddress = 0x000000000000000000000000000000000000dEaD (#439)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

LuckyMAOToken._excluded (#432) is never used in LuckyMAOToken (#413-913)
Remove unused state variables.

Additional information: link

LuckyMAOToken._decimals (#443) should be constant
LuckyMAOToken._name (#441) should be constant
LuckyMAOToken._symbol (#442) should be constant
LuckyMAOToken.w_rt (#463) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#194-197)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#199-203)
name() should be declared external:
- LuckyMAOToken.name() (#517-519)
symbol() should be declared external:
- LuckyMAOToken.symbol() (#521-523)
decimals() should be declared external:
- LuckyMAOToken.decimals() (#525-527)
totalSupply() should be declared external:
- LuckyMAOToken.totalSupply() (#529-531)
balanceOf(address) should be declared external:
- LuckyMAOToken.balanceOf(address) (#533-535)
transfer(address,uint256) should be declared external:
- LuckyMAOToken.transfer(address,uint256) (#588-591)
allowance(address,address) should be declared external:
- LuckyMAOToken.allowance(address,address) (#593-595)
approve(address,uint256) should be declared external:
- LuckyMAOToken.approve(address,uint256) (#597-600)
transferFrom(address,address,uint256) should be declared external:
- LuckyMAOToken.transferFrom(address,address,uint256) (#602-606)
increaseAllowance(address,uint256) should be declared external:
- LuckyMAOToken.increaseAllowance(address,uint256) (#608-611)
decreaseAllowance(address,uint256) should be declared external:
- LuckyMAOToken.decreaseAllowance(address,uint256) (#613-616)
setSwapAndLiquifyEnabled(bool) should be declared external:
- LuckyMAOToken.setSwapAndLiquifyEnabled(bool) (#637-640)
setSafeManager(address) should be declared external:
- LuckyMAOToken.setSafeManager(address) (#642-644)
Use the external attribute for functions never called from the contract.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d PancakeSwap volume is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Contract has 14% buy tax and 8% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Token is deployed only at one blockchain

Unable to find website, listings and other project-related information

Token has a considerable age, but we're still unable to find its website

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank

Token has a considerable age, but social accounts / website are missing or have few users

Token has a considerable age, but average PancakeSwap 30d trading volume is low