Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
KittyPunks.swapBack() (#366-407) sends eth to arbitrary user
Dangerous calls:
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
Reentrancy in KittyPunks._transferFrom(address,address,uint256) (#290-319):
External calls:
- swapBack() (#308)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#377-383)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
External calls sending eth:
- swapBack() (#308)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#312)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#315)
- amountReceived = takeFee(sender,recipient,amount) (#314)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#345)
Apply the check-effects-interactions pattern.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
KittyPunks.slitherConstructorVariables() (#187-503) performs a multiplication on the result of a division:
-swapThreshold = _totalSupply / 1000 * 3 (#227)
Consider ordering multiplication before division.
Additional information: link
KittyPunks.swapBack() (#366-407) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
Ensure that all the return values of the function calls are used.
Additional information: link
KittyPunks.setFees(uint256,uint256,uint256,uint256) (#436-443) should emit an event for:
- liquidityFee = _liquidityFee (#437)
- devFee = _devFee (#438)
- buybackFee = _buybackFee (#439)
- totalFee = _liquidityFee.add(_devFee).add(_buybackFee) (#440)
- feeDenominator = _feeDenominator (#441)
KittyPunks.setSellMultiplier(uint256) (#458-460) should emit an event for:
- _sellMultiplier = multiplier (#459)
KittyPunks.setTxLimit(uint256) (#466-469) should emit an event for:
- _maxTxAmount = amountBuy (#467)
Emit an event for critical parameter changes.
Additional information: link
Auth.transferOwnership(address).adr (#126) lacks a zero-check on :
- owner = adr (#127)
KittyPunks.setFeeReceiver(address,address)._devFeeReceiver (#461) lacks a zero-check on :
- devFeeReceiver = _devFeeReceiver (#462)
KittyPunks.setFeeReceiver(address,address)._buybackFeeReceiver (#461) lacks a zero-check on :
- buybackFeeReceiver = _buybackFeeReceiver (#463)
Check that the address is not zero.
Additional information: link
Reentrancy in KittyPunks._transferFrom(address,address,uint256) (#290-319):
External calls:
- swapBack() (#308)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#377-383)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
External calls sending eth:
- swapBack() (#308)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
State variables written after the call(s):
- launch() (#310)
- launchedAt = block.number (#427)
Reentrancy in KittyPunks.constructor() (#236-256):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#238)
State variables written after the call(s):
- _allowances[address(this)][address(router)] = type()(uint256).max (#239)
- _balances[_owner] = _totalSupply (#254)
- isFeeExempt[msg.sender] = true (#242)
- isTimelockExempt[msg.sender] = true (#249)
- isTimelockExempt[DEAD] = true (#250)
- isTimelockExempt[address(this)] = true (#251)
- isTxLimitExempt[msg.sender] = true (#244)
- isTxLimitExempt[address(this)] = true (#245)
- isTxLimitExempt[routerAddress] = true (#246)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in KittyPunks._transferFrom(address,address,uint256) (#290-319):
External calls:
- swapBack() (#308)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#377-383)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
External calls sending eth:
- swapBack() (#308)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount) (#346)
- amountReceived = takeFee(sender,recipient,amount) (#314)
- Transfer(sender,recipient,amountReceived) (#317)
Reentrancy in KittyPunks.constructor() (#236-256):
External calls:
- pair = IDEXFactory(router.factory()).createPair(WBNB,address(this)) (#238)
Event emitted after the call(s):
- Transfer(address(0),_owner,_totalSupply) (#255)
Reentrancy in KittyPunks.swapBack() (#366-407):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#377-383)
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
External calls sending eth:
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,devFeeReceiver,block.timestamp) (#397-404)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#405)
Apply the check-effects-interactions pattern.
Additional information: link
KittyPunks._transferFrom(address,address,uint256) (#290-319) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(cooldownTimer[recipient] < block.timestamp,Please wait for 1min between two operations) (#305)
Avoid relying on block.timestamp.
Additional information: link
KittyPunks.buyTokens(uint256,address) (#409-420) is never used and should be removed
Remove unused functions.
Additional information: link
KittyPunks._maxTxAmount (#199) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 8) / 100
KittyPunks._maxWalletSize (#200) is set pre-construction with a non-constant function or state variable:
- (_totalSupply * 8) / 100
KittyPunks.swapThreshold (#227) is set pre-construction with a non-constant function or state variable:
- _totalSupply / 1000 * 3
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Additional information: link
Pragma version^0.8.11 (#8) necessitates a version too recent to be trusted. Consider deploying with 0.6.12/0.7.6/0.8.7
solc-0.8.11 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.
Additional information: link
Low level call in KittyPunks.swapBack() (#366-407):
- (DevSuccess) = address(devFeeReceiver).call{gas: 30000,value: amountBNBDev}() (#391)
- (BuyBackSuccess) = address(buybackFeeReceiver).call{gas: 30000,value: amountBNBbuyback}() (#393)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Variable Auth._intAddr (#73) is not in mixedCase
Function IDEXRouter.WETH() (#141) is not in mixedCase
Parameter KittyPunks.tradingStatus(bool)._status (#352) is not in mixedCase
Parameter KittyPunks.setFees(uint256,uint256,uint256,uint256)._liquidityFee (#436) is not in mixedCase
Parameter KittyPunks.setFees(uint256,uint256,uint256,uint256)._devFee (#436) is not in mixedCase
Parameter KittyPunks.setFees(uint256,uint256,uint256,uint256)._buybackFee (#436) is not in mixedCase
Parameter KittyPunks.setFees(uint256,uint256,uint256,uint256)._feeDenominator (#436) is not in mixedCase
Parameter KittyPunks.cooldownEnabled(bool,uint8)._status (#445) is not in mixedCase
Parameter KittyPunks.cooldownEnabled(bool,uint8)._interval (#445) is not in mixedCase
Parameter KittyPunks.setFeeReceiver(address,address)._devFeeReceiver (#461) is not in mixedCase
Parameter KittyPunks.setFeeReceiver(address,address)._buybackFeeReceiver (#461) is not in mixedCase
Parameter KittyPunks.setSwapBackSettings(bool,uint256)._enabled (#470) is not in mixedCase
Parameter KittyPunks.setSwapBackSettings(bool,uint256)._amount (#470) is not in mixedCase
Parameter KittyPunks.blacklistAddress(address,bool)._address (#475) is not in mixedCase
Parameter KittyPunks.blacklistAddress(address,bool)._value (#475) is not in mixedCase
Parameter KittyPunks.transferForeignToken(address)._token (#483) is not in mixedCase
Variable KittyPunks.WBNB (#189) is not in mixedCase
Variable KittyPunks.DEAD (#190) is not in mixedCase
Variable KittyPunks.ZERO (#191) is not in mixedCase
Constant KittyPunks._name (#194) is not in UPPER_CASE_WITH_UNDERSCORES
Constant KittyPunks._symbol (#195) is not in UPPER_CASE_WITH_UNDERSCORES
Constant KittyPunks._decimals (#196) is not in UPPER_CASE_WITH_UNDERSCORES
Variable KittyPunks._totalSupply (#198) is not in mixedCase
Variable KittyPunks._maxTxAmount (#199) is not in mixedCase
Variable KittyPunks._maxWalletSize (#200) is not in mixedCase
Variable KittyPunks._balances (#202) is not in mixedCase
Variable KittyPunks._allowances (#203) is not in mixedCase
Variable KittyPunks._sellMultiplier (#215) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#146) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#147)
Prevent variables from having similar names.
Additional information: link
KittyPunks.slitherConstructorVariables() (#187-503) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#190)
KittyPunks.slitherConstructorVariables() (#187-503) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#191)
KittyPunks.slitherConstructorVariables() (#187-503) uses literals with too many digits:
- _totalSupply = 200000000 * (10 ** _decimals) (#198)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
KittyPunks.DEAD (#190) should be constant
KittyPunks.WBNB (#189) should be constant
KittyPunks.ZERO (#191) should be constant
KittyPunks._totalSupply (#198) should be constant
KittyPunks.routerAddress (#192) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
authorize(address) should be declared external:
- Auth.authorize(address) (#97-99)
unauthorize(address) should be declared external:
- Auth.unauthorize(address) (#105-107)
transferOwnership(address) should be declared external:
- Auth.transferOwnership(address) (#126-130)
tradingStatus(bool) should be declared external:
- KittyPunks.tradingStatus(bool) (#352-357)
cooldownEnabled(bool,uint8) should be declared external:
- KittyPunks.cooldownEnabled(bool,uint8) (#445-448)
blacklistAddress(address,bool) should be declared external:
- KittyPunks.blacklistAddress(address,bool) (#475-477)
transferForeignToken(address) should be declared external:
- KittyPunks.transferForeignToken(address) (#483-487)
isOverLiquified(uint256,uint256) should be declared external:
- KittyPunks.isOverLiquified(uint256,uint256) (#497-499)
Use the external attribute for functions never called from the contract.
Additional information: link
Unable to find website, listings and other project-related information
Young tokens have high risks of scam / price dump / death
Token has no active CoinGecko listing / rank
Token has no active CoinMarketCap listing / rank
Unable to find Telegram and Twitter accounts