Kaby Arena is a Free-to-Play turn-based NFT game where everyone can start playing without the need of any investment. Kaby Arena also employs the Play-to-Earn model to reward players with tokens and equipment through dynamic gameplay and participation in PvP tournaments. With this seamless combination of the F2P and P2E models, Kaby Arena gives players the opportunity to play and profit at the same time.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
AnyswapV5ERC20.delay (#146) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#319-322) ignores return value by IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#320)
Ensure that all the return values of the function calls are used.
Additional information: link
AnyswapV5ERC20.setMinter(address)._auth (#187) lacks a zero-check on :
- pendingMinter = _auth (#188)
AnyswapV5ERC20.setVault(address)._vault (#192) lacks a zero-check on :
- pendingVault = _vault (#193)
AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._underlying (#278) lacks a zero-check on :
- underlying = _underlying (#285)
Check that the address is not zero.
Additional information: link
Reentrancy in AnyswapV5ERC20.deposit() (#324-328):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),_amount) (#326)
State variables written after the call(s):
- _deposit(_amount,msg.sender) (#327)
- _totalSupply = newTotalSupply (#388)
- _deposit(_amount,msg.sender) (#327)
- balanceOf[account] += amount (#389)
Reentrancy in AnyswapV5ERC20.deposit(uint256) (#330-333):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#331)
State variables written after the call(s):
- _deposit(amount,msg.sender) (#332)
- _totalSupply = newTotalSupply (#388)
- _deposit(amount,msg.sender) (#332)
- balanceOf[account] += amount (#389)
Reentrancy in AnyswapV5ERC20.deposit(uint256,address) (#335-338):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#336)
State variables written after the call(s):
- _deposit(amount,to) (#337)
- _totalSupply = newTotalSupply (#388)
- _deposit(amount,to) (#337)
- balanceOf[account] += amount (#389)
Reentrancy in AnyswapV5ERC20.depositWithPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#313-317):
External calls:
- IERC20(underlying).permit(target,address(this),value,deadline,v,r,s) (#314)
- IERC20(underlying).safeTransferFrom(target,address(this),value) (#315)
State variables written after the call(s):
- _deposit(value,to) (#316)
- _totalSupply = newTotalSupply (#388)
- _deposit(value,to) (#316)
- balanceOf[account] += amount (#389)
Reentrancy in AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#319-322):
External calls:
- IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#320)
State variables written after the call(s):
- _deposit(value,to) (#321)
- _totalSupply = newTotalSupply (#388)
- _deposit(value,to) (#321)
- balanceOf[account] += amount (#389)
Apply the check-effects-interactions pattern.
Additional information: link
Reentrancy in AnyswapV5ERC20.deposit() (#324-328):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),_amount) (#326)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#390)
- _deposit(_amount,msg.sender) (#327)
Reentrancy in AnyswapV5ERC20.deposit(uint256) (#330-333):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#331)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#390)
- _deposit(amount,msg.sender) (#332)
Reentrancy in AnyswapV5ERC20.deposit(uint256,address) (#335-338):
External calls:
- IERC20(underlying).safeTransferFrom(msg.sender,address(this),amount) (#336)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#390)
- _deposit(amount,to) (#337)
Reentrancy in AnyswapV5ERC20.depositWithPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#313-317):
External calls:
- IERC20(underlying).permit(target,address(this),value,deadline,v,r,s) (#314)
- IERC20(underlying).safeTransferFrom(target,address(this),value) (#315)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#390)
- _deposit(value,to) (#316)
Reentrancy in AnyswapV5ERC20.depositWithTransferPermit(address,uint256,uint256,uint8,bytes32,bytes32,address) (#319-322):
External calls:
- IERC20(underlying).transferWithPermit(target,address(this),value,deadline,v,r,s) (#320)
Event emitted after the call(s):
- Transfer(address(0),account,amount) (#390)
- _deposit(value,to) (#321)
Apply the check-effects-interactions pattern.
Additional information: link
AnyswapV5ERC20.mpc() (#176-181) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp >= delayVault (#177)
AnyswapV5ERC20.applyVault() (#197-200) uses timestamp for comparisons
Dangerous comparisons:
- require(bool)(block.timestamp >= delayVault) (#198)
AnyswapV5ERC20.applyMinter() (#202-206) uses timestamp for comparisons
Dangerous comparisons:
- require(bool)(block.timestamp >= delayMinter) (#203)
AnyswapV5ERC20.permit(address,address,uint256,uint256,uint8,bytes32,bytes32) (#448-465) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp <= deadline,AnyswapV3ERC20: Expired permit) (#449)
AnyswapV5ERC20.transferWithPermit(address,address,uint256,uint256,uint8,bytes32,bytes32) (#467-491) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(block.timestamp <= deadline,AnyswapV3ERC20: Expired permit) (#468)
Avoid relying on block.timestamp.
Additional information: link
Address.isContract(address) (#86-92) uses assembly
- INLINE ASM (#90)
AnyswapV5ERC20.init(string,string,uint8,address,address,bool) (#278-306) uses assembly
- INLINE ASM (#298)
Do not use evm assembly.
Additional information: link
SafeERC20.safeApprove(IERC20,address,uint256) (#106-111) is never used and should be removed
Remove unused functions.
Additional information: link
Low level call in SafeERC20.callOptionalReturn(IERC20,bytes) (#112-123):
- (success,returndata) = address(token).call(data) (#116)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence
Additional information: link
Parameter AnyswapV5ERC20.setMinter(address)._auth (#187) is not in mixedCase
Parameter AnyswapV5ERC20.setVault(address)._vault (#192) is not in mixedCase
Parameter AnyswapV5ERC20.revokeMinter(address)._auth (#209) is not in mixedCase
Function AnyswapV5ERC20.Swapin(bytes32,address,uint256) (#249-254) is not in mixedCase
Function AnyswapV5ERC20.Swapout(uint256,address) (#256-262) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._name (#278) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._symbol (#278) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._decimals (#278) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._underlying (#278) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._vault (#278) is not in mixedCase
Parameter AnyswapV5ERC20.init(string,string,uint8,address,address,bool)._vaultOnly (#278) is not in mixedCase
Variable AnyswapV5ERC20.DOMAIN_SEPARATOR (#136) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
owner() should be declared external:
- AnyswapV5ERC20.owner() (#172-174)
changeMPCOwner(address) should be declared external:
- AnyswapV5ERC20.changeMPCOwner(address) (#230-236)
Swapin(bytes32,address,uint256) should be declared external:
- AnyswapV5ERC20.Swapin(bytes32,address,uint256) (#249-254)
Swapout(uint256,address) should be declared external:
- AnyswapV5ERC20.Swapout(uint256,address) (#256-262)
Use the external attribute for functions never called from the contract.
Additional information: link
Young tokens have high risks of price dump / death
Young tokens have high risks of price dump / death
Token has relatively low CoinGecko rank