Herity Network (https://herity.io/) is a unique Legal BSC project that plans to deliver a safer crypto investment ecosystem to all of its users.
They will offer:
1. A Crypto Seed Investment platform, providing an opportunity to their community to invest as if they were Venture Capital investors. Usually this is provided for big companies or important figures from the Crypto world. Not with Herity Network, their aim is to make every community member a VC investor. The projects that will be in the Seed Financing pools will have a legal entity attached, with fully doxed teams, making it a safe investment for their community in order to eliminate any scams or rug pulls from the get-go.
2. An NFT marketplace, but with a ‘’twist’’. Besides the fact that already have 18 NFT artists already onboard that are in the top 200 NFT artists in the World, they will also offer free services for anyone who has design, drawing or any artistic skill, to be trained and helped in becoming an NFT artist. They already have over 20 real life artists that will launch their collections in the near future.
3. A Charity Platform. The Herity Team feels that every profit made, comes with a responsibility, therefore they created an NGO that will give back to the word trough charity donations using a part of their profits, in ensuring that the funds will reach the cause in a full transparency.
Herity Network’s motto is ‘’Helping the Little Guy’’ , meaning that they wish to give an opportunity to normal people, to invest in legal and audited projects, as well as owning a piece of art before it becomes too expensive.
Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)
HerityNetwork.swapTokensForEth(uint256) (#406-432) sends eth to arbitrary user
Dangerous calls:
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
Ensure that an arbitrary user cannot withdraw unauthorized funds.
Additional information: link
HerityNetwork.transferResidualErc20(IERC20,address) (#520-523) ignores return value by token.transfer(to,erc20balance) (#522)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.
Additional information: link
Reentrancy in HerityNetwork._transfer(address,address,uint256) (#355-404):
External calls:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#420-426)
External calls sending eth:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#402)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#471)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#472)
- _rOwned[address(this)] = _rOwned[address(this)].add(rLiquidityFee) (#460)
Apply the check-effects-interactions pattern.
Additional information: link
Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.
Contract ownership is not renounced (belongs to a wallet)
HerityNetwork.slitherConstructorConstantVariables() (#165-525) uses literals with too many digits:
- _tTotal = 100000000 * 10 ** 9 (#177)
Use: Ether suffix, Time suffix, or The scientific notation
Additional information: link
HerityNetwork._transferStandard(address,address,uint256) (#445-462) performs a multiplication on the result of a division:
-tLiquidityFee = tAmount.mul(_liquidityFee).div(100) (#451)
-rLiquidityFee = tLiquidityFee.mul(currentRate) (#456)
Consider ordering multiplication before division.
Additional information: link
HerityNetwork.allowance(address,address).owner (#259) shadows:
- Ownable.owner() (#108-110) (function)
HerityNetwork._approve(address,address,uint256).owner (#345) shadows:
- Ownable.owner() (#108-110) (function)
Rename the local variables that shadow another component.
Additional information: link
Reentrancy in HerityNetwork._transfer(address,address,uint256) (#355-404):
External calls:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#420-426)
External calls sending eth:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#402)
- _liquidityFee = 8 (#332)
- _liquidityFee = 0 (#328)
- restoreAllFee() (#403)
- _liquidityFee = 8 (#332)
Reentrancy in HerityNetwork.transferFrom(address,address,uint256) (#277-292):
External calls:
- _transfer(sender,recipient,amount) (#282)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#420-426)
External calls sending eth:
- _transfer(sender,recipient,amount) (#282)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#283-290)
- _allowances[owner][spender] = amount (#351)
Apply the check-effects-interactions pattern.
Additional information: link
Variable HerityNetwork._liquidityFee (#181) is too similar to HerityNetwork._transferStandard(address,address,uint256).rLiquidityFee (#456)
Variable HerityNetwork._liquidityFee (#181) is too similar to HerityNetwork._transferStandard(address,address,uint256).tLiquidityFee (#451)
Variable HerityNetwork._transferStandard(address,address,uint256).rLiquidityFee (#456) is too similar to HerityNetwork._transferStandard(address,address,uint256).tLiquidityFee (#451)
Variable HerityNetwork._calculateReflectTransfer(address,address,uint256,uint256).rTransferAmount (#469) is too similar to HerityNetwork._transferStandard(address,address,uint256).tTransferAmount (#452)
Variable HerityNetwork._transferStandard(address,address,uint256).rTransferAmount (#457) is too similar to HerityNetwork._transferStandard(address,address,uint256).tTransferAmount (#452)
Prevent variables from having similar names.
Additional information: link
HerityNetwork._rTotal (#178) should be constant
HerityNetwork._tFeeTotal (#179) should be constant
Ownable._previousOwner (#96) should be constant
Add the constant attributes to state variables that never change.
Additional information: link
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#117-120)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#122-126)
name() should be declared external:
- HerityNetwork.name() (#226-228)
symbol() should be declared external:
- HerityNetwork.symbol() (#230-232)
decimals() should be declared external:
- HerityNetwork.decimals() (#234-236)
totalSupply() should be declared external:
- HerityNetwork.totalSupply() (#238-240)
humanBalanceOf(address) should be declared external:
- HerityNetwork.humanBalanceOf(address) (#246-248)
transfer(address,uint256) should be declared external:
- HerityNetwork.transfer(address,uint256) (#250-257)
allowance(address,address) should be declared external:
- HerityNetwork.allowance(address,address) (#259-266)
approve(address,uint256) should be declared external:
- HerityNetwork.approve(address,uint256) (#268-275)
transferFrom(address,address,uint256) should be declared external:
- HerityNetwork.transferFrom(address,address,uint256) (#277-292)
isExcludedFromFee(address) should be declared external:
- HerityNetwork.isExcludedFromFee(address) (#301-303)
Use the external attribute for functions never called from the contract.
Additional information: link
Ownable.constructor().msgSender (#103) lacks a zero-check on :
- _owner = msgSender (#104)
HerityNetwork.constructor(address,address,address).buyback (#203) lacks a zero-check on :
- _buybackAddress = buyback (#207)
HerityNetwork.constructor(address,address,address).ong (#204) lacks a zero-check on :
- _ongAddress = ong (#208)
HerityNetwork.constructor(address,address,address).router (#205) lacks a zero-check on :
- _routerAddress = router (#209)
HerityNetwork.setBuybackAddress(address)._address (#305) lacks a zero-check on :
- _buybackAddress = _address (#306)
HerityNetwork.setOngAddress(address)._address (#309) lacks a zero-check on :
- _ongAddress = _address (#310)
HerityNetwork.withdrawResidualBnb(address).newAddress (#516) lacks a zero-check on :
- address(newAddress).transfer(address(this).balance) (#517)
Check that the address is not zero.
Additional information: link
Reentrancy in HerityNetwork._transfer(address,address,uint256) (#355-404):
External calls:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#420-426)
External calls sending eth:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
Event emitted after the call(s):
- Transfer(sender,recipient,tTransferAmount) (#461)
- _tokenTransfer(from,to,amount,takeFee) (#402)
Reentrancy in HerityNetwork.constructor(address,address,address) (#202-224):
External calls:
- uniswapV2Pair = IUniswapV2Factory(_uniswapV2Router.factory()).createPair(address(this),_uniswapV2Router.WETH()) (#221-222)
Event emitted after the call(s):
- Transfer(address(0),_msgSender(),_tTotal) (#223)
Reentrancy in HerityNetwork.transferFrom(address,address,uint256) (#277-292):
External calls:
- _transfer(sender,recipient,amount) (#282)
- uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(tokenAmount,0,path,address(this),block.timestamp) (#420-426)
External calls sending eth:
- _transfer(sender,recipient,amount) (#282)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#352)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#283-290)
Apply the check-effects-interactions pattern.
Additional information: link
Function IUniswapV2Router02.WETH() (#146) is not in mixedCase
Parameter HerityNetwork.setIsExcludedFromFee(address,bool)._address (#294) is not in mixedCase
Parameter HerityNetwork.setIsExcludedFromFee(address,bool)._isExcluded (#294) is not in mixedCase
Parameter HerityNetwork.setBuybackAddress(address)._address (#305) is not in mixedCase
Parameter HerityNetwork.setOngAddress(address)._address (#309) is not in mixedCase
Parameter HerityNetwork.setSwapAndLiquifyEnabled(bool)._enabled (#511) is not in mixedCase
Constant HerityNetwork._name (#167) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HerityNetwork._symbol (#168) is not in UPPER_CASE_WITH_UNDERSCORES
Constant HerityNetwork._decimals (#169) is not in UPPER_CASE_WITH_UNDERSCORES
Variable HerityNetwork._isExcludedFromFee (#173) is not in mixedCase
Variable HerityNetwork._numTokensSellToAddToLiquidity (#176) is not in mixedCase
Constant HerityNetwork._tTotal (#177) is not in UPPER_CASE_WITH_UNDERSCORES
Variable HerityNetwork._liquidityFee (#181) is not in mixedCase
Variable HerityNetwork._buybackAddress (#184) is not in mixedCase
Variable HerityNetwork._ongAddress (#185) is not in mixedCase
Variable HerityNetwork._routerAddress (#186) is not in mixedCase
Variable HerityNetwork._maxTxAmount (#191) is not in mixedCase
Follow the Solidity naming convention.
Additional information: link
Reentrancy in HerityNetwork._transfer(address,address,uint256) (#355-404):
External calls:
- swapTokensForEth(_numTokensSellToAddToLiquidity) (#393)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
State variables written after the call(s):
- _tokenTransfer(from,to,amount,takeFee) (#402)
- _liquidityFee = 8 (#332)
- _liquidityFee = 0 (#328)
- restoreAllFee() (#403)
- _liquidityFee = 8 (#332)
- _tokenTransfer(from,to,amount,takeFee) (#402)
- _rOwned[sender] = _rOwned[sender].sub(rAmount) (#471)
- _rOwned[recipient] = _rOwned[recipient].add(rTransferAmount) (#472)
- _rOwned[address(this)] = _rOwned[address(this)].add(rLiquidityFee) (#460)
Event emitted after the call(s):
- Transfer(sender,recipient,tTransferAmount) (#461)
- _tokenTransfer(from,to,amount,takeFee) (#402)
Reentrancy in HerityNetwork.transferFrom(address,address,uint256) (#277-292):
External calls:
- _transfer(sender,recipient,amount) (#282)
- _ongAddress.transfer(half) (#430)
- _buybackAddress.transfer(amount.sub(half)) (#431)
State variables written after the call(s):
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#283-290)
- _allowances[owner][spender] = amount (#351)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#352)
- _approve(sender,_msgSender(),_allowances[sender][_msgSender()].sub(amount,ERC20: transfer amount exceeds allowance)) (#283-290)
Apply the check-effects-interactions pattern.
Additional information: link
Ownable._previousOwner (#96) is never used in HerityNetwork (#165-525)
HerityNetwork._tOwned (#171) is never used in HerityNetwork (#165-525)
HerityNetwork._tFeeTotal (#179) is never used in HerityNetwork (#165-525)
Remove unused state variables.
Additional information: link
Young tokens have high risks of scam / price dump / death
Young tokens have high risks of price dump / death