HELENA [Helena Financial] Token

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

Reentrancy in HelenaFinancial._transferFrom(address,address,uint256) (#597-635):
External calls:
- rebase() (#608)
- pairContract.sync() (#557)
- addLiquidity() (#612)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#687-693)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
- swapBack() (#616)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#723-729)
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
External calls sending eth:
- addLiquidity() (#612)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
- swapBack() (#616)
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
State variables written after the call(s):
- _gonBalances[sender] = _gonBalances[sender].sub(gonAmount) (#620)
- _gonBalances[recipient] = _gonBalances[recipient].add(gonAmountReceived) (#624-626)
- gonAmountReceived = takeFee(sender,recipient,gonAmount) (#621-623)
- _gonBalances[sControl] = _gonBalances[sControl].add(gonAmount.div(feeDenominator).mul(sControlFee)) (#652-654)
- _gonBalances[address(this)] = _gonBalances[address(this)].add(gonAmount.div(feeDenominator).mul(_hellenicFee.add(vaultFee))) (#655-657)
- _gonBalances[autoLiquidityFund] = _gonBalances[autoLiquidityFund].add(gonAmount.div(feeDenominator).mul(liquidityFee)) (#658-660)
- swapBack() (#616)
- inSwap = true (#455)
- inSwap = false (#457)
Apply the check-effects-interactions pattern.

Additional information: link

HelenaFinancial._decimals (#414) shadows:
- ERC20Detailed._decimals (#380)
HelenaFinancial._name (#412) shadows:
- ERC20Detailed._name (#378)
HelenaFinancial._symbol (#413) shadows:
- ERC20Detailed._symbol (#379)
Remove the state variable shadowing.

Additional information: link

HelenaFinancial.swapBack() (#710-747) sends eth to arbitrary user
Dangerous calls:
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

HelenaFinancial.swapBack().success (#735) is written in both
(success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
(success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
Fix or remove the writes.

Additional information: link

Pragma version^0.7.4 (#13) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

HelenaFinancial.isContract(address) (#935-939) uses assembly
- INLINE ASM (#937)
Do not use evm assembly.

Additional information: link

decimals() should be declared external:
- ERC20Detailed.decimals() (#400-402)
symbol() should be declared external:
- ERC20Detailed.symbol() (#396-398)
name() should be declared external:
- ERC20Detailed.name() (#392-394)
renounceOwnership() should be declared external:
- Ownable.renounceOwnership() (#361-364)
index() should be declared external:
- HelenaFinancial.index() (#949-951)
owner() should be declared external:
- Ownable.owner() (#348-350)
transferOwnership(address) should be declared external:
- Ownable.transferOwnership(address) (#366-368)
Use the external attribute for functions never called from the contract.

Additional information: link

Contract ownership is semi-renounced (passed to a contract)

HelenaFinancial.totalFee (#436-439) is set pre-construction with a non-constant function or state variable:
- liquidityFee.add(hellenicFee).add(vaultFee).add(sControlFee)
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

SafeMathInt.MAX_INT256 (#17) is never used in SafeMathInt (#15-49)
Remove unused state variables.

Additional information: link

HelenaFinancial.rebase() (#522-560) uses timestamp for comparisons
Dangerous comparisons:
- deltaTimeFromInit >= (8 * 31536000) (#530)
- deltaTimeFromInit >= (5 * 31536000) (#532)
- deltaTimeFromInit >= (3 * 31536000) (#534)
- deltaTimeFromInit >= (2 * 31536000) (#536)
- deltaTimeFromInit >= (31536000) (#538)
- i < times (#548)
HelenaFinancial.shouldRebase() (#774-781) uses timestamp for comparisons
Dangerous comparisons:
- _autoRebase && (_totalSupply < MAX_SUPPLY) && msg.sender != pair && ! inSwap && block.timestamp >= (_lastRebasedTime + 900) (#775-780)
HelenaFinancial.shouldAddLiquidity() (#783-789) uses timestamp for comparisons
Dangerous comparisons:
- _autoAddLiquidity && ! inSwap && msg.sender != pair && block.timestamp >= (_lastAddLiquidityTime + 86400) (#784-788)
Avoid relying on block.timestamp.

Additional information: link

SafeMathInt.div(int256,int256) (#27-31) is never used and should be removed
SafeMathInt.abs(int256) (#45-48) is never used and should be removed
SafeMathInt.mul(int256,int256) (#19-25) is never used and should be removed
SafeMathInt.sub(int256,int256) (#33-37) is never used and should be removed
SafeMath.mod(uint256,uint256) (#100-103) is never used and should be removed
SafeMathInt.add(int256,int256) (#39-43) is never used and should be removed
Remove unused functions.

Additional information: link

Low level call in HelenaFinancial.swapBack() (#710-747):
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable HelenaFinancial._autoRebase (#467) is not in mixedCase
Parameter HelenaFinancial.setAutoAddLiquidity(bool)._flag (#806) is not in mixedCase
Variable HelenaFinancial._lastAddLiquidityTime (#471) is not in mixedCase
Parameter HelenaFinancial.setFeeReceivers(address,address,address,address)._hellenicFund (#890) is not in mixedCase
Function IPancakeSwapPair.PERMIT_TYPEHASH() (#151) is not in mixedCase
Variable HelenaFinancial._isFeeExempt (#417) is not in mixedCase
Parameter HelenaFinancial.setPairAddress(address)._pairAddress (#919) is not in mixedCase
Variable HelenaFinancial._autoAddLiquidity (#468) is not in mixedCase
Function IPancakeSwapRouter.WETH() (#188) is not in mixedCase
Parameter HelenaFinancial.checkFeeExempt(address)._addr (#869) is not in mixedCase
Parameter HelenaFinancial.setRebaseRate(uint256)._rebaseRate (#514) is not in mixedCase
Variable HelenaFinancial._name (#412) is not in mixedCase
Variable HelenaFinancial._initRebaseStartTime (#469) is not in mixedCase
Parameter HelenaFinancial.setLP(address)._address (#923) is not in mixedCase
Function IPancakeSwapPair.DOMAIN_SEPARATOR() (#150) is not in mixedCase
Parameter HelenaFinancial.setFeeReceivers(address,address,address,address)._sControl (#892) is not in mixedCase
Parameter HelenaFinancial.setFeeReceivers(address,address,address,address)._vault (#891) is not in mixedCase
Parameter HelenaFinancial.setAutoRebase(bool)._flag (#797) is not in mixedCase
Function IPancakeSwapPair.MINIMUM_LIQUIDITY() (#168) is not in mixedCase
Variable HelenaFinancial._totalSupply (#472) is not in mixedCase
Parameter HelenaFinancial.setWhitelist(address)._addr (#910) is not in mixedCase
Parameter HelenaFinancial.setBotBlacklist(address,bool)._botAddress (#914) is not in mixedCase
Parameter HelenaFinancial.setFeeReceivers(address,address,address,address)._autoLiquidityFund (#889) is not in mixedCase
Parameter HelenaFinancial.setBotBlacklist(address,bool)._flag (#914) is not in mixedCase
Variable HelenaFinancial._lastRebasedTime (#470) is not in mixedCase
Variable HelenaFinancial._symbol (#413) is not in mixedCase
Variable HelenaFinancial._decimals (#414) is not in mixedCase
Variable HelenaFinancial.INDEX (#465) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IPancakeSwapRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#193) is too similar to IPancakeSwapRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#194)
Prevent variables from having similar names.

Additional information: link

HelenaFinancial.constructor() (#482-512) uses literals with too many digits:
- INDEX = gonsForBalance(100000) (#508)
HelenaFinancial.slitherConstructorConstantVariables() (#405-955) uses literals with too many digits:
- DEAD = 0x000000000000000000000000000000000000dEaD (#442)
HelenaFinancial.slitherConstructorConstantVariables() (#405-955) uses literals with too many digits:
- ZERO = 0x0000000000000000000000000000000000000000 (#443)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

HelenaFinancial.rebase() (#522-560) performs a multiplication on the result of a division:
-times = deltaTime.div(900) (#527)
-_lastRebasedTime = _lastRebasedTime.add(times.mul(900)) (#555)
HelenaFinancial.takeFee(address,address,uint256) (#637-664) performs a multiplication on the result of a division:
-_gonBalances[sControl] = _gonBalances[sControl].add(gonAmount.div(feeDenominator).mul(sControlFee)) (#652-654)
HelenaFinancial.takeFee(address,address,uint256) (#637-664) performs a multiplication on the result of a division:
-feeAmount = gonAmount.div(feeDenominator).mul(_totalFee) (#650)
HelenaFinancial.takeFee(address,address,uint256) (#637-664) performs a multiplication on the result of a division:
-_gonBalances[address(this)] = _gonBalances[address(this)].add(gonAmount.div(feeDenominator).mul(_hellenicFee.add(vaultFee))) (#655-657)
HelenaFinancial.getLiquidityBacking(uint256) (#900-908) performs a multiplication on the result of a division:
-liquidityBalance = _gonBalances[pair].div(_gonsPerFragment) (#905)
-accuracy.mul(liquidityBalance.mul(2)).div(getCirculatingSupply()) (#906-907)
HelenaFinancial.rebase() (#522-560) performs a multiplication on the result of a division:
-times = deltaTime.div(900) (#527)
-epoch = times.mul(15) (#528)
HelenaFinancial.takeFee(address,address,uint256) (#637-664) performs a multiplication on the result of a division:
-_gonBalances[autoLiquidityFund] = _gonBalances[autoLiquidityFund].add(gonAmount.div(feeDenominator).mul(liquidityFee)) (#658-660)
Consider ordering multiplication before division.

Additional information: link

HelenaFinancial.addLiquidity() (#666-708) ignores return value by router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
Ensure that all the return values of the function calls are used.

Additional information: link

HelenaFinancial.setRebaseRate(uint256) (#514-516) should emit an event for:
- ownerRebaseRate = _rebaseRate (#515)
Emit an event for critical parameter changes.

Additional information: link

HelenaFinancial.setFeeReceivers(address,address,address,address)._autoLiquidityFund (#889) lacks a zero-check on :
- autoLiquidityFund = _autoLiquidityFund (#894)
HelenaFinancial.setFeeReceivers(address,address,address,address)._vault (#891) lacks a zero-check on :
- vault = _vault (#896)
HelenaFinancial.setFeeReceivers(address,address,address,address)._hellenicFund (#890) lacks a zero-check on :
- hellenicFund = _hellenicFund (#895)
HelenaFinancial.setFeeReceivers(address,address,address,address)._sControl (#892) lacks a zero-check on :
- sControl = _sControl (#897)
HelenaFinancial.setPairAddress(address)._pairAddress (#919) lacks a zero-check on :
- pairAddress = _pairAddress (#920)
Check that the address is not zero.

Additional information: link

Reentrancy in HelenaFinancial.addLiquidity() (#666-708):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#687-693)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
External calls sending eth:
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
State variables written after the call(s):
- _lastAddLiquidityTime = block.timestamp (#707)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in HelenaFinancial._transferFrom(address,address,uint256) (#597-635):
External calls:
- rebase() (#608)
- pairContract.sync() (#557)
- addLiquidity() (#612)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#687-693)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
- swapBack() (#616)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#723-729)
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
External calls sending eth:
- addLiquidity() (#612)
- router.addLiquidityETH{value: amountETHLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityFund,block.timestamp) (#698-705)
- swapBack() (#616)
- (success) = address(hellenicFund).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(hellenicFee).div(hellenicFee.add(vaultFee))}() (#735-740)
- (success,None) = address(vault).call{gas: 30000,value: amountETHToHellenicAndRRFF.mul(vaultFee).div(hellenicFee.add(vaultFee))}() (#741-746)
Event emitted after the call(s):
- Transfer(sender,address(this),feeAmount.div(_gonsPerFragment)) (#662)
- gonAmountReceived = takeFee(sender,recipient,gonAmount) (#621-623)
- Transfer(sender,recipient,gonAmountReceived.div(_gonsPerFragment)) (#629-633)
Reentrancy in HelenaFinancial.rebase() (#522-560):
External calls:
- pairContract.sync() (#557)
Event emitted after the call(s):
- LogRebase(epoch,_totalSupply) (#559)
Apply the check-effects-interactions pattern.

Additional information: link

HelenaFinancial._symbol (#413) should be constant
HelenaFinancial.sellFee (#434) should be constant
HelenaFinancial._name (#412) should be constant
HelenaFinancial._decimals (#414) should be constant
HelenaFinancial.liquidityFee (#431) should be constant
HelenaFinancial.feeDenominator (#440) should be constant
HelenaFinancial.hellenicFee (#432) should be constant
HelenaFinancial.sControlFee (#435) should be constant
HelenaFinancial.vaultFee (#433) should be constant
HelenaFinancial.swapEnabled (#450) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

Average 30d PancakeSwap liquidity is less than $100. Token is either dead or inactive.

Average 30d number of PancakeSwap swaps is less than 1. Token is either dead or inactive.

Token is deployed only at one blockchain

Contract has 13% buy tax and 19% sell tax.
Taxes are high (over 10%) but contract ownership is renounced.

Token is not listed at Mobula.Finance

Additional information: link

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death

Young tokens have high risks of price dump / death