GMT [GemLook Finance] Token

Reentrancy in GemlookFinance.transferFrom(address,address,uint256) (#234-240):
External calls:
- _transfer(sender,recipient,amount) (#237)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
- _uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,receiver,block.timestamp + 1200) (#199)
External calls sending eth:
- _transfer(sender,recipient,amount) (#237)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
State variables written after the call(s):
- _approve(sender,msg.sender,currentAllowance - amount) (#238)
- _allowances[owner][spender] = amount (#225)
Apply the check-effects-interactions pattern.

Additional information: link

GemlookFinance.withdrawToken(address,uint256) (#280-283) ignores return value by _tokenContract.transfer(msg.sender,amount) (#282)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

GemlookFinance.swapAddLiquidity() (#202-220) performs a multiplication on the result of a division:
-devAmount = tokenBalance / (devFee + liquidityFee) * devFee (#207)
Consider ordering multiplication before division.

Additional information: link

GemlookFinance.addLiquidity(uint256,uint256) (#189-192) ignores return value by _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
Ensure that all the return values of the function calls are used.

Additional information: link

GemlookFinance.setFees(uint8,uint8) (#108-111) should emit an event for:
- devFee = _devFee (#109)
- liquidityFee = _liquidityFee (#110)
Emit an event for critical parameter changes.

Additional information: link

GemlookFinance.setAddresses(address)._devWallet (#98) lacks a zero-check on :
- devWallet = _devWallet (#99)
Check that the address is not zero.

Additional information: link

Reentrancy in GemlookFinance.swapAddLiquidity() (#202-220):
External calls:
- swapTokensForEth(devAmount,devWallet) (#208)
- _uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,receiver,block.timestamp + 1200) (#199)
- swapTokensForEth(sellHalf,address(this)) (#213)
- _uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,receiver,block.timestamp + 1200) (#199)
- addLiquidity(sellAmount - sellHalf,receivedEth) (#216)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
External calls sending eth:
- addLiquidity(sellAmount - sellHalf,receivedEth) (#216)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
State variables written after the call(s):
- addLiquidity(sellAmount - sellHalf,receivedEth) (#216)
- _allowances[owner][spender] = amount (#225)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in GemlookFinance.transferFrom(address,address,uint256) (#234-240):
External calls:
- _transfer(sender,recipient,amount) (#237)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
- _uniswapV2Router.swapExactTokensForETHSupportingFeeOnTransferTokens(amount,0,path,receiver,block.timestamp + 1200) (#199)
External calls sending eth:
- _transfer(sender,recipient,amount) (#237)
- _uniswapV2Router.addLiquidityETH{value: amount}(address(this),tokenAmount,0,0,address(this),block.timestamp + 1200) (#191)
Event emitted after the call(s):
- Approval(owner,spender,amount) (#226)
- _approve(sender,msg.sender,currentAllowance - amount) (#238)
Apply the check-effects-interactions pattern.

Additional information: link

solc-0.8.7 is not recommended for deployment
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

GemlookFinance (#29-285) should inherit from IERC20 (#10-12)
Inherit from the missing interface or contract.

Additional information: link

Parameter GemlookFinance.setFees(uint8,uint8)._liquidityFee (#108) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

GemlookFinance.slitherConstructorVariables() (#29-285) uses literals with too many digits:
- _totalSupply = 100000000 (#32)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

GemlookFinance._uniswapRouter (#34) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

withdrawToken(address,uint256) should be declared external:
- GemlookFinance.withdrawToken(address,uint256) (#280-283)
Use the external attribute for functions never called from the contract.

Additional information: link

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Number of Binance Smart Chain (BSC) token holders is low.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

BscScan page for the token does not contain additional info: website, socials, description, etc.

Additional information: link

Unable to find token on CoinGecko

Additional information: link

Unable to find token on CoinMarketCap

Additional information: link

Unable to find token/project description on the website or on BscScan, CoinMarketCap

Unable to find token contract audit

Unable to verify that token and website are owned by the same team (no listings + unable to find contract on website)

Unable to verify token contract address on the website

Unable to find audit link on the website

Unable to find whitepaper link on the website

Unable to find token on CoinHunt

Additional information: link

Unable to find code repository for the project

Young tokens have high risks of price dump / death

Young tokens have high risks of scam / price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank