GEM [GEMADA] Token

GEMADAContract.swapBack() (#613-657) sends eth to arbitrary user
Dangerous calls:
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
Ensure that an arbitrary user cannot withdraw unauthorized funds.

Additional information: link

Reentrancy in GEMADAContract._transferFrom(address,address,uint256) (#513-561):
External calls:
- swapBack() (#540)
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#624-630)
- distributor.deposit{value: amountBNBReflection}() (#640)
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#647-654)
External calls sending eth:
- swapBack() (#540)
- distributor.deposit{value: amountBNBReflection}() (#640)
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#647-654)
State variables written after the call(s):
- _balances[sender] = _balances[sender].sub(amount,Insufficient Balance) (#543)
- _balances[recipient] = _balances[recipient].add(amountReceived) (#546)
- amountReceived = takeFee(sender,amount) (#545)
- _balances[address(this)] = _balances[address(this)].add(feeAmount) (#581)
Apply the check-effects-interactions pattern.

Additional information: link

DividendDistributor.distributeDividend(address) (#320-331) ignores return value by REWARD.transfer(shareholder,amount) (#326)
Use SafeERC20, or ensure that the transfer/transferFrom return value is checked.

Additional information: link

Unable to find manual contract audit (e.g. Certik, PeckShield, Solidity...)

Too many vulnerabilities (Unchecked transfer, Reentrancy vulnerability, etc.). High risk of a scam. DYOR & manual audit are advised.

GEMADAContract.swapBack().tmpSuccess (#641) is written in both
(tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
tmpSuccess = false (#644)
Fix or remove the writes.

Additional information: link

Combination 1: Reentrancy vulnerabilities + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 2: Unchecked transfer + Functions that send Ether to arbitraty destination. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Combination 3: Reentrancy vulnerabilities + Unchecked transfer vulnerability. Usual for scams. May be justified by some complex mechanics (e.g. rebase, reflections). DYOR & manual audit are advised.

Reentrancy in DividendDistributor.setShare(address,uint256) (#253-267):
External calls:
- distributeDividend(shareholder) (#255)
- REWARD.transfer(shareholder,amount) (#326)
State variables written after the call(s):
- shares[shareholder].amount = amount (#265)
- shares[shareholder].totalExcluded = getCumulativeDividends(shares[shareholder].amount) (#266)
Apply the check-effects-interactions pattern.

Additional information: link

GEMADAContract.swapBack() (#613-657) ignores return value by router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#647-654)
Ensure that all the return values of the function calls are used.

Additional information: link

GEMADAContract.setTargetLiquidity(uint256,uint256) (#705-708) should emit an event for:
- targetLiquidity = _target (#706)
- targetLiquidityDenominator = _denominator (#707)
Emit an event for critical parameter changes.

Additional information: link

GEMADAContract.setFeeReceivers(address,address)._marketingFeeReceiver (#695) lacks a zero-check on :
- marketingFeeReceiver = _marketingFeeReceiver (#697)
Check that the address is not zero.

Additional information: link

GEMADAContract.airdrop(address,address[],uint256[]) (#736-759) has external calls inside a loop: distributor.setShare(addresses[i_scope_0],_balances[addresses[i_scope_0]]) (#751)
Favor pull over push strategy for external calls.

Additional information: link

Reentrancy in DividendDistributor.setShare(address,uint256) (#253-267):
External calls:
- distributeDividend(shareholder) (#255)
- REWARD.transfer(shareholder,amount) (#326)
State variables written after the call(s):
- addShareholder(shareholder) (#259)
- shareholderIndexes[shareholder] = shareholders.length (#353)
- removeShareholder(shareholder) (#261)
- shareholderIndexes[shareholders[shareholders.length - 1]] = shareholderIndexes[shareholder] (#359)
- addShareholder(shareholder) (#259)
- shareholders.push(shareholder) (#354)
- removeShareholder(shareholder) (#261)
- shareholders[shareholderIndexes[shareholder]] = shareholders[shareholders.length - 1] (#358)
- shareholders.pop() (#360)
- totalShares = totalShares.sub(shares[shareholder].amount).add(amount) (#264)
Apply the check-effects-interactions pattern.

Additional information: link

Reentrancy in GEMADAContract.swapBack() (#613-657):
External calls:
- router.swapExactTokensForETHSupportingFeeOnTransferTokens(amountToSwap,0,path,address(this),block.timestamp) (#624-630)
- distributor.deposit{value: amountBNBReflection}() (#640)
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#647-654)
External calls sending eth:
- distributor.deposit{value: amountBNBReflection}() (#640)
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
- router.addLiquidityETH{value: amountBNBLiquidity}(address(this),amountToLiquify,0,0,autoLiquidityReceiver,block.timestamp) (#647-654)
Event emitted after the call(s):
- AutoLiquify(amountBNBLiquidity,amountToLiquify) (#655)
Apply the check-effects-interactions pattern.

Additional information: link

GEMADAContract._transferFrom(address,address,uint256) (#513-561) uses timestamp for comparisons
Dangerous comparisons:
- require(bool,string)(cooldownTimer[recipient] < block.timestamp,Please wait for cooldown between buys) (#531)
Avoid relying on block.timestamp.

Additional information: link

DividendDistributor.process(uint256) (#289-313) has costly operations inside a loop:
- currentIndex ++ (#310)
Use a local variable to hold the loop computation result.

Additional information: link

GEMADAContract.swapThreshold (#440) is set pre-construction with a non-constant function or state variable:
- _totalSupply * 10 / 10000
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

Additional information: link

Pragma version^0.7.4 (#10) allows old versions
Deploy with any of the following Solidity versions: 0.5.16 - 0.5.17, 0.6.11 - 0.6.12, 0.7.5 - 0.7.6 Use a simple pragma version that allows any of these versions. Consider using the latest version of Solidity for testing.

Additional information: link

Low level call in GEMADAContract.swapBack() (#613-657):
- (tmpSuccess) = address(marketingFeeReceiver).call{gas: 30000,value: amountBNBMarketing}() (#641)
Avoid low-level calls. Check the call success. If the call is meant for a contract, check for code existence

Additional information: link

Variable GEMADAContract._allowances (#393) is not in mixedCase
Follow the Solidity naming convention.

Additional information: link

Variable IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountADesired (#147) is too similar to IDEXRouter.addLiquidity(address,address,uint256,uint256,uint256,uint256,address,uint256).amountBDesired (#148)
Prevent variables from having similar names.

Additional information: link

GEMADAContract.slitherConstructorVariables() (#364-764) uses literals with too many digits:
- distributorGas = 500000 (#432)
Use: Ether suffix, Time suffix, or The scientific notation

Additional information: link

GEMADAContract.REWARD (#368) is never used in GEMADAContract (#364-764)
Remove unused state variables.

Additional information: link

GEMADAContract.launchedAt (#428) should be constant
Add the constant attributes to state variables that never change.

Additional information: link

cooldownEnabled(bool,uint8) should be declared external:
- GEMADAContract.cooldownEnabled(bool,uint8) (#606-609)
Use the external attribute for functions never called from the contract.

Additional information: link

Number of Binance Smart Chain (BSC) token holders is less than 100. Token is either dead or inactive. Ignore for presale.

Average PancakeSwap trading volume, liqudity, number of swaps are extremely low. Token seems to be dead.

Token is deployed only at one blockchain

Token has only one trading pair

Unable to find PancakeSwap trading pair to compute liquidity.

Unable to find PancakeSwap trading pair to compute volume.

Unable to find PancakeSwap trading pair to compute number of swaps.

Unable to find website, listings and other project-related information

Young tokens have high risks of price dump / death

Token has no active CoinGecko listing / rank

Token has no active CoinMarketCap listing / rank